From patchwork Thu Nov 8 08:23:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun KS X-Patchwork-Id: 10673683 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6B9D8109C for ; Thu, 8 Nov 2018 08:23:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C75028774 for ; Thu, 8 Nov 2018 08:23:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5061A287E0; Thu, 8 Nov 2018 08:23:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SUBJ_OBFU_PUNCT_FEW autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D248C28774 for ; Thu, 8 Nov 2018 08:23:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 170BC6B05A1; Thu, 8 Nov 2018 03:23:29 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 0CB926B05A3; Thu, 8 Nov 2018 03:23:29 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D00196B05A2; Thu, 8 Nov 2018 03:23:28 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by kanga.kvack.org (Postfix) with ESMTP id 7E9EA6B059F for ; Thu, 8 Nov 2018 03:23:28 -0500 (EST) Received: by mail-pl1-f200.google.com with SMTP id m1-v6so18319333plb.13 for ; Thu, 08 Nov 2018 00:23:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id; bh=lFeGzotlLAnm/djsCpGMp1MDFzTFPnEhl1VAsDgTXQk=; b=a3acpkEg0lUeY8iwvdcACjFaMj2z8+xNdf9SU0DKVBLEcnhj3tf+CJUC6WfLkarpSZ ZhGvcZBDE+1/tF4aD4GIIykVcG5rEVeZNCodZIH4ifnQnNYN8ZaDOQ9gogniYK4JXWu5 F0UISCS3bOy5h9hLeeupOy8fK2DVfHsjS4yKUsoyietO1CD3V4B3yZ5Y95gjmC8p0k0P ECvZwnAOmiGvTHJnNM+kmMzX+E1GkLpTB6wfE61LJaR/V5gb0K/Bpb5FS9Razx+lNQVg N0bReIeW7N+cxFbupAPHPjwqrVgGequkFPQEcq1PQ0qY5tZ7nM6fE5GgsC/Tmbk5AYvn +wWQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-Gm-Message-State: AGRZ1gJNT5yPfkW+Uyb8NXABKgBRpmNrBtM+1XuswlB3KEdPFz2QvtKe 2L7YkDAJCoQrNsPCoHuIcsBKrEiyjg9Qxi///r++Rt5KlKFhkFVPXb/Ok8ZDlFpkHtZradavzoK odbGkhrAojmEeN6lYBdTr4af9VLfCALHncp4jT2DFE1Rf+mzycIJPRFLsqPS9WK4= X-Received: by 2002:a63:c642:: with SMTP id x2-v6mr2967373pgg.16.1541665408169; Thu, 08 Nov 2018 00:23:28 -0800 (PST) X-Google-Smtp-Source: AJdET5d8mPcoZdHVNHq1JL8zMwBUWXah0FaXPMa6SvuxhS4qv1pKIHS1C6mvU8X9xS76PZziZhC4 X-Received: by 2002:a63:c642:: with SMTP id x2-v6mr2967340pgg.16.1541665407215; Thu, 08 Nov 2018 00:23:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541665407; cv=none; d=google.com; s=arc-20160816; b=hRSyTLYjX3aJfUI9gHzfYVd6qoPY+k5PrCidKoxrAGPcKXt5Goc93Ku6PaRH7LguEr TTStDdph78uST/QXCqM935hupZIPycXtlIPrIF/UVVuhwZqF0HeTEPCzSuJwn33W80F2 T9u9MdbhLbOE6Mm0JlUZf+RS9py0nt7LYg0SFFpTqSseSXiAVHADsmAurQqa0qYjpA4j f/WzJySydb378KB7FBNq1ZDlXAWkQj9FpYcieQA7fE5eMIfhtJp8IUzJZs0niDneil9A A9B4IBNtheXg0ZOKNUOKzmArLLIihReHwt+FVflsmnFppUUj8POQ/PanMNky95DUWc1E t5Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=lFeGzotlLAnm/djsCpGMp1MDFzTFPnEhl1VAsDgTXQk=; b=CCQXUsUorsbx4eXAcg1UWKelGpcubqEhXr05at3WBEbuTEWndiTphRrsYxfJO4Kd0+ cfdIe7obz6lu+SFstjmJvtR6h9/ZDboEPc/Si+KMt8MrRNNohQDTeDfExvQ8jIK8/8GQ gEx7PJVcTNqxVuRbz0oD5w3JFXNojHTABoyQ+EPMzElehRBl+Bxn3A1BniUiNZxgdJfV wGyD3JHo7gO+5GE7pCxNMnrEFwJA0pRKUflRGGscbOAyiRyW8Lp5ZLk0sTLvyopKkxWY zGUQ/bQyf5FNlB3c2em27nTXdSepJJ8WbJO44U/YJpl7//RHNrv8WaucD99K/IpWu+zJ vXkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com Received: from alexa-out-blr-01.qualcomm.com (alexa-out-blr-01.qualcomm.com. [103.229.18.197]) by mx.google.com with ESMTPS id u34si3273678pgk.24.2018.11.08.00.23.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 00:23:27 -0800 (PST) Received-SPF: pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) client-ip=103.229.18.197; Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-IronPort-AV: E=Sophos;i="5.54,478,1534789800"; d="scan'208";a="279017" Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 08 Nov 2018 13:53:23 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9070"; a="5699120" Received: from blr-ubuntu-104.ap.qualcomm.com (HELO blr-ubuntu-104.qualcomm.com) ([10.79.40.64]) by ironmsg01-blr.qualcomm.com with ESMTP; 08 Nov 2018 13:53:22 +0530 Received: by blr-ubuntu-104.qualcomm.com (Postfix, from userid 346745) id 137E923A8; Thu, 8 Nov 2018 13:53:21 +0530 (IST) From: Arun KS To: akpm@linux-foundation.org, keescook@chromium.org, khlebnikov@yandex-team.ru, minchan@kernel.org, mhocko@kernel.org, vbabka@suse.cz, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: getarunks@gmail.com, Arun KS Subject: [PATCH v3 0/4] mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Date: Thu, 8 Nov 2018 13:53:14 +0530 Message-Id: <1541665398-29925-1-git-send-email-arunks@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on 4.20-rc1. And memory hotplug tested on arm64, but on an older version of kernel. totalram_pages, zone->managed_pages and totalhigh_pages updates are protected by managed_page_count_lock, but readers never care about it. Convert these variables to atomic to avoid readers potentially seeing a store tear. Main motivation was that managed_page_count_lock handling was complicating things. It was discussed in length here, https://lore.kernel.org/patchwork/patch/995739/#1181785 It seemes better to remove the lock and convert variables to atomic. With the change, preventing poteintial store-to-read tearing comes as a bonus. Changes in v3: - Fixed kbuild test robot errors. - Modifed changelogs to be more clear. - EXPORT_SYMBOL for _totalram_pages and _totalhigh_pages. Arun KS (4): mm: reference totalram_pages and managed_pages once per function mm: convert zone->managed_pages to atomic variable mm: convert totalram_pages and totalhigh_pages variables to atomic mm: Remove managed_page_count spinlock arch/csky/mm/init.c | 4 +- arch/powerpc/platforms/pseries/cmm.c | 10 ++-- arch/s390/mm/init.c | 2 +- arch/um/kernel/mem.c | 3 +- arch/x86/kernel/cpu/microcode/core.c | 5 +- drivers/char/agp/backend.c | 4 +- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +- drivers/hv/hv_balloon.c | 19 +++---- drivers/md/dm-bufio.c | 2 +- drivers/md/dm-crypt.c | 2 +- drivers/md/dm-integrity.c | 2 +- drivers/md/dm-stats.c | 2 +- drivers/media/platform/mtk-vpu/mtk_vpu.c | 2 +- drivers/misc/vmw_balloon.c | 2 +- drivers/parisc/ccio-dma.c | 4 +- drivers/parisc/sba_iommu.c | 4 +- drivers/staging/android/ion/ion_system_heap.c | 2 +- drivers/xen/xen-selfballoon.c | 6 +-- fs/ceph/super.h | 2 +- fs/file_table.c | 7 +-- fs/fuse/inode.c | 2 +- fs/nfs/write.c | 2 +- fs/nfsd/nfscache.c | 2 +- fs/ntfs/malloc.h | 2 +- fs/proc/base.c | 2 +- include/linux/highmem.h | 28 ++++++++++- include/linux/mm.h | 27 +++++++++- include/linux/mmzone.h | 15 +++--- include/linux/swap.h | 1 - kernel/fork.c | 5 +- kernel/kexec_core.c | 5 +- kernel/power/snapshot.c | 2 +- lib/show_mem.c | 2 +- mm/highmem.c | 5 +- mm/huge_memory.c | 2 +- mm/kasan/quarantine.c | 2 +- mm/memblock.c | 6 +-- mm/mm_init.c | 2 +- mm/oom_kill.c | 2 +- mm/page_alloc.c | 72 +++++++++++++-------------- mm/shmem.c | 7 +-- mm/slab.c | 2 +- mm/swap.c | 2 +- mm/util.c | 2 +- mm/vmalloc.c | 4 +- mm/vmstat.c | 4 +- mm/workingset.c | 2 +- mm/zswap.c | 4 +- net/dccp/proto.c | 7 +-- net/decnet/dn_route.c | 2 +- net/ipv4/tcp_metrics.c | 2 +- net/netfilter/nf_conntrack_core.c | 7 +-- net/netfilter/xt_hashlimit.c | 5 +- net/sctp/protocol.c | 7 +-- security/integrity/ima/ima_kexec.c | 2 +- 57 files changed, 195 insertions(+), 142 deletions(-)