From patchwork Tue Nov 12 14:06:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Shi X-Patchwork-Id: 11239361 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 70261159A for ; Tue, 12 Nov 2019 14:06:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4857A2196E for ; Tue, 12 Nov 2019 14:06:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4857A2196E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 626B76B0006; Tue, 12 Nov 2019 09:06:50 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5D7476B0007; Tue, 12 Nov 2019 09:06:50 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EE9C6B0008; Tue, 12 Nov 2019 09:06:50 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 3A4256B0006 for ; Tue, 12 Nov 2019 09:06:50 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id EFD7C181AEF15 for ; Tue, 12 Nov 2019 14:06:49 +0000 (UTC) X-FDA: 76147801338.06.soap48_582ca42bd655f X-Spam-Summary: 2,0,0,bedd8aa10575503f,d41d8cd98f00b204,alex.shi@linux.alibaba.com,:alex.shi@linux.alibaba.com:cgroups@vger.kernel.org:linux-kernel@vger.kernel.org::akpm@linux-foundation.org:mgorman@techsingularity.net:tj@kernel.org:hughd@google.com:khlebnikov@yandex-team.ru:daniel.m.jordan@oracle.com:yang.shi@linux.alibaba.com,RULES_HIT:41:69:355:379:541:967:968:973:988:989:1260:1261:1345:1381:1437:1534:1542:1711:1730:1747:1777:1792:1801:2393:2525:2559:2563:2682:2685:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4362:4605:5007:6119:6261:6737:7903:9025:10004:11026:11232:11657:11658:11914:12043:12048:12291:12296:12297:12683:12895:14040:14180:14181:14394:14721:14915:21060:21080:21451:21627:21795:21809:30051:30054:30056:30070,0,RBL:115.124.30.45:@linux.alibaba.com:.lbl8.mailshell.net-62.20.2.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,Doma inCache: X-HE-Tag: soap48_582ca42bd655f X-Filterd-Recvd-Size: 4066 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Nov 2019 14:06:45 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0Thubem1_1573567598; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0Thubem1_1573567598) by smtp.aliyun-inc.com(127.0.0.1); Tue, 12 Nov 2019 22:06:38 +0800 From: Alex Shi To: alex.shi@linux.alibaba.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com Subject: [PATCH v2 0/8] per lruvec lru_lock for memcg Date: Tue, 12 Nov 2019 22:06:20 +0800 Message-Id: <1573567588-47048-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi all, This patchset move lru_lock into lruvec, give a lru_lock for each of lruvec, thus bring a lru_lock for each of memcg per node. According to Daniel Jordan's suggestion, I run 64 'dd' with on 32 containers on my 2s* 8 core * HT box with the modefied case: https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git/tree/case-lru-file-readtwice With this change above lru_lock censitive testing improved 17% with multiple containers scenario. And no performance lose w/o mem_cgroup. Thanks Hugh Dickins and Konstantin Khlebnikov, they both bring the same idea 7 years ago. I don't know why they didn't go further, but according to my testing, and google internal usage. This feathre is clearly benefit multi-container user. So I like to introduce it here. v2: bypass a performance regression bug and fix some function issues --- Documentation/admin-guide/cgroup-v1/memcg_test.rst | 15 +++------------ Documentation/admin-guide/cgroup-v1/memory.rst | 6 +++--- Documentation/trace/events-kmem.rst | 2 +- Documentation/vm/unevictable-lru.rst | 22 ++++++++-------------- include/linux/memcontrol.h | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/mm_types.h | 2 +- include/linux/mmzone.h | 7 +++++-- mm/compaction.c | 62 ++++++++++++++++++++++++++++++++++++++++++-------------------- mm/filemap.c | 4 ++-- mm/huge_memory.c | 16 ++++++---------- mm/memcontrol.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++------------- mm/mlock.c | 27 ++++++++++++++------------- mm/mmzone.c | 1 + mm/page_alloc.c | 1 - mm/page_idle.c | 5 +++-- mm/rmap.c | 2 +- mm/swap.c | 77 +++++++++++++++++++++++++++++++---------------------------------------------- mm/vmscan.c | 74 ++++++++++++++++++++++++++++++++++++++------------------------------------ 18 files changed, 277 insertions(+), 177 deletions(-) [PATCH v2 1/8] mm/lru: add per lruvec lock for memcg [PATCH v2 2/8] mm/lruvec: add irqsave flags into lruvec struct [PATCH v2 3/8] mm/lru: replace pgdat lru_lock with lruvec lock [PATCH v2 4/8] mm/lru: only change the lru_lock iff page's lruvec is [PATCH v2 5/8] mm/pgdat: remove pgdat lru_lock [PATCH v2 6/8] mm/lru: remove rcu_read_lock to fix performance [PATCH v2 7/8] mm/lru: likely enhancement [PATCH v2 8/8] mm/lru: revise the comments of lru_lock