From patchwork Tue Sep 25 12:03:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 10613885 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8953D14DA for ; Tue, 25 Sep 2018 12:03:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 797CF2973F for ; Tue, 25 Sep 2018 12:03:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6ABB7297BA; Tue, 25 Sep 2018 12:03:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 009F52973F for ; Tue, 25 Sep 2018 12:03:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F02ED8E008D; Tue, 25 Sep 2018 08:03:44 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id EB2C88E0072; Tue, 25 Sep 2018 08:03:44 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA1E88E008D; Tue, 25 Sep 2018 08:03:44 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by kanga.kvack.org (Postfix) with ESMTP id 9AE9A8E0072 for ; Tue, 25 Sep 2018 08:03:44 -0400 (EDT) Received: by mail-pf1-f199.google.com with SMTP id i68-v6so12425113pfb.9 for ; Tue, 25 Sep 2018 05:03:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id; bh=VYEW7ht00VUcAk5YZHzmqxXiRl5qowM6sR3VDqHDTYs=; b=CCQoFLcnXPxd7l9ondGWrdvDcw8RCMGJRn66gwPp5cqQeEv2zTQOZN0DJtO5br4QxN BCwsTJBgtj5MpbXEdDX9U+r+cAeH0thiaGH+pn1JbEB814Gh7N9ri1+JJL2NBAOiXxF6 4VTpD7WiPMUK+Sd0KLD5Z1T4jXMyFHaSdO6/iED03BUMT7S6GhfBCWxtWL70eXeJ7/IW MPm+qs7bBkM+sXbMMPqOYbvHlDus5k5EBbmxgQDYS0t16wYeaCtAbItA86Q7h21PYUCp +q/DpxUAuD+ySpzQCa9XTrEZMgddv4Dr4WCUaWbzgCtvd2ByACso9D2gnZT6bhVfq+Nq gG1w== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: ABuFfojghwFqJNn3VhjHlJfn391MWYLdaEe27B9FKeaW+fFBW+HeOKvs P2/kOoJ0KC+XbwwQT4ayIqFhJO64WKrCHiumexwCaTnb++CTsk5r0gN58ZETS9TgigmUFguCLvj q9f4LH09J1P1kzjdRJEweZBrficTe+fDgraJpNdBkvgpMrerF2F/a8CJIk1yE4kmfYSJFafeK25 rHRkmUAmR+zMxkENlGSLMuWdXDGyNAvSlJy5EYc25N1Q2mzjfTFCESucgNpuaydDBBjXilHv8N2 IFkKP3US/GGUjOYuZWb76zijx1/L0uLtPL/buGPkQLCcGqlenWGjMNcRvnrqmF5kh34Phlr3AnV jA3Vr2Jp9vpLTwkOHegVM69dMKUFOk/xadtEaO0HLGGY+z+9q34nUDAIS1V51b6g9VBdjKqdjA= = X-Received: by 2002:a63:184a:: with SMTP id 10-v6mr767536pgy.81.1537877024294; Tue, 25 Sep 2018 05:03:44 -0700 (PDT) X-Received: by 2002:a63:184a:: with SMTP id 10-v6mr767464pgy.81.1537877023347; Tue, 25 Sep 2018 05:03:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537877023; cv=none; d=google.com; s=arc-20160816; b=d4owr4Ub0StruLZHeuFbfesu+oS7T6yRAb9lfzAgqH24/bLgAdIGK+HP1sJUq8+ovz BgSqAAyiJP07uWT0zdI+jPFLNxaxomGsplBs8nHjUtlE7ljm2nlEUGYT4G1bRDPSyt7m POs9deRsVjfBrqjaq3oUpDnLsU+muM1Qiu8aYLHcwLojIrLh7ioRWE53yDWkdsMcn/rg zZxDdUDv81AsNDy5Q4ZcDyAZjAEDDlCGtJU4Si4fZQALbHYYTWuCtEnj35d3VWPmHP0U 8lvGjrwlafNhqeZxjKJVBynctJCObvgn86u2MjzIg8yB8l8DgOY5N8KBh45LTW3vRVCy yNHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=VYEW7ht00VUcAk5YZHzmqxXiRl5qowM6sR3VDqHDTYs=; b=ewcNtDlHFu7maFeoUNq9saeILkvae/E3IMT5hR/N4iwgLMPTmVXNlEZ2YBQFS1kIrO WOfHfOvDRVKdURYtd2MYM6jcOGvI/YDxqcRkN/FqzyrlZ1i5jPBrnLBSCtuQ/ubUADwq sz/icRox8dl/ptWeYNuXVH4vDOhdg2Om0xSJz3rMH/tymcP1+HCpDVkO8fEoaNIgDFfH MrTiW3/sLvL0QNQ4Bq8BZUoQcr8eDfmTijh+hyGYJZV7OEkCp9rvHjiZ1cSLU6bpXAf1 NbcE3ZMIxw1xsNnbUmnhjoI9eg50MYDAdscdbxGAilhlCHHIhPJ+pEenB+QKQl2aUQ48 tcig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id e25-v6sor277917pge.323.2018.09.25.05.03.43 for (Google Transport Security); Tue, 25 Sep 2018 05:03:43 -0700 (PDT) Received-SPF: pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Google-Smtp-Source: ACcGV60hDR6AU3IycpSip7JKoqXdedt2CcxEYIlOI32wfBLSxTw52qW8zZKH1DYioiMlJ/TUiJ3agQ== X-Received: by 2002:a63:e116:: with SMTP id z22-v6mr755481pgh.89.1537877022928; Tue, 25 Sep 2018 05:03:42 -0700 (PDT) Received: from tiehlicka.suse.cz (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id h132-v6sm3657449pfc.100.2018.09.25.05.03.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Sep 2018 05:03:42 -0700 (PDT) From: Michal Hocko To: Andrew Morton Cc: Mel Gorman , Vlastimil Babka , David Rientjes , Andrea Argangeli , Zi Yan , Stefan Priebe - Profihost AG , "Kirill A. Shutemov" , , LKML Subject: [PATCH 0/2] thp nodereclaim fixes Date: Tue, 25 Sep 2018 14:03:24 +0200 Message-Id: <20180925120326.24392-1-mhocko@kernel.org> X-Mailer: git-send-email 2.18.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Hi, this has been brought up by Andrea [1] and he proposed two different fixes for the regression. I have proposed an alternative fix [2]. I have changed my mind in the end because whatever fix we end up with it should be backported to the stable trees so going with a minimalistic one is preferred so I have got back to the Andrea's second proposed solution [3] in the end. I have just reworded the changelog to reflect other bug report with the stall information. My primary concern about [3] was that the __GFP_THISNODE logic should be placed in alloc_hugepage_direct_gfpmask which I've done on top of the fix as a cleanup (patch 2) and it doesn't need to be backported to the stable tree. I am still not happy that the David's workload will regress as a result but we should really focus on the default behavior and come with a more robust solution for specialized one for those who have more restrictive NUMA preferences. I am thinking about a new numa policy that would mimic node reclaim behavior and I am willing to work on that but we really have to fix the regression first and that is the patch 1. Thoughts, alternative patches? [1] http://lkml.kernel.org/r/20180820032204.9591-1-aarcange@redhat.com [2] http://lkml.kernel.org/r/20180830064732.GA2656@dhcp22.suse.cz [3] http://lkml.kernel.org/r/20180820032640.9896-2-aarcange@redhat.com