From patchwork Fri Nov 16 08:30:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 10685703 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A956A14E2 for ; Fri, 16 Nov 2018 08:30:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 99D632D681 for ; Fri, 16 Nov 2018 08:30:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D6B82D666; Fri, 16 Nov 2018 08:30:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 110642D666 for ; Fri, 16 Nov 2018 08:30:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 113876B087E; Fri, 16 Nov 2018 03:30:34 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 09C9E6B087F; Fri, 16 Nov 2018 03:30:34 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA5FB6B0880; Fri, 16 Nov 2018 03:30:33 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id 8AEEE6B087E for ; Fri, 16 Nov 2018 03:30:33 -0500 (EST) Received: by mail-ed1-f71.google.com with SMTP id s50so2669810edd.11 for ; Fri, 16 Nov 2018 00:30:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; bh=dNJ+m15LciZQg8455eEFiwq59fDC0IvIzYdogCG8KR8=; b=iehVwsQ8H/PwDH3HQEiYweDPJ2uKipk6bWr8HmQ86Nd1m/j6Orj8r2Ast9TdMh0vdY ir60s5/xslMY+4e6a5L0qpV69sLLVLL1BangXB7vmMT4bYnjVuVH69cwdtC9x+++pT8U xJKOomjR2CBBsKYINgXnRMqfTGDpIRFTl/9iEF8TS9J2R71Yx/JqfVhS/9ymgxVH5kBD 1wEuB98YqrYuRW2wmuQHb3XZUg6QvYMwaExyRaEzHgYR9iAzvfNuLJwTxPdZSEaLvwCP pRbMEHwABPQP1Vp4e7NTNP30gDHL31sddS0PIkCxQQkkiCHstWyV2q5S8kO0WeNtoJzS JzEQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Gm-Message-State: AGRZ1gIcp+FeLV6igL0/luCIpCP5JCMNxSU2XX6Aws1LaHFdwpyeNtrW 0Q3jg45TvbDBIAaxh2uDmekY+tx/DjLyNrRmzI29+zDL7NhUGYwoMInjQewbA1HFEPPgzD4AJGI Z5HEHtY1DA49p1jbWyiZP3cU6VhVtI/9xkTzBbbhA7LJ3R2em66AP2IUDQ5FzlchB1x9VIeoRG4 Yx3yYzYsAEV3IPDlwiwzrfgNnXVBOnYuK++K1xGLbfzol7hBhn7EyHrOHaEwr01PrtKUJMQ2BkQ 82NqIH51H5sDrsz8mCC8T6tovNv/jikNTt72MjwYMRY623RV+98tGp1HSvW7zF1bihadx9PpvpU QoWf7l2mt2Fl0/U4pukyST71nWTYwd6K1WIXSIpv0yukRhBcY15OIkXaQSJTVgRroioALIrBZg= = X-Received: by 2002:a05:6402:295:: with SMTP id l21mr8859146edv.149.1542357033003; Fri, 16 Nov 2018 00:30:33 -0800 (PST) X-Received: by 2002:a05:6402:295:: with SMTP id l21mr8859088edv.149.1542357031886; Fri, 16 Nov 2018 00:30:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542357031; cv=none; d=google.com; s=arc-20160816; b=uokiKiyxMoNbSXd5AvGBw+m/tuT7bVkLY52Z9lyKc9iJy0v+DF35tiiTJJ1Kc7foew zbEmiovoC0tTiGMsQRH7Wo5UWnYMTxIcgb0lXFDjtA4WiIWc4NK4iMvhM5SwhWQrREy+ 2Sysg/RcExWonjumPwvlJPU1eHMQ1VB/vAg6E6pQbO+hokJOdLbg7Gqvf/AhvExDoyD4 /vbReuHUkwwoaQu26Wg9nE0hzSAdDZ/j/kZ07HjVnKV9eMb7c5XYKjpl89q018oqSxjW 1Wx8hcHEYBFvA2xzr8blrWPscnH63jluKTUuojmcW5QB6jszb703At+YTjOaPYsU73eZ JFJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=dNJ+m15LciZQg8455eEFiwq59fDC0IvIzYdogCG8KR8=; b=s367fz7ooGsgc3Q6dOrGr1TdJtgDynQK+zDcNpkR4VtV9lnHfjWoW4JwffZ/SqOeuA UIqHVp1Fj18SQda0xfqb1pkjA2/Iuvr0uRliASNya5xx4GNGQMrnW1WscD2kxY/tK+ro z6XIeQaHlhwCA6Q0rYCl7vyOJmjSaBBODjxfI9tDtjAwINBCXTFmZxw+l5hSE7758Sij SHKp8/9MTOjG4IR/SffNGbXiK3+ixhqwc/U9ulN1knEPsDmCtMdPYZRGppoph4AxMDJx FPr4Ps2zDS0OU90F6FyMsWCxsKGrFxNyJ+hVIebGTdbommlKi0szhogUg7ZCWMgP8r/l xlQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id w15-v6sor15286100edb.5.2018.11.16.00.30.31 for (Google Transport Security); Fri, 16 Nov 2018 00:30:31 -0800 (PST) Received-SPF: pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mstsxfx@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=mstsxfx@gmail.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Google-Smtp-Source: AJdET5dR7/BVul/SXsyz6L4/TIem+WYYb1wKMnbnBzxsamXQOdR6tBj3/H2oaDM/D207uoo0yeixVQ== X-Received: by 2002:a50:88c3:: with SMTP id d61-v6mr9024807edd.14.1542357031214; Fri, 16 Nov 2018 00:30:31 -0800 (PST) Received: from tiehlicka.suse.cz (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id m13sm5305393edd.2.2018.11.16.00.30.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 00:30:30 -0800 (PST) From: Michal Hocko To: Andrew Morton Cc: Oscar Salvador , Baoquan He , Anshuman Khandual , , LKML Subject: [PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Date: Fri, 16 Nov 2018 09:30:15 +0100 Message-Id: <20181116083020.20260-1-mhocko@kernel.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Hi, this has been posted as an RFC [1]. I have screwed during rebasing so there were few compilation issues in the previous version. I have also integrated review feedback from Andrew and Anshuman. I have been promissing to improve memory offlining failures debugging for quite some time. As things stand now we get only very limited information in the kernel log when the offlining fails. It is usually only [ 1984.506184] rac1 kernel: memory offlining [mem 0x82600000000-0x8267fffffff] failed without no further details. We do not know what exactly fails and for what reason. Whenever I was forced to debug such a failure I've always had to do a debugging patch to tell me more. We can enable some tracepoints but it would be much better to get a better picture without using them. This patch series does 2 things. The first one is to make dump_page more usable by printing more information about the mapping patch 1. Then it reduces the log level from emerg to warning so that this function is usable from less critical context patch 2. Then I have added more detailed information about the offlining failure patch 4 and finally add dump_page to isolation and offlining migration paths. Patch 3 is a trivial cleanup. Does this look go to you? [1] http://lkml.kernel.org/r/20181107101830.17405-1-mhocko@kernel.org Shortlog Michal Hocko (5): mm: print more information about mapping in __dump_page mm: lower the printk loglevel for __dump_page messages mm, memory_hotplug: drop pointless block alignment checks from __offline_pages mm, memory_hotplug: print reason for the offlining failure mm, memory_hotplug: be more verbose for memory offline failures Diffstat mm/debug.c | 23 ++++++++++++++++++----- mm/memory_hotplug.c | 52 +++++++++++++++++++++++++++++++--------------------- mm/page_alloc.c | 1 + 3 files changed, 50 insertions(+), 26 deletions(-)