From patchwork Mon Jun 24 22:29:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Song Liu X-Patchwork-Id: 11014267 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0F8DC1398 for ; Mon, 24 Jun 2019 22:30:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F372628AB8 for ; Mon, 24 Jun 2019 22:30:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E720028AC8; Mon, 24 Jun 2019 22:30:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6AF0A28AB8 for ; Mon, 24 Jun 2019 22:30:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13BA76B0005; Mon, 24 Jun 2019 18:30:01 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 0C5898E0003; Mon, 24 Jun 2019 18:30:01 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA7938E0002; Mon, 24 Jun 2019 18:30:00 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by kanga.kvack.org (Postfix) with ESMTP id AB3736B0005 for ; Mon, 24 Jun 2019 18:30:00 -0400 (EDT) Received: by mail-pf1-f197.google.com with SMTP id 5so10413189pff.11 for ; Mon, 24 Jun 2019 15:30:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:smtp-origin-hostprefix:from :smtp-origin-hostname:to:cc:smtp-origin-cluster:subject:date :message-id:mime-version; bh=yHK7I2PCiJSNC3RG5RZIOlmb5Bc2hZKp9GWkODEs0RU=; b=Irih8fCPOdrqwvJYBgTT6ewejUcWCzMEHWNTujmgQ/ggg91uiI0lcRlFkJ3QxEv9QX YNMFtSTvCaGjB1T0HF0PyBJ+H331eSdikHCAl43i7Z4TkQRHgAxmkbG/2utfAcOP/pXG s2WbWNfmth8I5saQ6q9XP26dhbGoRcWF4E9ewarIMqZ55EZkaKh1j/lOpzT7E84IL4Jn jJWDd1ej0rA1Msl9v1D1vN4Te98SP3ogmCsDudqNuYjbkaBZDDETdMzJYY5njpfZS4/q /2SsqBqKQpCGPMlc1MMzFAI8PxXMrvjcJPEL305DGXysKaZbq+Ne8TLAHuwmMikml7vK YTWw== X-Gm-Message-State: APjAAAUMgq+LdiWHxQ+c9Lrkm4SO5x2OmBIYPCtcdEoL+w0scFHtwst9 eh0TR1dXM6723v36dPfi1IPq9LehdFhHz3SylXVgj5CDYKKFUccgdllUsAZploQtqLfgpYmPrej BrOt5ZgpCn9houeH3ZcLa8xzop3qk5fcHllEOiviJg14flervSXoC9SzAkA4mFK2Rgg== X-Received: by 2002:a17:902:6b86:: with SMTP id p6mr82020550plk.14.1561415400120; Mon, 24 Jun 2019 15:30:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqySCoq+ma6KCoxo0pdnvbr4xnUKws6lYg0TdCpbmJ8Nz265dzK2nnONey2a+Q0h5czStaSO X-Received: by 2002:a17:902:6b86:: with SMTP id p6mr82020461plk.14.1561415399019; Mon, 24 Jun 2019 15:29:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561415399; cv=none; d=google.com; s=arc-20160816; b=Xh1RdvPOLNVq3pIHOuGd69k/o/GkdL+vczUGoOjK30wQplvyuAJzURKgbikjSnHStS oevzJsgkw6YPtgU6LVyo89AStSlGmrK6Zj7vJmHqzpPDHrRnctSdtWl51OIw2VGfvSwA G7Sl+nmioUKA1mGrOhHWgnS0/g+HiTlaSHgBg+/HWFhaYbiMVi8AWlfnCeezGagHXbTF 6Q4yuBytAIfW4CG9wi3s1mFn1PBdJI9gpmAztFXQBkKQ2SvNrzKuda2oshRDteUS72KM 6N9Fmn2xCeMbKiHYSj2GRl/gKyfAoX3t/xHGGK1rsoL8/EUpv/i+eClmPZ5ElSeP8z9c HdrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:message-id:date:subject:smtp-origin-cluster:cc:to :smtp-origin-hostname:from:smtp-origin-hostprefix:dkim-signature; bh=yHK7I2PCiJSNC3RG5RZIOlmb5Bc2hZKp9GWkODEs0RU=; b=Nm8vSx7SxgNsEOhnzJSzcAftpENog1i/BCDcJF1KTcTK3SRml4Wc7FFl4n8d7ZL/Ic DQV4+QSG5y07qMYCN7PlsJgQRdpeh2YKgcUjAzMLRYsPHEXX763nmX+wP7aX7U/P1tg2 uHXfd7He3KXrsqwU7iGoxcpvW+MgMPphlXmDxxssm0/8WBvKiUusOd24paQx8hQVFGZZ O1BDePNtqlTiS4pX6Jf58fI0yqh6R8lHF/74wuqPxL+HmENpTBMhMNO1gsbz7MZBTkIR o/Whcd6X9mi+B5FEKE6qbNsc/mb8Sn8jmVbacRtq8hZO81UmEFGQHbjjG8mLNnQkuS73 mgVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=J7Cl2623; spf=pass (google.com: domain of prvs=1078cbd532=songliubraving@fb.com designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=1078cbd532=songliubraving@fb.com"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com. [67.231.145.42]) by mx.google.com with ESMTPS id t5si7228596plq.410.2019.06.24.15.29.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 15:29:59 -0700 (PDT) Received-SPF: pass (google.com: domain of prvs=1078cbd532=songliubraving@fb.com designates 67.231.145.42 as permitted sender) client-ip=67.231.145.42; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=J7Cl2623; spf=pass (google.com: domain of prvs=1078cbd532=songliubraving@fb.com designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=1078cbd532=songliubraving@fb.com"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: from pps.filterd (m0044008.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5OMJPxC026762 for ; Mon, 24 Jun 2019 15:29:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=facebook; bh=yHK7I2PCiJSNC3RG5RZIOlmb5Bc2hZKp9GWkODEs0RU=; b=J7Cl2623fkeMdAUW6DgPFH0dHuxyL4C9QRX6NeFAcA1QRyXpC8WPyKzsjF6byO2QzoPM kcrrdylwOLCPWGEFF+fEe9/ogaKPZbplEuxepepFzL+Fx7PZiD0IUvLGOiFfaKBU+jWH psOexuxz5DOLUl/TDimuhaSAInApshq7//k= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com with ESMTP id 2tb3v00vqu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 24 Jun 2019 15:29:58 -0700 Received: from mx-out.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::c) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 24 Jun 2019 15:29:56 -0700 Received: by devbig006.ftw2.facebook.com (Postfix, from userid 4523) id 5761862E206E; Mon, 24 Jun 2019 15:29:55 -0700 (PDT) Smtp-Origin-Hostprefix: devbig From: Song Liu Smtp-Origin-Hostname: devbig006.ftw2.facebook.com To: , , CC: , , , , , , Song Liu Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH v8 0/6] Enable THP for text section of non-shmem files Date: Mon, 24 Jun 2019 15:29:45 -0700 Message-ID: <20190624222951.37076-1-songliubraving@fb.com> X-Mailer: git-send-email 2.17.1 X-FB-Internal: Safe MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-24_15:,, signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906240176 X-FB-Internal: deliver X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Changes v7 => v8: 1. Use IS_ENABLED wherever possible (Kirill A. Shutemov); 2. Improve handling of !PageUptodate case (Kirill A. Shutemov); 3. Add comment for calling lru_add_drain (Kirill A. Shutemov); 4. Add more information about DENYWRITE dynamic (Johannes Weiner). Changes v6 => v7: 1. Avoid accessing vma without holding mmap_sem (Hillf Dayton) 2. In collapse_file() use readahead API instead of gup API. This matches better with existing logic for shmem. 3. Add inline documentation for @nr_thps (kbuild test robot) Changes v5 => v6: 1. Improve THP stats in 3/6, (Kirill). Changes v4 => v5: 1. Move the logic to drop THP from pagecache to open() path (Rik). 2. Revise description of CONFIG_READ_ONLY_THP_FOR_FS. Changes v3 => v4: 1. Put the logic to drop THP from pagecache in a separate function (Rik). 2. Move the function to drop THP from pagecache to exit_mmap(). 3. Revise confusing commit log 6/6. Changes v2 => v3: 1. Removed the limitation (cannot write to file with THP) by truncating whole file during sys_open (see 6/6); 2. Fixed a VM_BUG_ON_PAGE() in filemap_fault() (see 2/6); 3. Split function rename to a separate patch (Rik); 4. Updated condition in hugepage_vma_check() (Rik). Changes v1 => v2: 1. Fixed a missing mem_cgroup_commit_charge() for non-shmem case. This set follows up discussion at LSF/MM 2019. The motivation is to put text section of an application in THP, and thus reduces iTLB miss rate and improves performance. Both Facebook and Oracle showed strong interests to this feature. To make reviews easier, this set aims a mininal valid product. Current version of the work does not have any changes to file system specific code. This comes with some limitations (discussed later). This set enables an application to "hugify" its text section by simply running something like: madvise(0x600000, 0x80000, MADV_HUGEPAGE); Before this call, the /proc//maps looks like: 00400000-074d0000 r-xp 00000000 00:27 2006927 app After this call, part of the text section is split out and mapped to THP: 00400000-00425000 r-xp 00000000 00:27 2006927 app 00600000-00e00000 r-xp 00200000 00:27 2006927 app <<< on THP 00e00000-074d0000 r-xp 00a00000 00:27 2006927 app Limitations: 1. This only works for text section (vma with VM_DENYWRITE). 2. Original limitation #2 is removed in v3. We gated this feature with an experimental config, READ_ONLY_THP_FOR_FS. Once we get better support on the write path, we can remove the config and enable it by default. Tested cases: 1. Tested with btrfs and ext4. 2. Tested with real work application (memcache like caching service). 3. Tested with "THP aware uprobe": https://patchwork.kernel.org/project/linux-mm/list/?series=131339 This set (plus a few uprobe patches) is also available at https://github.com/liu-song-6/linux/tree/uprobe-thp Please share your comments and suggestions on this. Thanks! Song Liu (6): filemap: check compound_head(page)->mapping in filemap_fault() filemap: update offset check in filemap_fault() mm,thp: stats for file backed THP khugepaged: rename collapse_shmem() and khugepaged_scan_shmem() mm,thp: add read-only THP support for (non-shmem) FS mm,thp: avoid writes to file with THP in pagecache drivers/base/node.c | 6 +++ fs/inode.c | 2 + fs/namei.c | 23 +++++++- fs/proc/meminfo.c | 4 ++ fs/proc/task_mmu.c | 4 +- include/linux/fs.h | 28 ++++++++++ include/linux/mmzone.h | 2 + mm/Kconfig | 11 ++++ mm/filemap.c | 9 ++-- mm/khugepaged.c | 117 ++++++++++++++++++++++++++++++++--------- mm/rmap.c | 12 +++-- mm/vmstat.c | 2 + 12 files changed, 184 insertions(+), 36 deletions(-) --- 2.17.1