From patchwork Tue Jun 25 07:52:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 11014947 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 15C996C5 for ; Tue, 25 Jun 2019 07:53:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0992A28990 for ; Tue, 25 Jun 2019 07:53:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F17CA289F3; Tue, 25 Jun 2019 07:53:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CA0C28990 for ; Tue, 25 Jun 2019 07:53:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 401E16B0003; Tue, 25 Jun 2019 03:53:06 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 3B2788E0003; Tue, 25 Jun 2019 03:53:06 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C9378E0002; Tue, 25 Jun 2019 03:53:06 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id D2A816B0003 for ; Tue, 25 Jun 2019 03:53:05 -0400 (EDT) Received: by mail-ed1-f71.google.com with SMTP id y24so24417670edb.1 for ; Tue, 25 Jun 2019 00:53:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id; bh=9svr2lbZ1/4XNVIxWXvUwRYc0udysxK1kbxlHLmFiTY=; b=s9HuzuFxUxjU4ttAW1H6rn9i55jP3y94pkZvvzundob7KCGiIMtpaVyqyThMOTx7yK fwg1bI3rUP15M+dTrHxLy7E+BXWOpud+2pGYMY28UKSQKPsftzi8qQg3gz9IPwXRLvbr ujneEe9643Lhdf4A7QLYzxnsO60XLgXThE8uYhHmcFXHS8ifSNdvFfh/zg85A3hZj7cV 9Ih/eNXjzIjso11uxKvaYpZYodFj8q//I2U7To38IZaDKY1TOSxKvTLHYEoLdsY/Vli2 Kpb8u4iKseIba0CD/1NsKaK9rmwRQg51qs4fYVq6xDNc79xy+RkZPZWl7ixlizWX4ym2 pj/A== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador@suse.de designates 195.135.221.5 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Gm-Message-State: APjAAAVH4ZcB+iPJch95p/CzOwKRnP7L9top+jDjqF7vbjwyFwQj3CVd /FWyXQ7WtZsL8EkEE83g4fu3lbdmFntJpXbkQx6reTpJn/6AJtPZ+34hqW0IOEN/siVfJF45DEV 8qb2Q32GTxVSTiMcdIzaSRaGIHca8vprTsEE/K3y47K+6kpqxj2EbpQKtbU5jNgkXfw== X-Received: by 2002:a05:6402:1446:: with SMTP id d6mr130909157edx.37.1561449185369; Tue, 25 Jun 2019 00:53:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqx54KXuWDqYhd5ZJdsK2Vh6AE1dWZAwv0bBUUTv65xwCM0xGtriJ+BKEjaNH6jBN3Vs9mK3 X-Received: by 2002:a05:6402:1446:: with SMTP id d6mr130909067edx.37.1561449184336; Tue, 25 Jun 2019 00:53:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561449184; cv=none; d=google.com; s=arc-20160816; b=oOJlBi06suFM9LeoI8aJbRDvNS8CPJZucum4rwKiHFPjCYIeCLmXu2yfHHnZXMMJA3 fNcVjmS/vXuXtxog7+U76H5lcDXdCoC7q0VTndpCrKiSwB+CUyFx5dhPeMV8h2QaXU4E /HgNgrdCFA44uixiB1nJHBW5Qt1vnHHdugiOCQF7cey5+wl3iG4l4g+zvWsw80AwXa4Q EmKDW0OpP3/Tl1LUXIUzI10bW0Sep43WoXrkBJKm9wMu0owM5GlTESmkGyj+rVaDD6ar 8Kdb1lmiu59J4vysuef/K/MzWOuL54KTejXxeIZKXSWU7Db0wuoA6nVk5fn/vUFtnz0x sssw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=9svr2lbZ1/4XNVIxWXvUwRYc0udysxK1kbxlHLmFiTY=; b=Y4vkbGZrWMa6GWaHLpGcdOCrMLypG0ACeAmqpKCATX18qPC0/JEB9MVbCURcfPTTU+ Uv4kZTWKqec+86a9DzihxS4D76i0agilWIPJbp4baxNvjE/myFIeO8O/Z54KjyBTakbK 9AMi3ZLHT4zXFSOT1CFpQNSHE9nNovj5OdFwRqj+h1eklXwPg5twJMHq6S72EF/vo9xb tmPAprFklGTIm+k6INEj/kMHjoIJeP+WekA5vJWpOf4OT1GwTxAdgjpHoamXHBjHvTgu 5sUoqvxt58t6GqB6xszaAsImyyg06cmPpJt5wTVw/ZQ4Q02KTC4f2skLxB0nzOnBfQrL IDPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of osalvador@suse.de designates 195.135.221.5 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from smtp.nue.novell.com (smtp.nue.novell.com. [195.135.221.5]) by mx.google.com with ESMTPS id u2si8195485ejk.197.2019.06.25.00.53.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jun 2019 00:53:04 -0700 (PDT) Received-SPF: pass (google.com: domain of osalvador@suse.de designates 195.135.221.5 as permitted sender) client-ip=195.135.221.5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador@suse.de designates 195.135.221.5 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Tue, 25 Jun 2019 09:53:03 +0200 Received: from suse.de (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (NOT encrypted); Tue, 25 Jun 2019 08:52:33 +0100 From: Oscar Salvador To: akpm@linux-foundation.org Cc: mhocko@suse.com, dan.j.williams@intel.com, pasha.tatashin@soleen.com, Jonathan.Cameron@huawei.com, david@redhat.com, anshuman.khandual@arm.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v2 0/5] Allocate memmap from hotadded memory Date: Tue, 25 Jun 2019 09:52:22 +0200 Message-Id: <20190625075227.15193-1-osalvador@suse.de> X-Mailer: git-send-email 2.13.7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Hi, It has been while since I sent previous version [1]. In this version I added some feedback I got back then, like letting the caller decide whether he wants allocating per memory block or per memory range (patch#2), and having the chance to disable vmemmap when users want to expose all hotpluggable memory to userspace (patch#5). [Testing] While I could test last version on powerpc, and Huawei's fellows helped me out testing it on arm64, this time I could only test it on x86_64. The codebase is quite the same, so I would not expect surprises. - x86_64: small and large memblocks (128MB, 1G and 2G) - Kernel module that adds memory spanning multiple memblocks and remove that memory in a different granularity. So far, only acpi memory hotplug uses the new flag. The other callers can be changed depending on their needs. Of course, more testing and feedback is appreciated. [Coverletter] This is another step to make memory hotplug more usable. The primary goal of this patchset is to reduce memory overhead of the hot-added memory (at least for SPARSEMEM_VMEMMAP memory model). The current way we use to populate memmap (struct page array) has two main drawbacks: a) it consumes an additional memory until the hotadded memory itself is onlined and b) memmap might end up on a different numa node which is especially true for movable_node configuration. a) it is a problem especially for memory hotplug based memory "ballooning" solutions when the delay between physical memory hotplug and the onlining can lead to OOM and that led to introduction of hacks like auto onlining (see 31bc3858ea3e ("memory-hotplug: add automatic onlining policy for the newly added memory")). b) can have performance drawbacks. Another minor case is that I have seen hot-add operations failing on archs because they were running out of order-x pages. E.g On powerpc, in certain configurations, we use order-8 pages, and given 64KB base pagesize, that is 16MB. If we run out of those, we just fail the operation and we cannot add more memory. We could fallback to base pages as x86_64 does, but we can do better. One way to mitigate all these issues is to simply allocate memmap array (which is the largest memory footprint of the physical memory hotplug) from the hot-added memory itself. SPARSEMEM_VMEMMAP memory model allows us to map any pfn range so the memory doesn't need to be online to be usable for the array. See patch 3 for more details. This feature is only usable when CONFIG_SPARSEMEM_VMEMMAP is set. [Overall design]: Implementation wise we reuse vmem_altmap infrastructure to override the default allocator used by vmemap_populate. Once the memmap is allocated we need a way to mark altmap pfns used for the allocation. If MHP_MEMMAP_{DEVICE,MEMBLOCK} flag was passed, we set up the layout of the altmap structure at the beginning of __add_pages(), and then we call mark_vmemmap_pages(). The flags are either MHP_MEMMAP_DEVICE or MHP_MEMMAP_MEMBLOCK, and only differ in the way they allocate vmemmap pages within the memory blocks. MHP_MEMMAP_MEMBLOCK: - With this flag, we will allocate vmemmap pages in each memory block. This means that if we hot-add a range that spans multiple memory blocks, we will use the beginning of each memory block for the vmemmap pages. This strategy is good for cases where the caller wants the flexiblity to hot-remove memory in a different granularity than when it was added. MHP_MEMMAP_DEVICE: - With this flag, we will store all vmemmap pages at the beginning of hot-added memory. So it is a tradeoff of flexiblity vs contigous memory. More info on the above can be found in patch#2. Depending on which flag is passed (MHP_MEMMAP_DEVICE or MHP_MEMMAP_MEMBLOCK), mark_vmemmap_pages() gets called at a different stage. With MHP_MEMMAP_MEMBLOCK, we call it once we have populated the sections fitting in a single memblock, while with MHP_MEMMAP_DEVICE we wait until all sections have been populated. mark_vmemmap_pages() marks the pages as vmemmap and sets some metadata: The current layout of the Vmemmap pages are: [Head->refcount] : Nr sections used by this altmap [Head->private] : Nr of vmemmap pages [Tail->freelist] : Pointer to the head page This is done to easy the computation we need in some places. E.g: Example 1) We hot-add 1GB on x86_64 (memory block 128MB) using MHP_MEMMAP_DEVICE: head->_refcount = 8 sections head->private = 4096 vmemmap pages tail's->freelist = head Example 2) We hot-add 1GB on x86_64 using MHP_MEMMAP_MEMBLOCK: [at the beginning of each memblock] head->_refcount = 1 section head->private = 512 vmemmap pages tail's->freelist = head We have the refcount because when using MHP_MEMMAP_DEVICE, we need to know how much do we have to defer the call to vmemmap_free(). The thing is that the first pages of the hot-added range are used to create the memmap mapping, so we cannot remove those first, otherwise we would blow up when accessing the other pages. What we do is that since when we hot-remove a memory-range, sections are being removed sequentially, we wait until we hit the last section, and then we free the hole range to vmemmap_free backwards. We know that it is the last section because in every pass we decrease head->_refcount, and when it reaches 0, we got our last section. We also have to be careful about those pages during online and offline operations. They are simply skipped, so online will keep them reserved and so unusable for any other purpose and offline ignores them so they do not block the offline operation. One thing worth mention is that vmemmap pages residing in movable memory is not a show-stopper for that memory to be offlined/migrated away. Vmemmap pages are just ignored in that case and they stick around until sections referred by those vmemmap pages are hot-removed. [1] https://patchwork.kernel.org/cover/10875017/ Oscar Salvador (5): drivers/base/memory: Remove unneeded check in remove_memory_block_devices mm,memory_hotplug: Introduce MHP_VMEMMAP_FLAGS mm,memory_hotplug: Introduce Vmemmap page helpers mm,memory_hotplug: allocate memmap from the added memory range for sparse-vmemmap mm,memory_hotplug: Allow userspace to enable/disable vmemmap arch/arm64/mm/mmu.c | 5 +- arch/powerpc/mm/init_64.c | 7 ++ arch/s390/mm/init.c | 6 ++ arch/x86/mm/init_64.c | 10 +++ drivers/acpi/acpi_memhotplug.c | 2 +- drivers/base/memory.c | 41 +++++++++-- drivers/dax/kmem.c | 2 +- drivers/hv/hv_balloon.c | 2 +- drivers/s390/char/sclp_cmd.c | 2 +- drivers/xen/balloon.c | 2 +- include/linux/memory_hotplug.h | 31 ++++++++- include/linux/memremap.h | 2 +- include/linux/page-flags.h | 34 +++++++++ mm/compaction.c | 7 ++ mm/memory_hotplug.c | 152 ++++++++++++++++++++++++++++++++++------- mm/page_alloc.c | 22 +++++- mm/page_isolation.c | 14 +++- mm/sparse.c | 93 +++++++++++++++++++++++++ mm/util.c | 2 + 19 files changed, 394 insertions(+), 42 deletions(-)