From patchwork Mon Nov 25 00:37:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Hubbard X-Patchwork-Id: 11259409 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D919813A4 for ; Mon, 25 Nov 2019 00:37:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9BA41207FD for ; Mon, 25 Nov 2019 00:37:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="irB0tCRU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BA41207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 458726B0563; Sun, 24 Nov 2019 19:37:21 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 408ED6B0564; Sun, 24 Nov 2019 19:37:21 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 344A26B0565; Sun, 24 Nov 2019 19:37:21 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 23EB26B0563 for ; Sun, 24 Nov 2019 19:37:21 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id C02E04850 for ; Mon, 25 Nov 2019 00:37:20 +0000 (UTC) X-FDA: 76192935840.30.stamp40_22ccb9d770c45 X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,jhubbard@nvidia.com,:akpm@linux-foundation.org:jgg@ziepe.ca:leon@kernel.org:hch@infradead.org:ira.weiny@intel.com:linux-rdma@vger.kernel.org::linux-kernel@vger.kernel.org:jhubbard@nvidia.com,RULES_HIT:30012:30054:30064,0,RBL:216.228.121.143:@nvidia.com:.lbl8.mailshell.net-62.18.0.100 64.10.201.10,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:ft,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: stamp40_22ccb9d770c45 X-Filterd-Recvd-Size: 3518 Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Nov 2019 00:37:18 +0000 (UTC) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 24 Nov 2019 16:37:21 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Sun, 24 Nov 2019 16:37:17 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Sun, 24 Nov 2019 16:37:17 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 00:37:17 +0000 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 00:37:17 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 25 Nov 2019 00:37:17 +0000 Received: from blueforge.nvidia.com (Not Verified[10.110.48.28]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Sun, 24 Nov 2019 16:37:16 -0800 From: John Hubbard To: Andrew Morton , Jason Gunthorpe , Leon Romanovsky , Christoph Hellwig CC: Ira Weiny , , , LKML , John Hubbard Subject: [PATCH 0/2] mm/gup + IB: allow FOLL_FORCE for gup_fast and use in IB Date: Sun, 24 Nov 2019 16:37:13 -0800 Message-ID: <20191125003715.516290-1-jhubbard@nvidia.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-NVConfidentiality: public DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574642241; bh=o2tsnwufqtiAaAcjzWDmAxcwkNpfpLpA2IYDm85B8JI=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: MIME-Version:X-NVConfidentiality:Content-Transfer-Encoding: Content-Type; b=irB0tCRUPHupwE4qwQoe5I0D8UvNcIkF7OLhCOorIQ9dnOPnV+qVaNEyXYup3lWxM rMe0WefT5a2SiudyNQnKo80GoU2hF8iECplAr2GsIm9LnBCyDlgP57SqC7J+kGjpuE aKP84FMBOdxKX1wQ62yFd68qS8HNZl+w/kRJrNasjqGCWf7UhJTZ7AxMVvXv6g5YXL zZyrmQiMVpGlaKn2UVerD1YATlHryBWkZCDoxY/+MrD7U/DC6xTreI05Ii/6FXGAyo Vq25DeXZpGwhJm+VzLYtyuhWPl2PcN9PKa0pb5lRL2a5/UEL8/48zrdawePmyxSCE7 tH5r/fbVLTHqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Leon, Jason, Christoph, Maybe I'm overlooking something, but as I wrote in patch 1, it looks like we can simply allow FOLL_FORCE to be passed to gup_fast(). This should fix Leon's reported RDMA failure [1] when using patch 2 by itself. (I've compile- and boot-tested these, and also did short LTP and fio with direct IO tests, but I don't have an Infiniband runtime setup that exercises the umem.c code.) [1] https://lore.kernel.org/r/20191124100724.GH136476@unreal John Hubbard (2): mm/gup: allow FOLL_FORCE for get_user_pages_fast() IB/umem: use get_user_pages_fast() to pin DMA pages drivers/infiniband/core/umem.c | 17 ++++++----------- mm/gup.c | 3 ++- 2 files changed, 8 insertions(+), 12 deletions(-)