mbox series

[0/3] tool lib traceevent: Fix some parsing errors

Message ID 20200324200845.763565368@goodmis.org (mailing list archive)
Headers show
Series tool lib traceevent: Fix some parsing errors | expand

Message

Steven Rostedt March 24, 2020, 8:08 p.m. UTC
Arnaldo,

Here's a few patches for lib traceevent.

The first one adds an "append()" helper function for appending to strings,
which will also simplify the next patch.

The second patch handles "__attribute__((user))" in the field of a
trace event. This is needed after the stack leak code added this
to parameters of system call events.

The last patch adds handling of __builtin_expect(), as someone wanted
to move IS_ERR_VALUE() from the fast path into the print fmt section,
which breaks the parsing. This should also be useful for other macros
that may evaluate down to a __builtin_expect().

Steven Rostedt (VMware) (3):
      tools lib traceevent: Add append() function helper for appending strings
      tools lib traceevent: Handle __attribute__((user)) in field names
      tools lib traceevent: Add handler for __builtin_expect()

----
 tools/lib/traceevent/event-parse.c | 168 ++++++++++++++++++++++++-------------
 1 file changed, 111 insertions(+), 57 deletions(-)

Comments

Steven Rostedt June 17, 2020, 9:28 p.m. UTC | #1
Hi Arnaldo,

I guess these patches were missed.

-- Steve


On Tue, 24 Mar 2020 16:08:45 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> Arnaldo,
> 
> Here's a few patches for lib traceevent.
> 
> The first one adds an "append()" helper function for appending to strings,
> which will also simplify the next patch.
> 
> The second patch handles "__attribute__((user))" in the field of a
> trace event. This is needed after the stack leak code added this
> to parameters of system call events.
> 
> The last patch adds handling of __builtin_expect(), as someone wanted
> to move IS_ERR_VALUE() from the fast path into the print fmt section,
> which breaks the parsing. This should also be useful for other macros
> that may evaluate down to a __builtin_expect().
> 
> Steven Rostedt (VMware) (3):
>       tools lib traceevent: Add append() function helper for appending strings
>       tools lib traceevent: Handle __attribute__((user)) in field names
>       tools lib traceevent: Add handler for __builtin_expect()
> 
> ----
>  tools/lib/traceevent/event-parse.c | 168 ++++++++++++++++++++++++-------------
>  1 file changed, 111 insertions(+), 57 deletions(-)
Arnaldo Carvalho de Melo June 17, 2020, 10:55 p.m. UTC | #2
On June 17, 2020 6:28:04 PM GMT-03:00, Steven Rostedt <rostedt@goodmis.org> wrote:
>Hi Arnaldo,
>
>I guess these patches were missed.

I'll pick those tomorrow,

Thanks for the reminder,


- Arnaldo

>
>-- Steve
>
>
>On Tue, 24 Mar 2020 16:08:45 -0400
>Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> Arnaldo,
>> 
>> Here's a few patches for lib traceevent.
>> 
>> The first one adds an "append()" helper function for appending to
>strings,
>> which will also simplify the next patch.
>> 
>> The second patch handles "__attribute__((user))" in the field of a
>> trace event. This is needed after the stack leak code added this
>> to parameters of system call events.
>> 
>> The last patch adds handling of __builtin_expect(), as someone wanted
>> to move IS_ERR_VALUE() from the fast path into the print fmt section,
>> which breaks the parsing. This should also be useful for other macros
>> that may evaluate down to a __builtin_expect().
>> 
>> Steven Rostedt (VMware) (3):
>>       tools lib traceevent: Add append() function helper for
>appending strings
>>       tools lib traceevent: Handle __attribute__((user)) in field
>names
>>       tools lib traceevent: Add handler for __builtin_expect()
>> 
>> ----
>>  tools/lib/traceevent/event-parse.c | 168
>++++++++++++++++++++++++-------------
>>  1 file changed, 111 insertions(+), 57 deletions(-)
Arnaldo Carvalho de Melo June 18, 2020, 1:24 p.m. UTC | #3
Em Wed, Jun 17, 2020 at 07:55:29PM -0300, Arnaldo Carvalho de Melo escreveu:
> 
> 
> On June 17, 2020 6:28:04 PM GMT-03:00, Steven Rostedt <rostedt@goodmis.org> wrote:
> >Hi Arnaldo,
> >
> >I guess these patches were missed.
> 
> I'll pick those tomorrow,
> 
> Thanks for the reminder,

Thanks, applied to perf/urgent, for v5.8.

- Arnaldo
 
> 
> - Arnaldo
> 
> >
> >-- Steve
> >
> >
> >On Tue, 24 Mar 2020 16:08:45 -0400
> >Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >> Arnaldo,
> >> 
> >> Here's a few patches for lib traceevent.
> >> 
> >> The first one adds an "append()" helper function for appending to
> >strings,
> >> which will also simplify the next patch.
> >> 
> >> The second patch handles "__attribute__((user))" in the field of a
> >> trace event. This is needed after the stack leak code added this
> >> to parameters of system call events.
> >> 
> >> The last patch adds handling of __builtin_expect(), as someone wanted
> >> to move IS_ERR_VALUE() from the fast path into the print fmt section,
> >> which breaks the parsing. This should also be useful for other macros
> >> that may evaluate down to a __builtin_expect().
> >> 
> >> Steven Rostedt (VMware) (3):
> >>       tools lib traceevent: Add append() function helper for
> >appending strings
> >>       tools lib traceevent: Handle __attribute__((user)) in field
> >names
> >>       tools lib traceevent: Add handler for __builtin_expect()
> >> 
> >> ----
> >>  tools/lib/traceevent/event-parse.c | 168
> >++++++++++++++++++++++++-------------
> >>  1 file changed, 111 insertions(+), 57 deletions(-)
> 
> -- 
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>