From patchwork Tue Apr 28 03:27:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jann Horn X-Patchwork-Id: 11513693 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C859992C for ; Tue, 28 Apr 2020 03:28:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7009020B1F for ; Tue, 28 Apr 2020 03:28:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KS7OZjdt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7009020B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F368C8E0005; Mon, 27 Apr 2020 23:27:59 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id EE7E58E0001; Mon, 27 Apr 2020 23:27:59 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD63B8E0005; Mon, 27 Apr 2020 23:27:59 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id C6F8B8E0001 for ; Mon, 27 Apr 2020 23:27:59 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6D3AF8248047 for ; Tue, 28 Apr 2020 03:27:59 +0000 (UTC) X-FDA: 76755829878.02.owl10_45b7e9a816b3a X-Spam-Summary: 10,1,0,72eb68d234eb1ec9,d41d8cd98f00b204,3vqknxgukcj0g7kkedlldib.9ljifkru-jjhs79h.lod@flex--jannh.bounces.google.com,,RULES_HIT:41:69:152:355:379:541:800:960:967:968:973:988:989:1260:1277:1313:1314:1345:1437:1516:1518:1535:1542:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2564:2682:2685:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3152:3354:3622:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4605:5007:6261:6653:6742:7875:7974:9010:9025:9969:10004:10400:10450:10455:11026:11658:11914:12043:12266:12291:12294:12296:12297:12438:12555:12663:12679:12683:12698:12737:12895:12986:13161:13229:13255:13618:13870:14096:14097:14157:14181:14394:14659:14721:19904:19999:21080:21325:21365:21444:21451:21524:21611:21627:21740:21749:21795:21811:21939:30012:30051:30054:30056:30070:30079,0,RBL:209.85.219.202:@flex--jannh.bounces.google.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100,CacheIP:non e,Bayesi X-HE-Tag: owl10_45b7e9a816b3a X-Filterd-Recvd-Size: 5927 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 28 Apr 2020 03:27:58 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id l187so23251389ybf.17 for ; Mon, 27 Apr 2020 20:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=u+G4hEDBCMfTTINsEe1rRLbmDctcZioKYhqJKU0a/to=; b=KS7OZjdt/sKvdslTKy6L/T6sE7YdAFI7rtNbHDh37qyDWlr6BYYTbLkiyvmD0nU0Vg PRRFYjaV7UbuK8P97MQGc1kQlBkhSW5m1ljSw8YwuhdjhF7jXweNqaFbkY9Plz6Wl1j4 osppM2gxoE4Yrgh4n66OgZ3JsEY6l1ff2OMDXWcjzIlhM9kTGJ4VqWohzV1FRAHXNefl ZYwNdvb4LAg5HEbG7ldnRs7JPffDElIHozrCI8WkjzJY+A19nzvQ5AN+xrhkWxSSzafL O46PyHQSSBOenRmN3cTUjh1IJpeaEsSCOrwDvLioHY9vH6+s/1WzYSsDqeo2yVlPtFEk +EUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=u+G4hEDBCMfTTINsEe1rRLbmDctcZioKYhqJKU0a/to=; b=KJYGSbI1DQDHILJ5YGz29kAI3cs4kknkbqX0aKzbAubcAEPDw4MKXPWC0lMq92ED2B Q/OyLdxjtpz2kVzExtMQwTu++NVG7fWliCEekT76iqiMUnsJ8gRayP9pH6X80HuBzupK U2ZmkRhVoioTwVoVTaweaMwKLs1/0wWkJGbOnS5+R7pZkuI4Sd+gI+DAbud9sPzv0jl6 um9ckjbEkMhveArYi6/zEubT+4PDqCjxuIRjT4X3PZflIsH7dSXQaaw32lLe5uOaHab6 5X3MQ5IwMh0NmdfhEZYjDW3t/E9f/i+SLjFX8y/QY1Gqv8Wv1Dg2BkQOwpevhL+m+6yi tWQA== X-Gm-Message-State: AGi0PuaW2XI2INoyVB07EyLWdXqleK+2qpPyHIKYwYH0h0c4yH2gKmen BzDH3BKcdGUzXYWOX+qh+5zH+G3+EA== X-Google-Smtp-Source: APiQypK6jqWOuNTokUNhG2QCt7A5zcXYd6+OoLGYxMDdl4Pak6sHqzfYvRIQd9LB/iLqowxAAwDHJLlsNA== X-Received: by 2002:a25:afd0:: with SMTP id d16mr42901934ybj.441.1588044478270; Mon, 27 Apr 2020 20:27:58 -0700 (PDT) Date: Tue, 28 Apr 2020 05:27:40 +0200 Message-Id: <20200428032745.133556-1-jannh@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.26.2.303.gf8c07b1a785-goog Subject: [PATCH 0/5] Fix ELF / FDPIC ELF core dumping, and use mmap_sem properly in there From: Jann Horn To: Andrew Morton Cc: Linus Torvalds , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Alexander Viro , "Eric W . Biederman" , Oleg Nesterov , Russell King , linux-arm-kernel@lists.infradead.org, Mark Salter , Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: At the moment, we have that rather ugly mmget_still_valid() helper to work around : ELF core dumping doesn't take the mmap_sem while traversing the task's VMAs, and if anything (like userfaultfd) then remotely messes with the VMA tree, fireworks ensue. So at the moment we use mmget_still_valid() to bail out in any writers that might be operating on a remote mm's VMAs. With this series, I'm trying to get rid of the need for that as cleanly as possible. In particular, I want to avoid holding the mmap_sem across unbounded sleeps. Patches 1, 2 and 3 are relatively unrelated cleanups in the core dumping code. Patches 4 and 5 implement the main change: Instead of repeatedly accessing the VMA list with sleeps in between, we snapshot it at the start with proper locking, and then later we just use our copy of the VMA list. This ensures that the kernel won't crash, that VMA metadata in the coredump is consistent even in the presence of concurrent modifications, and that any virtual addresses that aren't being concurrently modified have their contents show up in the core dump properly. The disadvantage of this approach is that we need a bit more memory during core dumping for storing metadata about all VMAs. After this series has landed, we should be able to rip out mmget_still_valid(). Testing done so far: - Creating a simple core dump on X86-64 still works. - The created coredump on X86-64 opens in GDB, and both the stack and the exectutable look vaguely plausible. - 32-bit ARM compiles with FDPIC support, both with MMU and !MMU config. I'm CCing some folks from the architectures that use FDPIC in case anyone wants to give this a spin. This series is based on (Christoph Hellwig's "remove set_fs calls from the coredump code v4"). Jann Horn (5): binfmt_elf_fdpic: Stop using dump_emit() on user pointers on !MMU coredump: Fix handling of partial writes in dump_emit() coredump: Refactor page range dumping into common helper binfmt_elf, binfmt_elf_fdpic: Use a VMA list snapshot mm/gup: Take mmap_sem in get_dump_page() fs/binfmt_elf.c | 170 ++++++++++++--------------------------- fs/binfmt_elf_fdpic.c | 106 +++++++++--------------- fs/coredump.c | 102 +++++++++++++++++++++++ include/linux/coredump.h | 12 +++ mm/gup.c | 69 +++++++++------- 5 files changed, 243 insertions(+), 216 deletions(-) base-commit: 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c prerequisite-patch-id: c0a20b414eebc48fe0a8ca570b05de34c7980396 prerequisite-patch-id: 51973b8db0fa4b114e0c3fd8936b634d9d5061c5 prerequisite-patch-id: 0e1e8de282ca6d458dc6cbdc6b6ec5879edd8a05 prerequisite-patch-id: d5ee749c4d3a22ec80bd0dd88aadf89aeb569db8 prerequisite-patch-id: 46ce14e59e98e212a1eca0aef69c6dcdb62b8242