[0/3] Drop unused MAX_PHYSADDR_BITS

Message

Arvind Sankar July 23, 2020, 11:15 p.m. UTC

This #define is not used anywhere, and has the wrong value on x86_64.

I tried digging into the history a bit, but it seems to have been unused
even in the initial merge of sparsemem in v2.6.13, when it was first
defined.

Arvind Sankar (3):
  x86/mm: Drop unused MAX_PHYSADDR_BITS
  sh/mm: Drop unused MAX_PHYSADDR_BITS
  sparc: Drop unused MAX_PHYSADDR_BITS

 arch/sh/include/asm/sparsemem.h    | 4 +---
 arch/sparc/include/asm/sparsemem.h | 1 -
 arch/x86/include/asm/sparsemem.h   | 6 +-----
 3 files changed, 2 insertions(+), 9 deletions(-)

Comments

Dave Hansen July 24, 2020, 3:04 p.m. UTC | #1

On 7/23/20 4:15 PM, Arvind Sankar wrote:
> This #define is not used anywhere, and has the wrong value on x86_64.

Yeah, it certainly is unused.

> I tried digging into the history a bit, but it seems to have been unused
> even in the initial merge of sparsemem in v2.6.13, when it was first
> defined.

Yep, I don't even remember why we thought we needed it back then.  Feel
free to add my ack on these, or at least the x86 one.

Mike Rapoport July 26, 2020, 6:48 a.m. UTC | #2

On Thu, Jul 23, 2020 at 07:15:41PM -0400, Arvind Sankar wrote:
> This #define is not used anywhere, and has the wrong value on x86_64.
> 
> I tried digging into the history a bit, but it seems to have been unused
> even in the initial merge of sparsemem in v2.6.13, when it was first
> defined.
> 
> Arvind Sankar (3):
>   x86/mm: Drop unused MAX_PHYSADDR_BITS
>   sh/mm: Drop unused MAX_PHYSADDR_BITS
>   sparc: Drop unused MAX_PHYSADDR_BITS

For the series

Acked-by: Mike Rapoport <[e-mail]>

 
>  arch/sh/include/asm/sparsemem.h    | 4 +---
>  arch/sparc/include/asm/sparsemem.h | 1 -
>  arch/x86/include/asm/sparsemem.h   | 6 +-----
>  3 files changed, 2 insertions(+), 9 deletions(-)
> 
> -- 
> 2.26.2
> 
>