From patchwork Fri Oct 9 07:59:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11825151 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E7F22109B for ; Fri, 9 Oct 2020 07:59:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5A18F22280 for ; Fri, 9 Oct 2020 07:59:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="DEazGm3/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A18F22280 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 741436B005C; Fri, 9 Oct 2020 03:59:54 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6F0B16B0062; Fri, 9 Oct 2020 03:59:54 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E06A6B0068; Fri, 9 Oct 2020 03:59:54 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id 3028F6B005C for ; Fri, 9 Oct 2020 03:59:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BA8911EE6 for ; Fri, 9 Oct 2020 07:59:53 +0000 (UTC) X-FDA: 77351638266.09.bike52_5003ae8271df Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 96536180AD806 for ; Fri, 9 Oct 2020 07:59:53 +0000 (UTC) X-Spam-Summary: 1,0,0,d6256109ea91ca5f,d41d8cd98f00b204,daniel.vetter@ffwll.ch,,RULES_HIT:41:69:152:355:379:541:800:967:968:973:988:989:1260:1277:1311:1313:1314:1345:1437:1515:1516:1518:1535:1543:1593:1594:1711:1730:1747:1777:1792:1801:2110:2194:2199:2393:2525:2559:2564:2682:2685:2859:2894:2901:2911:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4117:4321:4425:4605:5007:6119:6261:6653:7875:7903:9025:10004:10400:11026:11232:11658:11914:12043:12294:12296:12297:12517:12519:12555:12679:12895:12986:13071:13141:13161:13229:13230:13845:13894:14096:14097:14180:14181:14394:14659:14721:21060:21080:21444:21451:21627:21740:21749:21773:21811:21939:30012:30054:30056,0,RBL:209.85.128.68:@ffwll.ch:.lbl8.mailshell.net-62.8.0.100 66.201.201.201;04y8ydres816eygsa1fd65nwrew71ocn1apgnofqjj9hrfjh4pinryym69anwg6.eretx6iw5e7ew1ah4mm51dzgne9g1hrw6wsk4a15r1bnet4s1ceo7g97qi3et13.s-lbl8. mailshel X-HE-Tag: bike52_5003ae8271df X-Filterd-Recvd-Size: 6520 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Fri, 9 Oct 2020 07:59:53 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id f21so8841526wml.3 for ; Fri, 09 Oct 2020 00:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=immTPDdSm8V7ezbOteojXYm/j7WkY1f3P9Y0YpK7onQ=; b=DEazGm3//HS7eifrtPTNpv9gPNwxpuxjM7cgzXbcLG0mO5e39cJ73eX9iQKQEkxr4Y FwEAxZ/eknqujf87zOGqp6tESSOeL2I6VSIobgrZsNnXiWlr9VWW7WhVnV0GrVhO4vMj 1v4YtSGCDuC7IGf+ELUEOwyj9sMdI3c9bq3Xg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=immTPDdSm8V7ezbOteojXYm/j7WkY1f3P9Y0YpK7onQ=; b=S32VJ4+YcJt0Eo7+jsUGI031sZGDzzlEUDRg0YFniog9B0Nm74eTDRN3EVc7dShr3h znIeEKFeeYq2xXISWTo44H3akJDZaoGApP1ebgVsMx38C25Nu7hEUxWdiVmqz/aPzB3d D4j2Npm3waZPF9SQhOkjTAhw0AkFDCCwVbqoCBWDUfHT6WSQ07lgFnv1TgifVDMO3fch LHrEErilPDJE2Zjmh/X9XRqtFg5iDQtu597fBZiYgf4lsWX2/AQY263mcQ4XPVbNce7w HHIRVW1c8NJvjOZ+Mmyvfi8E5O89JPWX3B0/TKXaVlKkqfN7AexY6C8Nd1GbA60OFwlj v9Qw== X-Gm-Message-State: AOAM532jXQAuTdpcTz80eBClRfjnaHIANeLfT2OIJpYHJENqOUHARbmu O79Ms51FJ8Tj0a6wc2ZQeqo2g2xwy+/INAZk X-Google-Smtp-Source: ABdhPJzyDJpFjA/Q+sv1RhX5gsGPQpkP/4WlxxT8RLqjQWQaBWIid1inU3iHz1dJQWF+W7VpBZ1zIA== X-Received: by 2002:a1c:f311:: with SMTP id q17mr13703008wmq.168.1602230391713; Fri, 09 Oct 2020 00:59:51 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u17sm11634118wri.45.2020.10.09.00.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 00:59:50 -0700 (PDT) From: Daniel Vetter To: DRI Development , LKML Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Vetter Subject: [PATCH v2 00/17] follow_pfn and other iomap races Date: Fri, 9 Oct 2020 09:59:17 +0200 Message-Id: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi all, Round two of my patch series to clamp down a bunch of races and gaps around follow_pfn and other access to iomem mmaps. Previous version: v1: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ffwll.ch/ And the discussion that sparked this journey: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ffwll.ch/ Changes in v2: - tons of small polish&fixes all over, thanks to all the reviewers who spotted issues - I managed to test at least the generic_access_phys and pci mmap revoke stuff with a few gdb sessions using our i915 debug tools (hence now also the drm/i915 patch to properly request all the pci bar regions) - reworked approach for the pci mmap revoke: Infrastructure moved into kernel/resource.c, address_space mapping is now set up at open time for everyone (which required some sysfs changes). Does indeed look a lot cleaner and a lot less invasive than I feared at first. The big thing I can't test are all the frame_vector changes in habanalbas, exynos and media. Gerald has given the s390 patch a spin already. Review, testing, feedback all very much welcome. Cheers, Daniel Daniel Vetter (17): drm/exynos: Stop using frame_vector helpers drm/exynos: Use FOLL_LONGTERM for g2d cmdlists misc/habana: Stop using frame_vector helpers misc/habana: Use FOLL_LONGTERM for userptr mm/frame-vector: Use FOLL_LONGTERM media: videobuf2: Move frame_vector into media subsystem mm: Close race in generic_access_phys s390/pci: Remove races against pte updates mm: Add unsafe_follow_pfn media/videbuf1|2: Mark follow_pfn usage as unsafe vfio/type1: Mark follow_pfn as unsafe PCI: Obey iomem restrictions for procfs mmap /dev/mem: Only set filp->f_mapping resource: Move devmem revoke code to resource framework sysfs: Support zapping of binary attr mmaps PCI: Revoke mappings like devmem drm/i915: Properly request PCI BARs arch/s390/pci/pci_mmio.c | 98 +++++++++++-------- drivers/char/mem.c | 86 +--------------- drivers/gpu/drm/exynos/Kconfig | 1 - drivers/gpu/drm/exynos/exynos_drm_g2d.c | 48 ++++----- drivers/gpu/drm/i915/intel_uncore.c | 25 ++++- drivers/media/common/videobuf2/Kconfig | 1 - drivers/media/common/videobuf2/Makefile | 1 + .../media/common/videobuf2}/frame_vector.c | 54 ++++------ drivers/media/platform/omap/Kconfig | 1 - drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- drivers/misc/habanalabs/Kconfig | 1 - drivers/misc/habanalabs/common/habanalabs.h | 3 +- drivers/misc/habanalabs/common/memory.c | 50 ++++------ drivers/pci/pci-sysfs.c | 4 + drivers/pci/proc.c | 6 ++ drivers/vfio/vfio_iommu_type1.c | 4 +- fs/sysfs/file.c | 11 +++ include/linux/ioport.h | 6 +- include/linux/mm.h | 47 +-------- include/linux/sysfs.h | 2 + include/media/videobuf2-core.h | 42 ++++++++ kernel/resource.c | 95 +++++++++++++++++- mm/Kconfig | 3 - mm/Makefile | 1 - mm/memory.c | 76 +++++++++++++- mm/nommu.c | 17 ++++ security/Kconfig | 13 +++ 27 files changed, 412 insertions(+), 286 deletions(-) rename {mm => drivers/media/common/videobuf2}/frame_vector.c (85%)