From patchwork Thu Oct 15 00:00:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jann Horn X-Patchwork-Id: 11838315 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 334CC14B5 for ; Thu, 15 Oct 2020 00:00:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C003B221FF for ; Thu, 15 Oct 2020 00:00:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="hSX8Eum4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C003B221FF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B50536B0062; Wed, 14 Oct 2020 20:00:56 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B01556B0068; Wed, 14 Oct 2020 20:00:56 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C9EE900002; Wed, 14 Oct 2020 20:00:56 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 6F8266B0062 for ; Wed, 14 Oct 2020 20:00:56 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DC28E3622 for ; Thu, 15 Oct 2020 00:00:55 +0000 (UTC) X-FDA: 77372204070.06.party54_100d61e27210 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id B5CBF101C0E0B for ; Thu, 15 Oct 2020 00:00:55 +0000 (UTC) X-Spam-Summary: 10,1,0,ba70f87c5d79f3ac,d41d8cd98f00b204,jannh@google.com,,RULES_HIT:41:69:355:379:541:967:973:988:989:1260:1311:1314:1345:1437:1515:1535:1542:1711:1730:1747:1777:1792:1801:2198:2199:2393:2525:2559:2563:2682:2685:2731:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3152:3353:3865:3866:3867:3868:3870:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4605:5007:6261:6653:6742:7875:7901:7903:8957:9025:9969:10004:11026:11658:11914:12043:12266:12297:12438:12517:12519:12555:12679:12683:12698:12737:12895:12986:13095:13161:13229:13870:13894:14093:14096:14181:14394:14721:21080:21365:21433:21444:21451:21627:21740:21889:30003:30054:30070,0,RBL:209.85.221.66:@google.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100;04ygktu3aw9a35ubhr8gy6uxno1toopdrxqn9uww6ey5rbbrwg8wn3n379xj8ih.xthh1ueadxx96x4yczrei8ispc7nufnbbmq1ifcwzo5kzz3t9g68pc78qoswmmy.s-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,D omainCac X-HE-Tag: party54_100d61e27210 X-Filterd-Recvd-Size: 5340 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 15 Oct 2020 00:00:55 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id i1so1062604wro.1 for ; Wed, 14 Oct 2020 17:00:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dcwlglX8iOlpi6mOSe7tPpaLqVdYBCo/S0EI6csZEvA=; b=hSX8Eum4r3FmRooY1FU1i1yMO//cL7GCj57llsBbGkKQfr6zo9iMYqjUX/4DF8LHfb LRS8tGyofnY6n2M0Ykw6HChlj/thsee6pIpA30NW/w7KfLJshEf88/m6PVFoETxiRXD/ 82u5R3nlVYUGB26DnmqOEovqLVtxBli1ljzFIakT4Syf8Sb202bYI4tPXSO8Uu7+1tDH +hY7JRFAIVP5ltMKPeTliTOky59KMH6aE3tbzxVERkb44+pENz7qfhJWDUHS3CDLdXOB glZZ3WGXRvZ2w627pEe4bwPOjrql6E9ultblF3nu86OURTS+3wfgH1SeXJdKA83kbp2Q BGlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dcwlglX8iOlpi6mOSe7tPpaLqVdYBCo/S0EI6csZEvA=; b=QqIs5prVwAeLaiG6+Gj1pxQKSxViiVjjRCOtDUiOKMJrjFFZbxULWG0dzlSIZCKF5h qdNZtD73CqmYOrHjyaiDLbWeprDCFkReKfhJTizC+Gre28fVqlm7qMItnymXRQeZ2CYW YswBvpM8fY7Ul1KXwbxoyiupOGuKftNwkxjHlLr9th16Y5kfGjN2AL7BDARpIVJIPzK+ QfRlyECkwrmaH6YsXGOULgUS2vvaWnwXRgfYW6JQv98lopPKVxrCKXIkp/RnsP4iJXig XkE1zm9t5hxfdvP1UwvVlOOJyRsoGLH6ZXDPmvme0L0VPccSfQUovBRrxoK0BXUSq2Tt qtjA== X-Gm-Message-State: AOAM531pncOMLr/WuNCpSB/GfavNaho2x9thlCmBCzDp8jcFngFUKq8e CpwPjGa9zNQh1zI54+hcllaZBg== X-Google-Smtp-Source: ABdhPJym+Qy1Ozx/d9cUaPJGBmjZDj1SlCf0AIF1ayERayiA+KXQG6VjdYmuJ9wI/O3AcGbfGeStJw== X-Received: by 2002:a5d:60c4:: with SMTP id x4mr1115358wrt.75.1602720053779; Wed, 14 Oct 2020 17:00:53 -0700 (PDT) Received: from localhost ([2a02:168:96c5:1:55ed:514f:6ad7:5bcc]) by smtp.gmail.com with ESMTPSA id 24sm1489113wmg.8.2020.10.14.17.00.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 17:00:52 -0700 (PDT) From: Jann Horn To: Andrew Morton , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Eric W . Biederman" , Michel Lespinasse , Mauro Carvalho Chehab , Sakari Ailus , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, Jason Gunthorpe , John Hubbard , Johannes Berg Subject: [PATCH v3 0/2] Broad write-locking of nascent mm in execve Date: Thu, 15 Oct 2020 02:00:39 +0200 Message-Id: <20201015000041.1734214-1-jannh@google.com> X-Mailer: git-send-email 2.28.0.1011.ga647a8990f-goog MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: v3: - add note about how this also fixes arch/um/ locking in patch 1 (Johannes Berg) - use IS_DEFINED() instead of #ifdef in patch 2 (Jason Gunthorpe) v2: - fix commit message of patch 1/2 and be more verbose about where the old mmap lock is taken (Michel, Jason) - resending without mangling the diffs :/ (Michel, Jason) These two patches replace "mmap locking API: don't check locking if the mm isn't live yet"[1], which is currently in the mmotm tree, and should be placed in the same spot where the old patch was. While I originally said that this would be an alternative patch (meaning that the existing patch would have worked just as well), the new patches actually address an additional issue that the old patch missed (bprm->vma is used after the switch to the new mm). I have boot-tested these patches on x64-64 (with lockdep) and !MMU arm (the latter with both FLAT and ELF). [1] https://lkml.kernel.org/r/CAG48ez03YJG9JU_6tGiMcaVjuTyRE_o4LEQ7901b5ZoCnNAjcg@mail.gmail.com Jann Horn (2): mmap locking API: Order lock of nascent mm outside lock of live mm exec: Broadly lock nascent mm until setup_arg_pages() arch/um/include/asm/mmu_context.h | 3 +- fs/exec.c | 64 ++++++++++++++++--------------- include/linux/binfmts.h | 2 +- include/linux/mmap_lock.h | 23 ++++++++++- kernel/fork.c | 7 +--- 5 files changed, 59 insertions(+), 40 deletions(-) base-commit: fb0155a09b0224a7147cb07a4ce6034c8d29667f prerequisite-patch-id: 08f97130a51898a5f6efddeeb5b42638577398c7 prerequisite-patch-id: 577664d761cd23fe9031ffdb1d3c9ac313572c67 prerequisite-patch-id: dc29a39716aa8689f80ba2767803d9df3709beaa prerequisite-patch-id: 42b1b546d33391ead2753621f541bcc408af1769 prerequisite-patch-id: 2cbb839f57006f32e21f4229e099ae1bd782be24 prerequisite-patch-id: 1b4daf01cf61654a5ec54b5c3f7c7508be7244ee prerequisite-patch-id: f46cc8c99f1909fe2a65fbc3cf1f6bc57489a086 prerequisite-patch-id: 2b0caed97223241d5008898dde995d02fda544e4 prerequisite-patch-id: 6b7adcb54989e1ec3370f256ff2c35d19cf785aa