From patchwork Thu Oct 29 13:16:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Elver X-Patchwork-Id: 11866329 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 85CB41130 for ; Thu, 29 Oct 2020 13:17:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 21A6520E65 for ; Thu, 29 Oct 2020 13:17:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="bkpQw3q1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21A6520E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1303F6B006C; Thu, 29 Oct 2020 09:17:01 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 0B8AB6B0070; Thu, 29 Oct 2020 09:17:01 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC0DA6B0071; Thu, 29 Oct 2020 09:17:00 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id B62C56B006C for ; Thu, 29 Oct 2020 09:17:00 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5B68A1EF3 for ; Thu, 29 Oct 2020 13:17:00 +0000 (UTC) X-FDA: 77425013400.30.fog14_270a2012728d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 1D0D2180B3C8B for ; Thu, 29 Oct 2020 13:17:00 +0000 (UTC) X-Spam-Summary: 20,1.5,0,5c1e2adcea4f394f,d41d8cd98f00b204,3yscaxwukclkdkudqfnnfkd.bnlkhmtw-lljuzbj.nqf@flex--elver.bounces.google.com,,RULES_HIT:1:2:41:152:355:379:541:800:966:967:973:982:988:989:1260:1263:1277:1313:1314:1345:1437:1516:1518:1593:1594:1605:1730:1747:1777:1792:1801:1981:2194:2196:2199:2200:2393:2525:2568:2629:2682:2685:2693:2859:2892:2901:2912:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3152:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4034:4049:4250:4321:4385:4559:4605:4657:5007:6117:6119:6261:6299:6653:6690:6742:6743:6755:7875:7903:7974:8599:8603:8784:8957:9025:9388:9969:10009:11026:11257:11473:11658:11914:12043:12219:12291:12296:12297:12438:12555:12679:12776:12895:12986:13141:13161:13229:13230:13255:13846:14096:14097:14394:14651:14659:21067:21080:21094:21220:21323:21444:21450:21451:21627:21740:21990:30012:30029:30045:30054:30070:30074:30075,0,RBL:209.85.160.202:@flex--elver.bounces.googl e.com:.l X-HE-Tag: fog14_270a2012728d X-Filterd-Recvd-Size: 10115 Received: from mail-qt1-f202.google.com (mail-qt1-f202.google.com [209.85.160.202]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 13:16:59 +0000 (UTC) Received: by mail-qt1-f202.google.com with SMTP id w56so1829448qtw.10 for ; Thu, 29 Oct 2020 06:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=gJ+NyZrwSjh9xv4IitL3tDIsRKqkaN8A5XofNgnAjw0=; b=bkpQw3q1vLKk8DHo5pHLHBVE1CIav1oE1voIWji1HnsQ08+YTjgHqmcXNPvpEvKeJX fqyg8UADfhL3YCWwAyuqU1senrwPc8QfPpEt5Lk0hmZL10YHWhVsO4gZ7ivQm8EhP9x0 D/SXkdwqzsmoEdyysNzopPSuloZqi0uBgd59zF9Ik1Z3OS2aAO59SjyVg2z1dfhOlafL K9R8qDs+QEnNahOgYlbKRFVOgdBl+JRhs91xoEyWKV5tIksD26LJDse70QYAfLdS+RS3 IKaXGR4ELKqHdBk0eVTImANA7yaRtoe2Gtp/13tf/72Si6arhIafA5VVPQMvj4cjk8Jc uLhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=gJ+NyZrwSjh9xv4IitL3tDIsRKqkaN8A5XofNgnAjw0=; b=OoPCT+XJte8mLVf7JLYkXuNj6VhwUc+gLG8jZHsFxFHo3RJbi0QRous05AxW5i7Dg8 47otGAXpge3P4wnAQN1AR+3SoldB8KSWbkTzaqWP0nTbeMFj1zi41858MWB4ehf+IJEY KbaUgPQY4YMi5Ue7i4oHwAs0lY/ovf5OpDYv3b+S0783ZH4BBq/RdHR9ANvbEPclua7B HXHVrcZQUnxyDi4hND8mlMY8UGiBLysIRxQR8hGloocTsklHkgQIblYg+f2K5ShRYy9j FECQRmqalNaQrwqTQt/jDIChG7HRnr61K27TIkgzN2Ad5tIZpeGOqcAAiJkGr04LZbp3 phuQ== X-Gm-Message-State: AOAM53179qOuxdHD7JfGo2h+krnaGi2fzhaggWflasysxO29aFdJrVmO sstrPx/X9nv4R8cCjkbAQ4cP/SPdLw== X-Google-Smtp-Source: ABdhPJyiBEUA7qxqCN7bgZyMqRXcQURQ1iojG+u5gBlNOJrvBwDovJB4Z2UVeJEY7owHFDQXsGpnumDHpA== X-Received: from elver.muc.corp.google.com ([2a00:79e0:15:13:f693:9fff:fef4:2449]) (user=elver job=sendgmr) by 2002:ad4:45ca:: with SMTP id v10mr4429043qvt.48.1603977418489; Thu, 29 Oct 2020 06:16:58 -0700 (PDT) Date: Thu, 29 Oct 2020 14:16:40 +0100 Message-Id: <20201029131649.182037-1-elver@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.29.1.341.ge80a0c044ae-goog Subject: [PATCH v6 0/9] KFENCE: A low-overhead sampling-based memory safety error detector From: Marco Elver To: elver@google.com, akpm@linux-foundation.org, glider@google.com Cc: hpa@zytor.com, paulmck@kernel.org, andreyknvl@google.com, aryabinin@virtuozzo.com, luto@kernel.org, bp@alien8.de, catalin.marinas@arm.com, cl@linux.com, dave.hansen@linux.intel.com, rientjes@google.com, dvyukov@google.com, edumazet@google.com, gregkh@linuxfoundation.org, hdanton@sina.com, mingo@redhat.com, jannh@google.com, Jonathan.Cameron@huawei.com, corbet@lwn.net, iamjoonsoo.kim@lge.com, joern@purestorage.com, keescook@chromium.org, mark.rutland@arm.com, penberg@kernel.org, peterz@infradead.org, sjpark@amazon.com, tglx@linutronix.de, vbabka@suse.cz, will@kernel.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This adds the Kernel Electric-Fence (KFENCE) infrastructure. KFENCE is a low-overhead sampling-based memory safety error detector of heap use-after-free, invalid-free, and out-of-bounds access errors. This series enables KFENCE for the x86 and arm64 architectures, and adds KFENCE hooks to the SLAB and SLUB allocators. KFENCE is designed to be enabled in production kernels, and has near zero performance overhead. Compared to KASAN, KFENCE trades performance for precision. The main motivation behind KFENCE's design, is that with enough total uptime KFENCE will detect bugs in code paths not typically exercised by non-production test workloads. One way to quickly achieve a large enough total uptime is when the tool is deployed across a large fleet of machines. KFENCE objects each reside on a dedicated page, at either the left or right page boundaries. The pages to the left and right of the object page are "guard pages", whose attributes are changed to a protected state, and cause page faults on any attempted access to them. Such page faults are then intercepted by KFENCE, which handles the fault gracefully by reporting a memory access error. Guarded allocations are set up based on a sample interval (can be set via kfence.sample_interval). After expiration of the sample interval, the next allocation through the main allocator (SLAB or SLUB) returns a guarded allocation from the KFENCE object pool. At this point, the timer is reset, and the next allocation is set up after the expiration of the interval. To enable/disable a KFENCE allocation through the main allocator's fast-path without overhead, KFENCE relies on static branches via the static keys infrastructure. The static branch is toggled to redirect the allocation to KFENCE. The KFENCE memory pool is of fixed size, and if the pool is exhausted no further KFENCE allocations occur. The default config is conservative with only 255 objects, resulting in a pool size of 2 MiB (with 4 KiB pages). We have verified by running synthetic benchmarks (sysbench I/O, hackbench) that a kernel with KFENCE is performance-neutral compared to a non-KFENCE baseline kernel. KFENCE is inspired by GWP-ASan [1], a userspace tool with similar properties. The name "KFENCE" is a homage to the Electric Fence Malloc Debugger [2]. For more details, see Documentation/dev-tools/kfence.rst added in the series -- also viewable here: https://raw.githubusercontent.com/google/kasan/kfence/Documentation/dev-tools/kfence.rst [1] http://llvm.org/docs/GwpAsan.html [2] https://linux.die.net/man/3/efence v6: * Record allocation and free task pids, and show them in reports. This information helps more easily identify e.g. racy use-after-frees. v5: https://lkml.kernel.org/r/20201027141606.426816-1-elver@google.com * Lots of smaller fixes (see details in patches). * Optimize is_kfence_address() by using better in-range check. * Removal of HAVE_ARCH_KFENCE_STATIC_POOL and static pool support in favor of memblock_alloc'd pool only, as it avoids all issues with virt_to translations. With the new optimizations to is_kfence_address(), we measure no noticeable performance impact. * Taint with TAINT_BAD_PAGE, to distinguish memory errors from regular warnings (also used by SL*B/KASAN/etc. for memory errors). * Rework sample_interval parameter dynamic setting semantics. * Rework kfence_shutdown_cache(). * Fix obj_to_index+objs_per_slab_page, which among other things is required when using memcg accounted allocations. * Rebase to 5.10-rc1. v4: https://lkml.kernel.org/r/20200929133814.2834621-1-elver@google.com * MAINTAINERS: Split out from first patch. * Make static memory pool's attrs entirely arch-dependent. * Fix report generation if __slab_free tail-called. * Clarify RCU test comment [reported by Paul E. McKenney]. v3: https://lkml.kernel.org/r/20200921132611.1700350-1-elver@google.com * Rewrite SLAB/SLUB patch descriptions to clarify need for 'orig_size'. * Various smaller fixes (see details in patches). v2: https://lkml.kernel.org/r/20200915132046.3332537-1-elver@google.com * Various comment/documentation changes (see details in patches). * Various smaller fixes (see details in patches). * Change all reports to reference the kfence object, "kfence-#nn". * Skip allocation/free internals stack trace. * Rework KMEMLEAK compatibility patch. RFC/v1: https://lkml.kernel.org/r/20200907134055.2878499-1-elver@google.com Alexander Potapenko (5): mm: add Kernel Electric-Fence infrastructure x86, kfence: enable KFENCE for x86 mm, kfence: insert KFENCE hooks for SLAB mm, kfence: insert KFENCE hooks for SLUB kfence, kasan: make KFENCE compatible with KASAN Marco Elver (4): arm64, kfence: enable KFENCE for ARM64 kfence, Documentation: add KFENCE documentation kfence: add test suite MAINTAINERS: Add entry for KFENCE Documentation/dev-tools/index.rst | 1 + Documentation/dev-tools/kfence.rst | 291 ++++++++++ MAINTAINERS | 11 + arch/arm64/Kconfig | 1 + arch/arm64/include/asm/kfence.h | 19 + arch/arm64/mm/fault.c | 4 + arch/arm64/mm/mmu.c | 7 +- arch/x86/Kconfig | 1 + arch/x86/include/asm/kfence.h | 65 +++ arch/x86/mm/fault.c | 4 + include/linux/kfence.h | 191 +++++++ include/linux/slab_def.h | 3 + include/linux/slub_def.h | 3 + init/main.c | 3 + lib/Kconfig.debug | 1 + lib/Kconfig.kfence | 73 +++ mm/Makefile | 1 + mm/kasan/common.c | 15 + mm/kasan/generic.c | 3 +- mm/kfence/Makefile | 6 + mm/kfence/core.c | 821 ++++++++++++++++++++++++++++ mm/kfence/kfence.h | 107 ++++ mm/kfence/kfence_test.c | 822 +++++++++++++++++++++++++++++ mm/kfence/report.c | 235 +++++++++ mm/slab.c | 37 +- mm/slab_common.c | 5 +- mm/slub.c | 72 ++- 27 files changed, 2771 insertions(+), 31 deletions(-) create mode 100644 Documentation/dev-tools/kfence.rst create mode 100644 arch/arm64/include/asm/kfence.h create mode 100644 arch/x86/include/asm/kfence.h create mode 100644 include/linux/kfence.h create mode 100644 lib/Kconfig.kfence create mode 100644 mm/kfence/Makefile create mode 100644 mm/kfence/core.c create mode 100644 mm/kfence/kfence.h create mode 100644 mm/kfence/kfence_test.c create mode 100644 mm/kfence/report.c