From patchwork Thu Nov 19 10:57:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 11917127 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 084EDC388F9 for ; Thu, 19 Nov 2020 10:57:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 84238246CE for ; Thu, 19 Nov 2020 10:57:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84238246CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3BB076B005D; Thu, 19 Nov 2020 05:57:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24FE66B005C; Thu, 19 Nov 2020 05:57:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 002DF6B005C; Thu, 19 Nov 2020 05:57:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id A9D0E6B006E for ; Thu, 19 Nov 2020 05:57:31 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 42B673647 for ; Thu, 19 Nov 2020 10:57:31 +0000 (UTC) X-FDA: 77500866702.19.hole31_5f03ed427342 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 201B11ACC22 for ; Thu, 19 Nov 2020 10:57:31 +0000 (UTC) X-HE-Tag: hole31_5f03ed427342 X-Filterd-Recvd-Size: 3026 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Nov 2020 10:57:30 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8CA66AE30; Thu, 19 Nov 2020 10:57:28 +0000 (UTC) From: Oscar Salvador To: akpm@linux-foundation.org Cc: n-horiguchi@ah.jp.nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH 0/7] HWPoison: Refactor get page interface Date: Thu, 19 Nov 2020 11:57:09 +0100 Message-Id: <20201119105716.5962-1-osalvador@suse.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, following up on previous fix-ups an refactors, this patchset simplifies the get page interface and removes the MF_COUNT_INCREASED trick we have for soft offline. Please, note that this patchset is on top of [1] and [2]. This patchset does three things: 1) Drops MF_COUNT_INCREASED trick 2) Refactors get page interface 3) Places a common entry for grabbin a page from both hard offline and soft offline guarded by zone_pcp_{disable/enable}, so we do not have to drain pcplists by ourself and retry again. Note that the MF_COUNT_INCREASED trick was left because if get_hwpoison_page races with put_page (e.g:) CPU0 CPU1 put_page (refcount decremented to 0) __put_single_page free_unref_page free_unref_page_prepare free_pcp_prepare free_pages_prepare soft_offline_page :page->flags &= ~PAGE_FLAGS_CHECK_AT_PREP get_any_page get_hwpoison_page free_unref_page_commit free_one_page __free_one_page (place it in buddy) get_hwpoison_page sees that page has a refcount of 0, but since it was not placed in buddy yet we cannot really handle it. We now have a sort of maximum passes in get_any_page, so in case we race with either an allocation or a put_page, we retry again. After an off-list discussion with Naoya, he agreed to proceed. [1] https://patchwork.kernel.org/project/linux-mm/list/?series=364009 [2] https://patchwork.kernel.org/project/linux-mm/list/?series=381903 Naoya Horiguchi (3): mm,madvise: call soft_offline_page() without MF_COUNT_INCREASED mm,hwpoison: remove MF_COUNT_INCREASED mm,hwpoison: remove flag argument from soft offline functions Oscar Salvador (4): mm,hwpoison: Refactor get_any_page mm,hwpoison: Drop pfn parameter mm,hwpoison: Disable pcplists before grabbing a refcount mm,hwpoison: Remove drain_all_pages from shake_page drivers/base/memory.c | 2 +- include/linux/mm.h | 9 +-- mm/madvise.c | 19 +++-- mm/memory-failure.c | 168 +++++++++++++++++------------------------- 4 files changed, 85 insertions(+), 113 deletions(-)