From patchwork Sat Nov 21 19:45:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Arcangeli X-Patchwork-Id: 11923615 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A31C388F9 for ; Sat, 21 Nov 2020 19:45:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 265DA221F9 for ; Sat, 21 Nov 2020 19:45:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cemCWQ7o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 265DA221F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22F086B005C; Sat, 21 Nov 2020 14:45:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE926B005D; Sat, 21 Nov 2020 14:45:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A73A6B006C; Sat, 21 Nov 2020 14:45:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF32E6B005D for ; Sat, 21 Nov 2020 14:45:18 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 543833647 for ; Sat, 21 Nov 2020 19:45:18 +0000 (UTC) X-FDA: 77509454316.05.meat02_1506a3127356 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id AA2471801E691 for ; Sat, 21 Nov 2020 19:45:17 +0000 (UTC) X-HE-Tag: meat02_1506a3127356 X-Filterd-Recvd-Size: 3161 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Sat, 21 Nov 2020 19:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605987916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/n9qzU93yjpwWqpZ4t1OnDoSkIDxpyCWRVsrij+PqBU=; b=cemCWQ7oly83tjEpQa/ROAt9TQDAU0N6t3y3arP0+DmrNBq9rv7ABe2pf/RTGZFThIt0QJ PMYXOMNvsnr534+SWP7R6Ha/9OcNHDM9ackK4JawGBKyf7S95gzm034/EL0QH3qRcJAAnf Fddrcnx/4VxCmYKFCfRdxIGdYe3K+X8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-112-FDfrJ_tzPVSMkHwmKiKa3g-1; Sat, 21 Nov 2020 14:45:12 -0500 X-MC-Unique: FDfrJ_tzPVSMkHwmKiKa3g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A872151D8; Sat, 21 Nov 2020 19:45:10 +0000 (UTC) Received: from mail (ovpn-112-35.rdu2.redhat.com [10.10.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A24E18996; Sat, 21 Nov 2020 19:45:07 +0000 (UTC) From: Andrea Arcangeli To: Mel Gorman , Andrew Morton , linux-mm@kvack.org, Qian Cai Cc: Vlastimil Babka , Michal Hocko , David Hildenbrand , linux-kernel@vger.kernel.org, Mike Rapoport , Baoquan He Subject: [PATCH 0/1] VM_BUG_ON_PAGE(!zone_spans_pfn) in set_pfnblock_flags_mask Date: Sat, 21 Nov 2020 14:45:05 -0500 Message-Id: <20201121194506.13464-1-aarcange@redhat.com> In-Reply-To: <8C537EB7-85EE-4DCF-943E-3CC0ED0DF56D@lca.pw> References: <8C537EB7-85EE-4DCF-943E-3CC0ED0DF56D@lca.pw> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, After hitting this twice on two different systems, I'm now running with the tentative fix applied, but it's not a meaningful test since it's non reproducible. However it is possible to inject this bug if you do "grep E820 /proc/iomem" and then find a phys addr there with a struct page (i.e. pfn_valid) in a zone, with this change: min_pfn = pageblock_start_pfn(cc->free_pfn - (distance >> 1)); + if (cc->zone is the zone where the e820 physaddr has a pfn_valid) + min_pfn = physaddr_of_E820_non_RAM_page_with_valid_pfn >> PAGE_SHIFT; I didn't try to inject the bug to validate the fix and it'd be great if someone can try that to validate this or any other fix. Andrea Arcangeli (1): mm: compaction: avoid fast_isolate_around() to set pageblock_skip on reserved pages mm/compaction.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)