From patchwork Tue May 11 13:31:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matteo Croce X-Patchwork-Id: 12250983 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6FDC433ED for ; Tue, 11 May 2021 13:31:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9CD0261221 for ; Tue, 11 May 2021 13:31:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CD0261221 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D42A66B006E; Tue, 11 May 2021 09:31:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF2406B0071; Tue, 11 May 2021 09:31:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1E1A6B0072; Tue, 11 May 2021 09:31:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 944656B006E for ; Tue, 11 May 2021 09:31:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 87F8BB792 for ; Tue, 11 May 2021 13:31:39 +0000 (UTC) X-FDA: 78129037518.21.B3081FA Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf04.hostedemail.com (Postfix) with ESMTP id 825E53C5 for ; Tue, 11 May 2021 13:31:32 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id g14so22904199edy.6 for ; Tue, 11 May 2021 06:31:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oIa86m56V7D9OxvaRCpHAzJ1pFfZnNHw5kUPaITumU0=; b=rSEfCDdQrTdVWykoMNo6ePICLlwQ4oIZPbW1I9yOy41A386wo7ZyY6uc3G9aI4lXb7 ikhhGrpzfVfmK5tsRWCC8xcAwAvZcQOC/lGOOYLn36P0BLMTVFRhzentoI4LFF1i5OHs Fu2eROBB7GLx0nZtHO+51Po6klbxbBJB5aCHTBvWfGA0rh5hnboVqANyeM46uJB4BE+k nmxYnL82dPt7H1XD+LVrLDStgIcuDd4scOhwhRC9ajYgvY79wxCZSc6BS0dvs1FZFo8x WSrQqbBS63Zj0KoHYqKSUkCtj7hvsHJ2NYa6AkyFvDtGlxxOUM0ws9iYaOkJPgzWHNwP 9GrA== X-Gm-Message-State: AOAM531+Ezk7L8q/K36yN7BqND1EuIyjpQZ80SoKQr6ZflfFtbeh58iU oLLf5qwsHp+/tBBHxqdf34E= X-Google-Smtp-Source: ABdhPJxdcawn9TncpLMKVjYBQqwkA4w+GCL74vYFB+ERi6r8YHQrSwr9ybTvxZ/U/SAq58/0humi3g== X-Received: by 2002:a05:6402:2712:: with SMTP id y18mr37816019edd.41.1620739897451; Tue, 11 May 2021 06:31:37 -0700 (PDT) Received: from msft-t490s.teknoraver.net (net-5-94-253-60.cust.vodafonedsl.it. [5.94.253.60]) by smtp.gmail.com with ESMTPSA id b12sm14577136eds.23.2021.05.11.06.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 06:31:36 -0700 (PDT) From: Matteo Croce To: netdev@vger.kernel.org, linux-mm@kvack.org Cc: Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski , Thomas Petazzoni , Marcin Wojtas , Russell King , Mirko Lindner , Stephen Hemminger , Tariq Toukan , Jesper Dangaard Brouer , Ilias Apalodimas , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Boris Pismenny , Arnd Bergmann , Andrew Morton , "Peter Zijlstra (Intel)" , Vlastimil Babka , Yu Zhao , Will Deacon , Michel Lespinasse , Fenghua Yu , Roman Gushchin , Hugh Dickins , Peter Xu , Jason Gunthorpe , Jonathan Lemon , Alexander Lobakin , Cong Wang , wenxu , Kevin Hao , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Miaohe Lin , Yunsheng Lin , Guillaume Nault , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, Matthew Wilcox , Eric Dumazet , David Ahern , Lorenzo Bianconi , Saeed Mahameed , Andrew Lunn , Paolo Abeni , Sven Auhagen Subject: [PATCH net-next v4 0/4] page_pool: recycle buffers Date: Tue, 11 May 2021 15:31:14 +0200 Message-Id: <20210511133118.15012-1-mcroce@linux.microsoft.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=linux.microsoft.com (policy=none); spf=pass (imf04.hostedemail.com: domain of technoboy85@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=technoboy85@gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 825E53C5 X-Stat-Signature: fgoj3g65r5zxb9eatfj3sbigcw9sfm39 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=mail-ed1-f50.google.com; client-ip=209.85.208.50 X-HE-DKIM-Result: none/none X-HE-Tag: 1620739892-532854 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Matteo Croce This is a respin of [1] This patchset shows the plans for allowing page_pool to handle and maintain DMA map/unmap of the pages it serves to the driver. For this to work a return hook in the network core is introduced. The overall purpose is to simplify drivers, by providing a page allocation API that does recycling, such that each driver doesn't have to reinvent its own recycling scheme. Using page_pool in a driver does not require implementing XDP support, but it makes it trivially easy to do so. Instead of allocating buffers specifically for SKBs we now allocate a generic buffer and either wrap it on an SKB (via build_skb) or create an XDP frame. The recycling code leverages the XDP recycle APIs. The Marvell mvpp2 and mvneta drivers are used in this patchset to demonstrate how to use the API, and tested on a MacchiatoBIN and EspressoBIN boards respectively. Please let this going in on a future -rc1 so to allow enough time to have wider tests. Note that this series depends on the change "mm: fix struct page layout on 32-bit systems"[2] which is not yet in master. [1] https://lore.kernel.org/netdev/154413868810.21735.572808840657728172.stgit@firesoul/ [2] https://lore.kernel.org/linux-mm/20210510153211.1504886-1-willy@infradead.org/ Ilias Apalodimas (1): page_pool: Allow drivers to hint on SKB recycling Matteo Croce (3): mm: add a signature in struct page mvpp2: recycle buffers mvneta: recycle buffers drivers/net/ethernet/marvell/mvneta.c | 11 +++--- .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 17 +++++----- drivers/net/ethernet/marvell/sky2.c | 2 +- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- include/linux/mm_types.h | 1 + include/linux/skbuff.h | 34 ++++++++++++++++--- include/net/page_pool.h | 11 ++++++ net/core/page_pool.c | 27 +++++++++++++++ net/core/skbuff.c | 20 +++++++++-- net/tls/tls_device.c | 2 +- 10 files changed, 105 insertions(+), 22 deletions(-)