| Message ID | 20210609075752.4596-1-david@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | memory-hotplug.rst: complete admin-guide overhaul | expand |
David Hildenbrand <david@redhat.com> writes: > This is v3 of the memory hot(un)plug admin-guide overhaul. > > v2 -> v3: > - Added ACKs and RBs (thanks!) > - s/aarch64/arm64/ > - Refine error handling when onlining/offlining > - s/memory hotplug/memory offlining/ in the vmemmap optimization section > for huge pages So this set doesn't apply to docs-next, even when I correct for the fact that you didn't make the patch from the top-level kernel directory. What tree is this against? Thanks, jon
On 14.06.21 01:20, Jonathan Corbet wrote: > David Hildenbrand <david@redhat.com> writes: > >> This is v3 of the memory hot(un)plug admin-guide overhaul. >> >> v2 -> v3: >> - Added ACKs and RBs (thanks!) >> - s/aarch64/arm64/ >> - Refine error handling when onlining/offlining >> - s/memory hotplug/memory offlining/ in the vmemmap optimization section >> for huge pages > > So this set doesn't apply to docs-next, even when I correct for the fact > that you didn't make the patch from the top-level kernel directory. Hi Jon, oh, looks like I messed up v3 by git-format-patching from the wrong directory ... > What tree is this against? > Essentially against Andrew's mmotm, which already contains v1. Note mmotm was chosen due to a conflict in: https://lkml.kernel.org/r/20210510030027.56044-1-songmuchun@bytedance.com I'd suggest we take this via Andrew's tree, unless you have other preference on how to handle the conflict. Thanks! > Thanks, > > jon >
David Hildenbrand <david@redhat.com> writes: > Essentially against Andrew's mmotm, which already contains v1. Note > mmotm was chosen due to a conflict in: > > https://lkml.kernel.org/r/20210510030027.56044-1-songmuchun@bytedance.com > > I'd suggest we take this via Andrew's tree, unless you have other > preference on how to handle the conflict. Thanks! That's fine with me - one less thing for me to deal with :) Thanks, jon
On 14.06.21 16:14, Jonathan Corbet wrote: > David Hildenbrand <david@redhat.com> writes: > >> Essentially against Andrew's mmotm, which already contains v1. Note >> mmotm was chosen due to a conflict in: >> >> https://lkml.kernel.org/r/20210510030027.56044-1-songmuchun@bytedance.com >> >> I'd suggest we take this via Andrew's tree, unless you have other >> preference on how to handle the conflict. Thanks! > > That's fine with me - one less thing for me to deal with :) > Thanks! FWIW, the patches are fine. My setup simply seems to compress the file paths in the diff stats more aggressively: $ git format-patch -2 -v3 > /dev/null; cat v3-0000-cover-letter.patch | tail -6 .../admin-guide/mm/memory-hotplug.rst | 800 ++++++++++-------- 1 file changed, 455 insertions(+), 345 deletions(-) When I force to a bigger terminal size, I get longer paths: $ git format-patch -2 -v3 --stat=80 > /dev/null; cat v3-0000-cover-letter.patch | tail -6 Documentation/admin-guide/mm/memory-hotplug.rst | 800 ++++++++++++++---------- 1 file changed, 455 insertions(+), 345 deletions(-) (maybe my awesome-wm + xterm setup confuses git, or there is a BUG somewhere in my software stack)
On 09.06.21 09:57, David Hildenbrand wrote: > This is v3 of the memory hot(un)plug admin-guide overhaul. > > v2 -> v3: > - Added ACKs and RBs (thanks!) > - s/aarch64/arm64/ > - Refine error handling when onlining/offlining > - s/memory hotplug/memory offlining/ in the vmemmap optimization section > for huge pages > > v1 -> v2: > - Added "memory-hotplug.rst: remove locking details from admin-guide" > - Incorporated all feedback from Mike and Michal (thanks!) > - Compressed some lines to make full use of 80 chars. > - Added details regarding 64bit/supported archs to the introduction. > - Added KASAN to the list of sizing considerations. > > David Hildenbrand (2): > memory-hotplug.rst: remove locking details from admin-guide > memory-hotplug.rst: complete admin-guide overhaul > > .../admin-guide/mm/memory-hotplug.rst | 800 ++++++++++-------- > 1 file changed, 455 insertions(+), 345 deletions(-) > Andrew, are you planning on picking+sending this for this cycle, or do you prefer to let this doc update rest for a little bit longer? I can spot that mmotm still contains v1. Thanks!
On Thu, 1 Jul 2021 17:30:13 +0200 David Hildenbrand <david@redhat.com> wrote: > On 09.06.21 09:57, David Hildenbrand wrote: > > This is v3 of the memory hot(un)plug admin-guide overhaul. > > > > v2 -> v3: > > - Added ACKs and RBs (thanks!) > > - s/aarch64/arm64/ > > - Refine error handling when onlining/offlining > > - s/memory hotplug/memory offlining/ in the vmemmap optimization section > > for huge pages > > > > v1 -> v2: > > - Added "memory-hotplug.rst: remove locking details from admin-guide" > > - Incorporated all feedback from Mike and Michal (thanks!) > > - Compressed some lines to make full use of 80 chars. > > - Added details regarding 64bit/supported archs to the introduction. > > - Added KASAN to the list of sizing considerations. > > > > David Hildenbrand (2): > > memory-hotplug.rst: remove locking details from admin-guide > > memory-hotplug.rst: complete admin-guide overhaul > > > > .../admin-guide/mm/memory-hotplug.rst | 800 ++++++++++-------- > > 1 file changed, 455 insertions(+), 345 deletions(-) > > > > Andrew, > > are you planning on picking+sending this for this cycle, or do you > prefer to let this doc update rest for a little bit longer? > > I can spot that mmotm still contains v1. Seems that whenever I take a documentation patch, Jon pops up and takes it as well. Except this time ;) Please resend whatever's needed against current mainline?