From patchwork Tue Sep 14 07:28:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 12491849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF12CC433EF for ; Tue, 14 Sep 2021 07:32:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6965E60F4A for ; Tue, 14 Sep 2021 07:32:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6965E60F4A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9E6F4900002; Tue, 14 Sep 2021 03:32:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 996846B0071; Tue, 14 Sep 2021 03:32:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85EC4900002; Tue, 14 Sep 2021 03:32:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 776F96B006C for ; Tue, 14 Sep 2021 03:32:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 09FB72D001 for ; Tue, 14 Sep 2021 07:32:57 +0000 (UTC) X-FDA: 78585362394.06.EDDA94E Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf24.hostedemail.com (Postfix) with ESMTP id 10033B0000A1 for ; Tue, 14 Sep 2021 07:32:55 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id c4so6043604pls.6 for ; Tue, 14 Sep 2021 00:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8yA1aDR6gkxqIg6y5DZ1Vw9kfOVK0Ylz9+qgfpXtyKk=; b=KasYn3QFDwEkCtCg/46Y8ncnDXpl3N3dqcyFnJ67pj7o4A+hC/LQi7Q3Nj3A6I+fbc gekDCoCguFalsV34OxuVA5eou3y+btiwifsdh1F0XETMHGSB32g8kACL3jX+MKNGTKk/ gyYZtckLlPeC02Rho92YjCn6AB0zeq3ObjfIDQjzyXDT529q9dq1uPAEvnCh8a2onBFc ZBsCanKTy4a1HU8qVZ0dXhD44FaWtshNesT/MwWtw8nsEKG41v78McVsc1SHE6Hve+pw RzRuWxf4NVsCHB7cKiGQEUC6pPSHAs6nkqEU+2ZS9yenfc4L9xqdOMx6j05wwTIcmNXD xe2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8yA1aDR6gkxqIg6y5DZ1Vw9kfOVK0Ylz9+qgfpXtyKk=; b=rcV0zzd/glLQtmE613plhIO0oGE/rfD1B94iBEc7jSfSDb7shneyb/Vzd4nrjygiXn ZccqOzr2aCQW0s2qsB2WzX1C3CDP2kY+xyqk6c0Ww4Z5BRy5kGYdGGcqSeem/VEGvWeH BJUrrE+G5sH4AEsgYIBJGOeWQ7lF2/TfxNIf8wlVYxxmTxtQGh5D9QBZJZYbaQ2Z2ONY 7HFXZk/GT/4RoZJv6HF0fTnnUkv9mnwUQyZKSYfkePzazaZeb4o3xXpqn/wSwv/JOGP3 /ckPx8lEURcMEYH3jPyhzrfpGPSSyURVi0fMSQOEB741MVvXwVOAjcA0rjZSwCjxIE89 psVA== X-Gm-Message-State: AOAM5306HICeuQEN8wfn4k1sRu2wsO7weTfJLUoLszLhCpT5q5woMb04 KWE8VeXJJeMRChQOugJvv0sj8g== X-Google-Smtp-Source: ABdhPJw+tJJCZYmvWS0V/99J2vZGc3jQl5FaH3FghUH3rg11Abk7mWmtmj7qnhkifFtFA0WsvXtnNg== X-Received: by 2002:a17:90a:1de:: with SMTP id 30mr555002pjd.106.1631604774687; Tue, 14 Sep 2021 00:32:54 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.244]) by smtp.gmail.com with ESMTPSA id s3sm9377839pfd.188.2021.09.14.00.32.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Sep 2021 00:32:54 -0700 (PDT) From: Muchun Song To: willy@infradead.org, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, shakeelb@google.com, guro@fb.com, shy828301@gmail.com, alexs@kernel.org, richard.weiyang@gmail.com, david@fromorbit.com, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, zhengqi.arch@bytedance.com, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, smuchun@gmail.com, Muchun Song Subject: [PATCH v3 00/76] Optimize list lru memory consumption Date: Tue, 14 Sep 2021 15:28:22 +0800 Message-Id: <20210914072938.6440-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) MIME-Version: 1.0 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=KasYn3QF; spf=pass (imf24.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: q5d9g4hckowjbpeeiq8sfk4gnx6xqf4z X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 10033B0000A1 X-HE-Tag: 1631604775-887273 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We introduced alloc_inode_sb() in previous version 2, which sets up the inode reclaim context properly, to allocate filesystems specific inode. So we have to convert to new API for all filesystems, which is done in one patch. Some filesystems are easy to convert (just replace kmem_cache_alloc() to alloc_inode_sb()), while other filesystems need to do more work. In order to make it easy for maintainers of different filesystems to review their own maintained part, I split the patch into patches which are per-filesystem in this version. I am not sure if this is a good idea, because there is going to be more commits. In our server, we found a suspected memory leak problem. The kmalloc-32 consumes more than 6GB of memory. Other kmem_caches consume less than 2GB memory. After our in-depth analysis, the memory consumption of kmalloc-32 slab cache is the cause of list_lru_one allocation. crash> p memcg_nr_cache_ids memcg_nr_cache_ids = $2 = 24574 memcg_nr_cache_ids is very large and memory consumption of each list_lru can be calculated with the following formula. num_numa_node * memcg_nr_cache_ids * 32 (kmalloc-32) There are 4 numa nodes in our system, so each list_lru consumes ~3MB. crash> list super_blocks | wc -l 952 Every mount will register 2 list lrus, one is for inode, another is for dentry. There are 952 super_blocks. So the total memory is 952 * 2 * 3 MB (~5.6GB). But now the number of memory cgroups is less than 500. So I guess more than 12286 memory cgroups have been created on this machine (I do not know why there are so many cgroups, it may be a user's bug or the user really want to do that). Because memcg_nr_cache_ids has not been reduced to a suitable value. It leads to waste a lot of memory. If we want to reduce memcg_nr_cache_ids, we have to *reboot* the server. This is not what we want. In order to reduce memcg_nr_cache_ids, I had posted a patchset [1] to do this. But this did not fundamentally solve the problem. We currently allocate scope for every memcg to be able to tracked on every superblock instantiated in the system, regardless of whether that superblock is even accessible to that memcg. These huge memcg counts come from container hosts where memcgs are confined to just a small subset of the total number of superblocks that instantiated at any given point in time. For these systems with huge container counts, list_lru does not need the capability of tracking every memcg on every superblock. What it comes down to is that the list_lru is only needed for a given memcg if that memcg is instatiating and freeing objects on a given list_lru. As Dave said, "Which makes me think we should be moving more towards 'add the memcg to the list_lru at the first insert' model rather than 'instantiate all at memcg init time just in case'." This patchset aims to optimize the list lru memory consumption from different aspects. Patch 1-6 are code simplification. Patch 7 converts the array from per-memcg per-node to per-memcg Patch 8 introduces kmem_cache_alloc_lru() Patch 9 introduces alloc_inode_sb() Patch 10-66 convert all filesystems to alloc_inode_sb() respectively. Patch 70 let list_lru allocation dynamically. Patch 72 use xarray to optimize per memcg pointer array size. Patch 73-76 is code simplification. I had done a easy test to show the optimization. I create 10k memory cgroups and mount 10k filesystems in the systems. We use free command to show how many memory does the systems comsumes after this operation (There are 2 numa nodes in the system). +-----------------------+------------------------+ | condition | memory consumption | +-----------------------+------------------------+ | without this patchset | 24464 MB | +-----------------------+------------------------+ | after patch 7 | 21957 MB | <--------+ +-----------------------+------------------------+ | | after patch 70 | 6895 MB | | +-----------------------+------------------------+ | | after patch 72 | 4367 MB | | +-----------------------+------------------------+ | | The more the number of nodes, the more obvious the effect---+ BTW, there was a recent discussion [2] on the same issue. [1] https://lore.kernel.org/linux-fsdevel/20210428094949.43579-1-songmuchun@bytedance.com/ [2] https://lore.kernel.org/linux-fsdevel/20210405054848.GA1077931@in.ibm.com/ This series not only optimizes the memory usage of list_lru but also simplifies the code. Changelog in v3: - Fix mixing advanced and normal XArray concepts (Thanks to Matthew). - Split one patch into per-filesystem patches. Changelog in v2: - Update Documentation/filesystems/porting.rst suggested by Dave. - Add a comment above alloc_inode_sb() suggested by Dave. - Rework some patch's commit log. - Add patch 18-21. Thanks Dave. Muchun Song (76): mm: list_lru: fix the return value of list_lru_count_one() mm: memcontrol: remove kmemcg_id reparenting mm: memcontrol: remove the kmem states mm: memcontrol: move memcg_online_kmem() to mem_cgroup_css_online() mm: list_lru: remove holding lru lock mm: list_lru: only add memcg-aware lrus to the global lru list mm: list_lru: optimize memory consumption of arrays mm: introduce kmem_cache_alloc_lru fs: introduce alloc_inode_sb() to allocate filesystems specific inode dax: allocate inode by using alloc_inode_sb() 9p: allocate inode by using alloc_inode_sb() adfs: allocate inode by using alloc_inode_sb() affs: allocate inode by using alloc_inode_sb() afs: allocate inode by using alloc_inode_sb() befs: allocate inode by using alloc_inode_sb() bfs: allocate inode by using alloc_inode_sb() block: allocate inode by using alloc_inode_sb() btrfs: allocate inode by using alloc_inode_sb() ceph: allocate inode by using alloc_inode_sb() cifs: allocate inode by using alloc_inode_sb() coda: allocate inode by using alloc_inode_sb() ecryptfs: allocate inode by using alloc_inode_sb() efs: allocate inode by using alloc_inode_sb() erofs: allocate inode by using alloc_inode_sb() exfat: allocate inode by using alloc_inode_sb() ext2: allocate inode by using alloc_inode_sb() ext4: allocate inode by using alloc_inode_sb() fat: allocate inode by using alloc_inode_sb() freevxfs: allocate inode by using alloc_inode_sb() fuse: allocate inode by using alloc_inode_sb() gfs2: allocate inode by using alloc_inode_sb() hfs: allocate inode by using alloc_inode_sb() hfsplus: allocate inode by using alloc_inode_sb() hostfs: allocate inode by using alloc_inode_sb() hpfs: allocate inode by using alloc_inode_sb() hugetlbfs: allocate inode by using alloc_inode_sb() isofs: allocate inode by using alloc_inode_sb() jffs2: allocate inode by using alloc_inode_sb() jfs: allocate inode by using alloc_inode_sb() minix: allocate inode by using alloc_inode_sb() nfs: allocate inode by using alloc_inode_sb() nilfs2: allocate inode by using alloc_inode_sb() ntfs: allocate inode by using alloc_inode_sb() ocfs2: allocate inode by using alloc_inode_sb() openpromfs: allocate inode by using alloc_inode_sb() orangefs: allocate inode by using alloc_inode_sb() overlayfs: allocate inode by using alloc_inode_sb() proc: allocate inode by using alloc_inode_sb() qnx4: allocate inode by using alloc_inode_sb() qnx6: allocate inode by using alloc_inode_sb() reiserfs: allocate inode by using alloc_inode_sb() romfs: allocate inode by using alloc_inode_sb() squashfs: allocate inode by using alloc_inode_sb() sysv: allocate inode by using alloc_inode_sb() ubifs: allocate inode by using alloc_inode_sb() udf: allocate inode by using alloc_inode_sb() ufs: allocate inode by using alloc_inode_sb() vboxsf: allocate inode by using alloc_inode_sb() xfs: allocate inode by using alloc_inode_sb() zonefs: allocate inode by using alloc_inode_sb() ipc: allocate inode by using alloc_inode_sb() shmem: allocate inode by using alloc_inode_sb() net: allocate inode by using alloc_inode_sb() rpc: allocate inode by using alloc_inode_sb() f2fs: allocate inode by using alloc_inode_sb() nfs42: use a specific kmem_cache to allocate nfs4_xattr_entry mm: dcache: use kmem_cache_alloc_lru() to allocate dentry xarray: use kmem_cache_alloc_lru to allocate xa_node mm: workingset: use xas_set_lru() to pass shadow_nodes mm: list_lru: allocate list_lru_one only when needed mm: list_lru: rename memcg_drain_all_list_lrus to memcg_reparent_list_lrus mm: list_lru: replace linear array with xarray mm: memcontrol: reuse memory cgroup ID for kmem ID mm: memcontrol: fix cannot alloc the maximum memcg ID mm: list_lru: rename list_lru_per_memcg to list_lru_memcg mm: memcontrol: rename memcg_cache_id to memcg_kmem_id Documentation/filesystems/porting.rst | 5 + drivers/dax/super.c | 2 +- fs/9p/vfs_inode.c | 2 +- fs/adfs/super.c | 2 +- fs/affs/super.c | 2 +- fs/afs/super.c | 2 +- fs/befs/linuxvfs.c | 2 +- fs/bfs/inode.c | 2 +- fs/block_dev.c | 2 +- fs/btrfs/inode.c | 2 +- fs/ceph/inode.c | 2 +- fs/cifs/cifsfs.c | 2 +- fs/coda/inode.c | 2 +- fs/dcache.c | 3 +- fs/ecryptfs/super.c | 2 +- fs/efs/super.c | 2 +- fs/erofs/super.c | 2 +- fs/exfat/super.c | 2 +- fs/ext2/super.c | 2 +- fs/ext4/super.c | 2 +- fs/f2fs/super.c | 8 +- fs/fat/inode.c | 2 +- fs/freevxfs/vxfs_super.c | 2 +- fs/fuse/inode.c | 2 +- fs/gfs2/super.c | 2 +- fs/hfs/super.c | 2 +- fs/hfsplus/super.c | 2 +- fs/hostfs/hostfs_kern.c | 2 +- fs/hpfs/super.c | 2 +- fs/hugetlbfs/inode.c | 2 +- fs/inode.c | 2 +- fs/isofs/inode.c | 2 +- fs/jffs2/super.c | 2 +- fs/jfs/super.c | 2 +- fs/minix/inode.c | 2 +- fs/nfs/inode.c | 2 +- fs/nfs/nfs42xattr.c | 95 ++++--- fs/nilfs2/super.c | 2 +- fs/ntfs/inode.c | 2 +- fs/ocfs2/dlmfs/dlmfs.c | 2 +- fs/ocfs2/super.c | 2 +- fs/openpromfs/inode.c | 2 +- fs/orangefs/super.c | 2 +- fs/overlayfs/super.c | 2 +- fs/proc/inode.c | 2 +- fs/qnx4/inode.c | 2 +- fs/qnx6/inode.c | 2 +- fs/reiserfs/super.c | 2 +- fs/romfs/super.c | 2 +- fs/squashfs/super.c | 2 +- fs/sysv/inode.c | 2 +- fs/ubifs/super.c | 2 +- fs/udf/super.c | 2 +- fs/ufs/super.c | 2 +- fs/vboxsf/super.c | 2 +- fs/xfs/xfs_icache.c | 2 +- fs/zonefs/super.c | 2 +- include/linux/fs.h | 11 + include/linux/list_lru.h | 16 +- include/linux/memcontrol.h | 49 ++-- include/linux/slab.h | 3 + include/linux/swap.h | 5 +- include/linux/xarray.h | 9 +- ipc/mqueue.c | 2 +- lib/xarray.c | 10 +- mm/list_lru.c | 472 ++++++++++++++++------------------ mm/memcontrol.c | 190 ++------------ mm/shmem.c | 2 +- mm/slab.c | 39 ++- mm/slab.h | 17 +- mm/slob.c | 6 + mm/slub.c | 42 ++- mm/workingset.c | 2 +- net/socket.c | 2 +- net/sunrpc/rpc_pipe.c | 2 +- 75 files changed, 498 insertions(+), 598 deletions(-) Acked-by: Theodore Ts'o