From patchwork Tue Feb 15 00:23:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Kravetz X-Patchwork-Id: 12746292 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 655E4C433EF for ; Tue, 15 Feb 2022 00:24:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A7056B0078; Mon, 14 Feb 2022 19:24:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 42D446B0081; Mon, 14 Feb 2022 19:24:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA2FB6B0078; Mon, 14 Feb 2022 19:24:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id B9AE96B0078 for ; Mon, 14 Feb 2022 19:24:13 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6F490180ACF6C for ; Tue, 15 Feb 2022 00:24:13 +0000 (UTC) X-FDA: 79143117186.13.BE36338 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf09.hostedemail.com (Postfix) with ESMTP id 9A95814000B for ; Tue, 15 Feb 2022 00:24:12 +0000 (UTC) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21ELiLbg014427; Tue, 15 Feb 2022 00:24:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=uljJgiItuydJ5NO7xyNs9kjjHz9WeL/CxVdDnMHAyp8=; b=eYZvpEp1/aZcrK21N8qg0VTVdEu15+N8jteS6rAiQcn08Yn0AUrqRIzjjloTRJbr+APS HFzc8QQ3JYzwHM/YmdI7hJ4BuS32QKAo4428k9ZnRlXGBFHBrFRTOERw9DOKBNLQICqA UEMWv24kNrWNgUKL0upF7f6jVFeMnPg3iQIXgauf7JBIWOtf4k7bNJL3XeIyjXWwjPnJ sIAhd0MOQlsn1BLfm1qsnhT7H4S1xRtiOrNGiRHe4oxwZqqkrPcUwRNfw1JKbeWz1O/d rlxw0aegQtJ8LmstkWe2UPjX/IT88S5o1AdREolk4zpJRjocUN2/U4jQjOdX7DYEEhv8 lA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3e64sbwy2e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Feb 2022 00:24:02 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21F0GPam044981; Tue, 15 Feb 2022 00:24:01 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2049.outbound.protection.outlook.com [104.47.66.49]) by aserp3030.oracle.com with ESMTP id 3e62xdv8eh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Feb 2022 00:24:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ib3qjVd426Xz8MXEyM+rVarbiXFfIWAMOGk9JndgFPhjmfLTdJAkO491K1Ap3supblctmttuRVnbngG2z28V3tZ9HHXkdQgdtpryQ4aG5+4T/NMJW8Kkdu5ytv2LtLMjTAHYvsOl2wl9tNlcokzMjr3MQkCsGILtedbRxnoIDBcWhUv7aiL2HSFtEtjV4Qx/SrZDWH18KpG64RwKR/O6K5otmsUiI241AxfNn/SnAMCS0uU7Pc+UyQCtAFGg9c7pT4+uf/ok+uvrW4n6940Vu1nMNhnfu1mYxN6xLwnFG1/r0I6+llimcdgiyEGFvfSDmamGFhXzj234wHLD6wyEzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uljJgiItuydJ5NO7xyNs9kjjHz9WeL/CxVdDnMHAyp8=; b=Me1xHvmwpUijwtR2pfJ0xvBw0ZiniGJcKndCrIAAsNs4IZ/ntZ6qBQQJQ8cv0V8aZI+XUEUQn56Y6wDeklIPA28Wn3Dh+XFXIrx56wzRgFn4XZ0q7IEXckU97KAtLnQcTTd6HsQ/pNJo5aCECgWvf+ek86apTBWM/zmoxcRIGiH4oPCN3DhFYVpqmttUqOesGZyllqTz79PDHUoOwTxvaBftLXiz4owkddfj7+N4FOIwGSvC31JWBakMuomCkECSjv7XmuRUgJ+Gu2j+1cGHhcaEno2M3k17/eb8Vwv79dWeMHQ3FGwBGcCU5U8RzK1TT1ptoo4ebY1rscs+btxlWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uljJgiItuydJ5NO7xyNs9kjjHz9WeL/CxVdDnMHAyp8=; b=EQe9sl7t1S+NtshZ2kpLvqm5/IBuFa2soZMiFvktnnJD+YGJgpPGPZjvCvfWZp0Y+bqjH1rFSLR5BCB/JnaWWQcbB3zoKSOOTNcsyM3mUoTrh79DtiIArUKwQGyWvvyNVzuD51pJiZca8KrGamMleKUl9VXgX+T/ZRoAdSxcgTQ= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by CO1PR10MB4516.namprd10.prod.outlook.com (2603:10b6:303:6e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Tue, 15 Feb 2022 00:23:59 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::11f6:860e:575a:e6f1]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::11f6:860e:575a:e6f1%5]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 00:23:59 +0000 From: Mike Kravetz To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Naoya Horiguchi , David Hildenbrand , Axel Rasmussen , Mina Almasry , Michal Hocko , Peter Xu , Andrea Arcangeli , Shuah Khan , Mike Rapoport , Andrew Morton , Mike Kravetz Subject: [PATCH v3 0/3] Add hugetlb MADV_DONTNEED support Date: Mon, 14 Feb 2022 16:23:45 -0800 Message-Id: <20220215002348.128823-1-mike.kravetz@oracle.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: MW4PR03CA0128.namprd03.prod.outlook.com (2603:10b6:303:8c::13) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e5e90f2-f171-41d4-7ea8-08d9f01975e6 X-MS-TrafficTypeDiagnostic: CO1PR10MB4516:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TiHcku1CPCqO/owvRr6xGv+BbbFJw2aY+WFaPjal2KrZhUjJRYpBtxUnbaZGqmngvqn3uir8qfqws9ifT/TAD2/KvtSHALvrRgRkaRrWPoFN2iXcj0FeeTk4xZcmpWEP8HOyU8b/FvCk+gwlDxRMP9KtQJi2u4tAf+UakhBKhBGgrawC6J3zfGrueNlMpM+OWdCkfd+hE1fD0E/fZi9Tb/ELeJnS3Lr29KVaHLmArQ+q5e4Dxyw50EwKqWV36LrlmuW0hZNp5ceUH3AKHutTP0R3k11slueWmQB6E0oEvYnZjh6M11Yt7Ne1QdTZFk5/Jp0iINKA7ijK0m8rpqXykFfiH4HpSN7B8rDrFvuGrI2tKfBFDIeGZb3GlpVOkl7wmROsS4/ZlyAfzKIQdHlfM8UK1H76sbwEfrnBceqIEdU2fTJ7Yvia7hZ+BCuvy0QmLsLgH8BkVlKuuTxNbHpxRM+R2c4K9I8sDqh5q6oVJIlwmlg5v6g4mkQ/bRfE9vHmPfPGWl3MRfsYFhsxZvN1UpZjEmC8qVfjqNgUKRWTp3+mvRTWHxmG6SyceaLq1tKtcaXrHmMJvx16TVdAs65CzCA1R/2pgCe45VXS5cina6x7I9/YhT7PGsZ6YTyKq5q5leFOKRPHoqZKMB1vRKY736oKSSaDyeKR+9mWhkKaV9hIoBdp6Agup2P0GjbRsSvEpAlVMpIim24SlHH44VYcd99wJo/q4rlIB+IUaNPtsFx3/DFCap4zztkjmaLl+sr1DIP/wDEqzc6iyPFClRkzpb64s4UCVFkVxu6XyLB2iOs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66946007)(4326008)(8676002)(8936002)(66476007)(66556008)(6506007)(5660300002)(508600001)(316002)(52116002)(44832011)(7416002)(38350700002)(38100700002)(54906003)(36756003)(6486002)(6666004)(966005)(86362001)(186003)(107886003)(2616005)(6512007)(26005)(83380400001)(2906002)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cHdGLWxcBx4WOZ/JNwtng64w0603PB32Enr5vC6/S9Ui0kxcRTY1oYqHLvZEYhv9LKABbE25mbwtw8P2wQbwhU3D0iFjy0pJcx3AYFwjsunjVJVHcmIT6l0Hoxk7QD4Mupq8X9zWLFSgw/OU7nEMjB/ztvOZ5ljhuFDNrCMU2nMgDCulNmu0aktXzKYIzO3O5O8w+t3qIUojqqChcbwg30G9J5rcEgvBRU4XduT5gdt8obNPK5YmxucI7zGn2q9sFR1RQNzHXQ5tI6B0vt6TnhXQogHOn6YWADBj6O47yCqBRBuW8PhZh61+q/i0Haidar4z70tFjZPHK+cUIz/QvXVwhIvS9mCzITIm4vNYIQ1lSPXdLd//CbUgUbrQYxS3kQbNhJKU62IcP0vZZQHoYlnmIpAne/ejgAgX+VCMFXxaJVpD9XESWORcmZPgaTirenk+lD8KaiDMyFmOqfifxw7RGonim6hTNvOeqpQw9CpJ3QFbltTcPLiG1HKEN5N6a3PORTl78nKlnC6EhyjlxpLXZAIxYMT+y59ogDXC1WJlN8vOxMfdPruqSXQzFTMUTMODVRtf03WfNsxP+bbjRZLX0sHUM7kFUHx2N79eEbyy5oag2QZXYmsPsmf7qsX9J7o1ofuJpq+kv0fbIx9r+ESCn/pu0vNbttrwGDK6Ackwh8JiZZN9N9ocUgmfbmnBzHNCeQDKiGdQQkLvpzRgwJ0AYEZky2xV7BVZkYE6bKqO1JS+KXW9IJWUZD4U7wWtsdXwwGsB6f7r4Ie17bx/VDO94LoRjXM+XOVu6tNFw0eCvYSiiRmeT/OIq8x9WAUWi4FQ67/oqFi1bfc3pd195e8rTywOZlgUSHMz8SjPzWL8s9GfI1i4rlwgfXW0GxokFHnZelFKde0i8qCU2ncVP45pxal6sWUHSJmdIJI5iDLNU39TkTUcLo/Yt1Ik7IVrEgRgvKTL3TxdnrHEn3V347QbJlq7av+hK6y0YErXvE4xMTHp7WmXZaYmSF6lxg53064uQjd+aJYX4ExMAhw+jgIwZw/02hU3d8LpoDboY82/RL7UT+t3rIgylSCwyfoaSfhBB6WJhtCHYo8DfM+TaKCKZ++UdV09Tccb3RYPLWwcV0Ko7u3UL/nACZNu/8yl3TfKfSRtGxoTCSn0EOjQ7BtA9pzvtkpujtnCdxE+gNkKhitoSqpZPDdfM0tWJCoCjuD92eGwEpQmO3PpLZRHv+33bUYzJ9P7Fq+2aLDQhu0qd+umWrhtUU/0o+4Yl9Tc3v7mEOm3AzgqnCV625f5OOgt0Go3CqixOCA19hTUpCgCA71TPbZafSKPNUEagdwLZK1R9Uc6TeWGnT6tvhAYdjHfyjOW4vbnnUgl/2KFomVCXfbwNr3fhXk+9CXRoohaDxQLgmHjeIF5o1FgGqPv34rnhvDILdzIXcLQ3HGw/ooxQiBwLR1zdURNpbMEtYLYup2KYFmWKiEoD4GDbetOgLS9ww+/rXJGk7BIMB3nx2sndUXSqNbVFFaVl+ftCyaGBGKitJWDfd6Wagv69nwOT2OlG/Z0jJNp9/VIBEOc5BkTjYD/nwu40TZB0NOSMCNoXv84SZusAkkVHvTUl07WCScpdCsIS/OgzcHENCpCi98= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e5e90f2-f171-41d4-7ea8-08d9f01975e6 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 00:23:59.5180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GyX21GBymu7D6Aie52BU9Ifogy9Dd/n8O3xvYgBhZrRHC1vf/PddDBsWKO7rE3JD3qfvvoxBJEKPweJvcD4s4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4516 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10258 signatures=673431 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202150000 X-Proofpoint-GUID: _F3LutxtGvi_x89oO73Pfb27kav0axfq X-Proofpoint-ORIG-GUID: _F3LutxtGvi_x89oO73Pfb27kav0axfq X-Rspamd-Queue-Id: 9A95814000B X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=eYZvpEp1; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=EQe9sl7t; spf=none (imf09.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Stat-Signature: ffu9zgmuricewty6rrob5hkcnecd89ep X-Rspamd-Server: rspam03 X-HE-Tag: 1644884652-59243 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Userfaultfd selftests for hugetlb does not perform UFFD_EVENT_REMAP testing. However, mremap support was recently added in commit 550a7d60bd5e ("mm, hugepages: add mremap() support for hugepage backed vma"). While attempting to enable mremap support in the test, it was discovered that the mremap test indirectly depends on MADV_DONTNEED. madvise does not allow MADV_DONTNEED for hugetlb mappings. However, that is primarily due to the check in can_madv_lru_vma(). By simply removing the check and adding huge page alignment, MADV_DONTNEED can be made to work for hugetlb mappings. Do note that there is no compelling use case for adding this support. This was discussed in the RFC [1]. However, adding support makes sense as it is fairly trivial and brings hugetlb functionality more in line with 'normal' memory. After enabling support, add selftest for MADV_DONTNEED as well as MADV_REMOVE. Then update userfaultfd selftest. If new functionality is accepted, then madvise man page will be updated to indicate hugetlb is supported. It will also be updated to clarify what happens to the passed length argument. v2 -> v3 - Force start huge page alignment, extend length to huge page size. David - Added more selftests to verify alignment. - Remove double check for hugetlb vma. Peter v1 -> v2 - Use is_vm_hugetlb_page() instead of open coding vma hugetlb check. - Add new test to .gitignore and use meaningful symbolic names (#define) for constants used in test. Shuah - Updated help text in userfaultfd test and modified run_vmtests to not pass in a file for userfaultfd hugetlb test. Axel - Added Reviewed-by for selftest patches. RFC -> v1 - Fixed alignment issues when calling zap_page_range. Naoya - Added checks for invalid arguments and misalignment to selftest. [1] https://lore.kernel.org/linux-mm/20220113180308.15610-1-mike.kravetz@oracle.com/ Mike Kravetz (3): mm: enable MADV_DONTNEED for hugetlb mappings selftests/vm: add hugetlb madvise MADV_DONTNEED MADV_REMOVE test userfaultfd/selftests: enable hugetlb remap and remove event testing mm/madvise.c | 33 +- tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 1 + tools/testing/selftests/vm/hugetlb-madvise.c | 410 +++++++++++++++++++ tools/testing/selftests/vm/run_vmtests.sh | 15 +- tools/testing/selftests/vm/userfaultfd.c | 69 ++-- 6 files changed, 490 insertions(+), 39 deletions(-) create mode 100644 tools/testing/selftests/vm/hugetlb-madvise.c