mbox series

[0/9] A few cleanup patches for z3fold

Message ID 20220219092533.12596-1-linmiaohe@huawei.com (mailing list archive)
Headers show
Series A few cleanup patches for z3fold | expand

Message

Miaohe Lin Feb. 19, 2022, 9:25 a.m. UTC
Hi,
This series contains a few patches to simplify the code, remove unneeded
return value, fix obsolete comment and so on. More details can be found
in the respective changelogs. Thanks!

Miaohe Lin (9):
  mm/z3fold: declare z3fold_mount with __init
  mm/z3fold: remove obsolete comment in z3fold_alloc
  mm/z3fold: minor clean up for z3fold_free
  mm/z3fold: remove unneeded page_mapcount_reset and ClearPagePrivate
  mm/z3fold: remove confusing local variable l reassignment
  mm/z3fold: move decrement of pool->pages_nr into
    __release_z3fold_page()
  mm/z3fold: remove redundant list_del_init of zhdr->buddy in
    z3fold_free
  mm/z3fold: remove unneeded PAGE_HEADLESS check in free_handle()
  mm/z3fold: remove unneeded return value of z3fold_compact_page()

 mm/z3fold.c | 78 +++++++++++++++--------------------------------------
 1 file changed, 22 insertions(+), 56 deletions(-)

Comments

Miaohe Lin March 1, 2022, 1:03 p.m. UTC | #1
On 2022/2/19 17:25, Miaohe Lin wrote:
> Hi,
> This series contains a few patches to simplify the code, remove unneeded
> return value, fix obsolete comment and so on. More details can be found
> in the respective changelogs. Thanks!
> 

Friendly ping in case this is forgotten. :)

> Miaohe Lin (9):
>   mm/z3fold: declare z3fold_mount with __init
>   mm/z3fold: remove obsolete comment in z3fold_alloc
>   mm/z3fold: minor clean up for z3fold_free
>   mm/z3fold: remove unneeded page_mapcount_reset and ClearPagePrivate
>   mm/z3fold: remove confusing local variable l reassignment
>   mm/z3fold: move decrement of pool->pages_nr into
>     __release_z3fold_page()
>   mm/z3fold: remove redundant list_del_init of zhdr->buddy in
>     z3fold_free
>   mm/z3fold: remove unneeded PAGE_HEADLESS check in free_handle()
>   mm/z3fold: remove unneeded return value of z3fold_compact_page()
> 
>  mm/z3fold.c | 78 +++++++++++++++--------------------------------------
>  1 file changed, 22 insertions(+), 56 deletions(-)
>
Andrew Morton March 1, 2022, 5:36 p.m. UTC | #2
On Tue, 1 Mar 2022 21:03:37 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:

> On 2022/2/19 17:25, Miaohe Lin wrote:
> > Hi,
> > This series contains a few patches to simplify the code, remove unneeded
> > return value, fix obsolete comment and so on. More details can be found
> > in the respective changelogs. Thanks!
> > 
> 
> Friendly ping in case this is forgotten. :)

I was expecting updates resulting from the [6/9] discussion?
Miaohe Lin March 2, 2022, 1:54 a.m. UTC | #3
On 2022/3/2 1:36, Andrew Morton wrote:
> On Tue, 1 Mar 2022 21:03:37 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> 
>> On 2022/2/19 17:25, Miaohe Lin wrote:
>>> Hi,
>>> This series contains a few patches to simplify the code, remove unneeded
>>> return value, fix obsolete comment and so on. More details can be found
>>> in the respective changelogs. Thanks!
>>>
>>
>> Friendly ping in case this is forgotten. :)
> 
> I was expecting updates resulting from the [6/9] discussion?

I think that could be another separate patch to reduce the atomic operation overhead.
And I have some z3fold bugfix patches pending to sent. They might can be sent together
if such separate patch is prepared at that point.

Many thanks. :)

> .
>