From patchwork Mon Feb 28 23:57:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Shi X-Patchwork-Id: 12763899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A560C433F5 for ; Mon, 28 Feb 2022 23:58:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F38E38D0002; Mon, 28 Feb 2022 18:57:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE84D8D0001; Mon, 28 Feb 2022 18:57:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D891C8D0002; Mon, 28 Feb 2022 18:57:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id C74298D0001 for ; Mon, 28 Feb 2022 18:57:59 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 911702387D for ; Mon, 28 Feb 2022 23:57:59 +0000 (UTC) X-FDA: 79193854278.11.FF44D8A Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf13.hostedemail.com (Postfix) with ESMTP id 2B13220005 for ; Mon, 28 Feb 2022 23:57:59 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id bx5so12574997pjb.3 for ; Mon, 28 Feb 2022 15:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=h0sCSJGBWDN5mRT7aBgm8yBHFMNHKb8Jl03bv/QDMQY=; b=GujjR472ePh+4ybziZIBTl5oJqLyn60Vy/wWd2iruPDB8ietcm6zd0dPOqrAvbbVzg lu1rmIwMX1tX718vXxLYWh6HqAjNXf6Nt481UeNh7PTTVZnqLMfiLohrXOzMrndT/tF9 xF7yFEDCllEofZ/7wPRZvgRtjdnb6wT7kJB+cBCSAL+TJqyT67dxGGFriY4zwEms1cL6 WN3+St0LOh9HKPTqu+svRT/jobZW1/t3wxrwPM0+GURK/tdO/Ks0HXIFu5S6voTDBrJ9 kNKyUyoKks4IOeFQIC0M34I8we8kcEOXlJjYbXD7Pcj7TYN5u3X7MekovnN3yraE6PkT MPuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=h0sCSJGBWDN5mRT7aBgm8yBHFMNHKb8Jl03bv/QDMQY=; b=Hq6Er7jNcm2OISDOK1c+/F51vmSi/bveAgqHuEER8/DephBL2D7+E5FnKKrVwAPfL5 D5Cgqr9hys+hH7Njia4a5RVwNmqXtP7ITphGeOXLBkqTe7Uvk7TFIlFewaJj+Q37pK9w 2Gtp9zgxfc4+bUrXXeFnO4W6+zaKfunvbeO1l1OABuYOe1Fka+h3uRLHadDhivKHhoek vmr4AWSOCFI522YgtV1ceWdG1XHyBUEmMeUqDspuit8O2qXB6Z/2P5wV6tRMHHk+MRoy bscZ5RR9E5rr9aSOI06lrcpAetAKBzrEQwDnun0TFwtwbMoa7K2o6xskqvPk/bZtIapM +BKA== X-Gm-Message-State: AOAM531kOF2j9MeCCVDfLtQ2Uk+V+rKYfezNn2DcAtTuC+euZcyuGF+M vO6l9m7/08I0lbLJ+eI6f/M= X-Google-Smtp-Source: ABdhPJzD9SKtkQ8vuX0qPac1DGv6DOmMazBubWiEtu4ddPmWBpE6VIc64Q3TkV9smEiRbog2V++tHA== X-Received: by 2002:a17:903:2c7:b0:14f:522c:d33c with SMTP id s7-20020a17090302c700b0014f522cd33cmr23162298plk.143.1646092678136; Mon, 28 Feb 2022 15:57:58 -0800 (PST) Received: from localhost.localdomain (c-67-174-241-145.hsd1.ca.comcast.net. [67.174.241.145]) by smtp.gmail.com with ESMTPSA id on15-20020a17090b1d0f00b001b9d1b5f901sm396963pjb.47.2022.02.28.15.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 15:57:57 -0800 (PST) From: Yang Shi To: vbabka@suse.cz, kirill.shutemov@linux.intel.com, songliubraving@fb.com, linmiaohe@huawei.com, riel@surriel.com, willy@infradead.org, ziy@nvidia.com, akpm@linux-foundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, darrick.wong@oracle.com Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/8] Make khugepaged collapse readonly FS THP more consistent Date: Mon, 28 Feb 2022 15:57:33 -0800 Message-Id: <20220228235741.102941-1-shy828301@gmail.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2B13220005 X-Stat-Signature: exqepucbawwn7hw59sg76wm5mok7nd3g Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=GujjR472; spf=pass (imf13.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-HE-Tag: 1646092679-629033 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The readonly FS THP relies on khugepaged to collapse THP for suitable vmas. But it is kind of "random luck" for khugepaged to see the readonly FS vmas (see report: https://lore.kernel.org/linux-mm/00f195d4-d039-3cf2-d3a1-a2c88de397a0@suse.cz/) since currently the vmas are registered to khugepaged when: - Anon huge pmd page fault - VMA merge - MADV_HUGEPAGE - Shmem mmap If the above conditions are not met, even though khugepaged is enabled it won't see readonly FS vmas at all. MADV_HUGEPAGE could be specified explicitly to tell khugepaged to collapse this area, but when khugepaged mode is "always" it should scan suitable vmas as long as VM_NOHUGEPAGE is not set. So make sure readonly FS vmas are registered to khugepaged to make the behavior more consistent. Registering the vmas in mmap path seems more preferred from performance point of view since page fault path is definitely hot path. The patch 1 ~ 7 are minor bug fixes, clean up and preparation patches. The patch 8 converts ext4 and xfs. We may need convert more filesystems, but I'd like to hear some comments before doing that. Tested with khugepaged test in selftests and the testcase provided by Vlastimil Babka in https://lore.kernel.org/lkml/df3b5d1c-a36b-2c73-3e27-99e74983de3a@suse.cz/ by commenting out MADV_HUGEPAGE call. b/fs/ext4/file.c | 4 +++ b/fs/xfs/xfs_file.c | 4 +++ b/include/linux/huge_mm.h | 9 +++++++ b/include/linux/khugepaged.h | 69 +++++++++++++++++++++---------------------------------------- b/include/linux/sched/coredump.h | 3 +- b/kernel/fork.c | 4 --- b/mm/huge_memory.c | 15 +++---------- b/mm/khugepaged.c | 71 ++++++++++++++++++++++++++++++++++++++++++++------------------- b/mm/shmem.c | 14 +++--------- 9 files changed, 102 insertions(+), 91 deletions(-)