From patchwork Mon May 30 07:49:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 12864350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C7AC433EF for ; Mon, 30 May 2022 07:50:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F87D8D0003; Mon, 30 May 2022 03:50:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 180718D0001; Mon, 30 May 2022 03:50:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0218F8D0003; Mon, 30 May 2022 03:50:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E2B9E8D0001 for ; Mon, 30 May 2022 03:50:17 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id B40CC60ED4 for ; Mon, 30 May 2022 07:50:17 +0000 (UTC) X-FDA: 79521636474.15.4289266 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf15.hostedemail.com (Postfix) with ESMTP id CBE9FA0026 for ; Mon, 30 May 2022 07:49:54 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id t2so2014231pld.4 for ; Mon, 30 May 2022 00:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S3Tbyt5KcpmGR11iN8hvh+Wl6ORt3Cqz1+TY0tIhK3E=; b=uSQgQQfj5GqDrXU1zWs9WINjEKu656aXs9Fnzv6IGozce0pAhlKELt28GKZJz0Iytb WVaK3qt0SZvF9omLClcJC1XjtSHHkN4kFVqbLTBOCUpOqhbAXv1Baga55URrifp4GzMs OyoiVxPt8ri6Q3lu9a/+7IKmnWfVTBhbI9jrseo/aEfwl0CERh78WFAt3XAQiOk6ARHM B0syr/Pp/7WeA9P8s0xh7cw6Unvrn5G+yHzfx4FsNCYYvqHP/BFTGTz43+IFbLLStNti sgCNa0zBlIowrUwDfLfp84x+oJrY5jwytHHe60wTRfdq4aCx3r3CSUvVKplUluVJcZbL gEKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S3Tbyt5KcpmGR11iN8hvh+Wl6ORt3Cqz1+TY0tIhK3E=; b=CqZSAgxBe1gzZr53C/0kmmF9yePSJifSJPc8OkI8NKbGyOoyCHwPnt5kY1moU+FfDc 8AWZaAqFwhDuw8oiClPvV1U6jN3ujHktnAyso8ESCq1lhVFAMDJY4sK113KIaOQFyeFe H25VIVhwCn2uY1TPXwAqXA3PZiMevbtj5di+m2gfnHoyKuWgNssKx/nJ1Rh6wulJWppS Tp1cnYUUPv/7HnaLz963guXpdIPf9GBfzLw54g/HkrEx12vYR+S1lC7qoynKWMDL/s5x 8v0qJT7yOS4x8ZoyGl8V2Tg22n219KXVrVLPY/Y5nRGzZCet/ROaLp4xbLvNL5/XJmb2 yRcg== X-Gm-Message-State: AOAM531zW9ZhnKokhY6J5tPVqcp0noA15Wjr0FEXxrsb9gT4wd4EKv/6 I+Msp/WBv4xciaykC4yHECQ0pw== X-Google-Smtp-Source: ABdhPJxiOFKQmnWR0xGMOJtuFa01j/rINpkSTW4MnEPt0QGI1zIerAdsROSLkXaF8x1MHGpGcQM1ag== X-Received: by 2002:a17:90b:4d8b:b0:1dc:a9c0:3d53 with SMTP id oj11-20020a17090b4d8b00b001dca9c03d53mr21414474pjb.29.1653897015552; Mon, 30 May 2022 00:50:15 -0700 (PDT) Received: from FVFYT0MHHV2J.bytedance.net ([2408:8207:18da:2310:2071:e13a:8aa:cacf]) by smtp.gmail.com with ESMTPSA id a23-20020a170902b59700b001616c3bd5c2sm8421381pls.162.2022.05.30.00.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 00:50:14 -0700 (PDT) From: Muchun Song To: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com, Muchun Song Subject: [PATCH v5 00/11] Use obj_cgroup APIs to charge the LRU pages Date: Mon, 30 May 2022 15:49:08 +0800 Message-Id: <20220530074919.46352-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.32.1 (Apple Git-133) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: CBE9FA0026 X-Stat-Signature: nqufeoubudo431d5e1cbg1gpeky1p1x9 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=uSQgQQfj; spf=pass (imf15.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam09 X-HE-Tag: 1653896994-457545 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This version is rebased on v5.18. Since the following patchsets applied. All the kernel memory are charged with the new APIs of obj_cgroup. [v17,00/19] The new cgroup slab memory controller [1] [v5,0/7] Use obj_cgroup APIs to charge kmem pages [2] But user memory allocations (LRU pages) pinning memcgs for a long time - it exists at a larger scale and is causing recurring problems in the real world: page cache doesn't get reclaimed for a long time, or is used by the second, third, fourth, ... instance of the same job that was restarted into a new cgroup every time. Unreclaimable dying cgroups pile up, waste memory, and make page reclaim very inefficient. We can convert LRU pages and most other raw memcg pins to the objcg direction to fix this problem, and then the LRU pages will not pin the memcgs. This patchset aims to make the LRU pages to drop the reference to memory cgroup by using the APIs of obj_cgroup. Finally, we can see that the number of the dying cgroups will not increase if we run the following test script. ```bash #!/bin/bash dd if=/dev/zero of=temp bs=4096 count=1 cat /proc/cgroups | grep memory for i in {0..2000} do mkdir /sys/fs/cgroup/memory/test$i echo $$ > /sys/fs/cgroup/memory/test$i/cgroup.procs cat temp >> log echo $$ > /sys/fs/cgroup/memory/cgroup.procs rmdir /sys/fs/cgroup/memory/test$i done cat /proc/cgroups | grep memory rm -f temp log ``` [1] https://lore.kernel.org/linux-mm/20200623015846.1141975-1-guro@fb.com/ [2] https://lore.kernel.org/linux-mm/20210319163821.20704-1-songmuchun@bytedance.com/ v4: https://lore.kernel.org/all/20220524060551.80037-1-songmuchun@bytedance.com/ v3: https://lore.kernel.org/all/20220216115132.52602-1-songmuchun@bytedance.com/ v2: https://lore.kernel.org/all/20210916134748.67712-1-songmuchun@bytedance.com/ v1: https://lore.kernel.org/all/20210814052519.86679-1-songmuchun@bytedance.com/ RFC v4: https://lore.kernel.org/all/20210527093336.14895-1-songmuchun@bytedance.com/ RFC v3: https://lore.kernel.org/all/20210421070059.69361-1-songmuchun@bytedance.com/ RFC v2: https://lore.kernel.org/all/20210409122959.82264-1-songmuchun@bytedance.com/ RFC v1: https://lore.kernel.org/all/20210330101531.82752-1-songmuchun@bytedance.com/ v5: - Lots of improvements from Johannes, Roman and Waiman. - Fix lockdep warning reported by kernel test robot. - Add two new patches to do code cleanup. - Collect Acked-by and Reviewed-by from Johannes and Roman. - I didn't replace local_irq_disable/enable() to local_lock/unlock_irq() since local_lock/unlock_irq() takes an parameter, it needs more thinking to transform it to local_lock. It could be an improvement in the future. v4: - Resend and rebased on v5.18. v3: - Removed the Acked-by tags from Roman since this version is based on the folio relevant. v2: - Rename obj_cgroup_release_kmem() to obj_cgroup_release_bytes() and the dependencies of CONFIG_MEMCG_KMEM (suggested by Roman, Thanks). - Rebase to linux 5.15-rc1. - Add a new pacth to cleanup mem_cgroup_kmem_disabled(). v1: - Drop RFC tag. - Rebase to linux next-20210811. RFC v4: - Collect Acked-by from Roman. - Rebase to linux next-20210525. - Rename obj_cgroup_release_uncharge() to obj_cgroup_release_kmem(). - Change the patch 1 title to "prepare objcg API for non-kmem usage". - Convert reparent_ops_head to an array in patch 8. Thanks for Roman's review and suggestions. RFC v3: - Drop the code cleanup and simplification patches. Gather those patches into a separate series[1]. - Rework patch #1 suggested by Johannes. RFC v2: - Collect Acked-by tags by Johannes. Thanks. - Rework lruvec_holds_page_lru_lock() suggested by Johannes. Thanks. - Fix move_pages_to_lru(). Muchun Song (11): mm: memcontrol: remove dead code and comments mm: rename unlock_page_lruvec{_irq, _irqrestore} to lruvec_unlock{_irq, _irqrestore} mm: memcontrol: prepare objcg API for non-kmem usage mm: memcontrol: make lruvec lock safe when LRU pages are reparented mm: vmscan: rework move_pages_to_lru() mm: thp: make split queue lock safe when LRU pages are reparented mm: memcontrol: make all the callers of {folio,page}_memcg() safe mm: memcontrol: introduce memcg_reparent_ops mm: memcontrol: use obj_cgroup APIs to charge the LRU pages mm: lru: add VM_BUG_ON_FOLIO to lru maintenance function mm: lru: use lruvec lock to serialize memcg changes fs/buffer.c | 4 +- fs/fs-writeback.c | 23 +- include/linux/memcontrol.h | 213 +++++++++------ include/linux/mm_inline.h | 6 + include/trace/events/writeback.h | 5 + mm/compaction.c | 39 ++- mm/huge_memory.c | 153 +++++++++-- mm/memcontrol.c | 560 +++++++++++++++++++++++++++------------ mm/migrate.c | 4 + mm/mlock.c | 2 +- mm/page_io.c | 5 +- mm/swap.c | 62 ++--- mm/vmscan.c | 67 +++-- 13 files changed, 767 insertions(+), 376 deletions(-) base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f