From patchwork Tue Jul 12 13:39:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyeonggon Yoo <42.hyeyoo@gmail.com> X-Patchwork-Id: 12914999 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E3B9C43334 for ; Tue, 12 Jul 2022 13:39:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACF2E940075; Tue, 12 Jul 2022 09:39:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7FED940063; Tue, 12 Jul 2022 09:39:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 946B7940075; Tue, 12 Jul 2022 09:39:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8628C940063 for ; Tue, 12 Jul 2022 09:39:54 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 595B820F03 for ; Tue, 12 Jul 2022 13:39:54 +0000 (UTC) X-FDA: 79678555908.05.A7E86CB Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf31.hostedemail.com (Postfix) with ESMTP id D530220067 for ; Tue, 12 Jul 2022 13:39:53 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id p9so7632428pjd.3 for ; Tue, 12 Jul 2022 06:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GSCdzrG/hG5dXXM78OyhYj2dNDOwSiS9CiVXPuQBexc=; b=LSTVZAHfNUMVWow5R6+aLV7Og05WP08vNp+X1p1NTHhlYv2oyWpjSx/nvgBcRI0zvw YbSVAnS/ogdSUOeZG56fFF4jvbabU7vhupE1oM3cxJQ17pQhUSwtAeRBPM/SXb4ND1t2 2Sd99chJJOUXg4ZAiYhl56bLrhWtmxSy++fCRax+3fHBTdv72DE7NnYSQviJPpcaTUcz IZe/E0NIfYAfl0jzeg17+8hgIQ92bjiXqpS/0YQR4facTTZPIO4Ftzuk4M4JCJen6PMe CTygIUm9W/0OlEIoEdIEgVPtxQcZLd5oJEm/gqsYX+0GWj7AkWBMo1SNmpc1z91o4qJ9 RSgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GSCdzrG/hG5dXXM78OyhYj2dNDOwSiS9CiVXPuQBexc=; b=S6ZXcXzo+vAHXU5VjNNH/1hvTa67q7Q1uxw41Y+Ci0YDtfwjT7Vqw8jfIiN2ZwcYHV 6Nhi5SUNnsggO5vrKRMDdKwGcWzueoQogfPmEJxWuVykAThYxQk+q7NOTDz6VnY+59zJ yLGgQ4cLMmKD0aG247BfZSx87emDHPPsGhD4BOYvrISeBxtNRn22abahlFeOjuWsXpbV ND9tzf9Gb3EHkBzxgu5oG0PNQeXepw5KZBOoov77nig4dMAyaCvRtBc4V3Zua0LuWcEM a6cLex9Yj07T/Ps7pEeN5J7VCGEqMlRW/7u93HHQiuANGrpw4Q2l/EkBsGVRkdEhQcN4 8y+g== X-Gm-Message-State: AJIora83AFFdG8adLzzK44DFV02QaZrFwepGSe9HG7CZTc/JjH7V96/S i6Qt688soA3Bp6QbccgAgFI= X-Google-Smtp-Source: AGRyM1tR+Dra7PTDlJiULAt8/wFsye/iHU0JtuXduu4TSjMjAram+B9ATptMXy1oMKjLZ4Gsd8CfhQ== X-Received: by 2002:a17:902:7582:b0:16a:307a:5965 with SMTP id j2-20020a170902758200b0016a307a5965mr23812640pll.159.1657633192640; Tue, 12 Jul 2022 06:39:52 -0700 (PDT) Received: from ip-172-31-24-42.ap-northeast-1.compute.internal (ec2-35-75-15-180.ap-northeast-1.compute.amazonaws.com. [35.75.15.180]) by smtp.gmail.com with ESMTPSA id r6-20020aa79886000000b0052ae3bcb807sm1947178pfl.188.2022.07.12.06.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 06:39:51 -0700 (PDT) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joe Perches , Vasily Averin , Matthew WilCox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v3 00/15] common kmalloc v3 Date: Tue, 12 Jul 2022 13:39:30 +0000 Message-Id: <20220712133946.307181-1-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657633193; a=rsa-sha256; cv=none; b=Id0aoU//Vx/0MitvGxIME7qLJ4IBEAaQ6bSINJRY3nUaS2VWTzDmuWoNyEdt/ohriZ+AAM orHL1oWZ4WYqJ1k9xhOlyRixMWkMfF610hzPNNQEz7HBfDDIZWyt04rjvcY6vvA+YaI1Mf 4RF4WA0Z8g2b52mGfynMUS7aPbdhros= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LSTVZAHf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657633193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=GSCdzrG/hG5dXXM78OyhYj2dNDOwSiS9CiVXPuQBexc=; b=n+AFac4FWpDt7lQsALQNxBXwL2IJQj/bkfhGQeXMgK1uCf92t1/g+kwA+W+rx93ExKlk01 dsa7cOuCSQqhN3bosnhIXTQ/+DagiqS7tS9jKSN85mi9fZgwvHc3QHe1CJhMe34tv+TP1D G3vuI8tl/Kuian+8wusBTKIPG56JBog= X-Stat-Signature: no87oyo3yuywsupayfghzz8m81szxamc X-Rspamd-Queue-Id: D530220067 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LSTVZAHf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1657633193-483584 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is v3 of common kmalloc series. This series generalize most of kmalloc functions and move its implementation into mm/slab_common.c. I believe this series give better maintainability of code for SLAB and SLUB. Please consider applying. This series is based on slab/for-next and also available at https://github.com/hygoni/linux/tree/slab-common-v3r0 Any feedbacks/reviews will be appreciated. v2->v3: - Now this series does not unify tracepoints between kmalloc and kmem_cache_alloc(). And does not print its name. Instead, it implements common alloc/free function without tracepoint. - Dropped UMA version of tracepoints and removed _node suffix for NUMA version. (Vlastimil Babka) - Split kmem_alloc event class and defined kmem_cache_alloc and kmalloc events using TRACE_EVENT() macro. And avoided dereferencing fields of struct kmem_cache when not using tracepoints. (Vlastimil Babka) - Dropped patches cleaning up kmalloc() to avoid increasing size of kernel image. (Joe Perches) - Tried to avoid affecting inlined kmalloc calls and kmem_cache_alloc varients. - Fixed uninitialized variable bug in SLAB with NUMA. - Fixed an issue printing useless caller in kmalloc_node_track_caller() when it calls kmalloc_large_node(). - call WARN_ON() when __ksize() returns zero. (Christoph Lameter) - Adjusted feedbacks from Vlastimil Babka. (Coding Style, patch organization, etc.) Thank you all for feedback :) ===== sequence of patches ===== patch 1-2 make slab_alloc_node() available for non-NUMA configurations for generalization. patch 3-5 remove duplicate code in common kmalloc functions. patch 6-10 move implementation of kmalloc_large{,_node}() to slab_common.c and make SLAB pass requests larger than order-1 page to page allocator. (like SLUB) patch 11-12 generalize most of kmalloc functions. patch 13 drops kmem_alloc event class and rename kmem_alloc_node to kmem_alloc. and remove _node suffix for its events. patch 14 drop kmem_alloc event class and then define kmalloc and kmem_cache_alloc events using TRACE_EVENT() macro. It also avoids dereferencing fields when not using tracepoints. patch 15-16 are small improvements of __ksize(). They are not part of generalization but depends on this series. mm/slab: move NUMA-related code to __do_cache_alloc() mm/slab: cleanup slab_alloc() and slab_alloc_node() mm/slab_common: remove CONFIG_NUMA ifdefs for common kmalloc functions mm/slab_common: cleanup kmalloc_track_caller() mm/sl[au]b: factor out __do_kmalloc_node() mm/sl[auo]b: fold kmalloc_order_trace() into kmalloc_large() mm/slub: move kmalloc_large_node() to slab_common.c mm/slab_common: kmalloc_node: pass large requests to page allocator mm/slab_common: cleanup kmalloc_large() mm/slab: kmalloc: pass requests larger than order-1 page to page allocator mm/sl[au]b: introduce common alloc/free functions without tracepoint mm/sl[au]b: generalize kmalloc subsystem mm/slab_common: unify NUMA and UMA version of tracepoints mm/slab_common: drop kmem_alloc & avoid dereferencing fields when not using mm/sl[auo]b: move definition of __ksize() to mm/slab.h mm/sl[au]b: check if large object is valid in __ksize() include/linux/slab.h | 117 +++++---------- include/trace/events/kmem.h | 68 +++------ mm/slab.c | 290 ++++++++++-------------------------- mm/slab.h | 11 ++ mm/slab_common.c | 176 +++++++++++++++++++--- mm/slob.c | 28 +--- mm/slub.c | 218 +++------------------------ 7 files changed, 320 insertions(+), 588 deletions(-)