From patchwork Mon Nov 28 19:16:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 13057889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EEA8C4332F for ; Mon, 28 Nov 2022 19:16:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72F776B0071; Mon, 28 Nov 2022 14:16:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DF9E6B0075; Mon, 28 Nov 2022 14:16:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A84F6B0078; Mon, 28 Nov 2022 14:16:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 46BBA6B0071 for ; Mon, 28 Nov 2022 14:16:19 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1F37D160DD6 for ; Mon, 28 Nov 2022 19:16:19 +0000 (UTC) X-FDA: 80183806878.18.B9B0E58 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf28.hostedemail.com (Postfix) with ESMTP id 9E378C0008 for ; Mon, 28 Nov 2022 19:16:18 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id j12so11130049plj.5 for ; Mon, 28 Nov 2022 11:16:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7zVBwMXapBovi67IHJnxuLTYmJEmE4K0rauIUXooT+E=; b=Rvo58LN0xH2uPgO2irRcjReHIQUyNCuQcTXEhD2CLtjFDVZ+Id4mJQaHnhNowfb32z wHHKYx25qubJrnAw7MjU2xsLtNTN6trIJhv5Yf8+S9D48/Fdd1e0OdCMMCKWkaoKoRxM VINGjoxkEWXpRwsZhuob6hynARbiYcGljRxFM0V0lBm1j0JRK7jWXTKbiEVPzleIxhZy sKBfH4CPglQppn4K/awUOdjO0t3U6Oz3cJCx4vnYLHNzBxvAHj7mEGSxYn7W6lu2fbME LLUNozF7nG74dotX0YW2LnoY9sGyJ+rCjGHmFJ5LQTZV+s3P2ti+eYkXWBW/xp8KTnef QPfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7zVBwMXapBovi67IHJnxuLTYmJEmE4K0rauIUXooT+E=; b=cNKpCGQJLarZaD+rq7cbxPc3XCmWFxkmiwPga5xter2BmWjq0pjcFZnJm5dgUHxnpN 9nqMgnM3L/tUvyfbsVqmJxveJG8W0xUsATVL4v7pKyHKaPakRte+eXRdIH8ugW9svHGi ArR94VcHbVG1L+//0ZKnPPSxZNGLjGa3peRDnD0KmJ3iv5RX0akL86OVc+2j+efLEyOe PF12WUi+2fgCxcjmB9BrBjwO/sUkkX0sqQbfbyw0+psAFlAG8QuCj2nG+M1Ypvw8jbAD PTi09F81jduNecwiMkOy/V2StnV7HyvrlifjdUUucxkcIOziZf3TbVPNV5QrvxRHwlpX TXcA== X-Gm-Message-State: ANoB5pkkvChqUZpRWS5ADjOIF/d+7wbMvgM/RPp0V8+Fz8KMIQM091Kj oa7KPCdeozPCIYSILhhkYnE= X-Google-Smtp-Source: AA0mqf43Y0DPx80NwgbjVzmT/qMwCEbLySlmxjEzru6wlIHYC06U6j4UXOX48d8v/xJgcYFsLQGwSQ== X-Received: by 2002:a17:90a:8592:b0:219:2e8c:a775 with SMTP id m18-20020a17090a859200b002192e8ca775mr8501180pjn.102.1669662977242; Mon, 28 Nov 2022 11:16:17 -0800 (PST) Received: from localhost (fwdproxy-prn-010.fbsv.net. [2a03:2880:ff:a::face:b00c]) by smtp.gmail.com with ESMTPSA id gi12-20020a17090b110c00b00218fb3bec27sm7926149pjb.56.2022.11.28.11.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 11:16:16 -0800 (PST) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: [PATCH v7 0/6] Implement writeback for zsmalloc Date: Mon, 28 Nov 2022 11:16:09 -0800 Message-Id: <20221128191616.1261026-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669662978; a=rsa-sha256; cv=none; b=aIVtQFIpMm9VnjSLFfuLkNj6mMbMypG3k+00tH8mC1p2a7B53CH/N45MG5a0R7B/VoL+Ao l4pClAJ6mUORd0aX7Kru7w/3cxlo1I7IOlRRXEd5xZXDl8BnvynSm7+AwPX2n4+/+Gi8wP 7F18cA/mtYqicdF6Flj+wKZj2uAEDds= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Rvo58LN0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669662978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=7zVBwMXapBovi67IHJnxuLTYmJEmE4K0rauIUXooT+E=; b=bzPx4GvzleFdtDsb3DcP+W4adWLYmWWCZtEVouv+GEk+czlu6hfY/3YilpLXhQLdAeeOi3 mE7g2nPkzBMUYAJTeEjaYBWF5bW0NtHzYqCT1KAu/KLZkKKG2cNq10FdkKM4MXUWwSEz+t 9nxdYSX6jFN1n6jpoqc8B5IibhkMIK8= X-Rspamd-Queue-Id: 9E378C0008 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Rvo58LN0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: jzm4hrige94q5kmsdp14oetx6mixagjt X-HE-Tag: 1669662978-63068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Changelog: v7: * Rebase this series of patch on top of mm-unstable which removes some duplicate code (patch 1). v6-fix: * Add a comment explaining LRU update logic in zs_map_object. (patch 4) (sugegested by Sergey Senozhatsky and Johannes Weiner). * Use get_first_page() and add cond_resched() in retry-loop. (patch 6) (sugegested by Sergey Senozhatsky). v6: * Move the move-to-front logic into zs_map_object (patch 4) (suggested by Minchan Kim). * Small clean up for free_zspage at free_handles() call site (patch 6) (suggested by Minchan Kim). v5: * Add a new patch that eliminates unused code in zpool and simplify the logic for storing evict handler in zbud/z3fold (patch 2) * Remove redudant fields in zs_pool (previously required by zpool) (patch 3) * Wrap under_reclaim and deferred handle freeing logic in CONFIG_ZPOOL (patch 6) (suggested by Minchan Kim) * Move a small piece of refactoring from patch 6 to patch 4. v4: * Wrap the new LRU logic in CONFIG_ZPOOL (patch 3). (suggested by Minchan Kim) v3: * Set pool->ops = NULL when pool->zpool_ops is null (patch 4). * Stop holding pool's lock when calling lock_zspage() (patch 5). (suggested by Sergey Senozhatsky) * Stop holding pool's lock when checking pool->ops and retries. (patch 5) (suggested by Sergey Senozhatsky) * Fix formatting issues (.shrink, extra spaces in casting removed). (patch 5) (suggested by Sergey Senozhatsky) v2: * Add missing CONFIG_ZPOOL ifdefs (patch 5) (detected by kernel test robot). Unlike other zswap's allocators such as zbud or z3fold, zsmalloc currently lacks the writeback mechanism. This means that when the zswap pool is full, it will simply reject further allocations, and the pages will be written directly to swap. This series of patches implements writeback for zsmalloc. When the zswap pool becomes full, zsmalloc will attempt to evict all the compressed objects in the least-recently used zspages. There are 6 patches in this series: Johannes Weiner (2): zswap: fix writeback lock ordering for zsmalloc zpool: clean out dead code Nhat Pham (4): zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order zsmalloc: Add zpool_ops field to zs_pool to store evict handlers zsmalloc: Implement writeback mechanism for zsmalloc mm/z3fold.c | 36 +----- mm/zbud.c | 32 +---- mm/zpool.c | 10 +- mm/zsmalloc.c | 342 +++++++++++++++++++++++++++++++++++++++++--------- mm/zswap.c | 35 +++--- 5 files changed, 311 insertions(+), 144 deletions(-) --- 2.30.2