From patchwork Wed Jan 4 23:11:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 13089185 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DF7C53210 for ; Wed, 4 Jan 2023 23:11:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51F37900005; Wed, 4 Jan 2023 18:11:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A84A900002; Wed, 4 Jan 2023 18:11:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34A74900005; Wed, 4 Jan 2023 18:11:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2293F900002 for ; Wed, 4 Jan 2023 18:11:31 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E5C7116068D for ; Wed, 4 Jan 2023 23:11:30 +0000 (UTC) X-FDA: 80318665140.02.2B1B25F Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf09.hostedemail.com (Postfix) with ESMTP id 631CC140009 for ; Wed, 4 Jan 2023 23:11:29 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JiUO5mHS; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672873889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=B01nNF6+kAsKxYPfPU/0+WQhCbAoy0WeTmIq8oeqfFU=; b=eJzx0TEaM9sUnZicKbg1w7S+Fb9DAeCgvyH6JAgoIeIKuq/d+/B970n4yDd3ihUal7soyx 7Cic9YsuCD7p1BufHhvkFnkZgm3PSZ51aivpJof9+lzx0VbZkJKpimLMOfTFXP49bgADI5 YYOCMfFVG61SDz8BbrqWV+w7bQZQb7A= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JiUO5mHS; spf=pass (imf09.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672873889; a=rsa-sha256; cv=none; b=TFCn+QJUTFJYsIozVZrlg5vaDyHj/15MlxoVPhroYF5OMJIrwkyNBe2iYskCe+h76QXH22 SfdOCV3iQnu4xW7H126H+NT93cxqkv6wTPHdUhIFljWYHlJY4MmqDyr5O6Cj1/xIApTKxR SGvkbEOvl4ytOmBpFu53xMmxcPBGVJU= Received: by mail-pj1-f46.google.com with SMTP id v23so37917472pju.3 for ; Wed, 04 Jan 2023 15:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B01nNF6+kAsKxYPfPU/0+WQhCbAoy0WeTmIq8oeqfFU=; b=JiUO5mHSM/MIxGODEHrg/AoXwcS8ykkc7cqXOu6R17bTnhr/sxC80tsMyFwM3GSy0N TGUlhJqg6mI6r8OQxOaVw2psyT5SqCfYcaBfY8NrQFHUqXdx/ClXgMpwUW8xDQUqWpBf 6nLcUbQ5qEKGfNCnhgQG3Qo9NX51HteWTPJiZz6BQMKD/K4jAc52MjY993hSqYNCWpUd Ma7cG7D+1OliPk6NJjprZ395u57GtYGT3wBsD8H3+mS83uLagLvrvC9ntylFWb4IjcNu dV0qfBX8vSkEaUFyhweRVmpqN4dCl/IWZWkBl5SwKsUNC0E6nGtzJw+7C5dnsec4TmUu yV+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B01nNF6+kAsKxYPfPU/0+WQhCbAoy0WeTmIq8oeqfFU=; b=2pLmpI83KI3WH8fWFcxMc/wZ0oxsbCeWSMp/wyLz9TptoYEyO+Mz8EBqTxirqtWbgi 1BCv4OJ9bGYkjOV/yil4/TcMoaZDg6Lf/MQf+V+Ih3PTCDLmRFn4pwFhw+UjjBeVSuN1 QM1Rblm/4Kbbrsq2LUyQfgxwmNSUtpK9QS8waE+IfZuOZT+Yx/rPVim+54Vyiocgrw5R Z1+f4dc5fYJMB5pb5an2gUponQcuoVe8zapZecypwQFo9r211zK9Zx5hdHVOEIoIz6XB ETWfepnFzRjZv8831owLlEbWAFbUb58IZVnG9Vfza/QE5zQjKYWE4YWxUs4bEucQPkWe POnw== X-Gm-Message-State: AFqh2kqeQgDZf+UQ+w/uLLCZySxpIKJoxvTvHzd5Idg5q2hhyPfbPsGd 8M9BfU63yupeSdJ3ZeC9iVU= X-Google-Smtp-Source: AMrXdXu9OtNw7kC4ZerWZaqKJgogMCk/OiL0NNs4/nqn/3V8BlR2QnHZyoJulj8Z0gkiemu9zjXdFg== X-Received: by 2002:a05:6a20:e615:b0:a3:5864:e0c5 with SMTP id my21-20020a056a20e61500b000a35864e0c5mr65770842pzb.9.1672873888381; Wed, 04 Jan 2023 15:11:28 -0800 (PST) Received: from localhost (fwdproxy-prn-022.fbsv.net. [2a03:2880:ff:16::face:b00c]) by smtp.gmail.com with ESMTPSA id p26-20020a631e5a000000b004768ce9e4fasm20955212pgm.59.2023.01.04.15.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 15:11:27 -0800 (PST) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, willy@infradead.org, kernel-team@meta.com Subject: [PATCH v5 0/3] cachestat: a new syscall for page cache state of files Date: Wed, 4 Jan 2023 15:11:24 -0800 Message-Id: <20230104231127.2634648-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Rspamd-Queue-Id: 631CC140009 X-Stat-Signature: c3nzisb68q6sijxczd9xniw7ecpdwh9n X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672873889-513317 X-HE-Meta: U2FsdGVkX19sO1l5CB8WH+tCrB02J/VfpNyN7Gj881pkGpCRJOYCKVzVVs1j32PV43X6AXIQCAQFw1Y+4+/DwO7LnypkJEcHX/ZEkRY/JS/wPdkpqW58FJoOQ00IqfDGpaM+T1TSt/D4b4cdlYRfyMjw5L1HPEqBqEnQ7DTaobWJVQ8gSEdi+IPghrAuPCY5wO8cfes6SGn9xYjBM6vRqlbNGrT3zUQ1c1u+S3n0kX6STsYx6+ZIL40+faI/nUYle+IybP9xSltkkXqp5jiTtSuQuZ0VLVHN8uOWfc3XZtnIxr62C97fH21YM9M1Ov4yNWglYDE6jldgsjnCn4F63Xyb/dF60Y9wUU+g5US+yuCOpXXk5Unebq2QSwD3EnDLXrp8Hs4sP3vugwu27e3av9rrYiooeistq7UTBYlzVONF6LSuxopC9zLb9KBBKQTETuQYPMuBJ/stS+trjIdtLcoNXT03pKtTkQFYdkB81XC0hKRhxjE6YlMJIhLG3yRI2Q6+wkrVjKK+h8MNxGfQMD6bZi2yyhaaOSuwKEPQTNW1B2D+ExvVXWtgFlO0t5bW2zNlcSKrK5tg5XOZOqjRr5m3PpVgl0TRWGz7WcZzigQxVS4jd6C3cgYc4H0ts4pxcfcOI4rEVSCgTNzvNzi2zEYtLvgHd6YcVsaAWQE1GprWRQKO4QLxGXgGUmSxNcq/3GucE5IhVgXsckncqo6W+0TxeeL1qbblY/udfj+IES088NZr4+EjCQGt5LwlW1Uu4YxCGtq2yl1P8t5kLqUIgGyTDbtQplI/9tWlg7hxhB+m5BzSjM8phHGqBqyv4qTsPET1ejXdEOhZFGfKMl25uckf/IwFTcsViuo3BQl9Cg+emoaFhtBgai0OWG9ZYgh7Jx5Mxq+WlDPS+M0Ew+03O7vnCle4PT3V9GZAf9LnXoVG2QG8fDmH6bMwq0zsEi10BwLgfn1mNQcmwowJuda FCiYhTkH S2iVdhdnXhL5UGMpw3tYzfrjgVFXbnoc/R2Pd0rC62gIASshNgobBeZB+lBLgNxH10YP0Y3yE7fFQsyb9LxIj73aygBw0dw3M7P9K3TPao1Ckti208AeZkVHrPH7G9pOjwXq0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Changelog: v5: * Separate first patch into its own series. (suggested by Andrew Morton) * Expose filemap_cachestat() to non-syscall usage (patch 2) (suggested by Brian Foster). * Fix some build errors from last version. (patch 2) * Explain eviction and recent eviction in the draft man page and documentation (suggested by Andrew Morton). (patch 2) v4: * Refactor cachestat and move it to mm/filemap.c (patch 3) (suggested by Brian Foster) * Remove redundant checks (!folio, access_ok) (patch 3) (suggested by Matthew Wilcox and Al Viro) * Fix a bug in handling multipages folio. (patch 3) (suggested by Matthew Wilcox) * Add a selftest for shmem files, which can be used to test huge pages (patch 4) (suggested by Johannes Weiner) v3: * Fix some minor formatting issues and build errors. * Add the new syscall entry to missing architecture syscall tables. (patch 3). * Add flags argument for the syscall. (patch 3). * Clean up the recency refactoring (patch 2) (suggested by Yu Zhao) * Add the new Kconfig (CONFIG_CACHESTAT) to disable the syscall. (patch 3) (suggested by Josh Triplett) v2: * len == 0 means query to EOF. len < 0 is invalid. (patch 3) (suggested by Brian Foster) * Make cachestat extensible by adding the `cstat_size` argument in the syscall (patch 3) There is currently no good way to query the page cache state of large file sets and directory trees. There is mincore(), but it scales poorly: the kernel writes out a lot of bitmap data that userspace has to aggregate, when the user really doesn not care about per-page information in that case. The user also needs to mmap and unmap each file as it goes along, which can be quite slow as well. This series of patches introduces a new system call, cachestat, that summarizes the page cache statistics (number of cached pages, dirty pages, pages marked for writeback, evicted pages etc.) of a file, in a specified range of bytes. It also include a selftest suite that tests some typical usage This interface is inspired by past discussion and concerns with fincore, which has a similar design (and as a result, issues) as mincore. Relevant links: https://lkml.indiana.edu/hypermail/linux/kernel/1302.1/04207.html https://lkml.indiana.edu/hypermail/linux/kernel/1302.1/04209.html For comparison with mincore, I ran both syscalls on a 2TB sparse file: Using mincore: real 0m37.510s user 0m2.934s sys 0m34.558s Using cachestat: real 0m0.009s user 0m0.000s sys 0m0.009s This series should be applied on top of: workingset: fix confusion around eviction vs refault container https://lkml.org/lkml/2023/1/4/1066 This series consist of 3 patches: Nhat Pham (3): workingset: refactor LRU refault to expose refault recency check cachestat: implement cachestat syscall selftests: Add selftests for cachestat MAINTAINERS | 7 + arch/alpha/kernel/syscalls/syscall.tbl | 1 + arch/arm/tools/syscall.tbl | 1 + arch/ia64/kernel/syscalls/syscall.tbl | 1 + arch/m68k/kernel/syscalls/syscall.tbl | 1 + arch/microblaze/kernel/syscalls/syscall.tbl | 1 + arch/parisc/kernel/syscalls/syscall.tbl | 1 + arch/powerpc/kernel/syscalls/syscall.tbl | 1 + arch/s390/kernel/syscalls/syscall.tbl | 1 + arch/sh/kernel/syscalls/syscall.tbl | 1 + arch/sparc/kernel/syscalls/syscall.tbl | 1 + arch/x86/entry/syscalls/syscall_32.tbl | 1 + arch/x86/entry/syscalls/syscall_64.tbl | 1 + arch/xtensa/kernel/syscalls/syscall.tbl | 1 + include/linux/fs.h | 3 + include/linux/swap.h | 1 + include/linux/syscalls.h | 3 + include/uapi/asm-generic/unistd.h | 5 +- include/uapi/linux/mman.h | 9 + init/Kconfig | 10 + kernel/sys_ni.c | 1 + mm/filemap.c | 143 ++++++++++ mm/workingset.c | 129 ++++++--- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/cachestat/.gitignore | 2 + tools/testing/selftests/cachestat/Makefile | 8 + .../selftests/cachestat/test_cachestat.c | 259 ++++++++++++++++++ 27 files changed, 555 insertions(+), 39 deletions(-) create mode 100644 tools/testing/selftests/cachestat/.gitignore create mode 100644 tools/testing/selftests/cachestat/Makefile create mode 100644 tools/testing/selftests/cachestat/test_cachestat.c base-commit: 1440f576022887004f719883acb094e7e0dd4944 prerequisite-patch-id: 171a43d333e1b267ce14188a5beaea2f313787fb