From patchwork Thu Jan 5 12:52:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 13089803 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4868C3DA7D for ; Thu, 5 Jan 2023 12:56:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 067D3900002; Thu, 5 Jan 2023 07:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0A708E0001; Thu, 5 Jan 2023 07:56:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAA23900002; Thu, 5 Jan 2023 07:56:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA5E28E0001 for ; Thu, 5 Jan 2023 07:56:46 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8DB55AB3EC for ; Thu, 5 Jan 2023 12:56:46 +0000 (UTC) X-FDA: 80320744812.13.1F14C98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 0AD2840018 for ; Thu, 5 Jan 2023 12:56:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=isV9MBQO; spf=pass (imf07.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672923405; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=1jRVhGgkDfo2ov1sfU3sfMBRbJJBvfhXQvqYKuO2EBo=; b=Hr2PTLjJ4Yzhtq2Urp6rAk9iTSlCX0JQQs0a3n6KDrFu7oLG7ce5B8+wJbByOCOY/7ppvp pgF9R6iLN6xZwOcfZrKLvbySYrW/ASpu6mKKhy0+XQKJHvk/L8nMMdao3Cuc3SCqE+nxV4 nalRcvqYhLEO9S8XzAqlFcP344jHGvs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=isV9MBQO; spf=pass (imf07.hostedemail.com: domain of mtosatti@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=mtosatti@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672923405; a=rsa-sha256; cv=none; b=qhboDt5BHKAuZTxJHSPv5Zhpwm3t21NMrCKLr0cMCNDzN+IzKvwVrZupJ/OFk0vAEmKKVA rpmqVrrx5iso+pCZa/q1ud7mAsI8HCq1cQTO6PuXaKvu3K7t1thNHcru/g67dMUcilwCrd 7O7aM4WrvlpurxXQQJFpNrrYHnyimBc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672923404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=1jRVhGgkDfo2ov1sfU3sfMBRbJJBvfhXQvqYKuO2EBo=; b=isV9MBQOYqmEQRkBRYvJHKEbn60U/gS7iHRPONvEXAznvjQxxl8DcSSKc/bJEHvWecVDIO y+ZfJYp5pPUYcID1n5ToJzqEJYYifmqujPzLMEBe2Iodv7kNrAi2Ya6aih1nMDn/Z2vaSB rv8CEW6VpzEOT/4I7n3VeGaahlA13so= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-2bHDPxFwOV-e2Z5Hia4oTA-1; Thu, 05 Jan 2023 07:56:41 -0500 X-MC-Unique: 2bHDPxFwOV-e2Z5Hia4oTA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CFA778028B0; Thu, 5 Jan 2023 12:56:40 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-2.gru2.redhat.com [10.97.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37BD82166B30; Thu, 5 Jan 2023 12:56:40 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 936C2405026BF; Thu, 5 Jan 2023 09:54:47 -0300 (-03) Message-ID: <20230105125218.031928326@redhat.com> User-Agent: quilt/0.66 Date: Thu, 05 Jan 2023 09:52:18 -0300 From: Marcelo Tosatti To: atomlin@atomlin.com, frederic@kernel.org Cc: cl@linux.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, pauld@redhat.com, neelx@redhat.com, oleksandr@natalenko.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v13 0/6] Ensure quiet_vmstat() is called when returning to userpace and when idle tick is stopped X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Stat-Signature: ou6ezjy793sz6b66i68idrxx4iyynq9a X-Rspam-User: X-Rspamd-Queue-Id: 0AD2840018 X-Rspamd-Server: rspam06 X-HE-Tag: 1672923404-443434 X-HE-Meta: U2FsdGVkX18vw/Mb+lIhomdQJA4dZufTn3j94c/HgKzINo+/sF0EklYowJQ/m5AdBU5e+9bvIKXIAhrsi+S+TD8z/D4Zqpt1cQjJv2pQa4NVZ6Z17fWSSs50Z4OT/dMb3xwL4Mc6KJOfxbF24xMQvj5hZIpwdCZuhqUm9Q9qYuiGHZQHfE3QqEpFe/Hn6K2FNreRV0Tdt7tBLz9PDRFQ7D+bb1wKf0m/Rw1n34nCddBN9U6/mgBchOCJQUMDx2/u+5sGEKGBJcGOUwxXkyyJgDBxy9dvjKuN4OJ9Hl6Imozj5jZ2sYFdvDXaIKw5WOvxk/iiIA2FhpUO/fHP27bpv3Nrh5zjjgS9THEo1LAts4EtPnMUvmAFpxpA9Vf0iWc8ZyvzkEQ1Rxik5GfAb2G9rsVH2axEBEzOZRImqz+FRariQNyM322IpjdmeP6jbC9Mm1Q4g/ajLC85kfjJHmRSdbnm1/hkhyl784HEE7uNJjdP0M2/OaTghHpNAryTDcI8+8uRIfQbKfzPDYOIVCL/yw3k6K74WlbxWG8SDH/QIeAHu4WzNl815NuUotGhUkuEulNaA0XbFTBiZJfBq6LQt95dVnMwDHxZuVX4uraS9DxBkzsCURrmsib64rNMggfuwTCUAOkkXFtAzSwEnNTRH7peg1xer9a5xR2og/rYFvDKZvaxoV0DY2L8bR2cBw9FhK+KfK3Km66TulUd30Gbh+Tc7o7Nmr3wHNcxQjZEWj73LGU8Mmv8hZoPn4f3dVU3wYx4i9BgjmjdkfG0T0pTjibtWS8qDYKWwybWeBqX3BhUQ0wS2Bevkeav69YbhYjkOfAHfKsYCsTKdp9VcUN6XdZYHU77+rGjSJcaQG4N98byogaKbxBEvKYhkKCulD9PekoD+8WzyLM18CrJNpia8PHeODY+Igv8U379jgQblIE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch series addresses the following two problems: 1. A customer provided some evidence which indicates that the idle tick was stopped; albeit, CPU-specific vmstat counters still remained populated. Thus one can only assume quiet_vmstat() was not invoked on return to the idle loop. If I understand correctly, I suspect this divergence might erroneously prevent a reclaim attempt by kswapd. If the number of zone specific free pages are below their per-cpu drift value then zone_page_state_snapshot() is used to compute a more accurate view of the aforementioned statistic. Thus any task blocked on the NUMA node specific pfmemalloc_wait queue will be unable to make significant progress via direct reclaim unless it is killed after being woken up by kswapd (see throttle_direct_reclaim()) 2. With a SCHED_FIFO task that busy loops on a given CPU, and kworker for that CPU at SCHED_OTHER priority, queuing work to sync per-vmstats will either cause that work to never execute, or stalld (i.e. stall daemon) boosts kworker priority which causes a latency violation As seen previously, the trivial test program (i.e. attached at the end of this cover letter) executed inside a KVM VM, was used to determine the somewhat impact under vanilla and with the proposed changes. Firstly, the mlock(2) and munlock(2) system calls was used solely to modify vmstat item 'NR_MLOCK'. In another scenario, the nanosleep(2) system call was used several times to suspend execution for a period of time to approximately compute the number of CPU-cycles in the idle code path. The following is an average count of CPU-cycles across the aforementioned system calls and the idle loop, respectively. I believe these results are negligible: Vanilla Modified Cycles per idle loop 151858 153258 (+1.0%) Cycles per syscall 8461 8690 (+2.6%) Any feedback would be appreciated. Thanks. Changes since v12 [1]: - Protect vmstat cmpxchg and vmstat dirty bit write by disabling preemption (Frederic Weisbecker) Changes since v11 [2]: - Switch back to this_cpu_write/read when appropriate (Frederic Weisbecker) - Avoid ifdeffery in the middle of functions (Frederic Weisbecker) - Clarify down_prep callback comment (Frederic Weisbecker) - Move new Kconfig option close to CPU_ISOLATION option (Frederic Weisbecker) Changes since v10 [3]: - Close cpu hotplug race with nohz_full CPUs (Frederic Weisbecker) Changes since v9 [4]: - Add config to enable/disable syncing when returning to userspace (Frederic Weisbecker) - Add missing signed-off-by (Frederic Weisbecker) - Use proper CPU value when skipping nohz_full CPUs (Frederic Weisbecker) - Use this_cpu_ptr when appropriate (Frederic Weisbecker) - Improve changelogs (Frederic Weisbecker) - For stat_refresh sysfs file: avoid queueing work on CPU if stats are clean Changes since v8 [5]: - For nohz_full CPUs, manage per-CPU vmstat flushing from CPU context (Frederic Weisbecker) Changes since v7 [6]: - Added trivial helpers for modification and testing (Andrew Morton) - Modified comment since we do now cancel any delayed work if the tick is stopped in quiet_vmstat() - Moved check to ensure vmstat differentials do not remain if the tick is stopped on exiting to user-mode into a separate patch (Frederic Weisbecker) Changes since v6 [7]: - Clean vmstat_dirty before differential sync loop - Cancel pending work if tick stopped - Do not queue work to remote CPU if tick stopped Changes since v5 [8]: - Introduced __tick_nohz_user_enter_prepare() - Switched to EXPORT_SYMBOL_GPL() Changes since v4 [9]: - Moved vmstat_dirty specific changes into a separate patch (Marcelo Tosatti) Changes since v3 [10]: - Used EXPORT_SYMBOL() on tick_nohz_user_enter_prepare() - Replaced need_update() - Introduced CPU-specific variable namely vmstat_dirty and mark_vmstat_dirty() [1]: https://lore.kernel.org/linux-mm/20230104133459.5yaflf3yicpmhbbh@ava.usersys.com/T/ [2]: https://lore.kernel.org/lkml/20221223144150.GA79369@lothringen/T/ [3]: https://lore.kernel.org/linux-mm/20221216194904.075275493@redhat.com/T/ [4]: https://lore.kernel.org/lkml/20221214131839.GE1930067@lothringen/t/ [5]: https://lore.kernel.org/linux-mm/20220924152227.819815-1-atomlin@redhat.com/ [6]: https://lore.kernel.org/lkml/20220817191346.287594886@redhat.com/ [7]: https://lore.kernel.org/linux-mm/20220808194820.676246-1-atomlin@redhat.com/ [8]: https://lore.kernel.org/lkml/20220801234258.134609-1-atomlin@redhat.com/ [9]: https://lore.kernel.org/lkml/20220621172207.1501641-1-atomlin@redhat.com/ [10]: https://lore.kernel.org/lkml/20220422193647.3808657-1-atomlin@redhat.com/ Aaron Tomlin (4): mm/vmstat: Add CPU-specific variable to track a vmstat discrepancy mm/vmstat: Use vmstat_dirty to track CPU-specific vmstat discrepancies tick/nohz_full: Ensure quiet_vmstat() is called on exit to user-mode when the idle tick is stopped tick/sched: Ensure quiet_vmstat() is called when the idle tick was stopped too Marcelo Tosatti (2): mm/vmstat: Do not queue vmstat_update if tick is stopped mm/vmstat: avoid queueing work item if cpu stats are clean include/linux/tick.h | 5 +- include/linux/vmstat.h | 4 - init/Kconfig | 13 +++++ kernel/time/tick-sched.c | 20 ++++++++- mm/vmstat.c | 223 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------- 5 files changed, 214 insertions(+), 51 deletions(-)