From patchwork Mon Jan 23 22:04:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 13113073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B42C05027 for ; Mon, 23 Jan 2023 22:05:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A73236B0074; Mon, 23 Jan 2023 17:05:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A23CE6B0075; Mon, 23 Jan 2023 17:05:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C3A86B0078; Mon, 23 Jan 2023 17:05:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7EC0F6B0074 for ; Mon, 23 Jan 2023 17:05:18 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 49D3E40147 for ; Mon, 23 Jan 2023 22:05:18 +0000 (UTC) X-FDA: 80387445516.18.612BA6A Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf09.hostedemail.com (Postfix) with ESMTP id CB5C2140006 for ; Mon, 23 Jan 2023 22:05:15 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FlpMT7YI; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674511516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=68ELyDiBHLWpyo4x56Lnk79sf/vs4Dv5k6uw1xjCUtg=; b=51I/eyhyqzgLRcQcS0ZUS46nzVycsR95Wa2qpzP9Ec9ZkCNisD/8qxSr59GcbWBGPdRrF+ Zz6wNQ2GNuVuBp1cmiwSQLnFCv2j3buI8eeCmhAOL0qL1bdChvuKCheuUaxo3aiMIpwBn9 TK3c3V29OyHJZQz4pCcaTDpDWXqSfF8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FlpMT7YI; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674511516; a=rsa-sha256; cv=none; b=NYJHvQRnfDJSp0ky6uvy2kN0oZ6pVI6ySkw3HhhhhfI2+7lkUft+n0zblUEcf21sjJKc0g tP+xsj+P56LCVKimnrCWTyTEM2+rIF4EFPkJ8/EMWPxG2QulMhHNZvBQV6InQsTxodebMI RwRp0g9rgak2v9JkT3IdWyi81IKzgl8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674511515; x=1706047515; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5O7hqmNJ1lFPSSuT0JsuOLetVB0FETfr4/UVBwOA4ME=; b=FlpMT7YIkUjDU8KdpC74cu8ceq2yjqdDvz9fsUZ2KqB6v/KRPMnfNa90 NQ4lc0sPr+zHQANO3ziqzYbRXtQfviWz/9BaNORNgJBiq5+wjoc/Hu7yU d0TkcKndCr6GYFZDBEBoo+xoiFlp72R4/2zHwReXYe0CJish7xZaFFVw1 XqrnaId/Sz5OphHH0kYCjm6abyDM/XIonPeZQLgAMEjRloXCjcAO7crw4 obCQmpzE5JMC6TaiFlKybZQFqq2lLI2DLQtlLBg6XmMomSHZDUdNisAlA MCIMhGlUhoUHm/5Niq7jCbbHgnP5r14z/LViidqTO35JtlQDbX8gytRDx A==; X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="327421905" X-IronPort-AV: E=Sophos;i="5.97,240,1669104000"; d="scan'208";a="327421905" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 14:05:13 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10599"; a="661878089" X-IronPort-AV: E=Sophos;i="5.97,240,1669104000"; d="scan'208";a="661878089" Received: from ssauty-mobl1.ger.corp.intel.com (HELO box.shutemov.name) ([10.249.46.171]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2023 14:05:07 -0800 Received: by box.shutemov.name (Postfix, from userid 1000) id 1B42C10942C; Tue, 24 Jan 2023 01:05:03 +0300 (+03) From: "Kirill A. Shutemov" To: Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: [PATCHv15 00/17] Linear Address Masking enabling Date: Tue, 24 Jan 2023 01:04:43 +0300 Message-Id: <20230123220500.21077-1-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CB5C2140006 X-Stat-Signature: c9y8pj96si8b3nfrd4saqohgzawtcgjn X-HE-Tag: 1674511515-489468 X-HE-Meta: U2FsdGVkX1+nS4VUdlx6JDFVx0miQOg/caYeDhjyl+2it5brKswjOuP4s8vAm93broJ5ipwlKZS78DHgC1NZhULCw+ntlZUYyg3anC5whIOI+llGMuuAXnsZSQhraAms0BjzTx2qoEjbDLYvSQjW5wudiUO0BSXBnyHJFWpj1wszwkVI/QobQSz4Lay4HmPgMJyn4PzcyTIGmcGBpY+3hoZVepCNnraf0BIiDgn5SWmKLC689ybCGDFRVR6djTi4s+j2NWTUUcDmroX+Yj9LAaKYY8bK500g2GvFbxvlqN6bQIJteg7ZJ2IptDStNScP1W/MPPNhBo447XNF9RJwgJ7Vpdiebih9zmWTpTHpGdWxVDUbZOKjAqn+KYzCZzOnoX+A+lUJjBkjsgYna/75zL9nG0ZXRCN4CBzZn5yOT3l64RgfdRkMQYDs12NHWqlVfPgQa0UKwszthymjLN1QD8jnhmo1Os3aW0H+DmDBq4ImCTMn3/ePqGHQeaBLkLxbT+Bug4vj9dlkimoh3W2TlAvlenIYkE/WZsFgoQt8TU8DyEO2Vql9Jzs4EDmOqiudAZ/UN/qw1slQiMQKCJ5JKG37iBU2e8G+1YLPVMOCF1GwX8AVZMN8OPN+Q65OsKyUAOUBa+51toKl9SFNu3yTost/fJm53jRafTDmJKOjHONtt6ODBKSkadU2aVwAjsHTcDrTKcMXQs0FfxS4prxFauqUcWCHPY6ouNWUJ+p8vRrtcxzzwGvsS5t+24Vuj6LY6iXT4VMIX0ZglDBiMZCAKZTM3MCO/sYJ5k6nkWNnGVHv2kpnSt5nt9IGmPm7oEn+0eSyKWW3i64DAr0Jjgn4s24rZp/1qMJQC1rpETGFvrdYytVx1MDc0kW7rPJ/h7MMmvqzJd3Vly/OPqAWJk1JBa+GFwCcQAUSFZfTVG2R/2EvBWVcCoqn6eagx9g2VY/cFNZOnbh5UU6mnxXmlIg z1pEJfDm 5T+V6aRnrnLXcm9+m7fe7L0Si3YD9Taziabc8/c0N1tim8baiqCjLhDw4q3HtLecGvNedJw2CSVko4pgXKfpsE/sIjoseREt5ghfD8qfgEn/yd/6tIGRaMBgOqCrIbm2X21Ei4OXZzi/Nq/SAZf2OKeekw1TcE6hbj9W/7YargNSY/RFWUT8aJIYQ2GB2/cGGfvX020KK/vzOY9TwgE2ycIR6gkePTTFOI9f5sSb1qmBXAuzFxWIkPZ4/EciXPkFof7Ajbf2k4SnmjdJHJ4NLMP7gkudjRMTVT/Kx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Linear Address Masking[1] (LAM) modifies the checking that is applied to 64-bit linear addresses, allowing software to use of the untranslated address bits for metadata. The capability can be used for efficient address sanitizers (ASAN) implementation and for optimizations in JITs and virtual machines. The patchset brings support for LAM for userspace addresses. Only LAM_U57 at this time. Please review and consider applying. git://git.kernel.org/pub/scm/linux/kernel/git/kas/linux.git lam v15: - Replace static branch in untagged_addr() with alternative; - Drop unneeded READ_ONCE(); - Acks from Peter; v14: - Rework address range check in get_user() and put_user(); - Introduce CONFIG_ADDRESS_MASKING; - Cache untag masking in per-CPU variable; - Reject LAM enabling via PTRACE_ARCH_PRCTL; - Fix locking around untagged_addr_remote(); - Fix typo in MM_CONTEXT_ conversion patch; - Fix selftest; v13: - Fix race between untagged_addr() and LAM enabling: + Do not allow to enable LAM after the process spawned the second thread; + untagged_addr() untags the address according to rules of the current process; + untagged_addr_remote() can be used for untagging addresses for foreign process. It requires mmap lock for the target process to be taken; v12: - Rebased onto tip/x86/mm; - Drop VM_WARN_ON() that may produce false-positive on race between context switch and LAM enabling; - Adjust comments explain possible race; - User READ_ONCE() in mm_lam_cr3_mask(); - Do not assume &init_mm == mm in initialize_tlbstate_and_flush(); - Ack by Andy; v11: - Move untag_mask to /proc/$PID/status; - s/SVM/SVA/g; - static inline arch_pgtable_dma_compat() instead of macros; - Replace pasid_valid() with mm_valid_pasid(); - Acks from Ashok and Jacob (forgot to apply from v9); v10: - Rebased to v6.1-rc1; - Add selftest for SVM vs LAM; v9: - Fix race between LAM enabling and check that KVM memslot address doesn't have any tags; - Reduce untagged_addr() overhead until the first LAM user; - Clarify SVM vs. LAM semantics; - Use mmap_lock to serialize LAM enabling; v8: - Drop redundant smb_mb() in prctl_enable_tagged_addr(); - Cleanup code around build_cr3(); - Fix commit messages; - Selftests updates; - Acked/Reviewed/Tested-bys from Alexander and Peter; v7: - Drop redundant smb_mb() in prctl_enable_tagged_addr(); - Cleanup code around build_cr3(); - Fix commit message; - Fix indentation; v6: - Rebased onto v6.0-rc1 - LAM_U48 excluded from the patchet. Still available in the git tree; - add ARCH_GET_MAX_TAG_BITS; - Fix build without CONFIG_DEBUG_VM; - Update comments; - Reviewed/Tested-by from Alexander; v5: - Do not use switch_mm() in enable_lam_func() - Use mb()/READ_ONCE() pair on LAM enabling; - Add self-test by Weihong Zhang; - Add comments; v4: - Fix untagged_addr() for LAM_U48; - Remove no-threads restriction on LAM enabling; - Fix mm_struct access from /proc/$PID/arch_status - Fix LAM handling in initialize_tlbstate_and_flush() - Pack tlb_state better; - Comments and commit messages; v3: - Rebased onto v5.19-rc1 - Per-process enabling; - API overhaul (again); - Avoid branches and costly computations in the fast path; - LAM_U48 is in optional patch. v2: - Rebased onto v5.18-rc1 - New arch_prctl(2)-based API - Expose status of LAM (or other thread features) in /proc/$PID/arch_status [1] ISE, Chapter 10. https://cdrdv2.intel.com/v1/dl/getContent/671368 Kirill A. Shutemov (12): x86/mm: Rework address range check in get_user() and put_user() x86: Allow atomic MM_CONTEXT flags setting x86: CPUID and CR3/CR4 flags for Linear Address Masking x86/mm: Handle LAM on context switch mm: Introduce untagged_addr_remote() x86/uaccess: Provide untagged_addr() and remove tags before address check x86/mm: Reduce untagged_addr() overhead for systems without LAM x86/mm: Provide arch_prctl() interface for LAM mm: Expose untagging mask in /proc/$PID/status iommu/sva: Replace pasid_valid() helper with mm_valid_pasid() x86/mm/iommu/sva: Make LAM and SVA mutually exclusive selftests/x86/lam: Add test cases for LAM vs thread creation Weihong Zhang (5): selftests/x86/lam: Add malloc and tag-bits test cases for linear-address masking selftests/x86/lam: Add mmap and SYSCALL test cases for linear-address masking selftests/x86/lam: Add io_uring test cases for linear-address masking selftests/x86/lam: Add inherit test cases for linear-address masking selftests/x86/lam: Add ARCH_FORCE_TAGGED_SVA test cases for linear-address masking arch/arm64/include/asm/mmu_context.h | 6 + arch/sparc/include/asm/mmu_context_64.h | 6 + arch/sparc/include/asm/uaccess_64.h | 2 + arch/x86/Kconfig | 11 + arch/x86/entry/vsyscall/vsyscall_64.c | 2 +- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/disabled-features.h | 8 +- arch/x86/include/asm/mmu.h | 18 +- arch/x86/include/asm/mmu_context.h | 49 +- arch/x86/include/asm/processor-flags.h | 2 + arch/x86/include/asm/tlbflush.h | 48 +- arch/x86/include/asm/uaccess.h | 58 +- arch/x86/include/uapi/asm/prctl.h | 5 + arch/x86/include/uapi/asm/processor-flags.h | 6 + arch/x86/kernel/process.c | 6 + arch/x86/kernel/process_64.c | 66 +- arch/x86/kernel/traps.c | 6 +- arch/x86/lib/getuser.S | 83 +- arch/x86/lib/putuser.S | 54 +- arch/x86/mm/init.c | 5 + arch/x86/mm/tlb.c | 53 +- drivers/iommu/iommu-sva.c | 8 +- drivers/vfio/vfio_iommu_type1.c | 2 +- fs/proc/array.c | 6 + fs/proc/task_mmu.c | 9 +- include/linux/ioasid.h | 9 - include/linux/mm.h | 11 - include/linux/mmu_context.h | 14 + include/linux/sched/mm.h | 8 +- include/linux/uaccess.h | 22 + mm/debug.c | 1 + mm/gup.c | 4 +- mm/madvise.c | 5 +- mm/migrate.c | 11 +- tools/testing/selftests/x86/Makefile | 2 +- tools/testing/selftests/x86/lam.c | 1241 +++++++++++++++++++ 36 files changed, 1699 insertions(+), 149 deletions(-) create mode 100644 tools/testing/selftests/x86/lam.c