From patchwork Wed Feb 1 09:13:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13123983 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD534C05027 for ; Wed, 1 Feb 2023 09:13:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56B676B0071; Wed, 1 Feb 2023 04:13:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51A246B0072; Wed, 1 Feb 2023 04:13:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 408FD6B0074; Wed, 1 Feb 2023 04:13:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 328596B0071 for ; Wed, 1 Feb 2023 04:13:53 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DCA6A140D72 for ; Wed, 1 Feb 2023 09:13:52 +0000 (UTC) X-FDA: 80418160704.08.48DA6D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 3873E1C0002 for ; Wed, 1 Feb 2023 09:13:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gyA5+eTe; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675242831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=fJF72Zd85F4nvkHLPmd4ED2J4KvlszW2tzIwzQ+dNaM=; b=l3iKCyMemeSuT4p9pFCw0CNh6JdWV4alzn1Gy7exhmPuTvNdDSp6TYwzJzYuRij6rzjtPG VF/7fmJrhLFheG85Cv4f5TQOXX3wTQYRGsxOkPPU4WhcUZTv+mXpyUlt0elu4Aq+5njfku zHnXS+WEAW2fhFinA8H/5cVZJEVjoB4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gyA5+eTe; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675242831; a=rsa-sha256; cv=none; b=E5OWWYnGDGQPdTy8jQhHxjhAgoT07ls7ODjwzNIECqxtH3seTFohpXiMGAUFLxpxqohx6H rP5ndns3waNhOADv7GfI/y+9595OwaOlrWEWUh0uXOv0Sm3X+Q07YZlW+8B3KhW94QnePO BT0Kq4YXtvjIUdsMnz6GwN3x/eJuChI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675242830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fJF72Zd85F4nvkHLPmd4ED2J4KvlszW2tzIwzQ+dNaM=; b=gyA5+eTe85xGuqXMZY5PENJhp/S8FuRh/PC4WgGETO05s/gFuy/jkDVYcIC2mnWFUNapga xTdwYN4TtJ4STjJtRKNIomZziRSBERG13kcgWCGNB/HaP9AKtA4rtFKoZe4GzhlKFQSXjn eQG0S4XWxbbubqVQI3u9Zd5UL+JkzL8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659-qnPyJGJvPkuZbXLpej_Qrg-1; Wed, 01 Feb 2023 04:13:47 -0500 X-MC-Unique: qnPyJGJvPkuZbXLpej_Qrg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83D50800B23; Wed, 1 Feb 2023 09:13:46 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-13-89.pek2.redhat.com [10.72.13.89]) by smtp.corp.redhat.com (Postfix) with ESMTP id 00D79492C3E; Wed, 1 Feb 2023 09:13:41 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, stephen.s.brennan@oracle.com, urezki@gmail.com, lstoakes@gmail.com, willy@infradead.org, hch@infradead.org, error27@gmail.com, Baoquan He Subject: [PATCH v4 0/7] mm/vmalloc.c: allow vread() to read out vm_map_ram areas Date: Wed, 1 Feb 2023 17:13:32 +0800 Message-Id: <20230201091339.61761-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3873E1C0002 X-Stat-Signature: nd6k4wqs4zj3s6osrzx7uto9cr9xcwtg X-Rspam-User: X-HE-Tag: 1675242830-853972 X-HE-Meta: U2FsdGVkX1+o4UlwH9kh2XE+jhoYSS14dNqiD303yolX3kgZD8ps5GcQLUoVhRfWaHFzFh49IVcbJ7aKdco+ayMLW9whcag0N4z/biQhxPGpXlWF6h4ihrhyVkuYF5jDnzLJ0rpH2t7hCF+rAdy3qbddZpSiEkA0bnp/DgFJSl7Z0xU9F/NAi1CjRCRdUckADVeBkvLTUDe80Wc1d8dfpynXn6esRqiLP1TG7vSITn+erF5W6oV2KlvU4aUNeezOc9V+By0EJuguVPSYfFKkHdhc9VVFxWmeoVVhOCVjM8i7S/TlzINdIAzRPumk4U7HlS89Ov8QnrIE4SKFI9zwQyr1PDSZVBPUa+m5TdrydxIpXUMlo0khi8BcADJHkU857mnqLX7hr7dUEuKQ2VepnhowOmJKM+2NaGBrQv91SG2A0kGbOUcCDhhL/P9L8zYq1hmOJ61hrwvvk+Ji28h72OsAsg9x1s02zDLQCoIzUExZDTycqe9IsLWTQ9nHSsq82t7QGCYZqfQohC30a8gYEDKsjtUWwg3Pk17weoYEb1sGEMCoR04lKbRxdplXCpuy4dUuWnFGT+n/6iJ16tyBeGkMWNH/yAVnvuhMbrLyqwNdgURBih3eL/CEXDhfArbzajG9LaYemogpv5hmNLWVnIAK0M5YCrz6Gh1SrgXBhFu+TofDgwu+DxH1H2barkSXy8ul/BCAaKMVWAguzAxQZf0rT8bPZyeV2DgNLEI0KTjs2Ci1KROoh1IOoaNLPDdHbGcW/uQKc8NK2HdnBAf42dFVzH/rsWS7fBptfC0xxYNREEdiCT+7xBxyOai9gdghDPtVN0FpaIAJEQYqOoiClRsn7lZad9NcXL+bdVP43yps10tz1qzRA25I+SGWCE2eTI9n1xtb1Kdvv2hj7mfPamX0j8buMm/vwhdDOz1jRzcuhfKvDbJ2U6oShx1HoRgggs9BZ//kolqy/2d2A3U jrZood8J 6306EAYN9oR0h11RjpL0i5G0HcCkjzv3CTLjGYYua79SYxEcGMfNwgN0sKBwaKQjPc8nezS6wDoGCOKHOVc3rcmt0AfjhroLsHStojOahJOskS2La1IT71s9lIy6NCa25/2CrnN/a4z04Qk6BFaFSo2n2a7J6cScj2639z6Im8fNBW7JMJQEPwSU6A/K3qcT/R+JKC/iAakA5423viFbx22YRbCYsd69uu7+tE8gaYCSbYn56hXsXj1ozsKte1kH0EYZxsvI1ttuS7JP/6fsKpbKuY+t6gZyybtQhniBcn7JwcOk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Problem: *** Stephen reported vread() will skip vm_map_ram areas when reading out /proc/kcore with drgn utility. Please see below link to get more details. /proc/kcore reads 0's for vmap_block https://lore.kernel.org/all/87ilk6gos2.fsf@oracle.com/T/#u Root cause: *** The normal vmalloc API uses struct vmap_area to manage the virtual kernel area allocated, and associate a vm_struct to store more information and pass out. However, area reserved through vm_map_ram() interface doesn't allocate vm_struct to associate with. So the current code in vread() will skip the vm_map_ram area through 'if (!va->vm)' conditional checking. Solution: *** To mark the area reserved through vm_map_ram() interface, add field 'flags' into struct vmap_area. Bit 0 indicates this is vm_map_ram area created through vm_map_ram() interface, bit 1 marks out the type of vm_map_ram area which makes use of vmap_block to manage split regions via vb_alloc/free(). And also add bitmap field 'used_map' into struct vmap_block to mark those further subdivided regions being used to differentiate with dirty and free regions in vmap_block. With the help of above vmap_area->flags and vmap_block->used_map, we can recognize and handle vm_map_ram areas successfully. All these are done in patch 1~3. Meanwhile, do some improvement on areas related to vm_map_ram areas in patch 4, 5. And also change area flag from VM_ALLOC to VM_IOREMAP in patch 6, 7 because this will show them as 'ioremap' in /proc/vmallocinfo, and exclude them from /proc/kcore. Testing *** Only did the basic testing on kvm guest, and run below commands to access kcore file to do statistics: makedumpfile --mem-usage /proc/kcore Changelog *** v3->v4: - Fix typo in pach 2 catched by Lorenzo. - Add WARN_ON(flags == VMAP_BLOCK) in vread() to address Dan's concern that VMAP_BLOCK could be set alone in vmap->flags. - Add checking on the returned value from xa_load() in vmap_ram_vread(), Uladzislau commented on the risk of this place. - Fix a bug in s_show() which is changed in patch 5. The old change will cause 'va->vm is NULL but the VMAP_RAM flag is not set' case wrongly handled. Please see below link for details. - https://lore.kernel.org/all/Y8aAmuUY9OxrYlLm@kili/T/#u - Add Uladzislau and Lorenzo's Reviewed-by. v2->v3: - Benefited from find_unlink_vmap_area() introduced by Uladzislau, do not need to worry about the va->vm and va->flags reset during freeing. - Change to identify vm_map_area with VMAP_RAM in vmap->flags in vread(). - Rename the old vb_vread() to vmap_ram_vread(). - Handle two kinds of vm_map_area area reading in vmap_ram_vread() respectively. - Fix bug of the while loop code block in vmap_block reading, found by Lorenzo. - Improve conditional check related to vm_map_ram area, suggested by Lorenzo. v1->v2: - Change alloc_vmap_area() to pass in va_flags so that we can pass and set vmap_area->flags for vm_map_ram area. With this, no extra action need be added to acquire vmap_area_lock when doing the vmap_area->flags setting. Uladzislau reviewed v1 and pointed out the issue. - Improve vb_vread() to cover the case where reading is started from a dirty or free region. RFC->v1: - Add a new field flags in vmap_area to mark vm_map_ram area. It cold be risky reusing the vm union in vmap_area in RFC. I will consider reusing the union in vmap_area to save memory later. Now just take the simpler way to let's focus on resolving the main problem. - Add patch 4~7 for optimization. Baoquan He (7): mm/vmalloc.c: add used_map into vmap_block to track space of vmap_block mm/vmalloc.c: add flags to mark vm_map_ram area mm/vmalloc.c: allow vread() to read out vm_map_ram areas mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo mm/vmalloc: skip the uninitilized vmalloc areas powerpc: mm: add VM_IOREMAP flag to the vmalloc area sh: mm: set VM_IOREMAP flag to the vmalloc area arch/powerpc/kernel/pci_64.c | 2 +- arch/sh/kernel/cpu/sh4/sq.c | 2 +- include/linux/vmalloc.h | 1 + mm/vmalloc.c | 126 ++++++++++++++++++++++++++++++----- 4 files changed, 111 insertions(+), 20 deletions(-) Tested-by: Stephen Brennan