From patchwork Wed Feb 15 12:00:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13141569 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81ACBC636D4 for ; Wed, 15 Feb 2023 12:00:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABBB96B0072; Wed, 15 Feb 2023 07:00:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A41EE6B0073; Wed, 15 Feb 2023 07:00:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E4636B0074; Wed, 15 Feb 2023 07:00:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 77A1B6B0072 for ; Wed, 15 Feb 2023 07:00:45 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 39EB5A15CE for ; Wed, 15 Feb 2023 12:00:45 +0000 (UTC) X-FDA: 80469384450.23.1895334 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf24.hostedemail.com (Postfix) with ESMTP id 105BC180021 for ; Wed, 15 Feb 2023 12:00:42 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=WzXC4h4b; spf=pass (imf24.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676462443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=4VUdCGE49XRzHSapC26DVNo0zyTxpm/781TlQ/JM0hk=; b=Hga5PBhoUQJgHn+Yzw3gq79axUJmV4ZHFUFW0CIBjmJLwSd2unGVKza3zm8nYYJ6HrPmXv NhVq2acjG2ePMu+175YmSkl4xxsxCJNs2mi8hSuEjmDHwWh8nmrLnbJx7OHpHLBzBDVEpw 8CZNGNXwhb7MwlWq5bvwr4ApFVSFSWY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=WzXC4h4b; spf=pass (imf24.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.208.54 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676462443; a=rsa-sha256; cv=none; b=tKTGZPeh9dNdiC78L+npDoBU2Fyf3/+9C9mbuiLXSw8XZ6n6RzTZ3Ryj0tnfdfjakvze+d EbzkC4a9SOT3se8VvB5yumClznI93tm8lQuPzwaWzxooBkZeFhn0qnvXEIvyRkGcBXWNxi z+2ApV6rmaBRWnjAGcRaq++ZRYOOCRo= Received: by mail-ed1-f54.google.com with SMTP id eq11so21683720edb.6 for ; Wed, 15 Feb 2023 04:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=4VUdCGE49XRzHSapC26DVNo0zyTxpm/781TlQ/JM0hk=; b=WzXC4h4b9erT7h/NVTKsWubM7WnbXMEVDjLnATSbHHKXVr9Hue4pPMQhKxFKBzzZDe OwLX0YPR/wTYDjNQXTnJm0iXeo2bZq1SF38cjtgaYgAwA7VZfzmCONX0xZ/6iU+GLxbJ JVZ/WQL3g0v7hmdAdALL+HvjAAVAa2zpGBd9xAA7VQKHeUKKdRh5ZYkkxO7dj9TBpnyH Fkg95R4If1CaruvQdj8dV3vs+38lsOypQuTGQGos5IfQx0s/rBlQK6xEgD4glYr4Mnjm oELKMsBxoi29MDlefKELd4oXSzBgwTnAZL8DfAF53Q6lRW4zt9wh7wNqoFIcO/5tFEE7 nKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4VUdCGE49XRzHSapC26DVNo0zyTxpm/781TlQ/JM0hk=; b=5mwc3LtDWt6xyaAgoX8XBzyHl111e06LinWDktqz2cVNktcTYKYsbyXxYihv8F8pcs EZMO5OpEpy8gSJDIyhS5fU63iTENhG2EpqPv2aDDdxan4T5rQ42RBpiq9nmbHOwogzpC wXGGjxB9/HjEpMb47geX1e47Rd2/nZEoa+byEKJaCNQa3QNoXhWCMQdHkdCAC+fITzGm C5mv39tck278XYP7boqtpYGe+WjSkh4tx1KS8ir3gEmkwRcl5eZIaiD009qRTKPFWjP8 fbvmBtui1xA1Cl5UxHBHrMwu5PTpwVAVhizFil4+ChDFUHpBzPW94ONIkBTAIDJPuLCi VZGA== X-Gm-Message-State: AO0yUKUu8PE/RVpNAHlr8yOLYudMRsJPmf79uCmqrhXBm2z1fXBMZ3N3 cugBQ1gHDst+ZFEl+BgBUxVNkw== X-Google-Smtp-Source: AK7set8mzMZsxIghYW+QneLMlPjJkUSgm+fCQZ/b0Mr+7o4w9F+smHLglwSGm487RKihYyCIuty67g== X-Received: by 2002:aa7:d590:0:b0:4ac:bdf7:dffd with SMTP id r16-20020aa7d590000000b004acbdf7dffdmr1652543edq.12.1676462441534; Wed, 15 Feb 2023 04:00:41 -0800 (PST) Received: from [192.168.1.101] (abxh117.neoplus.adsl.tpnet.pl. [83.9.1.117]) by smtp.gmail.com with ESMTPSA id h2-20020a056402094200b004acb42134c4sm7001477edz.70.2023.02.15.04.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 04:00:41 -0800 (PST) From: Konrad Dybcio Subject: [PATCH 0/2] Revert boot-breaking changes in fs/ Date: Wed, 15 Feb 2023 13:00:37 +0100 Message-Id: <20230215-topic-next-20230214-revert-v1-0-c58cd87b9086@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGXJ7GMC/y2MQQqAMAzAviI9W3BTEfzNrFULUmWbIsj+bg8eE 0heSByFE4zVC5FvSXKogasroC3oyiizMfjGt413PebjFELlJ+PvOrSQY0YibmlZ3EBdDzaYQmK cYlDabKHXvpfyAUrgY5dxAAAA To: Alexander Viro , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mm@kvack.org, Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1676462440; l=1045; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Pk9Em+bfGAgf2e3KWWPVe2M5izGtozUbvqt4nZPzw3w=; b=AgaZWdOrEtG7yPe/2cMEuuiDpK04G3/UjW2o/dHw6W9oZj9z/YCE7ikh9viiSSH86j7Q6d+X3IiY nWs65LgUAJNmJKxkuOLxTpEfsmr3l+tO8KhzWcDEZ5bvH16X2poj X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: wg6oio86kiw6my3f1bmkhs67154chz6i X-Rspamd-Queue-Id: 105BC180021 X-HE-Tag: 1676462442-300390 X-HE-Meta: U2FsdGVkX19RPYH6Ut6rTjckzWStpngJ3HUg4+bE4pBMhXZsZcBGuGIrDXLDEOf9AvDyMBeNvA2U+xgwtwYGUgyzEA7HOYUkXgT7Huwr0mGe+PbPJfCpDUMa+IPRwJdEZ3bUuKqNKcJP2+PLRLXxMWDMPjFzi0LXFBrJEE3AYOgpoeyl9/Rf+KWhCUCK8e3e2a47FV03kWy0lnm/ZYHi+u9fsvPHDJRfzHNRMJxUaRgNi1EkWYMNWJU2u6+EfBsXHS+jZQ++v4cphvbFPeNAYD7BWVBUw0m0J4NhH2isISY08D0bl8YhtmqYDQMug1TsOajxipXx1yHQlTZ3h/CtrXeVyh+Kf9VmzvnfTovqLUMbhxAbQAxPWCUEY6GLNBBFn3+L7Yt8XR8MUcZN8mm228IiQX68eMeGT+jF6XP7TqxP+dBMLplzWLCcSs7mAbeHtLGkXkMyaXNU123VkIBYiZkr7FbaBxioOD/L5vCW8L5JWWTKkEC0iw2LyviCY5S3hrAKq//5grYCHGYeJepkjeurUBD+Ag78FXA31Nv9S2Z5TweBvHSkZrDeqa/9MPhpOx9OyRIEuOVMR+UUklVMJOMPb8Nl2QrljY/K+r2Cw3UqU82gOt+sl1WMNdgSZujDVUSZtxFy9Xs/Rb+4o8WM8KgrVk1lwaERy23n35YIThQj3XtZRcGspHoql9XOTaIRiLb8PkAlorjJxeAzgYVYQ5xxDqY5VH/95BYg9oVFMDXJB5AfVKhRIJ2an1vxVO+KQayBiUr/3E5V8SuSvzk1Hg+TpxczILnBh6d40/lTzB+CLEAuxZGbr9+gLwFDhPDfPWpjzw047D9i4Hv2Cdf2dNhsSToBgNZJOaAPNnFCCXn2xGSU33J2O7DOZQ8z4WDnEUsbx7hLL+8z89wmlztx5vaqL6FSSSEFgAhE1kELiYl+qsUJbpUGM9DWCBvgaYz2RDATCxGDZ+/pzOMCk3j GI4ImO30 lSqygOxG4o+C1ZXFTc2W4tygLN0CK1d5qazlTx1z6jKI6Gjm2vNIQXuUGzHG5uMJcBwFxdDcFG3VsgLj1axwiDSzEdGBw+daef/fSxF57U7FLaTReBfw3+c7v1lpVBVbtBiFERDhQasVy2068kCTsfjwc7JPZwJ4LNDnP9kVt7lj2OJl6dWbKQGTqL2WWHqgFR11viXt4O7E4MoDf3lkZH/G2kacZ4fuR3ZHbYpFC9P4ie/1QfafnpdSZD/FsFiusSTW1zeuOj4CPmkg5pz4i/ois66EMKAI5C1A1+DpIfKogb6AtqZ6CKmplyGFQl2ZOR75eELm+K3KQkV+YDbVVxCBMwA4nYF63Y6WxdyTyW+PnR62UvZtqh0epRPT6fqTVbgIQ48thkxb3sHnXwVqJ+bc20KDJ8ogd5QDy44LBv2C2YY4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: next-20230213 introduced commit d9722a475711 ("splice: Do splice read from a buffered file without using ITER_PIPE") which broke booting on any Qualcomm ARM64 device I grabbed, dereferencing a null pointer in generic_filesplice_read+0xf8/x598. Revert it (and its dependency) (or accept better solutions should anybody come up with such) to make them bootable again. Signed-off-by: Konrad Dybcio --- Konrad Dybcio (2): Revert "iov_iter: Kill ITER_PIPE" Revert "splice: Do splice read from a buffered file without using ITER_PIPE" fs/cifs/file.c | 8 +- fs/splice.c | 159 +++---------------- include/linux/uio.h | 14 ++ lib/iov_iter.c | 435 +++++++++++++++++++++++++++++++++++++++++++++++++++- mm/filemap.c | 3 +- 5 files changed, 479 insertions(+), 140 deletions(-) --- base-commit: 3ebb0ac55efaf1d0fb1b106f852c114e5021f7eb change-id: 20230215-topic-next-20230214-revert-cce3cff17c45 Best regards,