From patchwork Wed Apr 5 20:35:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13202506 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AA4C7619A for ; Wed, 5 Apr 2023 20:35:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 595EC6B007D; Wed, 5 Apr 2023 16:35:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51D996B007E; Wed, 5 Apr 2023 16:35:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BEA26B0080; Wed, 5 Apr 2023 16:35:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1E91D6B007E for ; Wed, 5 Apr 2023 16:35:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E41858050B for ; Wed, 5 Apr 2023 20:35:12 +0000 (UTC) X-FDA: 80648492064.12.6814878 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id C7343180019 for ; Wed, 5 Apr 2023 20:35:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UKqf4X5J; spf=none (imf16.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680726911; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=CGo2H4hJTPWzaMtaGj7Lktm7eVtZzNMbcJEtAOG6yWg=; b=peuDF/RYOluXdd8Hz8AT7ux8eXVXKfnOIK5jLHT7cjN4z6Id2HTul7BAT3mZZpSzOBnFXt KE1onNOcm+obKSx8fUBZ8+VjWBC4T7DP+DtXaLV74xlkntjIlYLW9SM5JraTNh6mTuaeY3 ai3PYFXkh/pm2EOti0NcgTcQN0irAOc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UKqf4X5J; spf=none (imf16.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680726911; a=rsa-sha256; cv=none; b=VKD9PVibsXzJx3kJVA2rlLLzU4reUfzlUIGezS0TxDyMenGEoyPWLZG7cRUtUTnmbD0qpe x0yTLPcwTSTOhhSraTm6j4e5XdAVZ5kg17fkcbSTb4eAhh2yC9yjIsqQjB2wL6JPsJyL6z Y1nxiziDwgL9gE3lKKZhfLXvg+ECpvk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=CGo2H4hJTPWzaMtaGj7Lktm7eVtZzNMbcJEtAOG6yWg=; b=UKqf4X5JbNA9vkONPxrzgBYW92 y09XAlnqRA7OvwgxflCIdnp0Um5FQLBJESmL9GajFwNqWNyPMsr3IH7WOA01XyOMbP4CP1z8jS3gz AoIFfDcZsDikZEyuzzGAs5QUAnyQnHqoorkaoXlh7AByLTwd+Tl1z/5xmLxuSwe1tdotRtxaIDwTm S5WOlqzZjRDkZPBG7HK9G4F/DbwDDRXcusDUt3P4eYN87AjkvhbHYj4R0LtL81zjvauwnezN+HlhK 4cwNNLBjtpvOE5WSXvIrFookL368xlZp4zhHqffGNtMeaRt5iCteXQXi8mm98bIUr3hlamASpWN8S aqZYwOfA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pk9qT-005dWW-2P; Wed, 05 Apr 2023 20:35:05 +0000 From: Luis Chamberlain To: david@redhat.com, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, rafael@kernel.org Cc: christophe.leroy@csgroup.eu, tglx@linutronix.de, peterz@infradead.org, song@kernel.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, mcgrof@kernel.org Subject: [PATCH v2 0/2] kmod: simplify with a semaphore Date: Wed, 5 Apr 2023 13:35:03 -0700 Message-Id: <20230405203505.1343562-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: f6zrpy8gcrzgfsctpgcn15uywxdtg7wc X-Rspamd-Queue-Id: C7343180019 X-HE-Tag: 1680726910-897524 X-HE-Meta: U2FsdGVkX180q6/ER4gxU5IprQWITKChqhntMcwFl+/GRwBfsAiP4dc6mH4vorjnOC+fa5A2wwYrwi1fnIF6eCrWc6d5YsYbPPxtFewbRV3wxp3rGZYKW83htdFcsr7e7fJIO6ZgBQtxSwEN1gTXeYe0Kv5GNT8KICekweqkRlbGVP9OHw6UWu4RdTGN1p9m3LGFMSnI4eujEATkWq4pdMHSazTCb+JuOXXcpgucM5ZFGQziG3kUnvDk9mZL5pbgy1Hz0tojSYj/vkWSSVcOVJ1DFVjBl7czlsK/LlRlOPPSUs+Znx7YiMh6B9cTcEkuziJXMTZiRj0nDZ4+dgeuysPOwBliWDy431u5P1iTBS+9IZ4v+bJJE61VufCvaXmSb+zx47IGzEETKv72EOOx2xBdhze8yUWCjdhspDe7Y+69J4tluvdtgEDYbCUTBPJQsYA2cxYUfAqnGJ/hNQwHnW/m7P5xv/AWlZvN3JLoctJjIE816U8I28NcFzLoD8Mr2tJLNGSzaYXmwHZn7kFdZsZW/rb6Vs8XUK1axq+28LeJlJwN+IE8e6kFavzrixQRl/nLbNjj7tTS9bLZrc9fw2fKqxwGmCrSB2vVhXE2dPEWqzdWj0gbaMgUGa5QjULovsDF5RZ5FxgmonhjvGzJs5ZrCebpBagA22V4tD1KBiN3AtRqszQKvqZ7Uoce1tQ3wSVTzDrqJPJ2y3jO/ENu7AyUP2HjiEMVysduTb+GpR9ydQayy/eOwTRp0kXrdSKbBABHLoPk5tu6LUjS9W0QaInok6H1Tb/eHGWQZWsaSxXGWathfbwJvKC5VYQ311dgqmdNBqIyL+eJO+UnUDGS9plDVLg8ixKSgv92Y8tfohTw1eBipbshRtTsDqN8wQcu8NCMjuAd+eHQiv8rf5JxmlDeiGDbNOwYV1imJOWGvJuDBJhbrqvi2brtu5N47hvQjIdWPgApSy/iq+69Uf3 ZmH0aQXz WTGX0vdXgx5lL7s98gfP6nnPG4M8cwRQe4hNPaYtiMTe/G9JMLMZcjTRHsepcO+xME5WhvUSN7rUW74/daAvoNCiwVuGGhVEdI7+he925+b29nMjaoalpK44p9h3y7e8V+vKFw2Sqgyjwl9JAzWMfFnpmq6zX+H6w7IC1o8owZVhU3AGASXYpyiUT7CesMudzn2R2yoNfagA0ERCFwjh6ciTf1TjfCSHK+DhK7/24qLkPJVeXbQpUbvKJBz5zdNTpwcCRbHya1s2Gv9DL2++aHm4P/ouTIU/cJMN/Ospi0dpa4C0Ou0bQnKcEIfDh7qyS7C7I8xsiWv3i2x1QkeJQh2IC5YHIHYZFLD1iM42zniJzh4nChWosiljEX1cAEKX/ai5NhPj07RBYXsIBMXb84FoYT6ISaIXpbe7ioVmmTsSq+rTDtY+nag9u1PQE7h63+GJjRoieaSk3JEPWugsfrj+qw2t+Llc7o8zO1R7Ue15+Z0M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I split the semaphore simplification work out from my first patch series [0] because as although the changes came out of that effort, in the end this set of patches are slightly orthogonal to the goal behind that series and this ended up being mostly a cleanup with mild bike shedding exercise. As revealed from the first series, there is some tribal knowledge around why some binary semaphores are not just mutexes, so we cannot just convert them all to mutex. So I've extended Peter's patch with some of that tribal knowledge. Changes on this v2: o split this series up into its own o adopt Peter's patch and extend it with some documentation as to why some folks stick to binary semaphores over mutexes o modify kmod.c to use the preferred declaration This goes boot tested. [0] https://lkml.kernel.org/r/20230329053149.3976378-1-mcgrof@kernel.orgsemaphore Luis Chamberlain (1): modules/kmod: replace implementation with a sempahore Peter Zijlstra (1): Change DEFINE_SEMAPHORE() to take a number argument arch/mips/cavium-octeon/setup.c | 2 +- arch/x86/kernel/cpu/intel.c | 2 +- drivers/firmware/efi/runtime-wrappers.c | 2 +- drivers/firmware/efi/vars.c | 2 +- drivers/macintosh/adb.c | 2 +- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- drivers/platform/x86/intel/ifs/sysfs.c | 2 +- drivers/scsi/esas2r/esas2r_ioctl.c | 2 +- .../interface/vchiq_arm/vchiq_arm.c | 2 +- include/linux/semaphore.h | 11 ++++++-- kernel/module/kmod.c | 26 +++++-------------- kernel/printk/printk.c | 2 +- net/rxrpc/call_object.c | 6 ++--- 13 files changed, 28 insertions(+), 35 deletions(-)