From patchwork Thu Apr 6 16:53:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Roesch X-Patchwork-Id: 13203737 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6553C7618D for ; Thu, 6 Apr 2023 16:54:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF93F6B0071; Thu, 6 Apr 2023 12:54:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA9836B0074; Thu, 6 Apr 2023 12:54:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B98966B0075; Thu, 6 Apr 2023 12:54:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AAA2E6B0071 for ; Thu, 6 Apr 2023 12:54:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5FA9DC038A for ; Thu, 6 Apr 2023 16:54:00 +0000 (UTC) X-FDA: 80651563440.16.AC08B90 Received: from 66-220-144-178.mail-mxout.facebook.com (66-220-144-178.mail-mxout.facebook.com [66.220.144.178]) by imf22.hostedemail.com (Postfix) with ESMTP id B3780C0024 for ; Thu, 6 Apr 2023 16:53:58 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=neutral (imf22.hostedemail.com: 66.220.144.178 is neither permitted nor denied by domain of shr@devkernel.io) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680800038; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=9Vv+0VYdKoksCHPSWy85J8yIkLMJQbgRQxUfmBrcwrk=; b=h5SfcSN2L9WJr/kYZW7U2aRtg95chsMGLXuAGVfdZXtMgKmG7wcp0GUAJoatOdkr6/rgxt ZO8V5texIurKiqMzY7LZy5wJxE9C27iqj+Q0Y6Cr6OilaSY1L9Apu1/AC1yLksqCLF4SFf PTthLC15U7HzzhykLP1Hx5wRs/w2Ikw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=neutral (imf22.hostedemail.com: 66.220.144.178 is neither permitted nor denied by domain of shr@devkernel.io) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680800038; a=rsa-sha256; cv=none; b=oULCZg2ymGnKstgqElKZYbaSmohKfwCUWIKchWKu2EoVI7w6mldYiceesEtYCJSFBMWvUN uTVQFdw4DXFoeWJV4ESuBOi/eMFJhr2jMt5m2cCNATmxmqbxNhv9tejDsZyGFlmKKFe2jj DklcDt+1dQNc5/Ok+ZUoQmA/CBaQjrA= Received: by dev0134.prn3.facebook.com (Postfix, from userid 425415) id 147F2AC5FA63; Thu, 6 Apr 2023 09:53:44 -0700 (PDT) From: Stefan Roesch To: kernel-team@fb.com Cc: shr@devkernel.io, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, david@redhat.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org Subject: [PATCH v5 0/3] mm: process/cgroup ksm support Date: Thu, 6 Apr 2023 09:53:36 -0700 Message-Id: <20230406165339.1017597-1-shr@devkernel.io> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: hf4e3umu6fag567z8fyzp3pizimwgz3d X-Rspamd-Queue-Id: B3780C0024 X-HE-Tag: 1680800038-9839 X-HE-Meta: U2FsdGVkX184NfMbY9UoG9hPk69r5qArUGEUYuEqROp5iKeR8+WzGlc7SvdPqbWJSGiylesaWiFqcB1WJzMg2VE85xicORzVVzL6Qz2suQ49OAT+YzexgXzTjscLJFvMJFBYzP2nlN9WxdFB5rFhPeE/XU2C3f9BPgCOoAPrhRQbCmuwoM6eYZTDmMPq2tgbBfWyT/uHjvaae1lvEUd2i99Dg8xydXnvQwnworhakxnKOY7T0BD8Ild+/h1smOAv/w8nBku+SJExWUTLctK5gK1QNI+9FDVftbmS5kgtzmEOCa+jgDC5J0fNCrVw8pY6AJKGOTC7Q2eD763+BaEkM4KJKdsdep/ELJ3px7RhUdILsfu1eCjOES6ANXYbb3Zmc2Rl7nTzbiVZADEtRB2e4tZkbFQlhB/5hB8vMapNiQ155KPjlVa3z6AbFNreVPhfrswXj2CvqLnh4h2288cqZgbFpdW0ZnhF0sk+vFeiiHZcnnriMG+3+zJc3otdbsWc+MPi8MKgkErEzvQCHOLD6LNxfKI/Dr+XlUMwZbZ5anLcL1uO/bqegD+M33yXp3DTRbO7fby92/l6QfmazSQil95zttpHRl62Cn3U24UWFXvIZNhS2Ujk80Qz9SwPr/FpL04+tbJ+CWQYiFcfWcGwOuERpvZLqbDoSP/nTJc1XXzAxtz8RWJp9w/HXkwcwzPhEUtZ4vWdQEMsDK/4xUEK61NRO6MNoN4R/wv5fvGjM7qlla6MP/y6/N5SUi3iEW0TeHxhO9UFZx18+WfiXv9CKon08EjPrTX/6IWj8NjfrA7MxuB3b8zAJA9hAWE78L3HNw+Q+dabINadnJVQpOOqmZQ8L3oF0dmUkWn9Kfuv27mgNbsqjrI0Mh8Qx9/lVhSI3YQaxKt9XprtLYfsyih7C9znWauvbvWntuZ8DTQxzgHmqd/wjRKjkbF0m/GN2W+DYE+HZOtmQXJP5SIqhAp L5Z9fkM0 eDbS1+C/OxdPzI/u4cEFfIrfG4gFmHMsAY0ICBeXLsHq0B2FnaaGZQUAj8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: So far KSM can only be enabled by calling madvise for memory regions. To be able to use KSM for more workloads, KSM needs to have the ability to be enabled / disabled at the process / cgroup level. Use case 1: The madvise call is not available in the programming language. An example for this are programs with forked workloads using a garbage collected language without pointers. In such a language madvise cannot be made available. In addition the addresses of objects get moved around as they are garbage collected. KSM sharing needs to be enabled "from the outside" for these type of workloads. Use case 2: The same interpreter can also be used for workloads where KSM brings no benefit or even has overhead. We'd like to be able to enable KSM on a workload by workload basis. Use case 3: With the madvise call sharing opportunities are only enabled for the current process: it is a workload-local decision. A considerable number of sharing opportunities may exist across multiple workloads or jobs (if they are part of the same security domain). Only a higler level entity like a job scheduler or container can know for certain if its running one or more instances of a job. That job scheduler however doesn't have the necessary internal workload knowledge to make targeted madvise calls. Security concerns: In previous discussions security concerns have been brought up. The problem is that an individual workload does not have the knowledge about what else is running on a machine. Therefore it has to be very conservative in what memory areas can be shared or not. However, if the system is dedicated to running multiple jobs within the same security domain, its the job scheduler that has the knowledge that sharing can be safely enabled and is even desirable. Performance: Experiments with using UKSM have shown a capacity increase of around 20%. 1. New options for prctl system command This patch series adds two new options to the prctl system call. The first one allows to enable KSM at the process level and the second one to query the setting. The setting will be inherited by child processes. With the above setting, KSM can be enabled for the seed process of a cgroup and all processes in the cgroup will inherit the setting. 2. Changes to KSM processing When KSM is enabled at the process level, the KSM code will iterate over all the VMA's and enable KSM for the eligible VMA's. When forking a process that has KSM enabled, the setting will be inherited by the new child process. In addition when KSM is disabled for a process, KSM will be disabled for the VMA's where KSM has been enabled. 3. Add general_profit metric The general_profit metric of KSM is specified in the documentation, but not calculated. This adds the general profit metric to /sys/kernel/debug/mm/ksm. 4. Add more metrics to ksm_stat This adds the process profit and ksm type metric to /proc//ksm_stat. 5. Add more tests to ksm_tests This adds an option to specify the merge type to the ksm_tests. This allows to test madvise and prctl KSM. It also adds a new option to query if prctl KSM has been enabled. It adds a fork test to verify that the KSM process setting is inherited by client processes. Changes: - V5: - When the prctl system call is invoked, mark all compatible VMA as mergeable - Instead of checcking during scan if VMA is mergeable, mark the VMA mergeable when the VMA is created (in case the VMA is compatible) - Remove earlier changes, they are no longer necessary - Unset the flag MMF_VM_MERGE_ANY in gmap_mark_unmergeable(). - When unsetting the MMF_VM_MERGE_ANY flag with prctl, only unset the flag - Remove pages_volatile function (with the simplar general_profit calculation, the function is no longer needed) - Use simpler formula for calculation of general_profit - V4: - removing check in prctl for MMF_VM_MERGEABLE in PR_SET_MEMORY_MERGE handling - Checking for VM_MERGEABLE AND MMF_VM_MERGE_ANY to avoid chaning vm_flags - This requires also checking that the vma is compatible. The compatibility check is provided by a new helper - processes which have set MMF_VM_MERGE_ANY, only need to call the helper and not madvise. - removed unmerge_vmas function, this function is no longer necessary, clearing the MMF_VM_MERGE_ANY bit is sufficient - V3: - folded patch 1 - 6 - folded patch 7 - 14 - folded patch 15 - 19 - Expanded on the use cases in the cover letter - Added a section on security concerns to the cover letter - V2: - Added use cases to the cover letter - Removed the tracing patch from the patch series and posted it as an individual patch - Refreshed repo Stefan Roesch (3): mm: add new api to enable ksm per process mm: add new KSM process and sysfs knobs selftests/mm: add new selftests for KSM Documentation/ABI/testing/sysfs-kernel-mm-ksm | 8 + Documentation/admin-guide/mm/ksm.rst | 8 +- arch/s390/mm/gmap.c | 1 + fs/proc/base.c | 5 + include/linux/ksm.h | 36 ++- include/linux/sched/coredump.h | 1 + include/uapi/linux/prctl.h | 2 + kernel/fork.c | 1 + kernel/sys.c | 24 ++ mm/ksm.c | 143 ++++++++-- mm/mmap.c | 7 + tools/include/uapi/linux/prctl.h | 2 + tools/testing/selftests/mm/Makefile | 2 +- tools/testing/selftests/mm/ksm_tests.c | 254 +++++++++++++++--- 14 files changed, 426 insertions(+), 68 deletions(-)