From patchwork Mon May 15 07:56:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13240935 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E55BC7EE24 for ; Mon, 15 May 2023 08:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E2AE280007; Mon, 15 May 2023 04:06:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67CCC280006; Mon, 15 May 2023 04:06:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BDFF280003; Mon, 15 May 2023 04:06:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1B1BE280001 for ; Mon, 15 May 2023 04:06:55 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EB160AF2E0 for ; Mon, 15 May 2023 08:06:54 +0000 (UTC) X-FDA: 80791758348.01.2727EE1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id E97F5C000F for ; Mon, 15 May 2023 08:06:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NfkvPcdW; spf=none (imf22.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684138013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=oaAnHSQUa44CIjEzLECo4Bz9k0HVG1DLxoBT0I79NeI=; b=bCwyLQubO9hG7xv+0Gemocj85Xuuux/JwOhlE22IJeWOxufB65OLyjRl8ff1k0+hzjmuKz Ymr2w3VHxQ4/EBVPnkcGKbkayMZzuoirGB0ACfcKmqQao8xaN+V+WPMmh10Sb1gd/55jSn P+BbeXZs4Oq7baPjmCrLLNeHDSrUi6w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684138013; a=rsa-sha256; cv=none; b=nIXpW6/mHC61TAIiTSnz+r31ySc5TbbDyJ0XY5JmTCmNR894zSfePcXcIvOr83kNTi5Zsf tYe9eKHKyUl0jUw2EINvmZYB+RhfkG0Gnlr0wEdDppkzddKrjw3fXupH87T3sakhP98PlG C09V2xLCzQu0vFLy53NP9mgE3CReZbE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NfkvPcdW; spf=none (imf22.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Subject:Cc:To:From:Date:Message-ID: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To:References; bh=oaAnHSQUa44CIjEzLECo4Bz9k0HVG1DLxoBT0I79NeI=; b=NfkvPcdWsJTjmoEQrA9fvkbzZc OLWjr4UU1kWvWf66uviIN6aqUIZ1bU0a8aEQPzT/ji1FUTxQToxV1V2kLh8dentwTx5nRMQ4vbB0i gIPkqOaBfpPHRlc4Q9v4DKGIZOs5zR693IMyllbhfUlUJPHFrv0sH5wUWWcgPRBAKgBI1lgDssb4e 9PWNLgpBVKQLGKCOHMSvDJkLwwQ85cxYADGoR5hXnOpJdsJmtsyLLYpk0hwzrXnE5x14WXOtUXAW9 mjJQ2i0rMf3kX9KquBpjBy/2GJyEk+TX/LIQwUBEiDSc3Rf/hALuWs5q5Nr/iPhIXqgtRSb4GdE7Z shGEbmvA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pyTDk-003HUQ-Em; Mon, 15 May 2023 08:06:17 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 079C030003A; Mon, 15 May 2023 10:06:10 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id A6A6E202F7F66; Mon, 15 May 2023 10:06:10 +0200 (CEST) Message-ID: <20230515075659.118447996@infradead.org> User-Agent: quilt/0.66 Date: Mon, 15 May 2023 09:56:59 +0200 From: Peter Zijlstra To: torvalds@linux-foundation.org Cc: corbet@lwn.net, will@kernel.org, peterz@infradead.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , Herbert Xu , davem@davemloft.net, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org Subject: [PATCH v3 00/11] Introduce cmpxchg128() -- aka. the demise of cmpxchg_double() X-Rspamd-Queue-Id: E97F5C000F X-Stat-Signature: 6qg8q5qi4mg8jzsd5h5hxfhwpkngimhu X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684138012-756309 X-HE-Meta: U2FsdGVkX1/17x+fEflCKAENGdIuBBEPz6kL5TRMO3KmDrYmNv9ZOYuWZC+8+8621KDFJIl7AjwuM/cJoU8QIwZFtCYqgJ+jjj6dSP22FGCQ85Vk+eCrmnA9Hr1ZHbpHlL2T3nUOnASo5GIknEvgY7qdzx5f5xCjxHGNmBcXYBVfmSjW/eudG3rVRW+/+n+hkrBO6lUOAT9oqyAHHfB9nammLRdovYWolYqZ7s4aAHzSGT1m6CXn7QEUH5WAZZmuKcqK748m0c5rYwY69zRySzj28gZzUrjfNdAPZ8EKFllcpwYPhn6zMr6FpckEOCa3j+N+B8Re6Ogyhrb/h+qnxoiSITxDhQcYkzg8NFSU9IAMu4g1WNvF6jfloPnbNKRC9B6vkKOKn3D/zOUk1Wzxrhs/hb0IPOgxNRHduriDIa4XQgQovQ0Ug0mBQjatIJvEMpiE/Lrg1Q1fLQ3yEpxIIq+l4iaVNLwXAfQ88zPE5gIAxLgNjivc8q1nN/9RWAhPGBVzqI3JT1Ep9ke8SaNi7M/CnN24cwv7eV50hRUViPpv114331BS1A9ghYpO9XtAA/ysSSUHx9d6SLHvQEE4nDObzjBq7Ox0aN+7C4Pe90/d7cTvDaXjxKzgzKveLDE6pqVkV7zkYIsksUVJG7Ntr3Z4M8OZxAEH/ZUaI4tlzDWGYfZyXq8ypTSaoTjx6c70NjY1QHptrhELXPiFF+3NaX/b9F7AtI2YivyBqlJW/MFEukGk+8ANe4JnzvVqUUdIwJmFDLE1liO6QGr3ARyjZAgNEqFjIwkxm1e1Wpig1jlhluKrU4/rY/CfVrzfCzsZ6hhCFCrcT0f2pE34mA0NvYyxLPI9viJleXhIB6GpFqPTcXYNEOjAeuUlWQ6UywPMkQfvrdclEAr/9o77+FY0K+b+9vh9ukiveGbNzvWO0P7KyEBidJpxWGRuZPD4XJjmj7gm0G+Yzd66jM7INu4 zOLZ7++y 1oUDNHRvqCUm8UYgzemyhA5OYXp8eoQODeKeeiapubRoocubO8NqKhlkog0bQdBfoXMy/rUA7Gdc740qLQssE55f3IpeWPXwgqLi2Pe+GWDzp2rZ3nL2+XZ2nxAinJ/mqQOUua2hng7Uv1WyjGQeuypVQ9IoZ3dmN+bWlE1ZXrKNoPb1a/0GLvF/qgUZlDtnvYqFerv32wtETngWoJlG83TzRjM0q3iXFmI/igvJWt+uJU37dnfHfzt5APCAmk2GaA9OF4QIyHr8f3LPbsBIuWRUo0N5rWUOcPN8mQQ8fy9SQToIis0Nms/lLCIEsj2hDOENu+t1Jx2/CoJ9B/u8HxAuYYtW+aWoFOInQXXYsP7rq0dyvhYE8pNlGNPSXVN5w23I3+SYY0yfUH/HWk/jWB+1p5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi! I seem to have forgotten to post this series last release; so here goes. I'm really hoping to merge it and forget about it. Since Linus hated on cmpxchg_double(), a few patches to get rid of it, as proposed here: https://lkml.kernel.org/r/Y2U3WdU61FvYlpUh@hirez.programming.kicks-ass.net These patches are based on 6.4.0-rc2. Available here: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git core/wip-u128 Since v2: - reworked this_cpu_cmpxchg() to not implicity do u128 but provide explicit this_cpu_cmpxchg128() (arnd) - added try_cmpxchg12_local() (per the addition of the try_cmpxchg*_local() family of functions) - slight cleanup of the SLUB conversion (due to rebase and having to touch it) - added a 'cleanup' patch for SLUB, since I was staring at that anyway Since v1: - rebaed on Eric's ghash cleanups (hence the cryptodev-2.6 dependency) - rebased on Heiko's s390/cpum_sf CDSG patch - fixed up a bunch of arch code - fixed up the inline asm to use 'u128 *' mem argument so the compiler knows how wide the modification is. - reworked the percpu thing to use union based type-punning instead of _Generic() based casts. Reviewed-by: Arnd Bergmann --- Documentation/core-api/this_cpu_ops.rst | 2 - arch/arm64/include/asm/atomic_ll_sc.h | 56 ++++---- arch/arm64/include/asm/atomic_lse.h | 39 +++--- arch/arm64/include/asm/cmpxchg.h | 48 ++----- arch/arm64/include/asm/percpu.h | 30 +++-- arch/s390/include/asm/cmpxchg.h | 32 +---- arch/s390/include/asm/cpu_mf.h | 2 +- arch/s390/include/asm/percpu.h | 34 +++-- arch/s390/kernel/perf_cpum_sf.c | 16 +-- arch/x86/include/asm/cmpxchg.h | 25 ---- arch/x86/include/asm/cmpxchg_32.h | 2 +- arch/x86/include/asm/cmpxchg_64.h | 63 ++++++++- arch/x86/include/asm/percpu.h | 100 +++++++++------ drivers/iommu/amd/amd_iommu_types.h | 9 +- drivers/iommu/amd/iommu.c | 10 +- drivers/iommu/intel/irq_remapping.c | 8 +- include/asm-generic/percpu.h | 66 ++-------- include/crypto/b128ops.h | 14 +- include/linux/atomic/atomic-arch-fallback.h | 95 +++++++++++++- include/linux/atomic/atomic-instrumented.h | 93 ++++++++++++-- include/linux/dmar.h | 125 +++++++++--------- include/linux/percpu-defs.h | 38 ------ include/linux/slub_def.h | 12 +- include/linux/types.h | 5 + include/uapi/linux/types.h | 4 + lib/crypto/curve25519-hacl64.c | 2 - lib/crypto/poly1305-donna64.c | 2 - mm/slab.h | 49 ++++++- mm/slub.c | 191 ++++++++++++++-------------- scripts/atomic/gen-atomic-fallback.sh | 4 +- scripts/atomic/gen-atomic-instrumented.sh | 19 +-- 31 files changed, 667 insertions(+), 528 deletions(-)