From patchwork Thu May 18 11:07:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13246482 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A60CC7EE22 for ; Thu, 18 May 2023 11:07:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9215900004; Thu, 18 May 2023 07:07:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A427E900003; Thu, 18 May 2023 07:07:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9322D900004; Thu, 18 May 2023 07:07:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 86732900003 for ; Thu, 18 May 2023 07:07:41 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5EB79140793 for ; Thu, 18 May 2023 11:07:41 +0000 (UTC) X-FDA: 80803100322.07.39F3558 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 6757E40019 for ; Thu, 18 May 2023 11:07:39 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684408059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=nM1RfkieUUw/+R1a5EL0kfVtnQnHLyPCkHqfiwjArQI=; b=DLy3/IQVs9kzWmLqWvHKl82O0AEpp1nc8ZGhBV359u5OZfpPsBfHXZ2dkMerQbEtDCTiam pG3v1Tp/MSUC1ycqPAzOPozpzutpx3U/MtZH8Auxs+/WxpK1fYT5oZX1v7ZYUYrUTm+gUJ qWsqml5gkJyr3LWn1WUsQO/VLGBm04c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684408059; a=rsa-sha256; cv=none; b=Ws7HLI695Xg0jUaB/sktDCg6w6rvmzvQ7qmIqrnq6yi057c6vSfTQ9mkNmDgdAfIJVTjUW v0cnLIdqSCtmrj+fnzVfeOzh1dULWP0HWYfdI/ZpZHEyNKfcOHBnU7A9gZYKRVLzTOmAHd xsyN8YWnH5tI7H+lkynurOm6QE7+9Qk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBDF81FB; Thu, 18 May 2023 04:08:22 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 91E4D3F793; Thu, 18 May 2023 04:07:36 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , SeongJae Park , Christoph Hellwig Cc: Ryan Roberts , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Lorenzo Stoakes , Uladzislau Rezki , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev Subject: [PATCH v2 0/5] Encapsulate PTE contents from non-arch code Date: Thu, 18 May 2023 12:07:22 +0100 Message-Id: <20230518110727.2106156-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 6757E40019 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: mes43iw3o35igbadstdbie3943z9xxip X-HE-Tag: 1684408059-907468 X-HE-Meta: U2FsdGVkX1/DaXT967/r/gnc2KBaS76W5mzcLaG7Ihwkx4DoeNPHAt/ECtz8+kXB5L1H4wbwZ4PQhMZKYI+hZSLSV+EPIjheZL0FQeN6JhtcoU5kqzc4RNvCZw4dFB1Nn3KTexHjxFa14KwOdekejixa1yzG/ZhgCPZwA3ZDdlrWSZ56CPnX9y4IJLvS63HmUi7tHueRncGXjISX0xg6ndvVqz8302eRAGwZdkKd85wZOmOURqc1OMbz3KVf/8Ayi1ogBglWvx/Is7976Z1kX9tT8qPe1BFeEOu5TXZebloC7pDN5bOwohjq9fehSutXXiRLL0o+UF++oO7B7EsOi1PUjyyzgFNpyz70G/N5DrVCkL+w5vLzGSut5ARdBP9IyNoOYgsnYU8MvtSzJa2II9F10XnI/FUCn5iApIfhBmaK8JsApsltXSggrJ1qCQb+2tmJDSl/WUS9YlmPk/qvYu6+M3AyljkDvOWCChWjVyvo3GgjjSm68r/i5xasrz2ankUBpUOViOymmskd0/XhFeAd383u2OSygmP+xjZMUbLwmMis4r1Ym8aSx18BPRzYsH08pXDc4J66VYX0B5rRRQFMtuuJcFtVvlfetXmIBUUeFubkTZ4Ak/WWB3r4tSUPOlnws7lsHwXE6jihr8AyXkwwsblVTu4SA0sYC2c52cZIho+rOkK/CbzjvHDFX23w5znkTgUhT8zLJ0bb+cM5LS8zkdveshrjRwbWecdquN7J3W9ZswXms3BLotCY8RbnqlnBh1AIxKYSazgTIgYYNPEFKG0jKtfT8F22ao7ou4XE74OdzUubFPLBnYCsnViAh87Nk4IsXs20MeSkVf4JPAtm5pwPxsKYw6sdALoHokt9mPKEMr87XQ3/zxQPG1Y7PymGwBcUwl2zG1tmKcV+XibK/r8fu0+e79+yOQ6OETgwDUdYtUsI7Nljh1Oh1JwvFNDbvDTC0MT0GQGz3ry O9y1M7VM +GO/xdXPLSsFUVH2+oEjU5G1A9dEsX0pYvryee7HYghM51kg01yy1d9/bCtdk81MOE1q5e2NQHCc2P1QXepF3LtKXDu0m9Q1GAY05WSK0WhjRqMGAct3woyhizSYu552VGHBUs2PH8+b4tcI1OK8Bp0mGqRYH3oJmtL76g+RQtcGp7rMmOYz9u5s61xLWo5H0PQH44eg7zlUFuBWxAZa8Ry6zld5B84AY2Vz0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi All, This is v2 of a series to improve the encapsulation of pte entries by disallowing non-arch code from directly dereferencing pte_t pointers. Instead code must use a new helper, `pte_t ptep_deref(pte_t *ptep)`. See the v1 cover letter at [1] for rationale and explanation of approach. As with v1, the series is split up as follows: patchs 1-2: Fix bugs where code was _setting_ ptes directly, rather than using set_pte_at() and friends. patch 3: Fix highmem unmapping issue I spotted while doing the work. patch 4: Introduce the new ptep_deref() helper with default implementation. patch 5: Convert all direct dereferences to use ptep_deref(). Patches are based on v6.4-rc2 and a branch is available at [2]. Changes since v1: - patch 5: Fixed sh build bug reported by 0-day CI - patch 1: Refactored pfn to use local variable - patch 1-2: Minor rewording of commit message: 'verify' -> 'check' - patch 1-3: applied Ack/Reviewed-by tags; thanks for those! [1] https://lore.kernel.org/linux-mm/20230511132113.80196-1-ryan.roberts@arm.com/ [2] https://gitlab.arm.com/linux-arm/linux-rr/-/tree/features/granule_perf/ptep_deref-lkml_v2 Thanks, Ryan Ryan Roberts (5): mm: vmalloc must set pte via arch code mm: damon must atomically clear young on ptes and pmds mm: Fix failure to unmap pte on highmem systems mm: Add new ptep_deref() helper to fully encapsulate pte_t mm: ptep_deref() conversion .../drm/i915/gem/selftests/i915_gem_mman.c | 8 +- drivers/misc/sgi-gru/grufault.c | 2 +- drivers/vfio/vfio_iommu_type1.c | 7 +- drivers/xen/privcmd.c | 2 +- fs/proc/task_mmu.c | 33 +++--- fs/userfaultfd.c | 6 +- include/linux/hugetlb.h | 4 + include/linux/mm_inline.h | 2 +- include/linux/pgtable.h | 13 ++- kernel/events/uprobes.c | 2 +- mm/damon/ops-common.c | 18 ++- mm/damon/ops-common.h | 4 +- mm/damon/paddr.c | 6 +- mm/damon/vaddr.c | 14 ++- mm/filemap.c | 2 +- mm/gup.c | 21 ++-- mm/highmem.c | 12 +- mm/hmm.c | 2 +- mm/huge_memory.c | 4 +- mm/hugetlb.c | 2 +- mm/hugetlb_vmemmap.c | 6 +- mm/kasan/init.c | 9 +- mm/kasan/shadow.c | 10 +- mm/khugepaged.c | 24 ++-- mm/ksm.c | 22 ++-- mm/madvise.c | 6 +- mm/mapping_dirty_helpers.c | 4 +- mm/memcontrol.c | 4 +- mm/memory-failure.c | 6 +- mm/memory.c | 105 +++++++++--------- mm/mempolicy.c | 6 +- mm/migrate.c | 14 ++- mm/migrate_device.c | 14 ++- mm/mincore.c | 2 +- mm/mlock.c | 6 +- mm/mprotect.c | 8 +- mm/mremap.c | 2 +- mm/page_table_check.c | 4 +- mm/page_vma_mapped.c | 26 +++-- mm/pgtable-generic.c | 2 +- mm/rmap.c | 32 +++--- mm/sparse-vmemmap.c | 8 +- mm/swap_state.c | 4 +- mm/swapfile.c | 16 +-- mm/userfaultfd.c | 4 +- mm/vmalloc.c | 16 ++- mm/vmscan.c | 14 ++- virt/kvm/kvm_main.c | 9 +- 48 files changed, 310 insertions(+), 237 deletions(-) --- 2.25.1