[V2,0/6] mm/vmalloc: Assorted fixes and improvements

Message

Thomas Gleixner May 25, 2023, 12:57 p.m. UTC

This an update of version 1 which can be found here:

  https://lore.kernel.org/mm/[e-mail]

Following up to the discussion about excessive TLB flushes

   https://lore.kernel.org/all/87a5y5a6kj.ffs@tglx

this series addresses the following issues:

  1) Prevent the stale TLB problem related to fully utilized vmap blocks

  2) Avoid the double per CPU list walk in _vm_unmap_aliases()

  3) Avoid flushing dirty space over and over

  4) Add a lockless quickcheck in vb_alloc() and add missing
     READ/WRITE_ONCE() annotations

  5) Prevent overeager purging of usable vmap_blocks if
     not under memory/address space pressure.

Changes vs. version 1:

  - Coding style issues
  - Remove unneccesary force_purge arguments
  - Amend changelog of 1/6
  - Pick up Reviewed-by tags where applicable

Thanks,

	tglx

Comments

Baoquan He May 27, 2023, 10:21 a.m. UTC | #1

On 05/25/23 at 02:57pm, Thomas Gleixner wrote:
> This an update of version 1 which can be found here:
> 
>   https://lore.kernel.org/mm/[e-mail]
> 
> Following up to the discussion about excessive TLB flushes
> 
>    https://lore.kernel.org/all/87a5y5a6kj.ffs@tglx
> 
> this series addresses the following issues:
> 
>   1) Prevent the stale TLB problem related to fully utilized vmap blocks
> 
>   2) Avoid the double per CPU list walk in _vm_unmap_aliases()
> 
>   3) Avoid flushing dirty space over and over
> 
>   4) Add a lockless quickcheck in vb_alloc() and add missing
>      READ/WRITE_ONCE() annotations
> 
>   5) Prevent overeager purging of usable vmap_blocks if
>      not under memory/address space pressure.
> 
> Changes vs. version 1:
> 
>   - Coding style issues
>   - Remove unneccesary force_purge arguments
>   - Amend changelog of 1/6
>   - Pick up Reviewed-by tags where applicable

The series looks good to me, thx.

Reviewed-by: Baoquan He <[e-mail]>