From patchwork Wed May 31 13:08:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Zijlstra X-Patchwork-Id: 13262286 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF30C7EE23 for ; Wed, 31 May 2023 13:28:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E29448E0006; Wed, 31 May 2023 09:28:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D286B8E0007; Wed, 31 May 2023 09:28:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F3DF8E0001; Wed, 31 May 2023 09:28:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 87A638E0002 for ; Wed, 31 May 2023 09:28:01 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 490528013F for ; Wed, 31 May 2023 13:28:01 +0000 (UTC) X-FDA: 80850628362.04.62DFA6C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id A80CDC001B for ; Wed, 31 May 2023 13:27:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZCaN9EKW; dmarc=none; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685539679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=wcJJV24VbYlY1PWzzae048ORvkrTfGMOvTB+4LRdIko=; b=UrQwITStUJZxnTeDhpLPSWa9NJ0gqt6Ks5YlSm/4Y+cRST+piAxlWgDpGZ0VnNiAHSMIKr MaYPnQfjRtE6HxC085L/7LW8FRiCRQdl++DIsHlZ9PU3WskCb19fb5lmYv1JDCqAFR5N7q 1BHLimHX6k2zJCquEwk/5ECTzD78VyY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZCaN9EKW; dmarc=none; spf=none (imf10.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685539679; a=rsa-sha256; cv=none; b=BL3CGTnHbBpwvOFacz9H3MByM+iWnGXHV3btZSFf24lHgkCZIlRI2F0wAkpCTF93WeyTsJ nKgNinuuEesS8crB8M0jWochS8VKtJlAxcSHqjXCMCFw0GitBNI3c0pw4aD2Qi8ObNnHs+ G8RFBxLXkXNxJuaei3eFl6HsmThOXFM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Subject:Cc:To:From:Date:Message-ID: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To:References; bh=wcJJV24VbYlY1PWzzae048ORvkrTfGMOvTB+4LRdIko=; b=ZCaN9EKWJgEkcuGgxM/ADbx94M G03dV6vMZ01SeuX4XeUD/ST9pnnkWJlhFyUn36PeSTx4HwZLOaV1Un1/UIQdwmGQcFJy5ke1y1ph0 4gI+sbIacF5Qi2XhKT65K6WXemSMLSlsiRy1sMyJNOgV1Tn8vRmRMUZmDLnUwZq+cghRKjKS3YSq2 nov0q53CxHjOQ380s4gPZqDiXzc10/7e5vnGZl2HdRLxV+I+eL6nN6JB7wWpO5iWlxdh7Qc4sUzGU t/I0z4d02H+1QiGZjucBz1TMMe0a61V9LL4YUcCfUju21PcwS5g76pVkW0OKG7aSE+R6CkRgnDmL/ hrab2zKA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1q4LrG-007IIj-33; Wed, 31 May 2023 13:27:22 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 03CEF30074B; Wed, 31 May 2023 15:27:16 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 7798E243B69E6; Wed, 31 May 2023 15:27:16 +0200 (CEST) Message-ID: <20230531130833.635651916@infradead.org> User-Agent: quilt/0.66 Date: Wed, 31 May 2023 15:08:33 +0200 From: Peter Zijlstra To: torvalds@linux-foundation.org Cc: corbet@lwn.net, will@kernel.org, peterz@infradead.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , Herbert Xu , davem@davemloft.net, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, sfr@canb.auug.org.au, mpe@ellerman.id.au, James.Bottomley@hansenpartnership.com, deller@gmx.de, linux-parisc@vger.kernel.org Subject: [PATCH 00/12] Introduce cmpxchg128() -- aka. the demise of cmpxchg_double() X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A80CDC001B X-Stat-Signature: 8ya541c1d1yu1eb9te8ak6hincatpg1q X-HE-Tag: 1685539679-286316 X-HE-Meta: U2FsdGVkX19oaMvVnJkhB97XrdJrAHfwFdCnjbkDPvZkCX03evEPdIGowSQeuWJoow91IrkbYm3FUSS3b6W+JhbOSCFc2LV7Z1/s+4gj3qpF4LDoEZHIULaIanGEFxaFyf1gNlIo8ZlGGZn62mf+cbPFAyjrYHIozfkMvnqo3o2eHWl4KQIZcXG7yvKPGEbvY8LD9BecbS43cpAnAACx+EOCnMfblz1U+rpAAbu5/0qEYUt3Qmo/zpqs6DdKsJNY5Z+CJnJ0YJDEcip4rpy9Zl/vwnq4Twfh1Rj1boYNrPxWRUuLOJzcsAWBXWfOSPAf5DtzR9eRvWw3xtUtKEVw2rDSiPq+a2MPhekIafxLqITScuYHN00jNC5P7PWIKXF2qg0vgkPzT8EGU/mM40tMe7l6nGpf/HI+Rx35un8XWzKi9lD2A/Zb7bvJEpTwWcDnJMPBUST8GcyypTM+whxlgXHfumfSCQKIv0SkJTF8r/YXwATTyMRzdOZOIAmYph0Wf+QlW1KxwZheX1vX6sB2MdKnl3RKWq5e4dA6aFd4whYSRu8jSBJ4l0PZddizGyHYiau0wzRdoKNfbXO27DKzgfBKDOtmBwMYhEgOefHYu2DvekzB8dfEPbx4yjmzfgpIfE78OiLAAsEvG4eYbI2tjVKnmiy1rTogGi2b5xBHfeyqe21FjDek7azNEhCmOxXJZAR3V6pLKuQ17FBObNRUAkOr+koi9lJ41ZDmHF7q66UTaFm5TZIswdEITmPP8Ixla8b1eX/Unmp4fbZZbgMtgKPpYNZjk5iVLEAaw8I9LQ6Y747zbr6aOvU+JUxqqfftBaEDqDWnYy79nQF3xbovWUY1WfEv04X5rKXIuu8JkBdgu4nz7hbFF70k00kGaiTEDrmLhA2Yd42/6rlk0I8mhc6ZgFfv7hLC4YJzFcpBXwCOein04G0r6GKopzb/iTVUe3H4Q/HS1XJuesVupkH /3ddecgt EsSMyoysU8Swj41e6talYoMIGZcLRfqUqzRBcYrEZbpO0KSmC/nfO721WlV9jPOoNdBZQmfqubrJFWA6PGyqw2Of9zRn5u2T4I65guCvIqoN6snBgg9vtxdY01SP84W4+ptDmqn5mDuzRbXG9nF1qBnb/QVQ958yYTYJ+47E9H8qEwldBPWnDRxFu0uWKeUXup4FATnvnrB32O97obJkjkTSTamtxg9ugGrNeAsxz5onXt7iwQTFI1YCtMWBFvG+QXiaYSSCvPhuWsvX+T0jKc44LI/LkpgohgmjCMMlcmrhy/pjdaGXy/x6nqWaoqoSDzoEIYMIB/xbdLZWheFWs2AuOGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi! After much breaking of things, find here the improved version. Since v3: - unbreak everything that does *NOT* have cmpxchg128() Notably this_cpu_cmpxchg_double() is used unconditionally by SLUB which means that this_cpu_try_cmpxchg128() needs to be unconditionally available on all 64bit architectures. - fixed up x86/x86_64 cmpxchg{8,16}b emulation for this_cpu_cmpxchg{64,128}() - introduce {raw,this}_cpu_try_cmpxchg*() - add fallback for !__SIZEOF_INT128__ 64bit architectures Sadly there are supported 64bit architecture/compiler combinations that do not have __SIZEOF_INT128__, specifically it was found that HPPA64 only added this with GCC-11. this is yuck, and ideally we'd simply raise compiler requirements, but this 'works'. My plan is to re-add this to tip/locking/core and thus -next later this week. Also available at: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/core Reviewed-by: Mark Rutland Tested-by: Mark Rutland --- Documentation/core-api/this_cpu_ops.rst | 2 - arch/arm64/include/asm/atomic_ll_sc.h | 56 +++--- arch/arm64/include/asm/atomic_lse.h | 39 ++--- arch/arm64/include/asm/cmpxchg.h | 48 ++---- arch/arm64/include/asm/percpu.h | 30 ++-- arch/s390/include/asm/cmpxchg.h | 32 +--- arch/s390/include/asm/cpu_mf.h | 2 +- arch/s390/include/asm/percpu.h | 34 ++-- arch/s390/kernel/perf_cpum_sf.c | 16 +- arch/x86/include/asm/cmpxchg.h | 25 --- arch/x86/include/asm/cmpxchg_32.h | 2 +- arch/x86/include/asm/cmpxchg_64.h | 63 ++++++- arch/x86/include/asm/percpu.h | 102 ++++++----- arch/x86/lib/Makefile | 3 +- arch/x86/lib/cmpxchg16b_emu.S | 43 +++-- arch/x86/lib/cmpxchg8b_emu.S | 67 ++++++-- drivers/iommu/amd/amd_iommu_types.h | 9 +- drivers/iommu/amd/iommu.c | 10 +- drivers/iommu/intel/irq_remapping.c | 8 +- include/asm-generic/percpu.h | 257 ++++++++++++++++++++++------ include/crypto/b128ops.h | 14 +- include/linux/atomic/atomic-arch-fallback.h | 95 +++++++++- include/linux/atomic/atomic-instrumented.h | 93 ++++++++-- include/linux/dmar.h | 125 +++++++------- include/linux/percpu-defs.h | 45 ++--- include/linux/slub_def.h | 12 +- include/linux/types.h | 12 ++ include/uapi/linux/types.h | 4 + lib/crypto/curve25519-hacl64.c | 2 - lib/crypto/poly1305-donna64.c | 2 - mm/slab.h | 53 +++++- mm/slub.c | 139 +++++++++------ scripts/atomic/gen-atomic-fallback.sh | 4 +- scripts/atomic/gen-atomic-instrumented.sh | 19 +- 34 files changed, 952 insertions(+), 515 deletions(-)