From patchwork Sat Jul 29 20:37:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13333212 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3912C04E69 for ; Sat, 29 Jul 2023 20:37:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 341D98D0003; Sat, 29 Jul 2023 16:37:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CB158D0001; Sat, 29 Jul 2023 16:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 192808D0003; Sat, 29 Jul 2023 16:37:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 094E18D0001 for ; Sat, 29 Jul 2023 16:37:42 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D953FA0828 for ; Sat, 29 Jul 2023 20:37:41 +0000 (UTC) X-FDA: 81065810322.01.B574CD6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 47FD9140005 for ; Sat, 29 Jul 2023 20:37:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vFJySY2r; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690663059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=+M3szxC5muvMWv6IZ2SXnfOddkpsna/oNeqrTerUHnQ=; b=LQjrsNUwhXP+ixl7vXGnkdFuKnoqeYqSfRlSgpnqyTq8cPXU9fipfAFEDvgHDeE6WtdfZV kppqmUjD/oHo0DNnA2NekSdOwDeOHselRKr33/guCIQuaIJuRkwdfRAr7hzjvM++oIf6gm nspmGO54TjdYjKWRH1/+Ze+3ZBDSejU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690663059; a=rsa-sha256; cv=none; b=lcZhddbj3ovYOhdpgR562C6YGh4bTndRkdu9CMH7u+rirMJANP+/ausAL//N1NqjH1B24N mqtaO8a5nSP27CO+MgNyvCi+pZqrHESO6n7lXggcT36qtD5thVQdYrVn29fTOYqzPACySF WFWMc7fl2QCLObIj6Hgqf+A5xzJR2Xs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vFJySY2r; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 425D46066F; Sat, 29 Jul 2023 20:37:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8B73C433C7; Sat, 29 Jul 2023 20:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690663057; bh=iMknI2mssvMpvNEEtPFsjpKnh0+OEHxOEdyJZpeCgHY=; h=From:To:Cc:Subject:Date:From; b=vFJySY2rk1//Bkt9H41fBKeJvOhjKt9m7pNLfcYd/YbXNoDwBUj2HavpAFun6VP8b fpqIbkQKa9JyY+9FArMVz3l5JUe+ji6L2OwZA4tOjXV8DBcT53kkP+kdJN+7rnGOgJ OHMq25YIkjtAIVhX71U9KccUySxnQwKh+gOANdDqlB+MqQ2dzQ9CwGpfpDGTdumfsq yVynLsLCQiJ3nHfOvA3dswClNDRjCrA4gGnrJ1mf5h5HnSXLHqmKThXGFP4U9BVWgG XP18+zQi8wTYIR2MG3bVK9SM43+WIrj2jk9NogyN69sz8qGzCSgQOHGmuOiqiWslzu Nq/Xps6fD3aVQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Brendan Higgins , damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] mm/damon/core: fix unitialized memory error from Date: Sat, 29 Jul 2023 20:37:31 +0000 Message-Id: <20230729203733.38949-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 47FD9140005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: q45inn64kjz6t5zybjxknap9i4qxafrr X-HE-Tag: 1690663059-441921 X-HE-Meta: U2FsdGVkX18wHKYSqo/8PFv5sTFWOP5xSKihEdlk7w9jkQOusxraoOH5aAiXRZVY6of+s1kwSzr7BwWOKggP3TVSd5ntxGjak2kgeURrUyK7FsHTdsGs6koW7IXcAwEKtIajqq9R2KfeXM7wTi8Oeuz31dlhKeM7ZboN3hse2BnA0f+zFUQicZKHXJlSCX/qmKnNtu5riL6XAII242+Qn7PX9pWAsfi+oKoPIuXAjVEOSu08kdX56ywe0lRr5DWZWXFzaFIdyzhfeZOWh0GoZbIMV9s2kqrz3SR2SotMeytNMOe/9n5gNmm3K8RUtE7x64aqcBsybUPmNcD4mDP5n6NT5sfCABrcYn6BIM7W/06ilwiykKUFqlenhU64TmYHv+txsxxiwN/g5GEgRyI1CMNN1SM/trOfbBnJtc+pwXLbMVjT5MksKHcF/wYvApY93arL4Fsg2BxGp54w616c/6N5DWlyGvWD1OJKxAYfFVoxxytn4jHAt5B1NYII2j4ioyiLBUlWzVbm2qUz/xOx0C9mxERascwnCC/XbBIg+AvGsedAqvX5oBPklQgvA8AbafatDaQ8W4Zl4hdTMo7mYez/mYuZHiUIyEhgiX3FbLSg/ZdYN6K7W2tFqRhMoxZnHh7LFjaQUdX1//1pCUcAR6ovSrnNJnbi73mb/9XNvd1QKSbu2topR8ev0rIO+oxjeZQZhmIlv1lq8L/fRwm6byXKuH2honoBgeXmzX5UwwSMJ+MXlB94p16WcHLM6W9YFNKJYYnBK+BDTZEF3facLaYeGK8v0+rBHSNe7sCKVgYhZKbxkCSlxmZYxGZKhlkaRt115zsPFiWG5EtX4e/cAcVSjaz37b4BQg60fERJ5uZfAsNhj2dIuS4Cl8PndlJd1OuxCICg3xtZoIwL8B6WVnfC70/Ht1+7YgIfEaL24gMFM+wu3RlBq3tYWOoTAkSYSXXpAYNYniumnMuvdrZ fKmrx3Uf 4yQg351J0l3Y2xOLqnw6v/88VCGaJKqPmx57+fbX8iFo6xZMYLcdeNNzrUD4akaFOYoC5Qv1M/8O30pGfrTSzW4GZn1woER3/2K1kCGDn+fsrdQ/K6zNbelMiMxrDBCwXVrhSoht+sTPZRz6rjBE5mXkQUZgk2qIABJCjBDJipKwNUSH3haK3Un1pqLOEQqfGcKjAVbGPG75HTpp8iHNBc8hwyFaN5aKh+pkKozsDdH7WjqKO0OaRn59zpcwppAcOoTRSZ+w2ECvd0eQBAtVqQmqblUvf1FYpUfDQ13WWAVczI+bC535ykn4IvqpjaTszd/KOSAzCAM2o9gueZEtSj78jdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: damos_new_filter() is returning a damos_filter struct without initializing its ->list field. And the users of the function uses the struct without initializing the field. As a result, uninitialized memory access error is possible. Actually, a kernel NULL pointer dereference BUG can be triggered using DAMON user-space tool, like below. # damo start --damos_action stat --damos_filter anon matching # damo tune --damos_action stat --damos_filter anon matching --damos_filter anon nomatching # dmesg [...] [ 36.908136] BUG: kernel NULL pointer dereference, address: 0000000000000008 [ 36.910483] #PF: supervisor write access in kernel mode [ 36.912238] #PF: error_code(0x0002) - not-present page [ 36.913415] PGD 0 P4D 0 [ 36.913978] Oops: 0002 [#1] PREEMPT SMP PTI [ 36.914878] CPU: 32 PID: 1335 Comm: kdamond.0 Not tainted 6.5.0-rc3-mm-unstable-damon+ #1 [ 36.916621] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 [ 36.919051] RIP: 0010:damos_destroy_filter (include/linux/list.h:114 include/linux/list.h:137 include/linux/list.h:148 mm/damon/core.c:345 mm/damon/core.c:355) [...] [ 36.938247] Call Trace: [ 36.938721] [...] [ 36.950064] ? damos_destroy_filter (include/linux/list.h:114 include/linux/list.h:137 include/linux/list.h:148 mm/damon/core.c:345 mm/damon/core.c:355) [ 36.950883] ? damon_sysfs_set_scheme_filters.isra.0 (mm/damon/sysfs-schemes.c:1573) [ 36.952019] damon_sysfs_set_schemes (mm/damon/sysfs-schemes.c:1674 mm/damon/sysfs-schemes.c:1686) [ 36.952875] damon_sysfs_apply_inputs (mm/damon/sysfs.c:1312 mm/damon/sysfs.c:1298) [ 36.953757] ? damon_pa_check_accesses (mm/damon/paddr.c:168 mm/damon/paddr.c:179) [ 36.954648] damon_sysfs_cmd_request_callback (mm/damon/sysfs.c:1329 mm/damon/sysfs.c:1359) [...] The first patch of this patchset fixes the bug by initializing the field in damos_new_filter(). The second patch adds a unit test for the problem. Note that the second patch Cc stable@ without Fixes: tag, since it would be better to be ingested together for avoiding any future regression. SeongJae Park (2): mm/damon/core: initialize damo_filter->list from damos_new_filter() mm/damon/core-test: add a test for damos_new_filter() mm/damon/core-test.h | 13 +++++++++++++ mm/damon/core.c | 1 + 2 files changed, 14 insertions(+)