From patchwork Thu Aug 10 14:29:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13349525 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87172C41513 for ; Thu, 10 Aug 2023 14:29:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04FDD6B0071; Thu, 10 Aug 2023 10:29:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F41896B0072; Thu, 10 Aug 2023 10:29:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E094E6B0075; Thu, 10 Aug 2023 10:29:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D1D666B0071 for ; Thu, 10 Aug 2023 10:29:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 55B18A08CD for ; Thu, 10 Aug 2023 14:29:56 +0000 (UTC) X-FDA: 81108429192.26.7BD9C00 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 3B28040003 for ; Thu, 10 Aug 2023 14:29:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691677794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=Cdc1/uEPu03BW2OxWBmJg3A9OXUj+zEHDujvIVOwFXU=; b=ct0Unm7Qk6/tpgQ6VtLaSTZbS16SqNXNQ/hABmtBobISxGbiLeE4wQ5motpAPyZKVE78vJ QXxUdhU4HUSG4XgSXzl94KlNPm4JUsoojc9QCfpP+Axh5j+0NJ3rbBfX/ab3AIG7kGhZZa 6X/KxaieYsSEwr7VF+g8zA2wcOG6FQI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691677794; a=rsa-sha256; cv=none; b=5PPbhLSuqM0QpZjw76Faac0Se2sHtS9arCwGAUUXpQWviv8WoR0JPs/k41D1IbTD1Thwj9 nJWbtyfTJBaX+r0x1OlfN+O5YLa3L75kkHrsosJZMT7G6zQDG+96RPEqbPeNYp78HczSOH f27B7iM0+PZAg9G0McRXf5nzU5+6e8g= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D555D75; Thu, 10 Aug 2023 07:30:35 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8E2083F64C; Thu, 10 Aug 2023 07:29:50 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , Matthew Wilcox , Yin Fengwei , David Hildenbrand , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" Cc: Ryan Roberts , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 0/5] variable-order, large folios for anonymous memory Date: Thu, 10 Aug 2023 15:29:37 +0100 Message-Id: <20230810142942.3169679-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3B28040003 X-Stat-Signature: t7hcbrofukkeco9hwrpjes3eqz6d8usn X-Rspam-User: X-HE-Tag: 1691677793-843008 X-HE-Meta: U2FsdGVkX1+usmAniZOoPamTllFbiaZcTniXWJr/ob2I+lwUkjsh+eThfhNBXF9oEn2tUkG/rv+7IV/dkZ4Ko9GTFf3eu274yx1HmlHQ61OVlyoE9iraYc2Ft0kScyt71AQxiHFmprjRa//9K6koPRJx8Y4RMI1mnwIbHVQk5EqjLkPRe5w3UfxMn//gSVPJlVbh7exS9EIMNSHAmh1Ry/Qy+jAWPGhueO28ZjdmI+WxEuJykXYQ32YrZv43EhJLgtioHbiwku9HJqOVwQn4KKiSfcOGIw9sFYazbqABj4RiHfNGwL+c8bW5K51gsskZdnfZXS2BOS/GoQQ2IFH5oOjQgNX+Ygx2+RIdeFrnQF4A3F3gMSyGbrIsyOme12YHPzkrICoZL/40WipddGmjye/aFL+qgEyDomPSlHT9HITcUmoZHXJpG8dXKU8YKwTrQH7bgp00T9j0MwGXn4sSTfGyCCaU+qH4l9cuVHImEME9iDF0gLJRbon3D+M0W8QnvtCXMfkz1EYUO+PkzgcFzX2Ae3YdBr0ISIOsYpjv/06c/2PNy7TAIAYaUpbNGxprFgakTeIdqb8gjuMYFfzvPRSvmDW8yoXpUyGRo+zioQfkoF9CtXds05H5o78vfvaPmA2aHSa5+VG2JHbBR6AM9Z+CVVHRRpcMmKmqyayHbt82FO2hujYAogbmZcmozk7oQfP5cihEE0CWGdrXdy0W+veE0KP3WjkrQEY7dIAAUCq25+nfd+XeFKBTc0bC8jcUB1c5MmWqN3m88rE23BYORsxfINOKwYDDlaxjNhb/veCQld1UYnaRiMLl6aSrOEkkKV9KkZ44EcIwR3xJRCRVrrTj/lwjO6Y2CSKATi3czrFTDIR840lyLxckx8JJayRySEOlEkRkS96dodp+q6QtOlwQfktm6iUUZb7j1aK20VSmIE0p0iqDZE9vcCNohbXBci/o+NtIRuBLuS2siSj wKe4khU8 W8hhSYsg2guvzozpNAUA3PylnYqZnP4mC/+5v0/rRs3Gos85Z6ip1Leb+P33MnFx/nYW2O/O70k8ODSc6hjt/CZkeSD2+fZE5C5hBe3vkHiIx5Hsha9WyE/MSYfmo9B+bz4EKoZ/iRgbXkjaa6FqP0PoqzD0dFP10vu2/x1FTWlXWm6dfxjSXjm4ke7DmGbrVLHtfEEXcPgt5ZUPXjkxR763iNmM3BN1q93ZLBUZTgIeVZ7S2CYZ9qdsWQOlmCQ5+ceSYMA6yDRzjhEJK0NrjRZXe8RIdv6FSxJBH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi All, This is v5 of a series to implement variable order, large folios for anonymous memory. (currently called "LARGE_ANON_FOLIO", previously called "FLEXIBLE_THP"). The objective of this is to improve performance by allocating larger chunks of memory during anonymous page faults: 1) Since SW (the kernel) is dealing with larger chunks of memory than base pages, there are efficiency savings to be had; fewer page faults, batched PTE and RMAP manipulation, reduced lru list, etc. In short, we reduce kernel overhead. This should benefit all architectures. 2) Since we are now mapping physically contiguous chunks of memory, we can take advantage of HW TLB compression techniques. A reduction in TLB pressure speeds up kernel and user space. arm64 systems have 2 mechanisms to coalesce TLB entries; "the contiguous bit" (architectural) and HPA (uarch). This patch set deals with the SW side of things (1). (2) is being tackled in a separate series. The new behaviour is hidden behind a new Kconfig switch, LARGE_ANON_FOLIO, which is disabled by default. Although the eventual aim is to enable it by default. My hope is that we are pretty much there with the changes at this point; hopefully this is sufficient to get an initial version merged so that we can scale up characterization efforts. Although they should not be merged until the prerequisites are complete. These are in progress and tracked at [5]. This series is based on mm-unstable (ad3232df3e41). I'm going to be out on holiday from the end of today, returning on 29th August. So responses will likely be patchy, as I'm terrified of posting to list from my phone! Testing ------- This version adds patches to mm selftests so that the cow tests explicitly test large anon folios, in the same way that thp is tested. When enabled you should see something similar at the start of the test suite: # [INFO] detected large anon folio size: 32 KiB Then the following results are expected. The fails and skips are due to existing issues in mm-unstable: # Totals: pass:207 fail:16 xfail:0 xpass:0 skip:85 error:0 Existing mm selftests reveal 1 regression in khugepaged tests when LARGE_ANON_FOLIO is enabled: Run test: collapse_max_ptes_none (khugepaged:anon) Maybe collapse with max_ptes_none exceeded.... Fail Unexpected huge page I believe this is because khugepaged currently skips non-order-0 pages when looking for collapse opportunities and should get fixed with the help of DavidH's work to create a mechanism to precisely determine shared vs exclusive pages. Changes since v4 [4] -------------------- - Removed "arm64: mm: Override arch_wants_pte_order()" patch; arm64 now uses the default order-3 size. I have moved this patch over to the contpte series. - Added "mm: Allow deferred splitting of arbitrary large anon folios" back into series. I originally removed this at v2 to add to a separate series, but that series has transformed significantly and it no longer fits, so bringing it back here. - Reintroduced dependency on set_ptes(); Originally dropped this at v2, but set_ptes() is in mm-unstable now. - Updated policy for when to allocate LAF; only fallback to order-0 if MADV_NOHUGEPAGE is present or if THP disabled via prctl; no longer rely on sysfs's never/madvise/always knob. - Fallback to order-0 whenever uffd is armed for the vma, not just when uffd-wp is set on the pte. - alloc_anon_folio() now returns `strucxt folio *`, where errors are encoded with ERR_PTR(). The last 3 changes were proposed by Yu Zhao - thanks! Changes since v3 [3] -------------------- - Renamed feature from FLEXIBLE_THP to LARGE_ANON_FOLIO. - Removed `flexthp_unhinted_max` boot parameter. Discussion concluded that a sysctl is preferable but we will wait until real workload needs it. - Fixed uninitialized `addr` on read fault path in do_anonymous_page(). - Added mm selftests for large anon folios in cow test suite. Changes since v2 [2] -------------------- - Dropped commit "Allow deferred splitting of arbitrary large anon folios" - Huang, Ying suggested the "batch zap" work (which I dropped from this series after v1) is a prerequisite for merging FLXEIBLE_THP, so I've moved the deferred split patch to a separate series along with the batch zap changes. I plan to submit this series early next week. - Changed folio order fallback policy - We no longer iterate from preferred to 0 looking for acceptable policy - Instead we iterate through preferred, PAGE_ALLOC_COSTLY_ORDER and 0 only - Removed vma parameter from arch_wants_pte_order() - Added command line parameter `flexthp_unhinted_max` - clamps preferred order when vma hasn't explicitly opted-in to THP - Never allocate large folio for MADV_NOHUGEPAGE vma (or when THP is disabled for process or system). - Simplified implementation and integration with do_anonymous_page() - Removed dependency on set_ptes() Changes since v1 [1] -------------------- - removed changes to arch-dependent vma_alloc_zeroed_movable_folio() - replaced with arch-independent alloc_anon_folio() - follows THP allocation approach - no longer retry with intermediate orders if allocation fails - fallback directly to order-0 - remove folio_add_new_anon_rmap_range() patch - instead add its new functionality to folio_add_new_anon_rmap() - remove batch-zap pte mappings optimization patch - remove enabler folio_remove_rmap_range() patch too - These offer real perf improvement so will submit separately - simplify Kconfig - single FLEXIBLE_THP option, which is independent of arch - depends on TRANSPARENT_HUGEPAGE - when enabled default to max anon folio size of 64K unless arch explicitly overrides - simplify changes to do_anonymous_page(): - no more retry loop [1] https://lore.kernel.org/linux-mm/20230626171430.3167004-1-ryan.roberts@arm.com/ [2] https://lore.kernel.org/linux-mm/20230703135330.1865927-1-ryan.roberts@arm.com/ [3] https://lore.kernel.org/linux-mm/20230714160407.4142030-1-ryan.roberts@arm.com/ [4] https://lore.kernel.org/linux-mm/20230726095146.2826796-1-ryan.roberts@arm.com/ [5] https://lore.kernel.org/linux-mm/f8d47176-03a8-99bf-a813-b5942830fd73@arm.com/ Thanks, Ryan Ryan Roberts (5): mm: Allow deferred splitting of arbitrary large anon folios mm: Non-pmd-mappable, large folios for folio_add_new_anon_rmap() mm: LARGE_ANON_FOLIO for improved performance selftests/mm/cow: Generalize do_run_with_thp() helper selftests/mm/cow: Add large anon folio tests include/linux/pgtable.h | 13 ++ mm/Kconfig | 10 ++ mm/memory.c | 144 +++++++++++++++++-- mm/rmap.c | 31 +++-- tools/testing/selftests/mm/cow.c | 229 ++++++++++++++++++++++--------- 5 files changed, 347 insertions(+), 80 deletions(-) --- 2.25.1