From patchwork Tue Aug 22 01:54:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 13360073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AE6EE4996 for ; Tue, 22 Aug 2023 01:55:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF27394001E; Mon, 21 Aug 2023 21:55:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7BCE940008; Mon, 21 Aug 2023 21:55:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF64A94001E; Mon, 21 Aug 2023 21:55:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AB1A4940008 for ; Mon, 21 Aug 2023 21:55:22 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 807081C8B6D for ; Tue, 22 Aug 2023 01:55:22 +0000 (UTC) X-FDA: 81150073284.19.5CA8CD2 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf04.hostedemail.com (Postfix) with ESMTP id D408240006 for ; Tue, 22 Aug 2023 01:55:20 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=dI1NF1M+; dmarc=none; spf=pass (imf04.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.51 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692669320; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=kduaF6NEmqtdigQR12l4zIQ9Z7Qe4cQI7f7goF2YonA=; b=a6J11sUlxCpZBp1MuVkfcH6oQZSY5vQUgKKRWSxkhr6YooxTG9RdNBBR72CBvmI1AVZNTT RdYgPVfjt7hFpTzda81qjp9+SStEHl8xtT4i5Ew2PcL+Bgzy5t39HJQd64cvSXcLbW2Rg8 GCwwkc9JccoDLRDcF8KMPpQuOnHfAdY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=dI1NF1M+; dmarc=none; spf=pass (imf04.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.51 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692669320; a=rsa-sha256; cv=none; b=Gex6flWR4n4AFoFINX1WUKmfna7OQMClimbTIEWYdSRAIrPJuZGiCmCNeURAtyblbaK6Tj mdzUp8f2mGg5HvuFCLaoC0XmdisbZnkN4i3iDkbLrcqZzqnCFVywrFyddc08m2aGQZE2nV UipA2CbVicaEgsaVtQ465L9cfyH1pps= Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7922ca5cdbfso40006839f.0 for ; Mon, 21 Aug 2023 18:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1692669320; x=1693274120; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kduaF6NEmqtdigQR12l4zIQ9Z7Qe4cQI7f7goF2YonA=; b=dI1NF1M+qizhBIuBYOb+MBxjF0sUdkyIROhUTZohfN3aqISp/JA4m5jbZcgSPWZegi aasvoXFYkhoA2/ZBaoZysBBdmhpS90nBfblwsKbPPUpeQ+QbB5AEEj3GcTFRzke0Zst7 Q+A31Fzlxgud3p4yedSBCBhWkDA9+KHXqyQWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692669320; x=1693274120; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kduaF6NEmqtdigQR12l4zIQ9Z7Qe4cQI7f7goF2YonA=; b=VX+3JGBJ2NhWznXI7hZnApUt0nihmo0zJ+ffxY44dlearmKzVrvps1VmbzfEzJWidJ T8u6NF9b1SXZQX3iVWSKZVdTpCcc9ZUUIhoDYfqzp4ZfIpFxOk5V9Hd3xwFCU2neKeDj cwrfiAHcIsjMrTL51BA+3uTTY/HT8E2Klw4XCKWkCKsWWtOIrjxR1n2ZZSy658A8YutX JJsmnMUqZvWz43xYtAQWnqvjGRJWwkXo12R4OgIfHnp4aoP3N+nzf5X+j9UVESjGfLkq Ikwvl/19Hrlb7pOrKZ7U0OSgm29j43A6evhLEs1yzBKP7nw4MyvF/yfJdKD0LaIwbMdg QjEA== X-Gm-Message-State: AOJu0YxRpT4FcOSPnsib0coAn+Xi8t8Bjy7b9D5/iFzQaWK7bQqC4E7/ ecJQRHTyZ/WQrTmS/I4JnWzmtQ== X-Google-Smtp-Source: AGHT+IFmsUAfJcyPXse8Hdp3SRmHFbe0cau7P07MO9wJsFGPEkow2OKRUv5tZ1eDPB6D8C1Kxe3K9Q== X-Received: by 2002:a05:6e02:1523:b0:349:345b:6595 with SMTP id i3-20020a056e02152300b00349345b6595mr8918842ilu.11.1692669319980; Mon, 21 Aug 2023 18:55:19 -0700 (PDT) Received: from joelboxx5.c.googlers.com.com (156.190.123.34.bc.googleusercontent.com. [34.123.190.156]) by smtp.gmail.com with ESMTPSA id q11-20020a92d40b000000b0034886587bdcsm2907390ilm.18.2023.08.21.18.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 18:55:19 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: [PATCH v5 0/7] Optimize mremap during mutual alignment within PMD Date: Tue, 22 Aug 2023 01:54:53 +0000 Message-ID: <20230822015501.791637-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.42.0.rc1.204.g551eb34607-goog MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: pfyactxmsxdg5zqrpmhatwcweqxkxy15 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D408240006 X-HE-Tag: 1692669320-6005 X-HE-Meta: U2FsdGVkX1/ZuRAUHbOyiXNkEOAz0AdCs53+ObUqsYSOixYPSiPz/+jg91hJw97EaKVNSNpXG7fB8F2izmPeY0E4MBl5iK8QVw8YtACK2vRBPxGNpWjd9bDB6bDZQAnjCXXUmyPIFaa3SqU3ByoA25+IZRUOlg7266MqMsCHvLkqwDS3529Ln5eWSIpzkw+mmQEoKTsgY1vh4cZ9Zfz1w5Clbp4WUQzgwTcf8Z3Gvqcmt88YdChkvoV2+HqemPBUTgNaSEnNU3gmD/ylmqvLy9w0M9tmmCnBq7+ii+MDWxihb/jR3CrCAvjqAUFKoBP0eD0R3Y2wfWLmm7zUa488MHyZh5gVYH7oBHSDkRva5G9ciGj5/SZxOHrSSXeUXE6bC/3IKQ5LYHknPqrgPzOgUtoY4z7CAEHOtUIwfyfG9PiMMF1qLDRLFFw1WUV0c6AZu9YQpL01UYUgnFOZpH3Nz5R3p37+0ILN5UoOQyLSRWiKaj9CY71zWc0u/9kRFNyl9B7dc1e7BZKloiWTvjkXwcJWbeZPo+hkspZu/Wl0vvT5XTR30WeNmwWHXgCWV5P98efa61E4dWxARhd8v2o3O5LRW163oGxktH8qWIV+jfLSIPs3UFJFkT69seEu2V/CCRCp49Th54UPf9QAIwzBS8Rc5yCtFj7AMiI3sVT8Ak0AQe6JAwdTCPnggOdwxUrpuJa9TXyOjV/AJ8i/Z9JYhwMqOSScQhx3SV14kOQQUaKJftU8rLyxuqy+481qUYzjvDgl/l/0O6/sq4c+eo9/JOr7mFcberou+pkLENI29WEwFN3LjeNys4m4K2EGW1X51qh4MspEvTun9pbpA3aX1Unwlwi2H+Gpk/Fer9ZqOOXEwy9Z43pQ7aubXUoD0NJ6ZuWiTPXHY4NHaGRn+Oxf7g2Ja8t9PHrt+gSWiBenBPDKDRWzr8tRRfg4glA2foFWftyxy0PIdxU9ACh6+rp 1wPoZ82U 9wU1/0QDIQ91yh5C5V+nnNcJfMf9YNJN37ZIPkEUYT8nvfjr5wfzLJB+/ApQYk+p3/0AW0rkQvjP5Pmgt+ISfziyYYB7J8QmFciRiZYxD7CFPIHN+aBblRFJCSvf+zo5WJNUalwdu4D3fCflxJiWaa3yzSHSS4jsx2ucAJzNJt8AUe+laStysuC/BYAajcKxSEMs2SpRsTaRdjTiPBJJSco+glaa2/27wR6IXlmY+WTz6ChWcWV+NRzjy1ijCE5c7xg5joXdTkF1imSvXGu9bx+Rlv5iz4QFiTagjFUU/LSNJbngsYVeNbVVpYqrSOL2LAWJDTDS6U/jkI1btrNlxaYccZ9J1JBNc+3AygO9A1tfuU+AOqmCHNQ9ot/acJFpb6vO0t6KvYsRLyxiMdhS8bldVNWmVLrs6azscLaGR/961qeCLfm+qePUrYXMrgfSmvNnI+8KRntdeUlEPWyMtUKfx2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello! Here is v5 of the mremap start address optimization / fix for exec warning. Description of patches ====================== These patches optimizes the start addresses in move_page_tables() and tests the changes. It addresses a warning [1] that occurs due to a downward, overlapping move on a mutually-aligned offset within a PMD during exec. By initiating the copy process at the PMD level when such alignment is present, we can prevent this warning and speed up the copying process at the same time. Linus Torvalds suggested this idea. Please check the individual patches for more details. [1] https://lore.kernel.org/all/ZB2GTBD%2FLWTrkOiO@dhcp22.suse.cz/ Link to v4: https://lore.kernel.org/all/20230531220807.2048037-1-joel@joelfernandes.org/ History of patches: v4->v5: 1. Rebased on mainline. 2. Several improvement suggestions from Lorenzo. v3->v4: 1. Care to be taken to move purely within a VMA, in other words this check in call_align_down(): if (vma->vm_start != addr_masked) return false; As an example of why this is needed: Consider the following range which is 2MB aligned and is a part of a larger 10MB range which is not shown. Each character is 256KB below making the source and destination 2MB each. The lower case letters are moved (s to d) and the upper case letters are not moved. |DDDDddddSSSSssss| If we align down 'ssss' to start from the 'SSSS', we will end up destroying SSSS. The above if statement prevents that and I verified it. I also added a test for this in the last patch. 2. Handle the stack case separately. We do not care about #1 for stack movement because the 'SSSS' does not matter during this move. Further we need to do this to prevent the stack move warning. if (!for_stack && vma->vm_start <= addr_masked) return false; v2->v3: 1. Masked address was stored in int, fixed it to unsigned long to avoid truncation. 2. We now handle moves happening purely within a VMA, a new test is added to handle this. 3. More code comments. v1->v2: 1. Trigger the optimization for mremaps smaller than a PMD. I tested by tracing that it works correctly. 2. Fix issue with bogus return value found by Linus if we broke out of the above loop for the first PMD itself. v1: Initial RFC. Joel Fernandes (1): selftests: mm: Add a test for moving from an offset from start of mapping Joel Fernandes (Google) (6): mm/mremap: Optimize the start addresses in move_page_tables() mm/mremap: Allow moves within the same VMA selftests: mm: Fix failure case when new remap region was not found selftests: mm: Add a test for mutually aligned moves > PMD size selftests: mm: Add a test for remapping to area immediately after existing mapping selftests: mm: Add a test for remapping within a range fs/exec.c | 2 +- include/linux/mm.h | 2 +- mm/mremap.c | 69 +++++- tools/testing/selftests/mm/mremap_test.c | 301 +++++++++++++++++++---- 4 files changed, 325 insertions(+), 49 deletions(-) --- 2.42.0.rc1.204.g551eb34607-goog