From patchwork Thu Sep 7 16:33:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 13376611 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BEC8EC873D for ; Thu, 7 Sep 2023 16:34:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 288538D0006; Thu, 7 Sep 2023 12:34:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 237E58D0003; Thu, 7 Sep 2023 12:34:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DA768D0006; Thu, 7 Sep 2023 12:34:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F07D98D0003 for ; Thu, 7 Sep 2023 12:34:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BEFA580220 for ; Thu, 7 Sep 2023 16:34:02 +0000 (UTC) X-FDA: 81210348324.04.7C8E9F8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id CE30FA002A for ; Thu, 7 Sep 2023 16:34:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LyHzwRhW; spf=pass (imf15.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694104440; a=rsa-sha256; cv=none; b=rlzrPMmxAbxIs17+QsDh9jLuJWBTineQM0ioHRgRrYoA3kB9bBeNTNXdLctEyc2WbJt5jq o9lBZNY89FNJD04/fNWKSr4TF0qjui8dcgsQT29llGKXRfHVjoo8kkzbxNRqMaNm5tK10q qYBqTqrrvtctsyt3IlsKv2B7dS+VtKg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LyHzwRhW; spf=pass (imf15.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694104440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Qb3N2d75JUC2RCAkC0aW44GGQ+33UOIa6NgytmpiYBQ=; b=wIbAg4lokt4oTYOXHAcL4V8upQXYHxW3/xt2WyrCax6z/ICFLEAzvnZmM6qDImIwwW1xxR xBpuOrb8pIMkhtyW5CbOaq7BTHTiSiIz1JXM7/UDdaXwUzFwuvv+SYl8CKDyllGj+9OBMG y/lT2KUfAdbEj9Y/FR8CJkyVh8jxdho= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1ED7612B1; Thu, 7 Sep 2023 16:33:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85E06C433D9; Thu, 7 Sep 2023 16:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694104439; bh=Tl7vhegXVwuJ4ZvlyXuRvL1PMLNp1QhwYV2qByndv0M=; h=From:Subject:Date:To:Cc:From; b=LyHzwRhW/1WH8vGEjolJBeAxo+0fnV54+EKtfS7fbcWru4PkPuic4KaNfEqOOHvo+ UMf9YAvH1RllPXOjbZQpYuzNI552aIcmiGGsyD8x0cLUoEMwXraz9kjmbfcXMD0FZl rKQicb7RlhznhMKqRQk3EoeMGsMl2HjASoF5GK2jGgJty2REhwxmPUncErJlNNmkfm VMeGlQ9454qnCCGZT9OjQtNLvTsdkPv2FxYlAXK7bemuYZ4y8MKegFMNYT9ort1H+p zSVEGZNmls9dWhxLa7BsgCQbrbT/1P+swRvoUI1DPE88hQJf7SXsdLd6lfx/HVvXdR CwHMSmyn+ArXg== From: Jeff Layton Subject: [PATCH 0/2] fs: fixes for multigrain ctime code Date: Thu, 07 Sep 2023 12:33:46 -0400 Message-Id: <20230907-ctime-fixes-v1-0-3b74c970d934@kernel.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGr7+WQC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI2MDSwNz3eSSzNxU3bTMitRi3dRkM2NDy+REA8OkVCWgjoKiVLAEUEN0bG0 tAB/Kz5VdAAAA To: Alexander Viro , Christian Brauner , Jan Kara Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton , kernel test robot X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1116; i=jlayton@kernel.org; h=from:subject:message-id; bh=Tl7vhegXVwuJ4ZvlyXuRvL1PMLNp1QhwYV2qByndv0M=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBk+ft2JmbTYxfi47ZsnUhmwPG2XIyZJofSPLphP 9TqCH5nSyCJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZPn7dgAKCRAADmhBGVaC FVFfD/9dO1oz+QsPO5nQ9QVPnj3TUFlSi/iws7NHnnTbVApK4PtoR0eDkE4oTZsXh6LXeNvky++ GxDGDgBDF7Q6pY6+zvH4juGZ2ovrZcgruV0PcqgbJ2+ktLIsxHeFnSWyU1qLjrIQGyJXnXlPVB9 W8861z/XlNUNTJaLiNawfKts7Td414e7psyj+SrZDi5Om5HvCz+smue7KUiwXwwYaRd5OGv3ikp gb7pdoY4yIwlIJi0h2PlaEjWEYoaZpXwVATrg4Uykr3/5S3sVOi7ddeLPzLSFisaLj2XxU1gwTI HVUQaLk9EP1hS+FOsv09z0tz2qNp4aFLrBCf/dZvZFwcfQRwWxyl9FjWivJJHj711rRzHW2EsuW 4DQv6nT+WPrJkpTZot2DVetRN6yQpHS9mqNBLzOwkRoP00wCvmVPKy2ZVfnk3miCR51MbiWycPe QbwdQdfEaK1SH6gG3iC1x63Od4g+SCC2hgznD6DpE4iqT98C4zlLAg3TQvBlGfxT232+ikl4Ps+ TYkJ6a5kSi10qPt9j4QBKa5AEd6iYtxVGtnvlosOqOBQWv+cBGa1vkM/f/PqPrBGho9xzci5ksS gILN0yMLurzYelhEpDVw+CP9Hiy083RmP6JzkSLSC0XK8wDAcIZmTYEATPmfZntc2q3CVjeo8pd ZWI7SNFEWgAvIww== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CE30FA002A X-Stat-Signature: ctczen1surmac8b7adfm95mkomocwm3w X-Rspam-User: X-HE-Tag: 1694104440-876213 X-HE-Meta: U2FsdGVkX18GYOITdT5uXKy/T+6XhebvlkXzDyJQno3MZWMi5/cXp0L3quP5BS0VUuGfhkEzoyk0Mv3Ynuu4FIAdwr/LdxBD22cJHORoz0AUJEriG2d/IuMJfYBCau/7miU1WCDTNyHG6FpNDK6uSSxmZmppruVBf3rDV+EZNy6LUzmr0Kzus4O0ryAs1MzStUh3eYoMmXeFSXinsfeJmSI3EKnq7uFRzaUqMHeleOsAODi6X4ZgVgQNkmQlhMswfYdq1D0vw3Jf7HRmJfFaecXtg7k9QDmPCCXjvt2YPugvYeMlxVO5eh319tDCHzM6LcfIbqrJscfBejcgHyg6WrgewqAoa7d3dTkVuGc9EFQ7ZCXJe0jv5vj15EeCyyT5Z0l4lr89sbINbFaspWSD+XUx8biXRVLbdgWgDyGREsKp4FnigMttqV6GuGPRllw1i7qaU4xUJqaqiX/+VHS1Z0CP/u1x8P4DaKBOpvigaJirzKJPgS76ICghRm8FD77OM6PjZ9q8VBCxMYvv1oxb9hK7ez4EqOCUiL6RbiOHmdc32ct8yKsXUrBpy9TxJzh77gfSiVHd05T0Mkh6JVbHDbv8kf/N2n5mwhi+bNvqkwfM1q5wYBd01PCS0LnBG4venm9GrdaBlAVLfaUKtL/zQFnXUcANtpzXScEUzfAwxETXivmz4HBcWORg4kmVBiKTfEoEzXHTl0zgXO1imBd7v8wJlQbIQOrFBjUkWjkBAqBMejYcpHVq2Mf10PAQaR885wC4ACUxv4S8yVy3tXj6UEga/KG+zgouC8bHoL6h6kxQiZXbHSZsjbdpUKwC/o2cUAIqVxvY4BhuKFgmJ68iFNeevGTm2cMadzzpV/Nc8RT0LiNSghTpC/ifpC08aDi2zKN465vMYKPBdHyaGBrv0wEamm8cAu5dHSE8J+XQdhsSiWqFFtecAuEskDMSiUHWkkvtashmoj/fNO/bhpz OB4IOuwG 85yKnldYXpN4O0rtobRzCCU/PsrNaBEhzAT/VxPjD7LRw19QAV729MOSkKLrkraz/eBUi63CDBkIoW64YQJXfcMfsMYNLRvVMnRNbI5yKajE/tWId2vFxj+oppcw8XF3CFmCJ1fY4DDwSjELkOiOb7imzKJV/FTUmlvjSjcGIRGQ6euNGs+g/qiRmt5E/l+O5lZn1wq6AZWVzwACMu7s5PZeoB0QZ1r6p1G7Pudsvf8Dgnw1ViWHdhG5C7p6Xf2h3qepV7u2m021zsMD/YUXIPSMk+4V0qC+YRTIEA2zf1MFnL4V8DREevBJPcUKJtFXwwk25IwFeIlMf5zVu6XMA7hc6f7gj7Goegvo1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The kernel test robot noted some test failures with the LTP mount03 test on tmpfs. From the test output, it looked like the atime had gone backward. One way this could happen would be for tmpfs to get a new inode from the slab that had a ctime that appeared to be in the future. inode_update_ctime_current would just return that time and then the mtime and atime would be set to the same value. Then later, the atime gets overwritten by "now" which is still lower than the garbage ctime value. I've not been able to reproduce this on my test rig, so I'm not certain this fixes the problem that was reported. I'm hopeful though, so I've left the KTR tags in place. Signed-off-by: Jeff Layton --- Jeff Layton (2): fs: initialize inode->__i_ctime to the epoch fs: don't update the atime if existing atime is newer than "now" fs/inode.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- base-commit: 7ba2090ca64ea1aa435744884124387db1fac70f change-id: 20230907-ctime-fixes-ec6319ca01be Best regards,