From patchwork Sun Sep 10 03:40:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13378438 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0910EE7FF4 for ; Sun, 10 Sep 2023 03:40:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43A736B0123; Sat, 9 Sep 2023 23:40:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E9876B0124; Sat, 9 Sep 2023 23:40:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FF266B0125; Sat, 9 Sep 2023 23:40:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2422C6B0123 for ; Sat, 9 Sep 2023 23:40:55 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DA8381407FE for ; Sun, 10 Sep 2023 03:40:54 +0000 (UTC) X-FDA: 81219286428.24.EDCB4FF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 4CF391C000F for ; Sun, 10 Sep 2023 03:40:53 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k0R1X6O8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694317253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=11CDfGlFaRrjbgiCw2z1U/L8MczRP86JnX6atLFSBp4=; b=zC0m6m+XnOYLaZysCraVPM/YqKppcqSIReNdSolP6n4/Dh86mzVUmAom8wfrmlrfWbKtpy PSl1RicrNd7Zfsywx7LpLzj2hQeBX5G6lp3GnmmltS+u4ytfLCFL5+VWSw7KQj+DgTogyl xDaEVNbOqIg6YyTBE2tKK6WsEiFruxI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k0R1X6O8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694317253; a=rsa-sha256; cv=none; b=EkfwOmsbiYdKYcwvyRepxo+dzhFY4h3Dc9kz2OkxqbcBMyfdMIdbFPUi9DT+svGZw4l6nQ NFyr0VMpJZsTGy6F1cPAGmqItIYnqdMEn+Juvz04W8pXX9XDsZPpbh+1yo3+V8vjCDwhIU xsZ1V9GfJK4kqvxiSc1gi40+VrK0x4w= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4580360C54; Sun, 10 Sep 2023 03:40:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAF52C433C8; Sun, 10 Sep 2023 03:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694317251; bh=YnN+3EEg+Kt4hqil0PHaLwXJvCyERiTOIWXnLJWZVHA=; h=From:To:Cc:Subject:Date:From; b=k0R1X6O8RtpH+OZ2kVJhQU38l8/QrE6lor2MzdhBIg4zhYkXb2jXTU6ZOJCRSCsoP na2pWCtgzkU9zCgjsPasZQ3ZyWGAZV7WCasVKZpgtQJvLwYMj/aklrd4jWTJr0Myrx hCKydtcy6X4yl58GEqmTZji1keb+mVB1oNYL1fe3HJsDTZGfUY7HQf3sQeL8XanFO3 vZj6RWuo8LM/VS0rxTKJmLL/RZLNA/Hwl3p9GSpyptquRfAOhhZfkmybwoKLVZjG7K cuoHbxKUqEPhvgEPzVRHB65I8//yyFl7jzlz49BFiEhl78+BlOlEE2YIBknxwHQjFU uyW3FkLs//50w== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , Jonathan Corbet , Steven Rostedt , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC 0/8] mm/damon: implement DAMOS apply intervals Date: Sun, 10 Sep 2023 03:40:40 +0000 Message-Id: <20230910034048.59191-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4CF391C000F X-Stat-Signature: obufemoejnzsqyjf5n176xm88kt93qx1 X-Rspam-User: X-HE-Tag: 1694317253-704534 X-HE-Meta: U2FsdGVkX19QiHTGJG7AcPvu36UdpMsXi4cT1QASclOHHcFyegoKGdV9/3+ZDAZHZS1HzahsH0QuvkbKVPbwUMN801jPaVdsb3X++qbt7KVExi9rg0DHQFkC+gYf5QR6jMXpd8gN+Td+R7Khd1PdffUoaDzQZU0IFen7d0Qt7BFZia6RsZfogopP3YEf7K0gPSmRS+u6lkFUcjiyccA9+11ArrmcAjah442aMJaFV6KFaxUtPZDB/nPXcWyX6xT5Tv/7vQGkqfBX/mEKpO2MMgTGbbYUZyAx5foOftPSXdCVGS4hsM8VyX7vL4yYI8LSFW1X5zJmnIzyMT9Mt0LqTy50BbfqDmpnhGbKaTHCRu6R+dhC787E893mDRMhVltb2Hj6Wt2KZ43DKy3dyPeX9EoJ4JeBUUls6YFYsHyiroNed55tKjtU44puHA6DJxcNnVpFShnzSQtMXCvOWfXr28JuW14XI7Pz40H7slbNxX0D4gYfPtEp1sd+H9XLS+bXzV9ns7vl3w7G1NuRGC8uP1vCPOqBRDwCICysQe1vUGBB0hmzhi+euDN8WtXCSYgAI7EupUBt5dK+nN6Nfxhg+OHQW7NTDZVB33iVTchHIevBtr2krWSdm8ELdfXEStj152ngZIVv+pChv40FJzPgrb8YvMkmFmak0e0GmmTmfuJQwkwklhGMjPJY+UzcVy2jjE1tc0HLnJZ2EzNMxqCNlJlppXq/8CkI085UTcxvEhesnPYof9xQGZ2MBV0uveo7b5hdeYuh9LbGFI/ISH7JiYEqZHqbSEZP5Rw2LMJhBHNp1gigCQXkdPSqZGC0UQEcfD9DXChN58pjRQiYcfg2XE/sUrWd74wCgU0JF9RB9PBJgRzp5nTYsm8JBSn9MwMOn+09aKYabLwYfSFny1Etu3oERrEM94/MqBdvfcG7KoINZLYRebS50uQSblL9YmUBtP0T9yEZQOC5NmR5FNT YxxdeDaZ n3l7EXI/V2TNDFf9r5fIObHapaxX94vLxWiFBjpO2PlzGGL6jrXPQ3LUt+YH167OS2tbTwMeGK8OVMSWyMFibd9XXUg43pjV3tjk+Hg1rgP/kR/AmnzSWHDHB/xzHrTp4E0ecS7jbf9WCopGdXenUFyQZyABm5ZZO/FOKnspAgBqFwAjTWg7MX6OFPKdPuOAkOIpLc1mQgiFap2sjaJaedOSq4X41lwFu5/a5dtzM4fUQyZMuDGFPr6Fzb1XQKOQ4rOpFNHTTLW+LNvBRkXu3y8oSGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: DAMON-based operation schemes are applied for every aggregation interval. That is mainly because schemes are using nr_accesses, which be complete to be used for every aggregation interval. However, DAMON provides nr_accesses_bp, which is updated for each sampling interval in a way that reasonable to be used. Therefore, there is no reason to not use nr_accesses_bp instead and apply schemes for their own time interval instead of the aggregation interval. Actually, the alignment with the aggregation interval is also making some use case of DAMOS tricky. Quota setting under long aggregation interval is one such example. Suppose the aggregation interval is ten seconds, and there is a scheme having CPU quota 100ms per 1s. The scheme will actually uses 100ms per ten seconds, since it cannobe be applied before next aggregation interval. The feature is working as intended, but the results might not that intuitive for some users. This could be fixed by updating the quota to 1s per 10s. But, in the case, the CPU usage of DAMOS could look like spikes, and actually make a bad effect to other CPU-sensitive workloads. This patchset makes DAMOS schemes to use nr_accesses_bp instead of nr_accesses, and have their own timing intervals. Note that the interval is 0 by default, and it is interpreted to use the aggregation interval instead. This is for avoid making behavioral changes to the old users. Patches Seuqeunce ----------------- The first patch (patch 1/8) makes DAMOS uses nr_accesses_bp instead of nr_accesses, and following two patches (patches 2/8 and 3/8) updates DAMON sysfs interface for DAMOS tried regions and the DAMOS before_apply tracespoint to expose nr_accesses_bp instead of nr_accesses, respectively. The following two patches (patches 4/8 and 5/8) implements the scheme-specific apply interval for DAMON kernel API users and update the design document for the new feature. Finally, the following three patches (patches 6/8, 7/8, and 8/8) add support of the feature in DAMON sysfs interface and documents it on usage and ABI documents, repsectively. SeongJae Park (8): mm/damon/core: make DAMOS uses nr_accesses_bp instead of nr_accesses mm/damon/sysfs-schemes: expose nr_accesses_bp via tried_regions//nr_accesses mm/damon/core: expose nr_accesses_bp from damos_before_apply tracepoint mm/damon/core: implement scheme-specific apply interval Docs/mm/damon/design: document DAMOS apply intervals mm/damon/sysfs-schemes: support DAMOS apply interval Docs/admin-guide/mm/damon/usage: update for DAMOS apply intervals Docs/ABI/damon: update for DAMOS apply intervals .../ABI/testing/sysfs-kernel-mm-damon | 7 ++ Documentation/admin-guide/mm/damon/usage.rst | 9 ++- Documentation/mm/damon/design.rst | 3 +- include/linux/damon.h | 17 +++- include/trace/events/damon.h | 2 +- mm/damon/core.c | 80 +++++++++++++++++-- mm/damon/dbgfs.c | 3 +- mm/damon/lru_sort.c | 2 + mm/damon/reclaim.c | 2 + mm/damon/sysfs-schemes.c | 40 ++++++++-- 10 files changed, 144 insertions(+), 21 deletions(-) base-commit: 2a43f312aed581fa5044c4a0c0d20cfd4e632aa6