From patchwork Thu Sep 21 16:19:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13394005 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D4F0E71090 for ; Thu, 21 Sep 2023 16:20:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB1D16B0186; Thu, 21 Sep 2023 12:20:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5FA16B01B1; Thu, 21 Sep 2023 12:20:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B27116B0207; Thu, 21 Sep 2023 12:20:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A5A776B0186 for ; Thu, 21 Sep 2023 12:20:27 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 74F2B80928 for ; Thu, 21 Sep 2023 16:20:27 +0000 (UTC) X-FDA: 81261117294.04.4387E5D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 97A2B80014 for ; Thu, 21 Sep 2023 16:20:25 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695313226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=qUyz7Y+MvvRCe+mAqo4ZDMmuZYuJbLYP31TN2y8wsAg=; b=VtpYeVW+lV3FC95cNuzOS2NW/yLgDBAPgIfeACmsDvlZ4Y7/gMCCDfFFYwC+ELAR8vvkOL JJcoWqZ1rKLKWnZuNvbMWutp+0Nnn2UOS2GGNjR87TdIFewCA+FJc5Xq63KYCnHAUuzyu5 afa2H/bdXiCJdRQDKNBzXcK9FTQbYas= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695313226; a=rsa-sha256; cv=none; b=8MyFpbkwvOZMaawkrFxqofi15kfeuxTBNkikqAzOAgYLVWmHnuLkBhqGB/ZD8NgwMJt1MO I0it0RnJkobCSoY8+H/2YEtLXqnVZdQFat880hx9XlNKd3aPqO4b85AijrDdTU2hk+IDQ7 YW1diizYmnLJzgmRue2Lwc4idkxAMU4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72F9616F8; Thu, 21 Sep 2023 09:21:01 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 036003F59C; Thu, 21 Sep 2023 09:20:19 -0700 (PDT) From: Ryan Roberts To: Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng Cc: Ryan Roberts , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64 Date: Thu, 21 Sep 2023 17:19:59 +0100 Message-Id: <20230921162007.1630149-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: f8cdg4maybommahp46ruo545zmdste7m X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 97A2B80014 X-HE-Tag: 1695313225-934047 X-HE-Meta: U2FsdGVkX1+7tLRl8cAWWktp5VeDBUYDlGC8+3a0/jZGzg8FMSdkCjMxpvV+uJCFRlN30+ERJM1/A/Om12+5/tLxiCbD3AudbX/7/sVO2dQfjy/r4eH4inN1bv4Nu70FzNsTe0UHw3bIFWuA+4LmYe9NytagUsWiC8jWO1FDaYyuiMLtdt2Hdct8IQq+9XhKj83NMqLQXYiYW6AyrN+bArInCtl1sTU2LmGZz6RiB2KDkEVuChjyJ1fM34YrCr2nkl6a7E8zSxK8mskDyPBCKRrnQ1OjoFMFFpBFO2CJVEq/AdYe7agvJYMnPzELl8I8uVcEHep7FTPSDJhvQEyw2E+dF3xwOzN6sctYPbm+PViUzHGdg801wFaHWvA/na5qJXVmmzb9rEu5Opy9l373Gfsunyplfvyw+ERaOor2io9XDezjWTmCJ024V4lrdeFR6hkoKdnJvQOuEndmAyXDPfKqPFSniyB9GhKdXIhyQvZq8HrYDaKJiPPwwSIPROkyQlE1JENkZ2orE/Z1nnW/JPRBqY+yMnK6VEzD5HM1k8kiWilwkHlWSTin1g9NY/+yjOkVcJAYk08GB+lE1V/PNs1GZir4OG+1FttlDbmwRuQk1HkQN/REaMADMJ6zdojegqN0TISrPyPJzlKe5OiRyVdXXSKIVzPgPK1v0Ku6SMwMEMc6S/0o/DiejJ5KLcr1uyXIs+6tpOD+ZWxSBWoFA6Cy3rSNi8BwkC8ID3TIV2kplho23Hcvnm5jVaiYQQufaGq2reczwGnJfeTz4BS3i1M0efNSkFLq0HycZI4wqVhfrYT4Kzbrqybbo+uY03gmUZu2/+3dFJcCnr2aJR+ctjybSVivr8GgPTtCdiDHSQ77lEx95w90WVFn9B27r26f2oLGM2ZAgFyO8F6jVfZJCjZ/C0m0MqMAHaEEfFmvmf0fj5YUvOHoEKLFR5RGuffgHuW2FwsiWDpnjkJ4S/R zX8EixJx OsLvfBWbBX+6YujtOURGm9xJHV4MDVeVLeLHZaGwuJlkyWiVZdtpMZsWL4K/vGTNY/ejOvwdzyITPMxQiTKPitlbMwb96UiQ31LSTIhbGBoSbsplEMPCx+UvZW8eZxudCoNH1HtAmU6ot8fb4Emji4oqYkUTBtjJlXSsG5yhuziZaREAfmBiiLufbMXHirlY3ABtpCey88eyRjaY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi All, This series fixes a bug in arm64's implementation of set_huge_pte_at(), which can result in an unprivileged user causing a kernel panic. The problem was triggered when running the new uffd poison mm selftest for HUGETLB memory. This test (and the uffd poison feature) was merged for v6.6-rc1. However, upon inspection there are multiple other pre-existing paths that can trigger this bug. Ideally, I'd like to get this fix in for v6.6 if possible? And I guess it should be backported too, given there are call sites where this can theoretically happen that pre-date v6.6-rc1 (I've cc'ed stable@vger.kernel.org). Description of Bug ------------------ arm64's huge pte implementation supports multiple huge page sizes, some of which are implemented in the page table with contiguous mappings. So set_huge_pte_at() needs to work out how big the logical pte is, so that it can also work out how many physical ptes (or pmds) need to be written. It does this by grabbing the folio out of the pte and querying its size. However, there are cases when the pte being set is actually a swap entry. But this also used to work fine, because for huge ptes, we only ever saw migration entries and hwpoison entries. And both of these types of swap entries have a PFN embedded, so the code would grab that and everything still worked out. But over time, more calls to set_huge_pte_at() have been added that set swap entry types that do not embed a PFN. And this causes the code to go bang. The triggering case is for the uffd poison test, commit 99aa77215ad0 ("selftests/mm: add uffd unit test for UFFDIO_POISON"), which sets a PTE_MARKER_POISONED swap entry. But review shows there are other places too (PTE_MARKER_UFFD_WP). If CONFIG_DEBUG_VM is enabled, we do at least get a BUG(), but otherwise, it will dereference a bad pointer in page_folio(): static inline struct folio *hugetlb_swap_entry_to_folio(swp_entry_t entry) { VM_BUG_ON(!is_migration_entry(entry) && !is_hwpoison_entry(entry)); return page_folio(pfn_to_page(swp_offset_pfn(entry))); } So the root cause is due to commit 18f3962953e4 ("mm: hugetlb: kill set_huge_swap_pte_at()"), which aimed to simplify the interface to the core code by removing set_huge_swap_pte_at() (which took a page size parameter) and replacing it with calls to set_huge_swap_pte_at() where the size was inferred from the folio, as descibed above. While that commit didn't break anything at the time, it did break the interface because it couldn't handle swap entries without PFNs. And since then new callers have come along which rely on this working. Fix --- The simplest fix would have been to revert the dodgy cleanup commit, but since things have moved on, this would have required an audit of all the new set_huge_pte_at() call sites to see if they should be converted to set_huge_swap_pte_at(). As per the original intent of the change, it would also leave us open to future bugs when people invariably get it wrong and call the wrong helper. So instead, I've converted the first parameter of set_huge_pte_at() to be a vma rather than an mm. This means that the arm64 code can easily recover the huge page size in all cases. It's a bigger change, due to needing to touch the arches that implement the function, but it is entirely mechanical, so in my view, low risk. I've compile-tested all touched arches; arm64, parisc, powerpc, riscv, s390 (and additionally x86_64). I've additionally booted and run mm selftests against arm64, where I observe the uffd poison test is fixed, and there are no other regressions. Patches ------- patches 1-7: Convert core mm and arches to pass vma instead of mm patch: 8: Fixes the arm64 bug Patches based on v6.6-rc2. Thanks, Ryan Ryan Roberts (8): parisc: hugetlb: Convert set_huge_pte_at() to take vma powerpc: hugetlb: Convert set_huge_pte_at() to take vma riscv: hugetlb: Convert set_huge_pte_at() to take vma s390: hugetlb: Convert set_huge_pte_at() to take vma sparc: hugetlb: Convert set_huge_pte_at() to take vma mm: hugetlb: Convert set_huge_pte_at() to take vma arm64: hugetlb: Convert set_huge_pte_at() to take vma arm64: hugetlb: Fix set_huge_pte_at() to work with all swap entries arch/arm64/include/asm/hugetlb.h | 2 +- arch/arm64/mm/hugetlbpage.c | 22 ++++---------- arch/parisc/include/asm/hugetlb.h | 2 +- arch/parisc/mm/hugetlbpage.c | 4 +-- .../include/asm/nohash/32/hugetlb-8xx.h | 3 +- arch/powerpc/mm/book3s64/hugetlbpage.c | 2 +- arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 2 +- arch/powerpc/mm/nohash/8xx.c | 2 +- arch/powerpc/mm/pgtable.c | 7 ++++- arch/riscv/include/asm/hugetlb.h | 2 +- arch/riscv/mm/hugetlbpage.c | 3 +- arch/s390/include/asm/hugetlb.h | 8 +++-- arch/s390/mm/hugetlbpage.c | 8 ++++- arch/sparc/include/asm/hugetlb.h | 8 +++-- arch/sparc/mm/hugetlbpage.c | 8 ++++- include/asm-generic/hugetlb.h | 6 ++-- include/linux/hugetlb.h | 6 ++-- mm/damon/vaddr.c | 2 +- mm/hugetlb.c | 30 +++++++++---------- mm/migrate.c | 2 +- mm/rmap.c | 10 +++---- mm/vmalloc.c | 5 +++- 22 files changed, 80 insertions(+), 64 deletions(-) -- 2.25.1