[0/5] Fix and cleanups to page-writeback

Message

Kemeng Shi Jan. 23, 2024, 6:33 p.m. UTC

This series contains some random cleanups and a fix to correct
calculation of cgroup wb's bg_thresh. More details can be found
respective patches. Thanks!

Kemeng Shi (5):
  mm: enable __wb_calc_thresh to calculate dirty background threshold
  mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh
  mm: call __wb_calc_thresh instead of wb_calc_thresh in
    wb_over_bg_thresh
  mm: remove redundant check in wb_min_max_ratio
  mm: remove stale comment __folio_mark_dirty

 mm/page-writeback.c | 43 +++++++++++++++++++++----------------------
 1 file changed, 21 insertions(+), 22 deletions(-)

Comments

Tejun Heo Jan. 23, 2024, 8:46 p.m. UTC | #1

On Wed, Jan 24, 2024 at 02:33:27AM +0800, Kemeng Shi wrote:
> This series contains some random cleanups and a fix to correct
> calculation of cgroup wb's bg_thresh. More details can be found
> respective patches. Thanks!
> 
> Kemeng Shi (5):
>   mm: enable __wb_calc_thresh to calculate dirty background threshold
>   mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh
>   mm: call __wb_calc_thresh instead of wb_calc_thresh in
>     wb_over_bg_thresh
>   mm: remove redundant check in wb_min_max_ratio
>   mm: remove stale comment __folio_mark_dirty

I don't have the fifth patch in my inbox and I find the patchset difficult
to review because it's changing subtle behaviors without sufficient
justifications or concrete cases which motivated the changes. For now, I
think it'd be prudent to not apply this patchset.

Thanks.