From patchwork Mon Feb 12 16:30:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 13553519 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F9A0C48297 for ; Mon, 12 Feb 2024 16:31:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA0CC6B0083; Mon, 12 Feb 2024 11:31:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF5036B0088; Mon, 12 Feb 2024 11:31:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7BD6B0085; Mon, 12 Feb 2024 11:31:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 67CC56B0081 for ; Mon, 12 Feb 2024 11:31:06 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 017EB120A1B for ; Mon, 12 Feb 2024 16:31:05 +0000 (UTC) X-FDA: 81783691332.28.15F1EA9 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf06.hostedemail.com (Postfix) with ESMTP id 7340718001D for ; Mon, 12 Feb 2024 16:31:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=kPjffymB; spf=pass (imf06.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707755464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=sTkMW2MEoNV9tERZSKyZ8En90iyAvaORNbZn6Nk54oI=; b=v8lPf0U+hwud5pB8jTOkBbpbMNG5pTjAa59sK71A8pmecJPaI+B7OBSID5Vlrh0YBOZXAT +ASVcisOUrIUE6jV4xCbcPH62iUSxP3n1i6QBXfi+UhsVez+vmzKPOVjnp6TH26zGd7QsL pNVfoInaus/sxs0uxrWzZQaXye8gK+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707755464; a=rsa-sha256; cv=none; b=ELNETp8aINlOOhxtz4R4IcUxqOvwlB6HgpExpYv7VBjyO8ejgF/JsFsk0OIRq7CKaMqTN9 3nbf4ITnnuwJh8aoHpe8GRcc0mryZaWFMp/nHkKj8/6xKJ8JSQMD4STZhILLaV+nRyQzJI A6qO5AREdpNWz4NEp25Ox6buYW2Garo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=kPjffymB; spf=pass (imf06.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1707755463; bh=78QteBENnmm+/z8tDMucsXOLPT3JPBJzzEePzC51z6Q=; h=From:To:Cc:Subject:Date:From; b=kPjffymBumPkN0jHfJ2pZQug2BmE+XLTR9XjyVcfnVzogFypi6zhaAiyosDHIPxFE JtdmC04KVmlUIjGPUg/TMFlN+1JWIX4TnzakWJgfTaOlvpEFjZ/o0nYC0hafDX3JMK /e3DhKEcRfYNbxXp8CPJEZ/M5sPooLb5moklGrAnvP8IWpokPCKFyc8zjp7FxYrWE1 wSH5eHsEzvmfCPBeq7/N3Mu59DFGY75AN2FFiLyuyZFBVuvwIUT2h/MrhTK79avcWs 14eLRExiDdQeypMzYN0sOQRKr8Cu165spyZ/nu/Crxp1TuYIhzbuJfnN98Sb8kTcW1 RWgiOarAoDw5w== Received: from thinkos.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TYVMC0NW7zXvP; Mon, 12 Feb 2024 11:31:03 -0500 (EST) From: Mathieu Desnoyers To: Dan Williams , Arnd Bergmann , Dave Chinner Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org Subject: [PATCH v5 0/8] Introduce cpu_dcache_is_aliasing() to fix DAX regression Date: Mon, 12 Feb 2024 11:30:53 -0500 Message-Id: <20240212163101.19614-1-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Rspamd-Queue-Id: 7340718001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wt9rrjud78hhm1hrd8sdoaogg3f853p4 X-HE-Tag: 1707755464-638029 X-HE-Meta: U2FsdGVkX1+MEVCmzUXKS7Ryk+sjUN+JacAFo5LK5ypORaI5+S08HSlR2Pyq27kZqpFvshBbZauinq8VhlyAumB+BlDAJapYLWed1n5UrmMby3v4jHSDdq9R0+5emiXj9YfbuNKtqeDv7F/NREEElxnbsy2V3ui1HixDnuefzce8IM+xlF4HOhG+eju8q4zReNE3WuPmpx1DMH1ommSLRprVj1tIJTuo/AedVY9NLV2+CpWLNijSlcblySzw1H4f+7X6qVBVE5Pgp6zK1vq9OalTsVMVWVDgQDuylQKZTvmEpIJzf5HeyKOJqXav0+jOGXEATKqbuEoGxxENiJOi1RI08BWU+5Ob2qN3NCKXVkfx95X0r6Sk9K01JRPBdLtHejPG7AhkRbpLKounyKH82SXucKdXcGCApWxc4qX/kbif7rhTHBEtlboqw5+dLUCATouugx7D4/8Jjx8ZdOZJi95W/ayBqBCz7kCn8QnxB/wK6jVTb92P5tJxFhjnOzkHnMWmgF8NTtsfgRLsyvpT6eUvRNV6pLUMhupotZyNgpDZitdqjdf9d6zYJzHs4NyVRP6ANVm13WRb+cQAUwvPxvt+a9pHimxgNY8LUKHQDCdcPDs5wl7B7d8M5dkfJdOuB5PjS+Nv1fH6CWDpQDpFj4OTfbo716v/z05U8MnPLZN1oAQwUquAZdmNugsedtz9G/7rHvTEmPpaSnrLTcfojq9Emn4zMeVYECR4BW5ppYoecCYmP1D6QTG2qGhcc1UwsswNwFSwBYKkVCtwYA1MfTAwP4NL0rBlNgMnCHo0d9+aFYu3HqR+iSPuI3PGOhF8DRnN6utII7NV6sZPq6F4Y6sj7+NmAWrKNvLyewa0ZaAZNETJrKgH0E6lzBvLOuafBw8+UG4D9MqhvZ8Mg4sSEdYhBIDbNfN/z0wU0Y24HPyqVloVXt/oDGSEsKNyc69PYKLJ3b2KTc3DSvqcKkB USUI1jpf uGkRTPEz/e8n1si8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This commit introduced in v4.0 prevents building FS_DAX on 32-bit ARM, even on ARMv7 which does not have virtually aliased data caches: commit d92576f1167c ("dax: does not work correctly with virtual aliasing caches") It used to work fine before: I have customers using DAX over pmem on ARMv7, but this regression will likely prevent them from upgrading their kernel. The root of the issue here is the fact that DAX was never designed to handle virtually aliasing data caches (VIVT and VIPT with aliasing data cache). It touches the pages through their linear mapping, which is not consistent with the userspace mappings with virtually aliasing data caches. This patch series introduces cpu_dcache_is_aliasing() with the new Kconfig option ARCH_HAS_CPU_CACHE_ALIASING and implements it for all architectures. The implementation of cpu_dcache_is_aliasing() is either evaluated to a constant at compile-time or a runtime check, which is what is needed on ARM. With this we can basically narrow down the list of architectures which are unsupported by DAX to those which are really affected. Testing done so far: - Compile allyesconfig on x86-64, - Compile allyesconfig on x86-64, with FS_DAX=n. - Compile allyesconfig on x86-64, with DAX=n. - Boot test after modifying alloc_dax() to force returning -EOPNOTSUPP even on x86-64, thus simulating the behavior expected on an architecture with data cache aliasing. There are many more axes to test however. I would welcome Tested-by for: - affected architectures, - affected drivers, - affected filesytems. [ Based on commit "nvdimm/pmem: Fix leak on dax_add_host() failure". ] Thanks, Mathieu Changes since v4: - Move the change which makes alloc_dax() return ERR_PTR(-EOPNOTSUPP) when CONFIG_DAX=n earlier in the series, - Fold driver cleanup patches into their respective per-driver changes. - Move "nvdimm/pmem: Fix leak on dax_add_host() failure" outside of this series. Changes since v3: - Fix a leak on dax_add_host() failure in nvdimm/pmem. - Split the series into a bissectable sequence of changes. - Ensure that device-dax use-cases still works on data cache aliasing architectures. Changes since v2: - Move DAX supported runtime check to alloc_dax(), - Modify DM to handle alloc_dax() error as non-fatal, - Remove all filesystem modifications, since the check is now done by alloc_dax(), - rename "dcache" and "cache" to "cpu dcache" and "cpu cache" to eliminate confusion with VFS terminology. Changes since v1: - The order of the series was completely changed based on the feedback received on v1, - cache_is_aliasing() is renamed to dcache_is_aliasing(), - ARCH_HAS_CACHE_ALIASING_DYNAMIC is gone, - dcache_is_aliasing() vs ARCH_HAS_CACHE_ALIASING relationship is simplified, - the dax_is_supported() check was moved to its rightful place in all filesystems. Cc: Andrew Morton Cc: Linus Torvalds Cc: Vishal Verma Cc: Dave Jiang Cc: Matthew Wilcox Cc: Russell King Cc: linux-arch@vger.kernel.org Cc: linux-cxl@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-xfs@vger.kernel.org Cc: dm-devel@lists.linux.dev Cc: nvdimm@lists.linux.dev Cc: linux-s390@vger.kernel.org Mathieu Desnoyers (8): dax: alloc_dax() return ERR_PTR(-EOPNOTSUPP) for CONFIG_DAX=n nvdimm/pmem: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal dm: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal dcssblk: Handle alloc_dax() -EOPNOTSUPP failure virtio: Treat alloc_dax() -EOPNOTSUPP failure as non-fatal dax: Check for data cache aliasing at runtime Introduce cpu_dcache_is_aliasing() across all architectures dax: Fix incorrect list of data cache aliasing architectures arch/arc/Kconfig | 1 + arch/arc/include/asm/cachetype.h | 9 +++++++++ arch/arm/Kconfig | 1 + arch/arm/include/asm/cachetype.h | 2 ++ arch/csky/Kconfig | 1 + arch/csky/include/asm/cachetype.h | 9 +++++++++ arch/m68k/Kconfig | 1 + arch/m68k/include/asm/cachetype.h | 9 +++++++++ arch/mips/Kconfig | 1 + arch/mips/include/asm/cachetype.h | 9 +++++++++ arch/nios2/Kconfig | 1 + arch/nios2/include/asm/cachetype.h | 10 ++++++++++ arch/parisc/Kconfig | 1 + arch/parisc/include/asm/cachetype.h | 9 +++++++++ arch/sh/Kconfig | 1 + arch/sh/include/asm/cachetype.h | 9 +++++++++ arch/sparc/Kconfig | 1 + arch/sparc/include/asm/cachetype.h | 14 ++++++++++++++ arch/xtensa/Kconfig | 1 + arch/xtensa/include/asm/cachetype.h | 10 ++++++++++ drivers/dax/super.c | 14 ++++++++++++++ drivers/md/dm.c | 17 +++++++++-------- drivers/nvdimm/pmem.c | 22 ++++++++++++---------- drivers/s390/block/dcssblk.c | 11 ++++++----- fs/Kconfig | 1 - fs/fuse/virtio_fs.c | 15 +++++++++++---- include/linux/cacheinfo.h | 6 ++++++ include/linux/dax.h | 6 +----- mm/Kconfig | 6 ++++++ 29 files changed, 165 insertions(+), 33 deletions(-) create mode 100644 arch/arc/include/asm/cachetype.h create mode 100644 arch/csky/include/asm/cachetype.h create mode 100644 arch/m68k/include/asm/cachetype.h create mode 100644 arch/mips/include/asm/cachetype.h create mode 100644 arch/nios2/include/asm/cachetype.h create mode 100644 arch/parisc/include/asm/cachetype.h create mode 100644 arch/sh/include/asm/cachetype.h create mode 100644 arch/sparc/include/asm/cachetype.h create mode 100644 arch/xtensa/include/asm/cachetype.h