From patchwork Wed Mar 6 12:32:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 13583997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6001C54E41 for ; Wed, 6 Mar 2024 12:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42B376B0072; Wed, 6 Mar 2024 07:31:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DADE6B0074; Wed, 6 Mar 2024 07:31:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27C036B0078; Wed, 6 Mar 2024 07:31:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 14C9E6B0072 for ; Wed, 6 Mar 2024 07:31:10 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D286114043C for ; Wed, 6 Mar 2024 12:31:09 +0000 (UTC) X-FDA: 81866549058.19.4C153C3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf18.hostedemail.com (Postfix) with ESMTP id 893981C000C for ; Wed, 6 Mar 2024 12:31:07 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aKwnTMXN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=sWi4DkF+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aKwnTMXN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=sWi4DkF+; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709728267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=7k1zCH7rJUyjn+pQMiSRznsRTbRsX0fOvgjrgBeV6A4=; b=nPBHqGvjPAG1pCGlHe4gMvn4nJB6oibMyvijT7GE/eMuQX8vSUDCJdsBErBffH5doWKWn+ Yd/cAChX17hlLethDX4LuwHfdnnjk2p1EogyW+WTDitTZb24vsCKSYzFYXzs87O2ggo+mT uaKKW6NyMF+D9oHubjy0gIPgoflTop4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aKwnTMXN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=sWi4DkF+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aKwnTMXN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=sWi4DkF+; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf18.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709728267; a=rsa-sha256; cv=none; b=QcytYFZDpQGuvKBElLVxILOLjUFQeey7VrA9HoTgK0w3lTlbbZIacu/x6U7ZlMISZrsAC2 GDorRYzA+ep3IwdvjLhpeq5YPj+VAGSejKM6r5e5jqkYesXpC8stS0p0taDyAUNVL9J337 HrsYl/nGZq+ma08s/+x2TNDZZKFt4KI= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 888F73F175; Wed, 6 Mar 2024 12:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709728265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7k1zCH7rJUyjn+pQMiSRznsRTbRsX0fOvgjrgBeV6A4=; b=aKwnTMXNgc9REm9yqZG4yA7xSay4ad6HAcMCKrWtKwCYNleez1FK92Qz6clVUOUpy9Jt0C Zs0r+XGUCLu1vS9vILHj+BsdBtKPlihx12HQXqiQbTBtupSQXh2BPvmI1Sa+SQDRMIVol/ Yz5zqIWS/PWrDmwY5y+OAI5WNSZ3UZ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709728265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7k1zCH7rJUyjn+pQMiSRznsRTbRsX0fOvgjrgBeV6A4=; b=sWi4DkF+w0Aacvtstg/Auv+UtdStARm08STTABEHlxz3u3VQnQD+OtCKqbYfjhYR1VRioB UmkzZO5c1JDPpMCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709728265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7k1zCH7rJUyjn+pQMiSRznsRTbRsX0fOvgjrgBeV6A4=; b=aKwnTMXNgc9REm9yqZG4yA7xSay4ad6HAcMCKrWtKwCYNleez1FK92Qz6clVUOUpy9Jt0C Zs0r+XGUCLu1vS9vILHj+BsdBtKPlihx12HQXqiQbTBtupSQXh2BPvmI1Sa+SQDRMIVol/ Yz5zqIWS/PWrDmwY5y+OAI5WNSZ3UZ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709728265; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7k1zCH7rJUyjn+pQMiSRznsRTbRsX0fOvgjrgBeV6A4=; b=sWi4DkF+w0Aacvtstg/Auv+UtdStARm08STTABEHlxz3u3VQnQD+OtCKqbYfjhYR1VRioB UmkzZO5c1JDPpMCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id EFD411377D; Wed, 6 Mar 2024 12:31:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id PbCJNwhi6GUaTwAAn2gu4w (envelope-from ); Wed, 06 Mar 2024 12:31:04 +0000 From: Oscar Salvador To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Vlastimil Babka , Marco Elver , Andrey Konovalov , Alexander Potapenko , Oscar Salvador Subject: [PATCH 0/2] page_owner: Fixup and cleanup Date: Wed, 6 Mar 2024 13:32:15 +0100 Message-ID: <20240306123217.29774-1-osalvador@suse.de> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Spamd-Bar: + X-Rspamd-Queue-Id: 893981C000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7n68dgktmtsrf9uw4tkopyjqmb46w9ui X-HE-Tag: 1709728267-325659 X-HE-Meta: U2FsdGVkX19APQYtrAuKi8q1S+g3fzFa4rwiSBlYBwc06DZxHABbhVNQUNqC6BzmRS2RKkzx7pvy4YR/o7wGTWNaF/DxZ4b88rrVLAPLg0Ne5c2ztl0CoOo7yjThSOY2tjmhG439XM/yBJvttpW/XIXN9xfqJeHzPyfpoDEmUv5Zh3H0wo2fu5jZieh79TVKmO3V6RiPFHKJZat7huwltf6zIw9PEomZZLQNiFL2DxU99APxu3vctZrpl0vuD7PGykiDwo9p2x6EpTf8SLFyhs7sINb+oZtYRYss8fbtLNJdGoHrZEnF9V7xCNs4mLaESlwNOvVBoLvfOST+AZ4jRM5dmmEvQEZY5yXX5hAhT1+kXWpQ6BmuoyZLkCVfuIBxfyNfq8pxFHhOSgTfkDYHEkZ1MelWVsSngo1FRVmWkV2I2iSLAyi1DuWPNVFTjcy0aMFHKCT1WLw/MVNvch63Eg2L4hCAmYJe4cgxWynGG2lqZ/GQNscOKDQZBq4ted+Rd/Nxu5OrOXBabpVDSlxA0nKr6FhY6py/FiRW5KUDylCH8HmP/Poh5c+qsXRPWVkp3hP5uGq6+SfG/ZBPmymIQ47rqeHEmJcUlxeWSFgPNUKjkQHWg/UUSSMT30gU+35dYhVre7UxClFy4YCLko8+n/5XbL7s8KjIXUS1k5TMa5sw5g1NP2QEe6r5G349N5BHvspzTY2gqMOxIummuqzLPpODYZbJ1GoJjUzw5tAdPrCyCE2sk8vXsOb+ayxDX6w1rfSUNKsdifkHsz47VmCa9hWsQvL/J1SMfFX9mJlovyk9X4U+p9Eq3mFFmvmT0PTXeff0XlkdRsMXW6QRZvAPWi/WxW6KGPkMbW+Lgo4hj8wI4JI6Lq4sGz8uCm1ymVC38/NB6MnBkO8JBNBMeRAU51YQ5NM3ZlrEzZDuXGZ9bSmbYeEa3Q6ScJV66IIQM6jeIls+mcJFJjH/2Cotgoo GNsZ5Gmp dMb3LtPn0KAQuZndIwQtx9F8IT2s8A0S+Pa8wC501jfckv50y6aqGZZTVDvV82zDoEfjdrN9OtvqfdQIfYjAtre4oB1bo7+qcGCpk57Pj+nqXD94OCZKCEL4GSIq2XS8rjQG4BEgcctgIyx3bsJj8vU5sbS/INqYWtW2wzfOwRPPOKArm36P1gKFZtGTJHmeEgxzyXkqOzl6qkheulMOnSc/SxRxyytVGoGrMdJzOr58Dvt6te0QEWzMo5Gp5xk9Hg3HlPuBJr3i6HGlhDrveYMesFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, this patchset consists of a fixup by an error that was reported by intel robot, where it seems to be that by the time page_owner gets initialized, stackdepot has already depleted its allocation space and returns 0-handles, turning that into null stack_records when trying to retrieve the stack_record. I was not able to reproduce that from the config because it booted fine for me, but when setting e.g: dummy_handle to 0 artificially, I could see the same error that was reported. The second patch is a cleanup that can also lead to a compilation warning. Oscar Salvador (2): mm,page_owner: Check for null stack_record before bumping its refcount mm,page_owner: Drop unnecesary check mm/page_owner.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)