From patchwork Thu Mar 21 03:27:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 13598362 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCD9C54E58 for ; Thu, 21 Mar 2024 03:28:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F39106B0089; Wed, 20 Mar 2024 23:28:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC06C6B008C; Wed, 20 Mar 2024 23:28:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB2896B0092; Wed, 20 Mar 2024 23:28:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BB0AC6B0089 for ; Wed, 20 Mar 2024 23:28:55 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 60FA9140758 for ; Thu, 21 Mar 2024 03:28:55 +0000 (UTC) X-FDA: 81919614630.18.4B11F90 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf22.hostedemail.com (Postfix) with ESMTP id C7676C0008; Thu, 21 Mar 2024 03:28:51 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710991733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=ykVaU5FE2L4/B9dlkyU+l4ZQg+q5IKEsUmRB7GI/mU0=; b=KwfkQQSXMV5UyCQv0PX/hXLuNrX2c7BJWoD+PYIZudg1QaFBMFyud/vcs+NI8nIsCs3Tz2 jR0weAD6+sWwXA1JQn/6wlNJzesZJg/yeY22KnyK3b1jmsWhrsGzLJIVu2E3941Wycuu4m PmaqzTOptPaKnkfMl7jXF4LM0GvKu1o= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710991733; a=rsa-sha256; cv=none; b=07J4bkT7TIzxbCj/npRVHP1tJ7Tv507mTZp3YdtD3XeaUbUEXykGmSupKEPMGj9+DjhCYa x98txWJstSKtq/g29iklWWR36OrAgllfiXDUgXGoNkbupahBq7cVifJLrMRGRneZBEvgvj lyluUmYzztCwf8qEvH1PqMw+r4mxmqg= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4V0WB86pN0z1vx2r; Thu, 21 Mar 2024 11:28:00 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 83F441400CB; Thu, 21 Mar 2024 11:28:47 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Mar 2024 11:28:46 +0800 From: Kefeng Wang To: Andrew Morton , CC: Tony Luck , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , , Zi Yan , Jiaqi Yan , Hugh Dickins , Kefeng Wang Subject: [PATCH v1 00/11] mm: migrate: support poison recover from migrate folio Date: Thu, 21 Mar 2024 11:27:36 +0800 Message-ID: <20240321032747.87694-1-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: C7676C0008 X-Rspam-User: X-Stat-Signature: 81ohpeye3mchdaaf879r9j6w4sbph4yb X-Rspamd-Server: rspam01 X-HE-Tag: 1710991731-359595 X-HE-Meta: U2FsdGVkX1+up8ACehiuKC0JJ6DDFGoSYh1qBrfw4sQ7tdCUUJY5WOXeRVNqD29J47zX7E6HZJ5QtQT8JV2VHnuHtkMxuKR5gl5pTTw8R8rb2NAGd0Vi/mn65WmCalrFPbwD2yBLDhAe70AxrIY7KLtJvJ/8pqxgmP83py17Rw4lIfrrZoUkaURLh7rq8cUU9tJb5IfGNj4fFRhxxP7LNl7vmf0NIJGrfq6VvjJUJGI/Q0JZ5vcwMoS1+LsjqEpOdlgt9kpJHtcPD7HNwAd3WQsiF4XyxcLRc2bRi+dEPfeTtKJNtw20/SYxuo7/8FV1bs/OJ2IdypkTxgofy3y1jtW03F+B9qwgOI6F2gfPtuZUoR0q3vOM46F2dNKWTB9pm5HYb34qqivrTcsTXrEcKdKs19Q9iZEJOvz0KZnb19MgZ+dSVeDE2hGauarOEtR6RUuv61IeZ2VL844Ao8HXP/axj0y8uejSyUimvCKR8Yc+Xc+2iHqI2z4Lca2BJ+PdJU887bx1nkG5VZUDJMfXTU9ob2uRfSq/RKrBqIR5pwpER2iHmQXhbsq94ABGrw/6VwiuYMkF05lwfTv9iNjSU8ZOovvMv2u/otdkBTl7jeSvaUERPc7gr/9w8Fd9kPVvc4M2FSvggsn8Xu4sgKB5pWLNIDojw/81XN/IfRWKxbCZftuwd1faqqG33zBppG3BAvw4UUWjiYYgKZ2a7XSdrj+DlFD/joHsCGEn20STtXFxfherDlCAx54HMtIGpPdqcNc+HHz3niUQTg3XJmFlhLVW/l3uyvJhsBX0nmZzgTS37lBgdClcAIqPbjt4zxmesRw2I3T7F5z9bp88V1vbcRW5cgtC8cwMfdL2QJn3ngAoZ/qIiaC/ys+sO6oLL75IgqXcsCVTN1aSthCdXp9MjFk3pDIRmofb3Xz4tU3b+Ddwr5aZjbd+U/sdX9un+PtprMt4IYLaQoUtn1R1Jbn h1hWGTFu PNG08rfebABOdCJAPlD/RvjJNOqU1+fF1AOX/ZvD6p+Xulps+G+m7sITQudJnVYBP9Ek7nmCd20XFnOzjHKQvduQVutvHm4lnbctZ6ihXL43wgzDTohpZXKwp4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The folio migration is widely used in kernel, memory compaction, memory hotplug, soft offline page, numa balance, memory demote/promotion, etc, but once access a poisoned source folio when migrating, the kerenl will panic. There is a mechanism in the kernel to recover from uncorrectable memory errors, ARCH_HAS_COPY_MC(Machine Check Safe Memory Copy), which is already used in NVDIMM or core-mm paths(eg, CoW, khugepaged, coredump, ksm copy), see copy_mc_to_{user,kernel}, copy_mc_{user_}highpage callers. This series of patches provide the recovery mechanism from folio copy for the widely used folio migration. Please note, because folio migration is no guarantee of success, so we could chose to make folio migration tolerant of memory failures, adding folio_mc_copy() which is a #MC versions of folio_copy(), once accessing a poisoned source folio, we could return error and make the folio migration fail, and this could avoid the similar panic shown below. CPU: 1 PID: 88343 Comm: test_softofflin Kdump: loaded Not tainted 6.6.0 pc : copy_page+0x10/0xc0 lr : copy_highpage+0x38/0x50 ... Call trace: copy_page+0x10/0xc0 folio_copy+0x78/0x90 migrate_folio_extra+0x54/0xa0 move_to_new_folio+0xd8/0x1f0 migrate_folio_move+0xb8/0x300 migrate_pages_batch+0x528/0x788 migrate_pages_sync+0x8c/0x258 migrate_pages+0x440/0x528 soft_offline_in_use_page+0x2ec/0x3c0 soft_offline_page+0x238/0x310 soft_offline_page_store+0x6c/0xc0 dev_attr_store+0x20/0x40 sysfs_kf_write+0x4c/0x68 kernfs_fop_write_iter+0x130/0x1c8 new_sync_write+0xa4/0x138 vfs_write+0x238/0x2d8 ksys_write+0x74/0x110 v1: - no change, resend and rebased on 6.9-rc1 rfcv2: - Separate __migrate_device_pages() cleanup from patch "remove migrate_folio_extra()", suggested by Matthew - Split folio_migrate_mapping(), move refcount check/freeze out of folio_migrate_mapping(), suggested by Matthew - add RB Kefeng Wang (11): mm: migrate: simplify __buffer_migrate_folio() mm: migrate_device: use more folio in __migrate_device_pages() mm: migrate_device: unify migrate folio for MIGRATE_SYNC_NO_COPY mm: migrate: remove migrate_folio_extra() mm: remove MIGRATE_SYNC_NO_COPY mode mm: migrate: split folio_migrate_mapping() mm: add folio_mc_copy() mm: migrate: support poisoned recover from migrate folio fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio() mm: migrate: remove folio_migrate_copy() fs: aio: add explicit check for large folio in aio_migrate_folio() fs/aio.c | 15 ++-- fs/hugetlbfs/inode.c | 5 +- include/linux/migrate.h | 3 - include/linux/migrate_mode.h | 5 -- include/linux/mm.h | 1 + mm/balloon_compaction.c | 8 -- mm/migrate.c | 157 +++++++++++++++++------------------ mm/migrate_device.c | 28 +++---- mm/util.c | 20 +++++ mm/zsmalloc.c | 8 -- 10 files changed, 115 insertions(+), 135 deletions(-)