From patchwork Wed Mar 27 13:05:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13606609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A8EC47DD9 for ; Wed, 27 Mar 2024 13:05:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6A646B007B; Wed, 27 Mar 2024 09:05:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1A706B0082; Wed, 27 Mar 2024 09:05:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE3156B0083; Wed, 27 Mar 2024 09:05:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AEFC46B007B for ; Wed, 27 Mar 2024 09:05:56 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6F7CBC02B4 for ; Wed, 27 Mar 2024 13:05:56 +0000 (UTC) X-FDA: 81942841512.18.6163232 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 0E869100036 for ; Wed, 27 Mar 2024 13:05:52 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NmFH0Y2d; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711544753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=rNcKksIhCQ6uwQhIYkqsC9yoUW4iGyOTSKFTVMknF84=; b=cJwVdpZQ/QWX4SlCDB6hDzUKp3iRxwbNJXNBOykbpUJMy5dWN8M3u5MppIXY6TV/UBv0KF 482nNpS4gq5IHnK9mgKOxQbi0g0OrxNFbGKmeKt5/8kALfuuktTdpvTTtmiEGnRMgsJG3x JImq9D9A2TPZPD3Mik6ThyYll0u4vqU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NmFH0Y2d; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711544753; a=rsa-sha256; cv=none; b=1DXWX2DwAKSrQ7FgItIU+BKHjjxYky18MicgXJX4XlqQWZaSA29vsVcAfWoq7M3nbQg6Tl K1BqGee1hAVspzkl/wW7UGJzC/HYO+XRnJ8OYVge+IP4rMEiPMYq0wLLvX3N6wpqrv2FsU MrbUWk3joi56GYqhr1rXmFgK9WlqOPM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711544752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=rNcKksIhCQ6uwQhIYkqsC9yoUW4iGyOTSKFTVMknF84=; b=NmFH0Y2dBGMlH2kMD7TAonT/i51W70HXIQk9oyQ6FXjPyY+a9k7ok0CrWL2E1QHKrGRT9N I/F28CBmn43TUT0H6LpecL1i4d4N+qx83mMIFN5KX/LiNuqqjZjvj1ncC2++3dvXVzbv+F rFA00F0MYaW609wQ4U17WvaUfe2nHzA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-hmCVBBIZOmqVEcZ9AutL7A-1; Wed, 27 Mar 2024 09:05:47 -0400 X-MC-Unique: hmCVBBIZOmqVEcZ9AutL7A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B304D85530E; Wed, 27 Mar 2024 13:05:46 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.193.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id E78F81C05E1C; Wed, 27 Mar 2024 13:05:42 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: David Hildenbrand , Andrew Morton , Mike Rapoport , Jason Gunthorpe , John Hubbard , Peter Xu , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org Subject: [PATCH RFC 0/3] mm/gup: consistently call it GUP-fast Date: Wed, 27 Mar 2024 14:05:35 +0100 Message-ID: <20240327130538.680256-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Rspamd-Queue-Id: 0E869100036 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: bxc1j3k3tz88p8f99dyw93exgy5tgu9d X-HE-Tag: 1711544752-875915 X-HE-Meta: U2FsdGVkX18GtBK//lucSJUzDzb7TZlg9VJ6DsNtC5WWNUfHk6Jxe5dZSBHehlyAQa1r0caOG3MFWesEaxrltzr+ZwoOjVoJr/mmlCM3IZB7Kbqw2C/7kAf/7sl2QQGSzRHZ6Sd8yIdeZEcdqmC+Ctpv8U1KfO0tEExKDZ5dwo6YoKOS95tJ1Hbcw6C989TEQ7+W0zkauekVrQ9TpZxfOTpNHU7+2cVnI3EN6nfOjVvFmfmiEM5PurP4NrU3sWcbkMc4eAvov4ig4Iw834y7W9XjpLs6a1bJxUFyjzxaurwLQO/dN/cqGWrS9JC6AjnBShaX8EOed3tO7AOps6wlaMro3fLi2G5FbN4DFJuE8TvzNShdp2mLE/UD9LQbVAr8pqzurGaOHtygRoUC8OMv4matC8IpLoy35dg0T6NYkNzgo/jzm/oFPvwUkbsZy3UrV47pQKfr13Bd+Y/PyIMFzqlRJyetStEo+gI3ONUMS/DYhABFciLE3xRNxVsgXfXrk6Jz21UXLGFUmwj91IQPuQe7fa887r31qQgnpKmLIAGqaQelpAOErQp9w+VjpDIFXcVAnglndizfZNhVbCB9s8uTlUtz7VQ58EYo5En0XfDXEVTFppTHX/bu7+ijKJYVi2rZEa9Xsr5Poku3UhZ4CVzote2DL5zOvZ+izmZ9Qp6AW+hcD4BYQtWi1oJd8/k7ZQbci/m6RAZ47Af4zGPntZpQ/bquzY9Y28iGnCCAbxBslMn3WNKJck+PBhwyWiBbcBdvXuXLde0717xYRx0ouo491c/oOc08icWvab723dqBiD8/LfhYyDAl7XbxHGH47YvdNz4PeziaaN4ErhyAlwAVTJjEDvyFQFHyB9FWl6vaP5g5dd9wCk+Ct5p7hss7aUr0oTYfhHD90pForGyJzOAt4VlCXtGBEdqJIare2xBQ4nxMRlXMf5MldMwpYcVQsbuG79xijerORZ0vPik Ra6FeUI2 deDUE/H61n4+8cDFhC+kDj1Og8jQHZXU5YjDk/uNQcf2+qUQmYypKOPYRDFfc6vRBEWwTZGKBDcT4utys4reP8Wuc0qqE5YgKHjQkJ83b+lKoT44E6YS6KzEroGpXCj5koB3MfAkZVT5MZ3lr0nWR3PofmqTY0zoRG+8ELwvpnT0gIVw5PNmcEUQywr66VNZJ2OV7od0H9TgdaUMeiNSZF95/VlLszi0meIvYwUdTy07QOiQpQRbdeU24O8h2fMtt+peHoTpXjfYjX2qAuy0HFd07wlx/VvmVPyKGbD62wN2wV9BhU1hZyYU29H2InqkRQSViVGLam3jFapVYTe8v7gXnirxQTJDAlglzQjMl1Kx1ZYvXchAMXO1uxXiRQPE8Jj8mKrVLCY4Tvu4Du7hML+mUmLUyKI0kvH1St5Npit+v/3Ift/uLr8iiIB/ZEQJhALc2WervViidLdb4pKsjpoMm2ILRvFlBFEmzLZ4+7uWGwUBjOfuuigcZMCopa8tK1OJrHoKV9GHzmQ/65Ze7kfVCuQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Some cleanups around function names, comments and the config option of "GUP-fast" -- GUP without "lock" safety belts on. With this cleanup it's easy to judge which functions are GUP-fast specific. We now consistently call it "GUP-fast", avoiding mixing it with "fast GUP", "lockless", or simply "gup" (which I always considered confusing in the ode). So the magic now happens in functions that contain "gup_fast", whereby gup_fast() is the entry point into that magic. Comments consistently reference either "GUP-fast" or "gup_fast()". Based on mm-unstable from today. I won't CC arch maintainers, but only arch mailing lists, to reduce noise. Tested on x86_64, cross compiled on a bunch of archs, whereby some of them don't properly even compile on mm-unstable anymore in my usual setup (alpha, arc, parisc64, sh) ... maybe the cross compilers are outdated, but there are no new ones around. Hm. Cc: Andrew Morton Cc: Mike Rapoport (IBM) Cc: Jason Gunthorpe Cc: John Hubbard Cc: Peter Xu Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-mips@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-s390@vger.kernel.org Cc: linux-sh@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-perf-users@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org Cc: x86@kernel.org David Hildenbrand (3): mm/gup: consistently name GUP-fast functions mm/treewide: rename CONFIG_HAVE_FAST_GUP to CONFIG_HAVE_GUP_FAST mm: use "GUP-fast" instead "fast GUP" in remaining comments arch/arm/Kconfig | 2 +- arch/arm64/Kconfig | 2 +- arch/loongarch/Kconfig | 2 +- arch/mips/Kconfig | 2 +- arch/powerpc/Kconfig | 2 +- arch/s390/Kconfig | 2 +- arch/sh/Kconfig | 2 +- arch/x86/Kconfig | 2 +- include/linux/rmap.h | 8 +- kernel/events/core.c | 4 +- mm/Kconfig | 2 +- mm/filemap.c | 2 +- mm/gup.c | 170 +++++++++++++++++++++-------------------- mm/internal.h | 2 +- mm/khugepaged.c | 2 +- 15 files changed, 105 insertions(+), 101 deletions(-)