Message ID | 20240402073237.240995-1-21cnbao@gmail.com (mailing list archive) |
---|---|
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D02BC6FD1F for <linux-mm@archiver.kernel.org>; Tue, 2 Apr 2024 07:33:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0E796B0082; Tue, 2 Apr 2024 03:33:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBF136B0089; Tue, 2 Apr 2024 03:33:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5D856B008A; Tue, 2 Apr 2024 03:33:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 873DE6B0082 for <linux-mm@kvack.org>; Tue, 2 Apr 2024 03:33:00 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 18C3580951 for <linux-mm@kvack.org>; Tue, 2 Apr 2024 07:33:00 +0000 (UTC) X-FDA: 81963775320.29.3065F5E Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf07.hostedemail.com (Postfix) with ESMTP id 50AD840005 for <linux-mm@kvack.org>; Tue, 2 Apr 2024 07:32:58 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SPGRGBWN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712043178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Sm0eiWhqAyCrmv9J3HkyEaHHDQnKEUCewHOK4gvWjMY=; b=ohWMH6lNHvFhDc4FjIvQNXEwcwWnule/rfFbD3729N1Q1BYCOWWtxw+xM8fsRH+FjVujs2 Uec+ziPUmedQXzJL4TDje6fD2VZ3SbajJwt1v7Wcl0WlVKkFQY0Zu7cJllvgz9+PzISxG6 TBQ11fBC//tESARSj+z4cymJyjAyCeU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SPGRGBWN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712043178; a=rsa-sha256; cv=none; b=B5EjVjmZLx/h/589ApksW9cyXlldMAjyzFyB+URl33RR2s4bS2CtkR8KGC4Ysxg1Zpw94P szzD3Gx5Ca/RjvyurLSRo4RrRrmkOw5+tw2eMT/T1lf5QyeSmaGwfHL3Zxzo89DzeLqMKd RUnHMBrFCW7H6m6p7VpyRPpyCjGzD6w= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1e0411c0a52so40229975ad.0 for <linux-mm@kvack.org>; Tue, 02 Apr 2024 00:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712043177; x=1712647977; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Sm0eiWhqAyCrmv9J3HkyEaHHDQnKEUCewHOK4gvWjMY=; b=SPGRGBWNEXVrsiNsYygf0dMwAvQgk0QHBSlSc/pUMlTEujvCeTvgo7x6Pz5kxGZzcK Jfx0Hp1j9tkqQm5mieKFvye/mMfeMBla2XrzuC2SYVqNdeX5D29wUBEySzl79itTPDvC A3d3iQDSsQFwsoOpThWAa48zLcLppRlAFK8v5yX2gEw00tOQZcNkpgN1hBYzIufZlMH6 ckeCgqsXVVZCu3DiNLFyEIHhKAkW46M/Jm35Wy9ktjR+A3raCCnHNVSjCTB/sWDeEOac XVmoW8pH/FLf5lAr8lwhrZGj0gpZwJGHRIFW5G5e7bj3BzKHXamJcTMmtJo5uSWqz4xj fBIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712043177; x=1712647977; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sm0eiWhqAyCrmv9J3HkyEaHHDQnKEUCewHOK4gvWjMY=; b=P/q5CN1OzfFBTuVKkmfEaicXVOx2HlZvi2trTTB+SKqEVRiQZzmRZ4v1532OgDl8mS sRLTfIUTa7amqG8zlRc2sDZN8wcLWx3CGetbqo98JwKt70SBqud/zy5DktF7F7T8b2ta BAaXl1I442HcTBfqK5j0SMcVCm8B0UAT9tO554CUQqUdXuYvggJE2rNgTwrHBx5IwyAi AEUoMtt2RrxjIW2cDVU5ZLX7iBqWntdMeRGWxWg9YhjQd4O5j20OD9qOfIoy9teJtr81 mNrCAulTUrf6STChxhtLqg7qNIomgDsx0nFd1GzLIEu1lWidlSCB0CoMVnBHH00Ft9ds c+kQ== X-Forwarded-Encrypted: i=1; AJvYcCUyE7OIPhawV1t8JJ8k602tbHC/2s4Vu1Af/56YZjfgGjhHa8KGVoJgHGoDHepWhWuxJGMiP8zAZ0kZV6lmDqz8C+U= X-Gm-Message-State: AOJu0YzUYAUyYibaKHfEssYF4G87yltMBEiYQPp/1Bu7+w6tnr7r/rKK jc23kiw9JMYmNfx4KUj0S9inM5ydNHE8swWeAHiD0mZsGAFhQZ41 X-Google-Smtp-Source: AGHT+IFqhASzzOTjvjXha+bZND0ylMq+ShxL/ost39znoXOn1+CBDW9Gxat+S/c3SvsPQPjS6LFdGQ== X-Received: by 2002:a17:902:e94e:b0:1e2:3d05:5f4c with SMTP id b14-20020a170902e94e00b001e23d055f4cmr10982722pll.39.1712043176815; Tue, 02 Apr 2024 00:32:56 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id x15-20020a170902ec8f00b001dc9422891esm10187588plg.30.2024.04.02.00.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 00:32:56 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: david@redhat.com, willy@infradead.org, ryan.roberts@arm.com, yosryahmed@google.com, hughd@google.com, hannes@cmpxchg.org, surenb@google.com, xiang@kernel.org, yuzhao@google.com, ying.huang@intel.com, chrisl@kernel.org, kasong@tencent.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, hanchuanhua@oppo.com, Barry Song <v-songbaohua@oppo.com> Subject: [PATCH 0/4] large folios swap-in: handle refault cases first Date: Tue, 2 Apr 2024 20:32:33 +1300 Message-Id: <20240402073237.240995-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 50AD840005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: s8j1ok4njmffzngc3ijfskxpydgcjh4c X-HE-Tag: 1712043178-670997 X-HE-Meta: U2FsdGVkX18wmCtyll5YS5rD50lI5B/9Uv++BkcV/VzrBiJSk7VPY7u33qijkLm/m2TNTirQbQstq2uBnBggIP0yiZPnLgafPs0DdPedlhLF9luYuGoJ6WihZ3du1W3CD4DfNPLd/KTl5kLRNFz/vxUt/AMcshj1HqEQV8voNo6TBw9Ues3SIokR+MM+TU/ARfz1yJkfHhshoYGN/CWBHOp+5U7EtQ8NyZOTwyVL3CgZh+oiZfcJK8ys5tQcrrGAnM16lIBhxUwbfB4WFL//SlW8xFmefk+a03zvtARnux95d2cxMkLzpUZEMQ/5WBy8iCCtdmNk+4lqNJYbwD7MuSexJgDKvRQL7uYgGL6BiMkQ0WoKioYwzXq1BH2/Q+SWzGA8JdLdvCua2wsgF0UAkdJgZ9jcBZXHiFmZMRoDNk+0LizTcKE0k7qBIX3PqLY6MSV1oDxPnM/wYV2WjPpBBXk7gocGcLg0SgZeAdn/a5dLCkvfstV0Y7F07tQb/suLU1nStOINrcJh6HW563n2PtO3jbblAhYfoTwm1WLXjeV6AYwSiCI+2Fv+cAUIFnzoTq0cVqtsekae7wbm5jDERzzKwkojT0NRUxnPZ4Cadf4d6gZy03858Np91LELrj9jvnUHW9Jm6i7PuX7jYknObMcuiTsswnEjBWIvzQ1hyu8pafbqMb4sYGhtcR4Bji2/10s1wkdByrdpd+IM+82vTiaH0gaRjhEUGBzNyW0tfPPoUoajMUAg30ym5t6MQNT6nB9wKnCoKyYadU7jmoksTJN6E2jZVtSXD2fXp281p3ut4JLc8nHXvFlBSYWo2vZB6YDU+pELzxpfOIJgH6agndQq76pthS43UDfAw8P+FLSR5bap2jf3rKJbJUef9giwqixosyqyU7atOyjgpcvVIMXzVUXnEtm8ImlBVhdI8PNI91bma0A2gVKjFTbZIs64irbk3OlNwqcdr3PJziA QfvVrKUl mjdc3ZzmBbkxxtPavVsyj7SmUKNcrATGLr4NPZIjhgWximxEuoZ4X+UlLBKnb/GBGcbkom3BDLcot7awCxXYr5Hibn9nz749JkllwDDkCLt8Tnhio4f1uMyZXXMwpeUx+JsnF/eXjuUJLgRPbKG5f9XODt2DUGJGhGhe1Nu/9+uv8+I5vmGvM5Zr97/TbD2G84k78zEU1PNiXd/gUkNx0RH1NO9nl7CAXcVJDGaxanNeDU4zz4MUbiYf8JYZaUq9UmtJuwyrfLlyCWQBlvGlUddUhP9Fjl6MEuUCxhDhQ6pAutAH19wviNNenJz5Hz1Vt6C6Qy14Ygyb7052YRE3vPs40K0WDxdlmr+r0YTHXjOBmVoCu9bG7+Egud1DOfn69YNUH+h3ouqcnjqNyDpW6qiH0ClL242T1s4L3Yl1AiieRSpkgkyWZ1nB42+bi0xpA3BGP8hKwwy0iOWP0jRXcBEM3hC67JfW6pKQTkMwfqVF0IfH+QucZn6UzQx4Hs9NueLD4obtcg/5ju0Gv0MTiEpPNZ49L13xl+EIVmy5Xsy1ig/2n5lGv7xG77rBlEN5lhIwUPxbfvnC0vsyu9cT9HjPEAOjdBVDLKRon5phMlWXqWdVZY0145JJvcOp5xlPkSq0a X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
large folios swap-in: handle refault cases first
|
expand
|
From: Barry Song <v-songbaohua@oppo.com> This patch is extracted from the large folio swapin series[1], focusing initially on handling the scenario where large folios are found in the swap cache. This should facilitate code review and enable sooner inclusion of this portion into the MM tree. It relies on Ryan's swap-out series[2], leveraging the helper function swap_pte_batch() introduced by that series. Presently, do_swap_page only encounters a large folio in the swap cache before the large folio is released by vmscan. However, the code should remain equally useful once we support large folio swap-in via swapin_readahead(). This approach can effectively reduce page faults and eliminate most redundant checks and early exits for MTE restoration in recent MTE patchset[3]. The large folio swap-in for SWP_SYNCHRONOUS_IO and swapin_readahead() will be split into separate patch sets and sent at a later time. Differences with the original large folios swap-in series - collect r-o-b, acked; - rename swap_nr_free to swap_free_nr, according to Ryan; - limit the maximum kernel stack usage for swap_free_nr, Ryan; - add output argument in swap_pte_batch to expose if all entries are exclusive - many clean refinements, handle the corner case folio's virtual addr might not be naturally aligned [1] https://lore.kernel.org/linux-mm/20240304081348.197341-1-21cnbao@gmail.com/ [2] https://lore.kernel.org/linux-mm/20240327144537.4165578-1-ryan.roberts@arm.com/ [3] https://lore.kernel.org/linux-mm/20240322114136.61386-1-21cnbao@gmail.com/ Barry Song (1): mm: swap_pte_batch: add an output argument to reture if all swap entries are exclusive Chuanhua Han (3): mm: swap: introduce swap_free_nr() for batched swap_free() mm: swap: make should_try_to_free_swap() support large-folio mm: swap: entirely map large folios found in swapcache include/linux/swap.h | 5 ++++ mm/internal.h | 5 +++- mm/madvise.c | 2 +- mm/memory.c | 65 ++++++++++++++++++++++++++++++++++---------- mm/swapfile.c | 51 ++++++++++++++++++++++++++++++++++ 5 files changed, 112 insertions(+), 16 deletions(-) Appendix: The following program can generate numerous instances where large folios are hit in the swap cache if we enable 64KiB mTHP, #echo always > /sys/kernel/mm/transparent_hugepage/hugepages-64kB/enabled #define DATA_SIZE (128UL * 1024) #define PAGE_SIZE (4UL * 1024) #define LARGE_FOLIO_SIZE (64UL * 1024) static void *write_data(void *addr) { unsigned long i; for (i = 0; i < DATA_SIZE; i += PAGE_SIZE) memset(addr + i, (char)i, PAGE_SIZE); } static void *read_data(void *addr) { unsigned long i; for (i = 0; i < DATA_SIZE; i += PAGE_SIZE) { if (*((char *)addr + i) != (char)i) { perror("mismatched data"); _exit(-1); } } } static void *pgout_data(void *addr) { madvise(addr, DATA_SIZE, MADV_PAGEOUT); } int main(int argc, char **argv) { for (int i = 0; i < 10000; i++) { pthread_t tid1, tid2; void *addr = mmap(NULL, DATA_SIZE * 2, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0); unsigned long aligned_addr = ((unsigned long)addr + LARGE_FOLIO_SIZE) & ~(LARGE_FOLIO_SIZE - 1); if (addr == MAP_FAILED) { perror("fail to malloc"); return -1; } write_data(aligned_addr); if (pthread_create(&tid1, NULL, pgout_data, (void *)aligned_addr)) { perror("fail to pthread_create"); return -1; } if (pthread_create(&tid2, NULL, read_data, (void *)aligned_addr)) { perror("fail to pthread_create"); return -1; } pthread_join(tid1, NULL); pthread_join(tid2, NULL); munmap(addr, DATA_SIZE * 2); } return 0; }