| Message ID | 20240411061713.1847574-1-alexs@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | transfer page to folio in KSM | expand |
On 11.04.24 08:17, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" <alexs@kernel.org> > > This is the first part of page to folio transfer on KSM. Since only > single page could be stored in KSM, we could safely transfer stable tree > pages to folios. > This patchset could reduce ksm.o 57kbytes from 2541776 bytes on latest > akpm/mm-stable branch with CONFIG_DEBUG_VM enabled. It pass the KSM testing > in LTP and kernel selftest. Just a nit (no need to address for this patch set): "transfer page to folio" sounds very misleading to me. I'm not a native speaker, but I'd have called this patch set "mm/ksm: convert some KSM code to use folios" It's rather code conversion/transformation, not a transfer. But again, I'm not a native speaker ...
On 4/11/24 3:55 PM, David Hildenbrand wrote: > On 11.04.24 08:17, alexs@kernel.org wrote: >> From: "Alex Shi (tencent)" <alexs@kernel.org> >> >> This is the first part of page to folio transfer on KSM. Since only >> single page could be stored in KSM, we could safely transfer stable tree >> pages to folios. >> This patchset could reduce ksm.o 57kbytes from 2541776 bytes on latest >> akpm/mm-stable branch with CONFIG_DEBUG_VM enabled. It pass the KSM testing >> in LTP and kernel selftest. > > Just a nit (no need to address for this patch set): "transfer page to folio" sounds very misleading to me. I'm not a native speaker, but I'd have called this patch set > > "mm/ksm: convert some KSM code to use folios" > > It's rather code conversion/transformation, not a transfer. > > But again, I'm not a native speaker ... > Uh, me neither. but sounds you're right. I will take care this next time. Thanks Alex
From: "Alex Shi (tencent)" <alexs@kernel.org> This is the first part of page to folio transfer on KSM. Since only single page could be stored in KSM, we could safely transfer stable tree pages to folios. This patchset could reduce ksm.o 57kbytes from 2541776 bytes on latest akpm/mm-stable branch with CONFIG_DEBUG_VM enabled. It pass the KSM testing in LTP and kernel selftest. Thanks for Matthew Wilcox and David Hildenbrand's suggestions and comments! Alex Shi (tencent) (9): mm/ksm: add ksm_get_folio mm/ksm: use folio in remove_rmap_item_from_tree mm/ksm: add folio_set_stable_node mm/ksm: use folio in remove_stable_node mm/ksm: use folio in stable_node_dup mm/ksm: use ksm_get_folio in scan_get_next_rmap_item mm/ksm: use folio in write_protect_page mm/ksm: Convert chain series funcs and replace get_ksm_page mm/ksm: replace set_page_stable_node by folio_set_stable_node David Hildenbrand (1): mm/ksm: rename get_ksm_page_flags() to ksm_get_folio_flags mm/ksm.c | 273 ++++++++++++++++++++++++++------------------------- mm/migrate.c | 2 +- 2 files changed, 139 insertions(+), 136 deletions(-)