From patchwork Fri Apr 19 07:43:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13635738 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26613C4345F for ; Fri, 19 Apr 2024 07:44:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 514BC6B0083; Fri, 19 Apr 2024 03:43:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C3496B0085; Fri, 19 Apr 2024 03:43:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B28E6B0087; Fri, 19 Apr 2024 03:43:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1E70A6B0083 for ; Fri, 19 Apr 2024 03:43:59 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C0E6EC0E77 for ; Fri, 19 Apr 2024 07:43:58 +0000 (UTC) X-FDA: 82025492556.02.CEE643C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id C6DD2C000A for ; Fri, 19 Apr 2024 07:43:56 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713512637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=mCDzovF4l6h0pPPgeQWLqUygCMpJ+KPSgCxuIMTKXKI=; b=gZR2vQ6by7pkYfJm+xg8LETUphNPCJ8Vf/aQLZnVdH+t0qn3dbqa3XzxdUPlkNqgL9yuDF TDMPvsrgdgXqEVDtB53nZe0IwmXuG+BSbHTqdk7yVgFeHd2aN4d9S8WXmo2oIQN8p2n0e5 cnypq0B8TJ23/io27VGlgbXgXKOFSl4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713512637; a=rsa-sha256; cv=none; b=tZ9KbN9lP0vPkoOqJVXTM/0eP1sgkQt5QCCT/5Oag/pNo/A05w4fClVQCG97lpKwufRLn7 Al88N6QiE+hlmnsMTXVM6lzYCyYuls9uVmC6ORFqjkJ2JdFEeRm46JqUSUryeNlcQOXeJo mgZQXv54fmJQIKH+tc2GYa87WmoueWY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E48F62F; Fri, 19 Apr 2024 00:44:23 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 93E4A3F792; Fri, 19 Apr 2024 00:43:53 -0700 (PDT) From: Ryan Roberts To: Catalin Marinas , Will Deacon , Andrew Morton , Shuah Khan , Joey Gouly , Ard Biesheuvel , Mark Rutland , Anshuman Khandual , David Hildenbrand , Shivansh Vij Cc: Ryan Roberts , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH v1 0/5] arm64/mm: uffd write-protect and soft-dirty tracking Date: Fri, 19 Apr 2024 08:43:39 +0100 Message-Id: <20240419074344.2643212-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C6DD2C000A X-Stat-Signature: oagn33h1xqqaxmde9htunhrijttj5n1w X-HE-Tag: 1713512636-220325 X-HE-Meta: U2FsdGVkX1/q24C0ptUZzJcIQPC0kBRrqXoUAzV0do95TRvoVyZnAVrPF908UxtlB0isRb9kRPX0jnTHnxTq82E0JLsSZYkqLfuckn++aWaFxcM0qd9ukM8mbUPRbl/njHobtCVoVXCibPNfJgxuw7PMg23PbUUJ4O2egwFTiXRKj/WcBnrUfzrmj/XK8/f9va61Nba5WxwALNO/pQlBYSrZJfIffOWMFdNIv8nwoGeYMeYCNbLZstMz8uWSFtOnal5t5Fp+UZaDSEkAdlGCEnMbo+wgeHHl2thPVt/DPu/VRN0vACIr7DNpqURK6KVQ39eloKqgT3RSV1M6FXDINQ10K9NbBw9tk4RlbBp1xpefpOXdOkLDLboGZnLnbZHqwaW+oNLzZ9vQYRqp8wek8Gk1BCjL6rIFsj7HSMiSLdMWBJLzWmkeWJC/Of1UFKUJQOXRY9iGCE8sXKv2cgRwk4UwdGF0bPFJMBNLcxFnznZy0tFHGojnXSM0EXYHz6eONaIEfNNGAI4ngkE6nCGc5ubSpffy/7mP4f4DGC8gtHZI/Oz6PbuofY6ryTSNrk59DTGoZbHhwAE8liHb0HPuNm4pNTO4CYNmTNRifLkxiyfo4RiuEucMqO993sYdhyFqeZ8da6nAOKnhhUeKFznBtMlB5VIZoc742RB6lllWPVBG5qvcUw63zrwkaXThOcPPJgz1UTWHRHWXFYQf68LjB1Hcp1m5GJas4RV3/TDSwCXBW/R4rfDtX92Orrm2HCoguggmgVRCaCyGkkqK1m0hHyTtYqwvupj4ifOdKZxYdzHLfkdb0xd97ezWQo9maIngbSJdwvNThyN77vGQfCECa7cd3FKLIZk+SKeyvVRoVxGMCHnh+ZU3Zq6aNufky3GUqJN3a1rq0IapdF1lOe3dbe4YOY/+cawul5M9/WbRnKQ7NAcOorHy43twfxSNf2408jt1ni8bHryrw1rCrFw jke3piM4 z0Oc3L55mHlt920oXNNrLRFByDVxPkXRKfdOnYeGHbSszb30+o4upUnH+nxgjHNStCyoT3HVn5Vc78Btn4c1UyCjLkCj+qb9P+kRAjHNknB4JQICdubjcTXGpM6i+qkONXqPG5uNuw6cn8mnFVgHbbXZViBlD/R4R2XOpQs1OMZT+WguHMdC+WkhdNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi All, This series adds uffd write-protect and soft-dirty tracking support for arm64. I consider the soft-dirty support (patches 3 and 4) as RFC - see rationale below. Previous attempts to add these features have failed because of a perceived lack of available PTE SW bits. However it actually turns out that there are 2 available but they are hidden. PTE_PROT_NONE was previously occupying a SW bit, but it only applies when PTE_VALID is clear, so this is moved to overlay PTE_UXN in patch 1, freeing up the SW bit. Bit 63 is marked as "IGNORED" in the Arm ARM, but it does not currently indicate "reserved for SW use" like it does for the other SW bits. I've confirmed with the spec owner that this is an oversight; the bit is intended to be reserved for SW use and the spec will clarify this in a future update. So we have our two bits; patch 2 enables uffd-wp, patch 3 enables soft-dirty and patches 4 and 5 sort out the selftests so that the soft-dirty tests are compiled for, and run on arm64. That said, these are the last 2 SW bits and we may want to keep 1 bit in reserve for future use. soft-dirty is only used for CRIU to my knowledge, and it is thought that their use case could be solved with the more generic uffd-wp. So unless somebody makes a clear case for the inclusion of soft-dirty support, we are probably better off dropping patches 3 and 4 and keeping bit 63 for future use. Although note that the most recent attempt to add soft-dirty for arm64 was last month [1] so I'd like to give Shivansh Vij the opportunity to make the case. ---8<--- As an appendix, I've also experimented with adding an "extended SW bits" region linked by the `struct ptdesc` (which you can always find from the `pte_t *`). If demonstrated to work, this would act as an insurance policy in case we ever need more SW bits in future, giving us confidence to merge soft-dirty now. Unfortunately this approach suffers from 2 problems; 1) its slow; my fork() microbenchmark takes 40% longer in the worst case. 2) it is not possible to read the HW pte and the extended SW bits atomically so it is impossible to implement ptep_get_lockess() in its current form. So I've abandoned this experiment. (I can provide more details if there is interest). ---8<--- [1] https://lore.kernel.org/linux-arm-kernel/MW4PR12MB687563EFB56373E8D55DDEABB92B2@MW4PR12MB6875.namprd12.prod.outlook.com/ Thanks, Ryan Ryan Roberts (5): arm64/mm: Move PTE_PROT_NONE and PMD_PRESENT_INVALID arm64/mm: Add uffd write-protect support arm64/mm: Add soft-dirty page tracking support selftests/mm: Enable soft-dirty tests on arm64 selftests/mm: soft-dirty should fail if a testcase fails arch/arm64/Kconfig | 2 + arch/arm64/include/asm/pgtable-prot.h | 20 +++- arch/arm64/include/asm/pgtable.h | 118 +++++++++++++++++++-- arch/arm64/mm/contpte.c | 6 +- arch/arm64/mm/fault.c | 3 +- arch/arm64/mm/hugetlbpage.c | 6 +- tools/testing/selftests/mm/Makefile | 5 +- tools/testing/selftests/mm/madv_populate.c | 26 +---- tools/testing/selftests/mm/run_vmtests.sh | 5 +- tools/testing/selftests/mm/soft-dirty.c | 2 +- 10 files changed, 141 insertions(+), 52 deletions(-) --- 2.25.1