From patchwork Wed Apr 24 13:59:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 13641916 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB24EC4345F for ; Wed, 24 Apr 2024 13:59:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54EEA8D000E; Wed, 24 Apr 2024 09:59:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FF3E8D0001; Wed, 24 Apr 2024 09:59:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EDB18D000E; Wed, 24 Apr 2024 09:59:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2409B8D0001 for ; Wed, 24 Apr 2024 09:59:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B9884A150D for ; Wed, 24 Apr 2024 13:59:41 +0000 (UTC) X-FDA: 82044583362.03.EA4445A Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf28.hostedemail.com (Postfix) with ESMTP id D0A83C0027; Wed, 24 Apr 2024 13:59:37 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713967179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=koVTrCraWsbab7H6ZIpTmlZt67eTKntM8v1QK9XXrWY=; b=Uv1i8rtpi9/I7EJdLdfvOCoWPCGBK3ckY8Gg6xbzD6wrRBroZySxns4/prJXGvMYDzjbw3 PGATf+BSEuffyvXVAOgr5czkIi1SexViTZTwHZoDCIcqLuVV/tomXVgXJaFPch5XAuYo7E IttP3lMhO56IhuNOOqEWDA+QRKVaCSk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713967179; a=rsa-sha256; cv=none; b=lpQTcZMNiTKRYQW/b+7ROdLZu2n3K9qbSj5LdzK09tNk3MAYhN94HLwJlXwhLgxpzeioYk h1xDYBBf70RAeY1aLmSDOQAUF9aS35BHZ3UeCwjcWY7P3U4DztxWTtgRPpAA1s0Q0iCK5v oCs4dHmMpit7LvWPXe1/albIeW3rwiQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VPgW76fqgzXlLD; Wed, 24 Apr 2024 21:56:03 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 96A00140156; Wed, 24 Apr 2024 21:59:33 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Apr 2024 21:59:32 +0800 From: Kefeng Wang To: Andrew Morton , CC: Tony Luck , Miaohe Lin , Naoya Horiguchi , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , , Zi Yan , Jiaqi Yan , Hugh Dickins , Vishal Moola , Kefeng Wang Subject: [PATCH v2 00/10] mm: migrate: support poison recover from migrate folio Date: Wed, 24 Apr 2024 21:59:19 +0800 Message-ID: <20240424135929.2847185-1-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Stat-Signature: sh6i8ng9wggifrkdrcokqsi3kj384ewk X-Rspamd-Queue-Id: D0A83C0027 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713967177-766641 X-HE-Meta: U2FsdGVkX1/sFQcFsb655O1ngcKHwmJ2YhAn7zs/CI6tzm0nxSyX8qCCCVOhzZR9e2A+KdInpmA3F9JO9rVeBYZrHdljmmvb41NRMCbHb8ayM+VfmlXtKdQojTJTWHhTHrfpAlU218UPJQbRqeQ4voegd5Wb595B1ife91Fa4PxlkfNu8MRj3gyH6G0XwfhYhBU1tIZPmEnmDmGKF44eExvJxPCAcYlmr+ZjLssfWWI2Rz4bcaDoUryaDHGLpni4EyJgJw3ltwSPBMhraQK1ygR37XuvaGayFP4qLYaKAZAUr9TXMLdxdMgjo0mrbhiHLvSzp2I69dk9yfZCWShuEPEXdVxm7mICJo4s0lXWzkCpkQd8NN1YWaTyKtaKxtXOIos7/GDJkFHxcshjJ0LebQLTOcNfMl54oQug03z+rzRSJNwGjATf+zE/0zPKIlC5Fra1pGDuuesbQ9pBdIyK6lOPriZ0WUlT9+Hs7i5WSAtVYeam0hn6n3hAg/R+U3PxLpIK6/pO2vq65/LWmhRqTiVBoUiiPH8H/O846YIy69v6PS4lpXNVnKHTJyfycp0iI1nHX+0nWP0VWZYB48ANGFO2AByD/5M66RDWxeRtzTG7ZKneFX0imuYW4AYD7kpRLp0HuAqQgRR3ntEPadVOjzNWgr8WYCgzIEaU2ZnLxXqVnPwhyF4515G2weziWinEj/Ckatihl17MuMJlbeTin+KYgztLL8o+ZEVzfD47f3LNFys/xpgWtQ2UGuvVDPokswSK24Mc7quYbxTosjZ6wWk8UItqesvYNXnY8BmH219CuXD9jT73wgO6b9Jyu/TqH7q+KQUSkyMPRb0oIE/YGZs2LykRgYfvT+02Nkh/wQHVLi0/FTIgCfziMeCi1boq5uPG1eRJBj1jwCvxaZQnCXBlOzX8tR1b7BybNA4nXTxMCnxWHQ/0anlP+0bHePjSUl6GgijBTJgwnpIc9kR z4JV3A4O 1Ix7acHX9gkBFIHQUKqNmFVOMEomvQWrgh48tYKBTQfu+gGTT44FhYA0qwGtGfT1ZmThOKiOic/8j/C7y3IaNiNEMIBqrbYT0qTL1DsTWBXkNRXOIg277fqs2CAQT4YnLTOw59Dz47WJJMmGz3xfzeKTe+e5jOnWiFqLCvo3/+HgyqYxMDKT3GhYdaVcaq0V14jgE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The folio migration is widely used in kernel, memory compaction, memory hotplug, soft offline page, numa balance, memory demote/promotion, etc, but once access a poisoned source folio when migrating, the kerenl will panic. There is a mechanism in the kernel to recover from uncorrectable memory errors, ARCH_HAS_COPY_MC(Machine Check Safe Memory Copy), which is already used in NVDIMM or core-mm paths(eg, CoW, khugepaged, coredump, ksm copy), see copy_mc_to_{user,kernel}, copy_mc_{user_}highpage callers. This series of patches provide the recovery mechanism from folio copy for the widely used folio migration. Please note, because folio migration is no guarantee of success, so we could chose to make folio migration tolerant of memory failures, adding folio_mc_copy() which is a #MC versions of folio_copy(), once accessing a poisoned source folio, we could return error and make the folio migration fail, and this could avoid the similar panic shown below. CPU: 1 PID: 88343 Comm: test_softofflin Kdump: loaded Not tainted 6.6.0 pc : copy_page+0x10/0xc0 lr : copy_highpage+0x38/0x50 ... Call trace: copy_page+0x10/0xc0 folio_copy+0x78/0x90 migrate_folio_extra+0x54/0xa0 move_to_new_folio+0xd8/0x1f0 migrate_folio_move+0xb8/0x300 migrate_pages_batch+0x528/0x788 migrate_pages_sync+0x8c/0x258 migrate_pages+0x440/0x528 soft_offline_in_use_page+0x2ec/0x3c0 soft_offline_page+0x238/0x310 soft_offline_page_store+0x6c/0xc0 dev_attr_store+0x20/0x40 sysfs_kf_write+0x4c/0x68 kernfs_fop_write_iter+0x130/0x1c8 new_sync_write+0xa4/0x138 vfs_write+0x238/0x2d8 ksys_write+0x74/0x110 v2: - remove patch11 since fio don't support large folio - add RB - rebased on next-20240424 v1: - no change, resend and rebased on 6.9-rc1 rfcv2: - Separate __migrate_device_pages() cleanup from patch "remove migrate_folio_extra()", suggested by Matthew - Split folio_migrate_mapping(), move refcount check/freeze out of folio_migrate_mapping(), suggested by Matthew - add RB Kefeng Wang (10): mm: migrate: simplify __buffer_migrate_folio() mm: migrate_device: use more folio in __migrate_device_pages() mm: migrate_device: unify migrate folio for MIGRATE_SYNC_NO_COPY mm: migrate: remove migrate_folio_extra() mm: remove MIGRATE_SYNC_NO_COPY mode mm: migrate: split folio_migrate_mapping() mm: add folio_mc_copy() mm: migrate: support poisoned recover from migrate folio fs: hugetlbfs: support poison recover from hugetlbfs_migrate_folio() mm: migrate: remove folio_migrate_copy() fs/aio.c | 15 +--- fs/hugetlbfs/inode.c | 5 +- include/linux/migrate.h | 3 - include/linux/migrate_mode.h | 5 -- include/linux/mm.h | 1 + mm/balloon_compaction.c | 8 -- mm/migrate.c | 157 +++++++++++++++++------------------ mm/migrate_device.c | 28 +++---- mm/util.c | 20 +++++ mm/zsmalloc.c | 8 -- 10 files changed, 113 insertions(+), 137 deletions(-)